Re: [PATCH weston v2] libinput: Suppress unhandled-case warning

2017-03-16 Thread Peter Hutterer
On Thu, Mar 16, 2017 at 10:01:05AM +, Daniel Stone wrote: > When the wheel tilt source is present, gcc complains that we don't > handle all possible enumeration values. We already ensure this cannot > happen in its only caller (handle_pointer_axis), but gcc doesn't > recognise this. Give it a d

Re: [PATCH weston v9 01/62] libweston: Add pixel-format helpers

2017-03-16 Thread Emil Velikov
On 16 March 2017 at 10:54, Daniel Stone wrote: > Hey Emil, > > On 13 March 2017 at 17:57, Emil Velikov wrote: >> On 10 March 2017 at 15:28, Daniel Stone wrote: >>> On 9 March 2017 at 22:57, Emil Velikov wrote: According to WL_bind_wayland_display and the i965/i915 drivers (afaict) abo

Re: [PATCH weston v9 06/62] compositor-drm: Refactor destroy drm_fb function

2017-03-16 Thread Emil Velikov
On 16 March 2017 at 10:48, Daniel Stone wrote: > Hey Emil, > > On 13 March 2017 at 18:03, Emil Velikov wrote: >> On 10 March 2017 at 15:12, Daniel Stone wrote: >>> Honestly, I don't think it makes any practical difference. The dumb >>> buffer itself has a reference held by the fb, so won't actua

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-16 Thread Emil Velikov
On 16 March 2017 at 12:40, Pekka Paalanen wrote: > On Tue, 21 Feb 2017 16:14:28 + > Emil Velikov wrote: > >> From: Emil Velikov >> >> Currently both of libwayland-{client,server} export the same util >> (amongst other) symbols. >> >> Although not crucial this is something which should be avo

Re: [PATCH wayland v2 3/4] wayland-util: build/ship as separate shared library

2017-03-16 Thread Pekka Paalanen
On Tue, 21 Feb 2017 16:14:28 + Emil Velikov wrote: > From: Emil Velikov > > Currently both of libwayland-{client,server} export the same util > (amongst other) symbols. > > Although not crucial this is something which should be avoided where > possible. > > As such let's move the library

Re: [PATCH weston] configure: bump libweston to 3.0.0

2017-03-16 Thread Pekka Paalanen
On Tue, 14 Mar 2017 11:34:45 +0100 Emilio Pozuelo Monfort wrote: > On 14/03/17 11:29, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Bump the future release to 3.0.0 due to breaking ABI in libweston. > > > > We have merged a few patches already that change libweston/compositor.h. > > W

Re: [PATCH wayland] connection-test: fix assert

2017-03-16 Thread Pekka Paalanen
On Thu, 16 Mar 2017 11:46:06 + Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > tests/connection-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/connection-test.c b/tests/connection-test.c > index 8be6c38..157e1bc 100644 > --- a/tests/

[PATCH wayland] connection-test: fix assert

2017-03-16 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- tests/connection-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/connection-test.c b/tests/connection-test.c index 8be6c38..157e1bc 100644 --- a/tests/connection-test.c +++ b/tests/connection-test.c @@ -603,8 +603,8 @@ suu_han

Re: [PATCH weston v9 01/62] libweston: Add pixel-format helpers

2017-03-16 Thread Daniel Stone
Hey Emil, On 13 March 2017 at 17:57, Emil Velikov wrote: > On 10 March 2017 at 15:28, Daniel Stone wrote: >> On 9 March 2017 at 22:57, Emil Velikov wrote: >>> According to WL_bind_wayland_display and the i965/i915 drivers >>> (afaict) above five should have two planes. Then again, the FOURCC an

Re: [PATCH weston v9 06/62] compositor-drm: Refactor destroy drm_fb function

2017-03-16 Thread Daniel Stone
Hey Emil, On 13 March 2017 at 18:03, Emil Velikov wrote: > On 10 March 2017 at 15:12, Daniel Stone wrote: >> Honestly, I don't think it makes any practical difference. The dumb >> buffer itself has a reference held by the fb, so won't actually get >> destroyed until both the buffer has been dest

[PATCH weston v2] libinput: Suppress unhandled-case warning

2017-03-16 Thread Daniel Stone
When the wheel tilt source is present, gcc complains that we don't handle all possible enumeration values. We already ensure this cannot happen in its only caller (handle_pointer_axis), but gcc doesn't recognise this. Give it a default value to quiet the warning. Signed-off-by: Daniel Stone ---