Re: [PATCH weston v9 03/62] compositor-drm: Calculate more cursor state up front

2017-03-13 Thread Emil Velikov
On 10 March 2017 at 15:16, Daniel Stone wrote: > Hey Emil, > > On 9 March 2017 at 23:12, Emil Velikov wrote: >> On 3 March 2017 at 23:05, Daniel Stone wrote: >>> - x = (x - output->base.x) * output->base.current_scale; >>> - y = (y - output->base.y) * output->base.current_scale; >>>

Re: [PATCH weston v9 06/62] compositor-drm: Refactor destroy drm_fb function

2017-03-13 Thread Emil Velikov
Hi Dan, On 10 March 2017 at 15:12, Daniel Stone wrote: > Hey Emil, > > On 9 March 2017 at 23:51, Emil Velikov wrote: >> On 3 March 2017 at 23:05, Daniel Stone wrote: >>> +static void >>> +drm_fb_destroy_dumb(struct drm_fb *fb) >>> +{ >>> + struct drm_mode_destroy_dumb destroy_arg; >>> + >

Re: [PATCH weston v9 01/62] libweston: Add pixel-format helpers

2017-03-13 Thread Emil Velikov
On 10 March 2017 at 15:28, Daniel Stone wrote: > Hey Emil, > > On 9 March 2017 at 22:57, Emil Velikov wrote: >> So was feeling a bit bored and decided to remind myself about all the >> crazy formats out there :-) >> >> I believe you've got a couple of mistakes, plus there's a couple of >> questio

Re: [PATCH weston 2/2] launcher: Add sysmacros.h include for major()

2017-03-13 Thread Daniel Stone
Hi Emilio, On 13 March 2017 at 17:45, Emilio Pozuelo Monfort wrote: > On 13/03/17 17:33, Daniel Stone wrote: >> glibc 2.25 produces a warning when sysmacros.h is not directly included >> but major() is used, as it is intended to be moved to sysmacros.h and >> only there. Include it to keep the bu

Re: [PATCH weston 2/2] launcher: Add sysmacros.h include for major()

2017-03-13 Thread Emilio Pozuelo Monfort
On 13/03/17 17:33, Daniel Stone wrote: > glibc 2.25 produces a warning when sysmacros.h is not directly included > but major() is used, as it is intended to be moved to sysmacros.h and > only there. Include it to keep the build happy. > > Signed-off-by: Daniel Stone Series is: Reviewed-by: Emil

[PATCH weston 1/2] Fix 'implicit fallthrough' warning with new GCC

2017-03-13 Thread Daniel Stone
GCC 7 now warns on case statements falling through without an explicit comment that falling through is OK. Insert some to make it happy. Signed-off-by: Daniel Stone --- desktop-shell/shell.c | 2 ++ tests/subsurface-test.c | 9 + 2 files changed, 11 insertions(+) diff --git a/desktop-

[PATCH weston 2/2] launcher: Add sysmacros.h include for major()

2017-03-13 Thread Daniel Stone
glibc 2.25 produces a warning when sysmacros.h is not directly included but major() is used, as it is intended to be moved to sysmacros.h and only there. Include it to keep the build happy. Signed-off-by: Daniel Stone --- libweston/launcher-direct.c| 1 + libweston/launcher-logind.c

[PATCH weston] man: move pageflip-timeout later

2017-03-13 Thread Pekka Paalanen
From: Pekka Paalanen The paragraph about pageflip-timeout was added in between the two paragraphs of idle-time, causing the paragraphs to be associated wrong. Move the pageflip-timeout paragraph to the end. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=100163 Signed-off-by: Pekka Paalanen

Re: [PATCH weston v2 10/11] [RFC] Account for very large repaint window misses

2017-03-13 Thread Pekka Paalanen
On Fri, 10 Mar 2017 14:52:58 + Daniel Stone wrote: > Hi Pekka, > > On 10 March 2017 at 13:41, Pekka Paalanen > wrote: > > On Wed, 1 Mar 2017 11:34:09 + Daniel Stone > > wrote: > >>* the deadline given by repaint_msec? In that case we delay until > >>* the deadline o

Re: [PATCH weston v2 00/11] Grouped output repaint

2017-03-13 Thread Pekka Paalanen
On Wed, 1 Mar 2017 11:33:59 + Daniel Stone wrote: > Hi, > I'm submitting v2 of this series after Pekka's review. At this point, > we now keep all time values in absolute timespec structs, only using > normalisation to nsec for relative comparisons. This required the > addition of subtraction

Re: [PATCH weston v2 09/11] Switch to global output repaint timer

2017-03-13 Thread Pekka Paalanen
On Fri, 10 Mar 2017 14:37:14 + Daniel Stone wrote: > Hi, > > On 8 March 2017 at 14:05, Pekka Paalanen > wrote: > > On Wed, 1 Mar 2017 11:34:08 + Daniel Stone > > wrote: > >> + /* XXX: This can keep postponing forever, maybe? */ > >> + if (msec_to_next < 1) > >> +

Re: not completely booting to the desktop without a screen connected?

2017-03-13 Thread Pekka Paalanen
On Sat, 11 Mar 2017 19:48:59 +0100 Simon Eigeldinger wrote: > Hi all, > > I sent this message to the x server mailing list as well because i > figured out that the server doesn't start the desktop because of no > screen being connected. > so i am asking this on the wayland list as well. > > -