[PATCH libinput] evdev: improve default scroll button detection

2017-02-27 Thread Peter Hutterer
Try to guess the default scroll buttons a bit better. Right now we default to scroll button 0 (disabled) whenever a device doesn't have a middle button but we might as well cast a wider net here as setting a scroll button only has a direct effect when button scrolling is enabled. Use the first ext

Re: weston-simple-egl fullscreen broken?

2017-02-27 Thread Daniel Stone
Hi Arnaud, On 27 February 2017 at 23:12, Arnaud Vrac wrote: > On Mon, Feb 27, 2017 at 11:18 PM Daniel Stone wrote: >> On 6 February 2017 at 16:56, Fabien DESSENNE wrote: >> > I remember I used to get « weston-simple-egl -f » working fine. >> > But it does not work anymore : nothing is displayed

Re: weston-simple-egl fullscreen broken?

2017-02-27 Thread Arnaud Vrac
On Mon, Feb 27, 2017 at 11:18 PM Daniel Stone wrote: > > Hi Fabien, > > On 6 February 2017 at 16:56, Fabien DESSENNE wrote: > > I remember I used to get « weston-simple-egl -f » working fine. > > But it does not work anymore : nothing is displayed. From the logs I can see > > (among others) zxdg_

Re: [PATCH weston 21/68] compositor-drm: Use drm_fb for cursor buffers

2017-02-27 Thread Daniel Stone
Hi, On 22 February 2017 at 14:08, Pekka Paalanen wrote: > On Fri, 9 Dec 2016 19:57:36 + Daniel Stone wrote: > looks like this patch causes an FB to be created from cursor bo-s, and > this was not done before and the FBs are not used yet. I think this > requires an explanation in the commit

Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-02-27 Thread Daniel Stone
Hi Pekka, On 21 February 2017 at 15:19, Pekka Paalanen wrote: > On Fri, 9 Dec 2016 19:57:34 + Daniel Stone wrote: >> @@ -312,6 +316,7 @@ drm_fb_create_dumb(struct drm_backend *b, int width, int >> height, >> if (!fb->format->depth || !fb->format->bpp) { >> weston_log("f

Re: [PATCH weston 17/68] compositor-drm: Refactor destroy drm_fb function

2017-02-27 Thread Daniel Stone
Hi, On 21 February 2017 at 13:58, Pekka Paalanen wrote: > On Fri, 9 Dec 2016 19:57:32 + Daniel Stone wrote: >> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c >> index af43a15..7dbfc6b 100644 >> --- a/libweston/compositor-drm.c >> +++ b/libweston/compositor-drm.c >> @@

Re: [PATCH weston 15/68] compositor-drm: Add explicit type member to drm_fb

2017-02-27 Thread Daniel Stone
Hi Pekka, Thanks for the thoughtful review, as ever. On 22 February 2017 at 13:45, Pekka Paalanen wrote: > On Tue, 21 Feb 2017 15:29:09 +0200 Pekka Paalanen wrote: >> On Fri, 9 Dec 2016 19:57:30 + Daniel Stone >> wrote: >> > @@ -452,15 +461,19 @@ drm_output_release_fb(struct drm_output *o

Re: weston-simple-egl fullscreen broken?

2017-02-27 Thread Daniel Stone
Hi Fabien, On 6 February 2017 at 16:56, Fabien DESSENNE wrote: > I remember I used to get « weston-simple-egl -f » working fine. > But it does not work anymore : nothing is displayed. From the logs I can see > (among others) zxdg_toplevel_v6.configure and wl_surface.commit > Testing with another

Re: [PATCH weston] Update COPYING

2017-02-27 Thread Daniel Stone
Hi Bryce, Sorry, totally neglected this whilst travelling. On 17 February 2017 at 18:09, Bryce Harrington wrote: > On Fri, Feb 17, 2017 at 05:19:55PM +, Daniel Stone wrote: >> On 17 February 2017 at 17:12, Bryce Harrington wrote: >> > It seems atypical amongst open source projects to have an

Re: libwayland-server ABI change: [PATCH] wayland-server: Destroy Clients upon wl_display_destroy()

2017-02-27 Thread Pekka Paalanen
On Wed, 25 Jan 2017 13:29:08 +0200 Pekka Paalanen wrote: > On Wed, 25 Jan 2017 11:08:26 +0800 > Jonas Ådahl wrote: > > > On Mon, Jan 23, 2017 at 03:40:11PM +0200, Pekka Paalanen wrote: > > > On Tue, 20 Dec 2016 18:40:13 +0530 > > > viveka wrote: > > > > > > > From: "Vivek.A" > > > > >

Re: [PATCH libinput] touchpad: reduce minimum height for horiz edge scrolling to 40mm

2017-02-27 Thread Hans de Goede
Hi, On 27-02-17 02:02, Peter Hutterer wrote: Introduced in commit 8e7f99c27ab39 we only allowed horizontal edge scrolling on devices larger than 50mm to leave enough reactive space on the touchpad. Looking at a ruler, a 50mm high touchpad is still large enough to leave the bottom 7mm as an horiz