[PATCH libinput 1/2] touchpad: add a hwdb quirk for (external) touchpad/keyboard combos

2017-02-09 Thread Peter Hutterer
Specify the layout of the combo so we know when to initialize palm detection. This allows us to drop palm detection on external touchpads otherwise, replacing the wacom-specific check with something more generic.. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c| 19 +++

[PATCH libinput 2/2] touchpad: drop 'is blacklisted' check for dwt pairing

2017-02-09 Thread Peter Hutterer
dwt is needed on internal touchpads only and those external ones that are a combo device. This also now gives us the same check for palm detect and dwt. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 54 - 1 file changed, 17 insertions

Re: [PATCH libinput 10/11] touchpad: use pressure values for touch is-down decision

2017-02-09 Thread Peter Hutterer
On Thu, Feb 09, 2017 at 05:25:36PM +0100, Hans de Goede wrote: > Hi, > > First of all patches 1-9 and 11 looks good to me and are: > > Reviewed-by: Hans de Goede thx, fwiw, I already pushed these, so fixups will come as a separate patch. > I've some remarks inline on this one. > > On 30-01-17

Re: [PATCH weston] compositor: Improve xwayland warning message

2017-02-09 Thread Quentin Glidic
On 09/02/2017 21:28, Armin Krezović wrote: And fix formatting. Signed-off-by: Armin Krezović Nice: Reviewed-by: Quentin Glidic And pushed: efc2b1d4..e6b71366 master -> master Thanks, --- compositor/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/comp

[PATCH weston] compositor: Improve xwayland warning message

2017-02-09 Thread Armin Krezović
And fix formatting. Signed-off-by: Armin Krezović --- compositor/main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/compositor/main.c b/compositor/main.c index 4bd6e681..72c3cd10 100644 --- a/compositor/main.c +++ b/compositor/main.c @@ -860,9 +860,10 @@ load_modul

Re: [PATCH weston v2 0/3] compositor-drm: Allow high object IDs

2017-02-09 Thread Daniel Stone
Hi, On 9 February 2017 at 16:44, Daniel Stone wrote: > Pekka quite rightly suggested that some small helper functions would > make this patchset more reasonable; fair enough. > > Patches 1 and 2 certainly look a bit better, but patch 3 unfortunately > couldn't benefit since we needed to do the re

Re: [PATCH weston v2 3/3] compositor-drm: Remove connector_allocator

2017-02-09 Thread Quentin Glidic
On 09/02/2017 17:44, Daniel Stone wrote: Remove the last usage of connector_allocator, which was to check for displays which have been hot-unplugged, and replace it with an array which doesn't rely on the connector IDs remaining below 32 (or 64). Signed-off-by: Daniel Stone Reported-by: Peter S

Re: [PATCH weston v2 2/3] compositor-drm: Avoid connector_allocator for hotplugs

2017-02-09 Thread Quentin Glidic
On 09/02/2017 17:44, Daniel Stone wrote: Rather than using connector_allocator to determine whether an output is newly connected or not, use a list walk across all outputs instead. Signed-off-by: Daniel Stone Reported-by: Peter Senna Tschudin Seems good: Reviewed-by: Quentin Glidic Cheers,

Re: [PATCH weston v2 1/3] compositor-drm: Remove crtc_allocator

2017-02-09 Thread Quentin Glidic
On 09/02/2017 17:44, Daniel Stone wrote: crtc_allocator was used as a bitmask of CRTC IDs, so we didn't try to use the same CRTC for multiple outputs. Unfortunately, this only works to the extent that CRTC object IDs fit within the bitmask; though they were previously, they are not guaranteed to

[PATCH weston v2 3/3] compositor-drm: Remove connector_allocator

2017-02-09 Thread Daniel Stone
Remove the last usage of connector_allocator, which was to check for displays which have been hot-unplugged, and replace it with an array which doesn't rely on the connector IDs remaining below 32 (or 64). Signed-off-by: Daniel Stone Reported-by: Peter Senna Tschudin --- libweston/compositor-dr

[PATCH weston v2 0/3] compositor-drm: Allow high object IDs

2017-02-09 Thread Daniel Stone
Hi, Pekka quite rightly suggested that some small helper functions would make this patchset more reasonable; fair enough. Patches 1 and 2 certainly look a bit better, but patch 3 unfortunately couldn't benefit since we needed to do the reverse lookup (for every drm_output we track, is it still pre

[PATCH weston v2 2/3] compositor-drm: Avoid connector_allocator for hotplugs

2017-02-09 Thread Daniel Stone
Rather than using connector_allocator to determine whether an output is newly connected or not, use a list walk across all outputs instead. Signed-off-by: Daniel Stone Reported-by: Peter Senna Tschudin --- libweston/compositor-drm.c | 31 +-- 1 file changed, 25 inser

[PATCH weston v2 1/3] compositor-drm: Remove crtc_allocator

2017-02-09 Thread Daniel Stone
crtc_allocator was used as a bitmask of CRTC IDs, so we didn't try to use the same CRTC for multiple outputs. Unfortunately, this only works to the extent that CRTC object IDs fit within the bitmask; though they were previously, they are not guaranteed to be under 32 or even 64. Replace the only u

Re: [PATCH libinput 1/2] evdev: improve type-safety on dispatch switches

2017-02-09 Thread Hans de Goede
Hi, On 30-01-17 23:21, Peter Hutterer wrote: Set the dispatch type on creation, then check that whenever we try to get the dispatch struct. This avoids a potential mismatch between the backends. Plus, use of container_of means we're not dependent on the exact layout anymore. Signed-off-by: Pet

Re: [PATCH libinput 10/11] touchpad: use pressure values for touch is-down decision

2017-02-09 Thread Hans de Goede
Hi, First of all patches 1-9 and 11 looks good to me and are: Reviewed-by: Hans de Goede I've some remarks inline on this one. On 30-01-17 01:58, Peter Hutterer wrote: Don't rely on BTN_TOUCH for "finger down", the value for that is hardcoded in the kernel and not always suitable. Some devic

Re: [PATCH libinput] touchpad: expand top middle button to cover 40mm to 60mm

2017-02-09 Thread Hans de Goede
Hi, On 08-02-17 01:17, Peter Hutterer wrote: 42 and 58 were within the middle button already, 40/60 are more accurate values. https://bugs.freedesktop.org/show_bug.cgi?id=99212 Signed-off-by: Peter Hutterer Looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-mt-

[PATCH weston 0/3] compositor-drm: Allow high object IDs

2017-02-09 Thread Daniel Stone
The KMS backend was previously using a 32-bit-wide bitmask to mark out CRTCs and connectors it had already allocated to outputs, to avoid trying to reuse them across multiple outputs. Unfortunately, this relied on KMS object IDs remaining below 32, and even extending that out to 64 doesn't fix tha

[PATCH weston 3/3] compositor-drm: Remove connector_allocator

2017-02-09 Thread Daniel Stone
Remove the last usage of connector_allocator, which was to check for displays which have been hot-unplugged, and replace it with an array which doesn't rely on the connector IDs remaining below 32 (or 64). Signed-off-by: Daniel Stone Reported-by: Peter Senna Tschudin --- libweston/compositor-dr

[PATCH weston 2/3] compositor-drm: Avoid connector_allocator for hotplugs

2017-02-09 Thread Daniel Stone
Rather than using connector_allocator to determine whether an output is newly connected or not, use a list walk across all outputs instead. Signed-off-by: Daniel Stone Reported-by: Peter Senna Tschudin --- libweston/compositor-drm.c | 25 - 1 file changed, 20 insertions(

[PATCH weston 1/3] compositor-drm: Remove crtc_allocator

2017-02-09 Thread Daniel Stone
crtc_allocator was used as a bitmask of CRTC IDs, so we didn't try to use the same CRTC for multiple outputs. Unfortunately, this only works to the extent that CRTC object IDs fit within the bitmask; though they were previously, they are not guaranteed to be under 32 or even 64. Replace the only u