Re: [PATCH weston v2 12/24] xwm: move set_title and set_pid

2017-01-16 Thread Pekka Paalanen
On Sun, 15 Jan 2017 14:52:40 +0100 Quentin Glidic wrote: > On 21/12/2016 15:40, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Move the calls to set_title() and set_pid() out of > > weston_wm_window_read_properties() and into the three callers, each > > slightly different. > > > > xser

Re: [PATCH weston v2 09/24] xwm: detect legacy fullscreen on MapRequest

2017-01-16 Thread Pekka Paalanen
On Sun, 15 Jan 2017 14:44:05 +0100 Quentin Glidic wrote: > On 21/12/2016 15:40, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The legacy fullscreen state needs to be detected at MapRequest time, > > because that is when the X11 client has alredy set up the initial window > > state. > >

Re: [PATCH weston v2] editor: Drop g_type_init() call

2017-01-16 Thread Quentin Glidic
On 16/01/2017 14:04, Daniel Stone wrote: Hi, On 16 January 2017 at 13:01, Emil Velikov wrote: On 15 January 2017 at 12:26, Quentin Glidic wrote: - PKG_CHECK_MODULES(PANGO, [pangocairo], [have_pango=yes], [have_pango=no]) + PKG_CHECK_MODULES(PANGO, [pangocairo pango glib >= 2.36], [have_pan

Re: [PATCH weston 2/2] desktop-shell: Support panel-position 'none'

2017-01-16 Thread Daniel Stone
Hi, On 16 January 2017 at 15:12, Quentin Glidic wrote: > Hey, didn’t it work already? A tiny warning is no big. ;-) Nope, it warned and then left the panel on the left. > Anyway: > Reviewed-by: Quentin Glidic Thanks! Pushed both, and your manpage fix: To ssh://git.freedesktop.org/git/wayland/

Re: [PATCH weston] man/weston.ini: Fix panel-position

2017-01-16 Thread Quentin Glidic
On 16/01/2017 14:24, Daniel Stone wrote: Hi Quentin, On 4 January 2017 at 18:15, Quentin Glidic wrote: It was renamed from panel-location in 55d5701ddf018887a30d9ddede38550967da61bc, and gained a few possible values. Conditional on the two patches to actually support panel-position 'none' th

Re: [PATCH weston 2/2] desktop-shell: Support panel-position 'none'

2017-01-16 Thread Quentin Glidic
On 16/01/2017 14:23, Daniel Stone wrote: The manpage claims that none is valid, so let's make it so. Signed-off-by: Daniel Stone Hey, didn’t it work already? A tiny warning is no big. ;-) Anyway: Reviewed-by: Quentin Glidic --- clients/desktop-shell.c | 25 - 1

Re: [PATCH weston 1/2] desktop-shell: Initialise panel surface listener

2017-01-16 Thread Quentin Glidic
On 16/01/2017 14:23, Daniel Stone wrote: The desktop-shell output destroy code assumes that we always set up a panel listener. Initialise its list explicitly, so if we don't have a panel, then we can still unconditionally destroy the listener on output destroy. Signed-off-by: Daniel Stone Goo

[PATCH weston] compositor-drm: Try to preserve existing output routing

2017-01-16 Thread Daniel Stone
Previously in picking CRTC -> encoder -> connecting routing, we went for the first triplet we found which claimed to work. Preserving the existing routing means that startup will be faster: on a multi-head system, changing the routing implies disabling both CRTCs, then re-enabling them with a new

Re: [PATCH weston v5] libweston: Position layers in an absolute way

2017-01-16 Thread Daniel Stone
Hi, On 17 December 2016 at 12:40, Quentin Glidic wrote: > Currently, layers’ order depends on the module loading order and it does > not survive runtime modifications (like shell locking/unlocking). > With this patch, modules can safely add their own layer at the expected > position in the stack,

Re: [PATCH weston] man/weston.ini: Fix panel-position

2017-01-16 Thread Daniel Stone
Hi Quentin, On 4 January 2017 at 18:15, Quentin Glidic wrote: > It was renamed from panel-location in > 55d5701ddf018887a30d9ddede38550967da61bc, and gained a few possible > values. Conditional on the two patches to actually support panel-position 'none' that I just posted being merged, this is:

[PATCH weston 1/2] desktop-shell: Initialise panel surface listener

2017-01-16 Thread Daniel Stone
The desktop-shell output destroy code assumes that we always set up a panel listener. Initialise its list explicitly, so if we don't have a panel, then we can still unconditionally destroy the listener on output destroy. Signed-off-by: Daniel Stone --- desktop-shell/shell.c | 1 + 1 file changed

[PATCH weston 2/2] desktop-shell: Support panel-position 'none'

2017-01-16 Thread Daniel Stone
The manpage claims that none is valid, so let's make it so. Signed-off-by: Daniel Stone --- clients/desktop-shell.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index bd0032a..b133d86 100644 ---

Re: [PATCH weston v2] editor: Drop g_type_init() call

2017-01-16 Thread Daniel Stone
Hi, On 16 January 2017 at 13:01, Emil Velikov wrote: > On 15 January 2017 at 12:26, Quentin Glidic > wrote: >> - PKG_CHECK_MODULES(PANGO, [pangocairo], [have_pango=yes], [have_pango=no]) >> + PKG_CHECK_MODULES(PANGO, [pangocairo pango glib >= 2.36], >> [have_pango=yes], [have_pango=no]) > > A

Re: [PATCH weston v2] editor: Drop g_type_init() call

2017-01-16 Thread Emil Velikov
On 15 January 2017 at 12:26, Quentin Glidic wrote: > From: Quentin Glidic > > HAVE_PANGO is not in any AC_DEFINE(), so the check is just wrong. > g_type_init() was never called, which is fine since GLib 2.36 anyway. > It is better not to have a wrong usage of HAVE_PANGO here. > Just check for GLi

Re: [PATCH RFC weston 3/4] compositor-x11: Remove support for ancient XCB

2017-01-16 Thread Daniel Stone
Hi Quentin, On 15 January 2017 at 13:05, Quentin Glidic wrote: > On 29/11/2016 18:00, Daniel Stone wrote: >> We had two non-pkg-config check paths in the configure script, to >> support XCB functionality used before XCB had had an accompanying >> release: xcb_poll_for_queued_event (released in 1.

Re: [PATCH weston] desktop-shell: Stop asking for a RGB565 background

2017-01-16 Thread Daniel Stone
Hi, On 15 January 2017 at 18:07, Quentin Glidic wrote: > On 15/01/2017 18:54, Emmanuel Gil Peyrot wrote: >> This makes the background image look much nicer, at the expense of >> slightly more memory bandwidth used. >> >> Signed-off-by: Emmanuel Gil Peyrot > > I see no reason not to: > Reviewed-b

Re: Schedule for 1.13 release

2017-01-16 Thread Pekka Paalanen
On Fri, 13 Jan 2017 12:35:13 -0800 Bryce Harrington wrote: > Lets try that again: > > > Friday the 13th of January seems an auspiciously ominous time to > announce the schedule for 1.13. So here's the upcoming dates: > > - 1.13-alpha around Jan 24th. Major features done by this point. > >