Re: [PATCH wayland-protocols, weston 0/10] format modifier support for linux-dmabuf

2017-01-11 Thread Varad Gautam
Hi Daniel, Since the v2 appears to be botched up in patchwork, I've put a rebase onto current master at [1][2]. Do you think we can merge the series yet? The patches are on top of the roundtrip elimination bits at [3]. [1] https://git.collabora.com/cgit/user/varad/wayland-protocols.git/log/?h=d

Re: [PATCH v2 wayland 4/5] protocol: add axis_source.wheel_tilt

2017-01-11 Thread Peter Hutterer
On Thu, Jan 12, 2017 at 10:13:30AM +1000, Peter Hutterer wrote: > Unlike a wheel rotation, a wheel tilt is a discrete-only axis. Wheel rotations > are mapped to degrees in libinput but that that does not apply to wheel tilt > axes where there is no physical equivalent. before I forget: I did *not*

[PATCH libinput 1/4] test: add a synaptics RMI4 test device

2017-01-11 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/Makefile.am| 1 + test/litest-device-synaptics-rmi4.c | 132 test/litest.c | 2 + test/litest.h | 1 + 4 files changed, 136 insertions(+) create mode

[PATCH libinput 4/4] test: use some helper functions

2017-01-11 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/touchpad.c | 31 +-- 1 file changed, 5 insertions(+), 26 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index 3c38785..267d9a4 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -1718,7 +1718,6 @@ START_TEST(touch

[PATCH libinput 3/4] test: fix some empty queue handling

2017-01-11 Thread Peter Hutterer
Use the litest_assert_empty_queue() instead of manual checking, and remove the manual checks after the function call. Signed-off-by: Peter Hutterer --- test/touchpad-tap.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/test/touchpad-tap.c b/test/t

[PATCH libinput 2/4] test: skip a few unnecessary base event conversions

2017-01-11 Thread Peter Hutterer
These were just there so we didn't have an unused variable warning, but there's no reason even assigning to anything in the first place Signed-off-by: Peter Hutterer --- test/touchpad.c | 55 --- 1 file changed, 24 insertions(+), 31 deletions(-

Re: libinput 1.5.901 touchpad speed on HiDPI screen

2017-01-11 Thread Peter Hutterer
On Wed, Jan 11, 2017 at 10:12:52AM +, François Guerraz wrote: > Hi, > > I've just installed libinput-git 1.5.901.r3.g72e0148-1 to test the > awesomeness of the new trackpad pointer acceleration. I'm using > gnome/wayland one a DELL XPS 2016 (DLL0704:01 06CB:76AE Touchpad). > > Acceleration wo

Re: [PATCH libinput v2 5/5] test: add tests for lid switch

2017-01-11 Thread Peter Hutterer
On Tue, Jan 10, 2017 at 12:24:25PM +1100, James Ye wrote: > Signed-off-by: James Ye Reviewed-by: Peter Hutterer Cheers, Peter > --- > Changes since v1: > - test switch type in litest_is_switch_event() > - test duplicate switch events > - event conversion test > - improved scroll interrup

Re: [PATCH libinput v2 4/5] Pair touchpad and lid_switch for disable

2017-01-11 Thread Peter Hutterer
On Tue, Jan 10, 2017 at 12:24:24PM +1100, James Ye wrote: > Add listener for lid switch events, disable touchpad on switch event. > > Signed-off-by: James Ye > --- > src/evdev-mt-touchpad.c | 47 +++ > src/evdev-mt-touchpad.h | 5 + > 2 files chan

Re: [PATCH libinput v2 3/5] Add evdev_dispatch interface for lid switch

2017-01-11 Thread Peter Hutterer
On Tue, Jan 10, 2017 at 12:24:23PM +1100, James Ye wrote: > Create a lid_switch_interface to handle lid switch events, so the touchpad can > be disabled when lid is closed. > > Signed-off-by: James Ye > --- > Changes since v1: > - style and text fixes > > src/evdev.c | 94 > ++

Re: [PATCH libinput v2 1/5] udev: mark switches as input devices

2017-01-11 Thread Peter Hutterer
fwiw, I got the maching udev bits merged into systemd and they should be available with the next version. So I'm mostly thinking of *not* merging this patch and having distributions ship it as an extra patch if they want. or the udev patch, it's only 2 lines anyway. https://github.com/systemd/syst

Re: [PATCH wayland 2/2] scanner: support "since" attribute for enum entries

2017-01-11 Thread Peter Hutterer
On Wed, Jan 11, 2017 at 07:14:45AM -0800, Yong Bakos wrote: > Hi Peter, > > > On Jan 9, 2017, at 7:27 PM, Peter Hutterer wrote: > > > > This was already in the DTD but not supported by the scanner. > > > > The request/event parsing have an additional check that "since" cannot be < > > interface

[PATCH v2 wayland 2/5] scanner: add helper function to convert "since" to a version

2017-01-11 Thread Peter Hutterer
Same code we already had, just moved into a helper function Signed-off-by: Peter Hutterer Reviewed-by: Yong Bakos --- No changes to v1 src/scanner.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index a239

[PATCH v2 wayland 3/5] scanner: support "since" attribute for enum entries

2017-01-11 Thread Peter Hutterer
This was already in the DTD but not supported by the scanner. The request/event parsing have an additional check that "since" cannot be < interface version. This is missing here. For requests/events we can rely on the xml containing the required "since" attributes already. enums don't have those,

[PATCH v2 wayland 5/5] test: remove test attribute for 'since' parsing

2017-01-11 Thread Peter Hutterer
Now that we have the wheel tilt with a since attribute, we don't need a separate test attribute anymore. Remove it to avoid confusion and make syncing the protocol easier in the future. Signed-off-by: Peter Hutterer --- Changes to v1: - new in this series tests/data/example-client.h | 9 ---

[PATCH v2 wayland 1/5] tests: sync example.xml with wayland.xml

2017-01-11 Thread Peter Hutterer
These are the protocol.xml changes from: 66a26aeb2a: protocol: Remove inconsistent line breaks a26ed0949e: protocol: indentation fixes 6a18a87727: protocol: Extend wl_touch with touchpoint shape and orientation and a few other, smaller ones. Signed-off-by: Peter Hutterer --- Changes to v1: - new

[PATCH v2 wayland 4/5] protocol: add axis_source.wheel_tilt

2017-01-11 Thread Peter Hutterer
Unlike a wheel rotation, a wheel tilt is a discrete-only axis. Wheel rotations are mapped to degrees in libinput but that that does not apply to wheel tilt axes where there is no physical equivalent. Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl Acked-by: Daniel Stone --- Changes to v1

Re: [PATCH wayland 2/2] scanner: support "since" attribute for enum entries

2017-01-11 Thread Yong Bakos
Hi Peter, > On Jan 9, 2017, at 7:27 PM, Peter Hutterer wrote: > > This was already in the DTD but not supported by the scanner. > > The request/event parsing have an additional check that "since" cannot be < > interface version. This is missing here. For requests/events we can rely on > the xml

libinput 1.5.901 touchpad speed on HiDPI screen

2017-01-11 Thread François Guerraz
Hi, I've just installed libinput-git 1.5.901.r3.g72e0148-1 to test the awesomeness of the new trackpad pointer acceleration. I'm using gnome/wayland one a DELL XPS 2016 (DLL0704:01 06CB:76AE Touchpad). Acceleration works, finally, which is great. However, I don't know if it's because I'm on a HiD