Re:Re: Hide or show the surface

2017-01-05 Thread Anthenony
Hi,Jonas: I try to set invisible on current surface with “attach(0, 0, 0)”, but as said in website, attach NULL buffer will cause freeze issue, so I want to use another way to make invisible effort. I find this function “set_buffer_scale”, but how to use it? I have done experiment to use wl_su

[PATCH libinput 2/5] test: simplify some checks in the path test

2017-01-05 Thread Peter Hutterer
The first event is always a device added event, skip the loops that would paper over this. If we ever change this, the tests *should* fail. Signed-off-by: Peter Hutterer --- test/path.c | 150 ++-- 1 file changed, 64 insertions(+), 86 delet

[PATCH libinput 3/5] test: fix pointer accel defaults test

2017-01-05 Thread Peter Hutterer
Loop immediately exited, this code was never triggered. Signed-off-by: Peter Hutterer --- test/pointer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/pointer.c b/test/pointer.c index e0cd064..f4663db 100644 --- a/test/pointer.c +++ b/test/pointer.c @@ -1062,7 +1062,7

[PATCH libinput 4/5] test: fix some tablet tests' unreached code

2017-01-05 Thread Peter Hutterer
These conditions were never triggered by our test suite, so let's tighten up the tests to match what we expect. Signed-off-by: Peter Hutterer --- test/tablet.c | 42 +++--- 1 file changed, 7 insertions(+), 35 deletions(-) diff --git a/test/tablet.c b/test/tab

[PATCH libinput 5/5] test: remove tablet axis normalization test

2017-01-05 Thread Peter Hutterer
gcov analysis showed that none of the actual testing conditions were hit, so the test succeeded despite not actually testing anything. Which is good, because testing for tilt normalization isn't correct anyway, tilt is in physical degrees, Drop the test and replace it with a test for pressure norm

[PATCH libinput 1/5] test: remove some untriggered code from the keyboard tests

2017-01-05 Thread Peter Hutterer
The second condition was never triggered because we shouldn't get anything but keyboard events here. Drain the initial event burst and remove the two skipping conditions that won't happen anyway. Signed-off-by: Peter Hutterer --- test/keyboard.c | 16 ++-- 1 file changed, 2 insertion

Re: [PATCH libinput 0/5] Disable laptop touchpad on lid close

2017-01-05 Thread Peter Hutterer
On Thu, Jan 05, 2017 at 06:00:05PM +0100, Carlos Garnacho wrote: > Hey, > > Thanks James for these patches! > > On Thu, Jan 5, 2017 at 11:02 AM, Peter Hutterer > wrote: > > On Thu, Jan 05, 2017 at 05:11:24PM +1100, James Ye wrote: > >> Although a laptop touchpad is usually not accessible when th

Re: [PATCH libinput 0/5] Disable laptop touchpad on lid close

2017-01-05 Thread Carlos Garnacho
Hey, Thanks James for these patches! On Thu, Jan 5, 2017 at 11:02 AM, Peter Hutterer wrote: > On Thu, Jan 05, 2017 at 05:11:24PM +1100, James Ye wrote: >> Although a laptop touchpad is usually not accessible when the lid is closed, >> some laptop models suffer from a hardware bug where the touch

Re: A solution for gamma-adjustment support in Wayland

2017-01-05 Thread Graeme Gill
Chris Murphy wrote: > On Mon, Dec 26, 2016 at 10:25 PM, Graeme Gill I'm not sure what you are thinking of here - the existing per channel > VideoLUT API's are universally simple, and the only temptation in > making changes to this might be in the direction of better coordinating >

Re: [RFC wayland-protocols] Color management protocol

2017-01-05 Thread Graeme Gill
Daniel Stone wrote: > (By way of example, Mesa does not usefully expose 10bpc formats for > non-Intel drivers right now; the hardware and underlying drivers do; > it's just a small bit of missing glue code. On the other hand, there > is no silent jump between precision; it just wouldn't work.) Ri

Re: A solution for gamma-adjustment support in Wayland

2017-01-05 Thread Graeme Gill
Chris Murphy wrote: Hi Chris, > As for CIEXYZ, to literally convert pixels into this space, or even as an > exchange space, > it will require minimum 16 bits per channel or there will be noticeable > quantization. It's > a huge color space. You could maybe get away with 8 bit per channel CIE >

Re: A solution for gamma-adjustment support in Wayland

2017-01-05 Thread Graeme Gill
Mattias Andrée wrote: Hi, > Ideally I think the display server should support sRGB, > CIE XYZ, and the monitors' native RGB for input. sRGB is > useful for programs such as image viewers and video players. Hmm. It's not a typical approach for a color managed workflow to have hard wired colorspac

Re: [RFC wayland-protocols] Color management protocol

2017-01-05 Thread Graeme Gill
Daniel Stone wrote: > (By way of example, Mesa does not usefully expose 10bpc formats for > non-Intel drivers right now; the hardware and underlying drivers do; > it's just a small bit of missing glue code. On the other hand, there > is no silent jump between precision; it just wouldn't work.) Ri

Re: [RFC wayland-protocols] Color management protocol

2017-01-05 Thread Graeme Gill
Daniel Stone wrote: Hi Daniel, > I would definitely benefit from seeing an expansion of some of the > terminology that is thrown around which can be subtly misleading. But > yes, as said, I've got some Christmas reading to do. If anybody would like some concise explanations for color management

Re: [PATCH libinput 0/5] Disable laptop touchpad on lid close

2017-01-05 Thread Peter Hutterer
On Thu, Jan 05, 2017 at 05:11:24PM +1100, James Ye wrote: > Although a laptop touchpad is usually not accessible when the lid is closed, > some laptop models suffer from a hardware bug where the touchpad can be > activated even if the lid is closed. This bug can be worked around by > disabling >

Re: [PATCH libinput 2/5] Add a "switch" interface for parts of the SW_* range

2017-01-05 Thread Peter Hutterer
On Thu, Jan 05, 2017 at 05:11:26PM +1100, James Ye wrote: > Adapted from: > https://lists.freedesktop.org/archives/wayland-devel/2016-January/026349.html Note: libinput requires patches to be signed-off please, thanks. Only two doxygen nitpicks here, but given the diffstat to the patch you linked

Re: [PATCH libinput 5/5] test: add tests for lid switch

2017-01-05 Thread Peter Hutterer
On Thu, Jan 05, 2017 at 05:11:29PM +1100, James Ye wrote: > --- > test/Makefile.am| 4 +- > test/lid.c | 228 > > test/litest-device-lid-switch.c | 58 ++ > test/litest.c | 28 + > test

Re: [PATCH libinput 3/5] Add evdev_dispatch interface for lid switch

2017-01-05 Thread Peter Hutterer
On Thu, Jan 05, 2017 at 05:11:27PM +1100, James Ye wrote: > Create a lid_switch_interface to handle lid switch events, so touchpad typo: so *the* touchpad ... > can be disabled when lid is closed. > --- > src/evdev.c | 92 > +++-- > src/ev

Re: [PATCH libinput 1/5] udev: mark switches as input devices

2017-01-05 Thread Peter Hutterer
On Thu, Jan 05, 2017 at 05:11:25PM +1100, James Ye wrote: > --- fwiw, I have the required bits here https://github.com/whot/systemd/tree/wip/ID_INPUT_SWITCH I'll get the upstream as soon as we're happy with this set Cheers, Peter > udev/90-libinput-model-quirks.hwdb | 6 ++ > 1 file cha