Re: [PATCH libinput] touchpad: add a quirk for the HP Pavilion dm4

2016-11-28 Thread Peter Hutterer
On Mon, Nov 28, 2016 at 03:33:25PM +0100, Hans de Goede wrote: > Hi, > > On 27-11-16 23:55, Peter Hutterer wrote: > > This touchpad has cursor jumps for 2-finger scrolling that also affects the > > single-finger emulation. So disable any multitouch bits on this device and > > disallow the 2-finger

[PATCH libinput 4/4] test: add wheel tilt tests

2016-11-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/Makefile.am | 1 + test/litest-device-mouse-wheel-tilt.c | 76 +++ test/litest.c | 2 + test/litest.h | 1 + test/pointer.c| 34 ++

[PATCH libinput 3/4] evdev: add support for wheel tilt

2016-11-28 Thread Peter Hutterer
This is added on top of the click angle handling, so the actual axis values simply fall back onto whatever is set by udev, including the default fallbacks to 15 and whatnot. Signed-off-by: Peter Hutterer --- src/evdev.c| 31 +-- src/evdev.h| 2

[PATCH libinput 2/4] Add wheel tilt as axis source

2016-11-28 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/libinput.h | 15 +++ tools/event-debug.c | 3 +++ 2 files changed, 18 insertions(+) diff --git a/src/libinput.h b/src/libinput.h index 18a96bd..aac93fc 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -259,6 +259,12 @@ enum libinput_poin

[PATCH libinput 0/4] Wheel tilt scroll source

2016-11-28 Thread Peter Hutterer
Quite a few mice have tilt-capable wheels for horizontal scrolling. We can't detect those automatically so we'll have to rely on systemd/udev for the tagging. But despite that, we should be honest about the scroll source and mark them as tilt where possible rather than pretending that they're degr

[PATCH libinput 1/4] evdev: add helper function to parse a udev flag

2016-11-28 Thread Peter Hutterer
Only allow values of 0 and 1 for udev flags. Not that I'm aware of anyone using anything else (i.e. his shouldn't break anything) but it's best to be as restrictive as possible here. Bonus effect: it's now possible to unset LIBINPUT_MODEL_* tags as well, previously any value (including 0) was coun

[PATCH libinput] evdev: init axis range warnings for touch devices too

2016-11-28 Thread Peter Hutterer
Move the code from the touchpad code into the more generic evdev code Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 76 + src/evdev-mt-touchpad.h | 5 src/evdev.c | 6 src/evdev.h | 65 +

Re: [PATCH weston 2/2] compositor-wayland: Destroy cursor images earlier

2016-11-28 Thread Dima Ryazanov
On Thu, Nov 24, 2016 at 7:32 AM, Daniel Stone wrote: > Destroying a wl_cursor will attempt to access the wl_display, which > we have just freed. Avoid a segfault by destroying the cursor images > before we destroy the display. > > Signed-off-by: Daniel Stone > Yep, fixes the crash for me. Revi

Re: [PATCH weston 2/2] compositor-wayland: Destroy cursor images earlier

2016-11-28 Thread Peter Hutterer
On Thu, Nov 24, 2016 at 03:32:41PM +, Daniel Stone wrote: > Destroying a wl_cursor will attempt to access the wl_display, which > we have just freed. Avoid a segfault by destroying the cursor images > before we destroy the display. > > Signed-off-by: Daniel Stone Reviewed-by: Peter Hutterer

Re: [PATCH weston 1/2] Don't prepend protocol/ to include paths

2016-11-28 Thread Dima Ryazanov
On Thu, Nov 24, 2016 at 7:32 AM, Daniel Stone wrote: > No need to add protocol/, as it's already handled by an explicit > compiler include path. > > Signed-off-by: Daniel Stone > Reviewed-by: Dima Ryazanov > --- > libweston-desktop/xdg-shell-v5.c | 2 +- > libweston-desktop/xdg-shell-v6.c |

Re: [PATCH weston v3 1/2] editor: Use parse_options() from shared for command line options

2016-11-28 Thread Bryce Harrington
On Sun, Nov 27, 2016 at 02:54:54PM -0800, Yong Bakos wrote: > On Nov 21, 2016, at 1:26 PM, Bryce Harrington wrote: > > > > Also add a basic --help option > > > > Signed-off-by: Bryce Harrington > > This patch extracts some option flags out of main, uses parse_options instead > of strcmp, and a

Re: [PATCH weston] compositor-wayland: Set frame callback for Pixman

2016-11-28 Thread Daniel Stone
Hi Dima, On 28 November 2016 at 21:31, Dima Ryazanov wrote: > Yep, fixes the crash, thanks! Pushed now, thanks! To ssh://git.freedesktop.org/git/wayland/weston 6a38ad7..21fac60 upstream -> master Cheers, Daniel ___ wayland-devel mailing list wayl

Re: [PATCH weston v2] compositor-wayland: Fix a use after free

2016-11-28 Thread Dima Ryazanov
Oh, good catch; just reviewed it. Thanks! On Mon, Nov 28, 2016 at 10:20 AM, Daniel Stone wrote: > Hi Dima, > > On 24 November 2016 at 13:13, Dima Ryazanov wrote: > > When a window is being closed, the frame_done callback often runs after > > the output is already destroyed, i.e: > > > > wayla

Re: [PATCH weston] compositor-wayland: Set frame callback for Pixman

2016-11-28 Thread Dima Ryazanov
Yep, fixes the crash, thanks! Reviewed-by: Dima Ryazanov On Mon, Nov 28, 2016 at 8:06 AM, Daniel Stone wrote: > Fixing 89c2f637b9, also set the output's frame_cb for the Pixman > renderer, not just GL. Fixes a segfault when using compositor-wayland > with --use-pixman. > > Signed-off-by: Danie

Re: [PATCH weston v2] compositor-wayland: Fix a use after free

2016-11-28 Thread Daniel Stone
Hi Dima, On 24 November 2016 at 13:13, Dima Ryazanov wrote: > When a window is being closed, the frame_done callback often runs after > the output is already destroyed, i.e: > > wayland_output_start_repaint_loop > input_handle_button > wayland_output_destroy > frame_done > > To fix this

[PATCH weston] compositor-wayland: Set frame callback for Pixman

2016-11-28 Thread Daniel Stone
Fixing 89c2f637b9, also set the output's frame_cb for the Pixman renderer, not just GL. Fixes a segfault when using compositor-wayland with --use-pixman. Signed-off-by: Daniel Stone Cc: Dima Ryazanov --- libweston/compositor-wayland.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [PATCH libinput 1/7] test: add a test for safe_atoi

2016-11-28 Thread Hans de Goede
Hi, On 28-11-16 06:20, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Entire series looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- test/misc.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/test/misc.c b/test/misc.c

Re: [PATCH libinput] touchpad: add a quirk for the HP Pavilion dm4

2016-11-28 Thread Hans de Goede
Hi, On 27-11-16 23:55, Peter Hutterer wrote: This touchpad has cursor jumps for 2-finger scrolling that also affects the single-finger emulation. So disable any multitouch bits on this device and disallow the 2-finger scroll method. This still allows for 2-finger tapping/clicking. https://bugs.

Re: [PATCH wayland] doc: Remove wayland-util.c from file list

2016-11-28 Thread Daniel Stone
On 27 November 2016 at 09:48, Peter Hutterer wrote: > On Fri, Nov 25, 2016 at 10:48:36AM -0800, Yong Bakos wrote: >> Documentation generation via doxygen includes wayland-util.c in its file >> list. Although functions are documented in wayland-util.h, doxygen is >> not automatically using the same

Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-28 Thread Daniel Stone
Hi Dima, Apparently my reply here got lost in the ether ... On 24 November 2016 at 12:50, Dima Ryazanov wrote: > Forgot to mention: this only happens when using the wayland backend, not > x11. It's triggered by the next call to eglMakeCurrent (when the remaining > window is repainted), so it migh