[ANNOUNCE] libinput 1.5.2

libinput 1.5.2 is now available. The most significant change is a tweak in the handling of touchpad deltas which leads to much more responsive pointer motion. If you had issues with touchpad acceleration before, update to this version the difference is significant. A custom quirk for the HP Zbook

[PATCH weston v2] Move weston-egl-ext.h to shared

Given that it's used by clients, it's really the very definition of shared. Signed-off-by: Daniel Stone --- Makefile.am| 2 +- {libweston => shared}/weston-egl-ext.h | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename {libweston => shared}/weston-egl-ext.h (10

[PATCH weston 1/2] simple-egl: Don't prefix protocol include

Signed-off-by: Daniel Stone --- clients/simple-egl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-egl.c b/clients/simple-egl.c index ca88472..9b6fa1f 100644 --- a/clients/simple-egl.c +++ b/clients/simple-egl.c @@ -45,7 +45,7 @@ #include "xdg-shell-unstable-

[PATCH weston 2/2] Move weston-egl-ext.h to shared

Given that it's used by clients, it's really the very definition of shared. Signed-off-by: Daniel Stone --- {libweston => shared}/weston-egl-ext.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {libweston => shared}/weston-egl-ext.h (100%) diff --git a/libweston/weston-egl-ext.h b

Re: [PATCH weston 5/6] libweston-desktop/xwayland: XWAYLAND surfaces are never 'added'

Hi, On 24 November 2016 at 15:22, Pekka Paalanen wrote: > On Thu, 24 Nov 2016 16:02:14 +0100 Quentin Glidic > wrote: >> Not a big fan of asserts in internal stuff, but if you feel like it’s >> needed: > > Heh, my view is quite the opposite. > > Internal stuff is where the asserts actually belon

[PATCH weston 2/2] compositor-wayland: Destroy cursor images earlier

Destroying a wl_cursor will attempt to access the wl_display, which we have just freed. Avoid a segfault by destroying the cursor images before we destroy the display. Signed-off-by: Daniel Stone --- libweston/compositor-wayland.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

[PATCH weston 1/2] Don't prepend protocol/ to include paths

No need to add protocol/, as it's already handled by an explicit compiler include path. Signed-off-by: Daniel Stone --- libweston-desktop/xdg-shell-v5.c | 2 +- libweston-desktop/xdg-shell-v6.c | 2 +- libweston/input.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) d

Re: [PATCH weston 5/6] libweston-desktop/xwayland: XWAYLAND surfaces are never 'added'

On Thu, 24 Nov 2016 16:02:14 +0100 Quentin Glidic wrote: > On 24/11/2016 12:40, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Add documentation (asserts) that show that windows of types XWAYLAND are > > never registered with the shell. > > > > Signed-off-by: Pekka Paalanen > > Not a

Re: [PATCH weston 4/6] libweston-desktop/xwayland: clarify 'added' logic

On 24/11/2016 12:40, Pekka Paalanen wrote: From: Pekka Paalanen Setting to a constant is much easier to read and grep for than setting to a computed variable. There are no functional changes. Signed-off-by: Pekka Paalanen It was clear to me at least. ;-) Anyway: Reviewed-by: Quentin Glidic

Re: [PATCH weston 5/6] libweston-desktop/xwayland: XWAYLAND surfaces are never 'added'

On 24/11/2016 12:40, Pekka Paalanen wrote: From: Pekka Paalanen Add documentation (asserts) that show that windows of types XWAYLAND are never registered with the shell. Signed-off-by: Pekka Paalanen Not a big fan of asserts in internal stuff, but if you feel like it’s needed: Reviewed-by

Re: [PATCH weston 6/6] libweston-desktop/xwayland: add is_mapped handling for XWAYLAND

On Thu, 24 Nov 2016 15:09:39 +0100 Quentin Glidic wrote: > On 24/11/2016 12:40, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The xwayland window type XWAYLAND is not handled by the shell at all, > > instead libweston-desktop maps such surfaces itself. However, it forgot > > to set west

Re: [PATCH weston 3/6] libweston-desktop/xwayland: window type XWAYLAND cannot have a parent

On Thu, 24 Nov 2016 15:04:08 +0100 Quentin Glidic wrote: > On 24/11/2016 13:59, Pekka Paalanen wrote: > > On Thu, 24 Nov 2016 12:29:26 + > > Daniel Stone wrote: > > > >> Hi, > >> > >> On 24 November 2016 at 11:40, Pekka Paalanen wrote: > >>> Add an assert to ensure that a window of type

Re: [PATCH weston 6/6] libweston-desktop/xwayland: add is_mapped handling for XWAYLAND

On 24/11/2016 12:40, Pekka Paalanen wrote: From: Pekka Paalanen The xwayland window type XWAYLAND is not handled by the shell at all, instead libweston-desktop maps such surfaces itself. However, it forgot to set weston_surface::is_mapped and weston_view::is_mapped. weston_surface::is_mapped a

Re: [PATCH weston 3/6] libweston-desktop/xwayland: window type XWAYLAND cannot have a parent

On 24/11/2016 13:59, Pekka Paalanen wrote: On Thu, 24 Nov 2016 12:29:26 + Daniel Stone wrote: Hi, On 24 November 2016 at 11:40, Pekka Paalanen wrote: Add an assert to ensure that a window of type XWAYLAND is never attempted with a parent. This essentially adding documentation. Signed-

[PATCH weston v2] compositor-wayland: Fix a use after free

When a window is being closed, the frame_done callback often runs after the output is already destroyed, i.e: wayland_output_start_repaint_loop input_handle_button wayland_output_destroy frame_done To fix this, destroy the callback before destroying the output. (Also, fix the type of o

Re: [PATCH weston] compositor-wayland: Fix a use after free

Oh damn, I was looking for an API to cancel a callback and couldn't find anything; didn't realize all I needed to do is destroy it. That makes it so much simpler. I'll send out a follow-up patch. Thanks! On Thu, Nov 24, 2016 at 4:05 AM, Daniel Stone wrote: > Hi Dima, > > On 24 November 2016 at

Re: [PATCH weston 3/6] libweston-desktop/xwayland: window type XWAYLAND cannot have a parent

On Thu, 24 Nov 2016 12:29:26 + Daniel Stone wrote: > Hi, > > On 24 November 2016 at 11:40, Pekka Paalanen wrote: > > Add an assert to ensure that a window of type XWAYLAND is never > > attempted with a parent. > > > > This essentially adding documentation. > > > > Signed-off-by: Pekka Paala

Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

Hi Daniel, Forgot to mention: this only happens when using the wayland backend, not x11. It's triggered by the next call to eglMakeCurrent (when the remaining window is repainted), so it might not happen immediately, either. I'm using an Intel graphics card and Mesa 12.0.3. I actually saw the com

Re: [PATCH weston 6/6] libweston-desktop/xwayland: add is_mapped handling for XWAYLAND

Hi Pekka, On 24 November 2016 at 11:40, Pekka Paalanen wrote: > The xwayland window type XWAYLAND is not handled by the shell at all, > instead libweston-desktop maps such surfaces itself. However, it forgot > to set weston_surface::is_mapped and weston_view::is_mapped. > > weston_surface::is_map

Re: [PATCH weston 3/6] libweston-desktop/xwayland: window type XWAYLAND cannot have a parent

Hi, On 24 November 2016 at 11:40, Pekka Paalanen wrote: > Add an assert to ensure that a window of type XWAYLAND is never > attempted with a parent. > > This essentially adding documentation. > > Signed-off-by: Pekka Paalanen > --- > libweston-desktop/xwayland.c | 1 + > 1 file changed, 1 inser

Re: KVM and Xen guest fail with cirrus emulated graphic card

Hi Dario, On 21 November 2016 at 16:55, Dario Faggioli wrote: > So, as I reported in my comment to this (already existing) bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1227770 > > - on Wayland, with Cirrus as emulated graphic card, I don't see the >GNOME login screen appearing. > > -

Re: KVM and Xen guest fail with cirrus emulated graphic card

On Mon, 21 Nov 2016 17:55:28 +0100 Dario Faggioli wrote: > Hello, > > I've recently tried Fedora 25 inside both a KVM and Xen guest. In both > cases, the emulated graphic card selected by default is the "bad old" > Cirrus. > > So, as I reported in my comment to this (already existing) bug: > ht

Re: [PATCH weston] compositor-wayland: Fix a use after free

Hi Dima, On 24 November 2016 at 06:07, Dima Ryazanov wrote: > When a window is being closed, the frame_done callback often runs after > the output is already destroyed, i.e: > > wayland_output_start_repaint_loop > input_handle_button > wayland_output_destroy > frame_done > > To fix this

Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

Hi Dima, On 24 November 2016 at 02:41, Dima Ryazanov wrote: > Call eglMakeCurrent before destroying the native EGL window, similar to what > other sample clients are already doing. This doesn't show as an error here, with your suggested reproduction instructions. From eglDestroySurface: 'If the

Re: [PATCH weston] compositor-x11: fix segfault when use_pixman is true

Hi Munakata-san, On 24 November 2016 at 10:05, Ryo Munakata wrote: > Signed-off-by: Ryo Munakata > --- > libweston/compositor-x11.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c > index de64e49..34ef854 100644

Re: [PATCH weston] Don't include version.h from compositor.h

Hi Bryce, On 23 November 2016 at 18:57, Bryce Harrington wrote: > On Wed, Nov 23, 2016 at 06:48:42PM +, Daniel Stone wrote: >> Signed-off-by: Daniel Stone > > Nothing in compositor.h or its includes seem to need the > version #defines from version.h, so LGTM. Pushed, thanks! To ssh://git.f

[PATCH weston 3/6] libweston-desktop/xwayland: window type XWAYLAND cannot have a parent

From: Pekka Paalanen Add an assert to ensure that a window of type XWAYLAND is never attempted with a parent. This essentially adding documentation. Signed-off-by: Pekka Paalanen --- libweston-desktop/xwayland.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libweston-desktop/xwayland.c

[PATCH weston 5/6] libweston-desktop/xwayland: XWAYLAND surfaces are never 'added'

From: Pekka Paalanen Add documentation (asserts) that show that windows of types XWAYLAND are never registered with the shell. Signed-off-by: Pekka Paalanen --- libweston-desktop/xwayland.c | 4 1 file changed, 4 insertions(+) diff --git a/libweston-desktop/xwayland.c b/libweston-desktop

[PATCH weston 1/6] XWM: debug position on create_notify

From: Pekka Paalanen Helps debugging X11 window positioning issues. Signed-off-by: Pekka Paalanen --- xwayland/window-manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index c0eb7b0..4a799e3 100644 --- a/xwayla

[PATCH weston 6/6] libweston-desktop/xwayland: add is_mapped handling for XWAYLAND

From: Pekka Paalanen The xwayland window type XWAYLAND is not handled by the shell at all, instead libweston-desktop maps such surfaces itself. However, it forgot to set weston_surface::is_mapped and weston_view::is_mapped. weston_surface::is_mapped affects the behaviour of weston_view_unmap() a

[PATCH weston 4/6] libweston-desktop/xwayland: clarify 'added' logic

From: Pekka Paalanen Setting to a constant is much easier to read and grep for than setting to a computed variable. There are no functional changes. Signed-off-by: Pekka Paalanen --- libweston-desktop/xwayland.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston-d

[PATCH weston 2/6] XWM: debug position and size on map request

From: Pekka Paalanen Helps debugging initial placement problems. Signed-off-by: Pekka Paalanen --- xwayland/window-manager.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index 4a799e3..56d65af 100644 --- a/xwayla

[PATCH weston] compositor-x11: fix segfault when use_pixman is true

Signed-off-by: Ryo Munakata --- libweston/compositor-x11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston/compositor-x11.c b/libweston/compositor-x11.c index de64e49..34ef854 100644 --- a/libweston/compositor-x11.c +++ b/libweston/compositor-x11.c @@ -917,8 +917,9

Re: [PATCH weston] clients/simple-shm: remove unreachable function call

Hi Daniel-san. On Mon, 21 Nov 2016 09:44:42 + Daniel Stone wrote: > Hi Munakata-san, > > On 18 November 2016 at 12:17, Ryo Munakata wrote: > > window->wait_for_configure should be false after dispatching more than once. > > Therefore this redraw() will never be called. > > > > Signed-off-

RE: RDP backend not working along with fbdev backend

Hi, Currently, hot plugging screens is not working with ivi-shell. Best regards Emre Ucan Software Group I (ADITG/SW1) Tel. +49 5121 49 6937 > -Original Message- > From: wayland-devel [mailto:wayland-devel- > boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen > Sent: Donnerstag

Re: RDP backend not working along with fbdev backend

On Thu, 24 Nov 2016 10:28:13 +0530 Arun Kumar wrote: > Hi, > > I'm trying to port the rdp-backend in IMX6 ARM target running fb-dev as > the graphic backend. The target has the Weston > compositor with IVI shell. > > Target : NXP IMX6 > FreeRDP : 1.0.0 > Weston /Wayland : 1.9.0 > IVI shell. 1.