[PATCH weston] compositor-wayland: Fix a use after free

2016-11-23 Thread Dima Ryazanov
When a window is being closed, the frame_done callback often runs after the output is already destroyed, i.e: wayland_output_start_repaint_loop input_handle_button wayland_output_destroy frame_done To fix this, destroy the output from an idle handler (same as compositor-x11), and also s

RDP backend not working along with fbdev backend

2016-11-23 Thread Arun Kumar
Hi, I'm trying to port the rdp-backend in IMX6 ARM target running fb-dev as the graphic backend. The target has the Weston compositor with IVI shell. Target : NXP IMX6 FreeRDP : 1.0.0 Weston /Wayland : 1.9.0 IVI shell. 1.9.1 But once my system is up and running I am able to see my target comeup

Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-23 Thread Dima Ryazanov
To repro, run "valgrind weston --output-count=2", and close one of the windows. (When you close the last window, there are even more errors, so this particular one isn't as noticeable.) On Wed, Nov 23, 2016 at 6:41 PM, Dima Ryazanov wrote: > Call eglMakeCurrent before destroying the native EGL w

[PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-23 Thread Dima Ryazanov
Call eglMakeCurrent before destroying the native EGL window, similar to what other sample clients are already doing. Signed-off-by: Dima Ryazanov --- libweston/gl-renderer.c | 4 1 file changed, 4 insertions(+) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index d08bfd0..c

Re: [PATCH weston] Don't include version.h from compositor.h

2016-11-23 Thread Bryce Harrington
On Wed, Nov 23, 2016 at 06:48:42PM +, Daniel Stone wrote: > Signed-off-by: Daniel Stone Nothing in compositor.h or its includes seem to need the version #defines from version.h, so LGTM. Reviewed-by: Bryce Harrington > --- > libweston/compositor.h | 1 - > 1 file changed, 1 deletion(-) >

[PATCH weston] Don't include version.h from compositor.h

2016-11-23 Thread Daniel Stone
Signed-off-by: Daniel Stone --- libweston/compositor.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libweston/compositor.h b/libweston/compositor.h index c78cc3b..ce3d9ab 100644 --- a/libweston/compositor.h +++ b/libweston/compositor.h @@ -40,7 +40,6 @@ extern "C" { #define WL_HIDE_DEPRECA

[PATCH v3] protocol: Define further the behavior of input on the presence of grabs

2016-11-23 Thread Carlos Garnacho
The leave events in the respective device interfaces has been further documented so those can convey the necessary info when input is being redirected out of their currently focused surface. Only wl_touch is missing something semantically similar, a wl_touch.leave event has been added so the touch

[PATCH wayland] tests: Test wl_argument_from_va_list

2016-11-23 Thread Yong Bakos
From: Yong Bakos connection-test.c did not cover wl_argument_from_va_list, so add one test that specifically tests this method. Signed-off-by: Yong Bakos --- tests/connection-test.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/tests/connection-test.c

Re: [wayland-protocols v3] linux-dmabuf: advertise format modifiers with modifier event

2016-11-23 Thread Daniel Vetter
On Wed, Nov 23, 2016 at 02:39:01PM +0100, Daniel Vetter wrote: > On Mon, Nov 21, 2016 at 07:59:51PM +, Daniel Stone wrote: > > Hi Varad, > > > > On 21 November 2016 at 10:17, Varad Gautam wrote: > > > advertise the supported fourcc format modifiers along with supported > > > formats to the cl

Re: [wayland-protocols v3] linux-dmabuf: advertise format modifiers with modifier event

2016-11-23 Thread Daniel Vetter
On Mon, Nov 21, 2016 at 07:59:51PM +, Daniel Stone wrote: > Hi Varad, > > On 21 November 2016 at 10:17, Varad Gautam wrote: > > advertise the supported fourcc format modifiers along with supported > > formats to the client. > > > > bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interfac

Re: [PATCH weston] build: fix wayland-backend distcheck

2016-11-23 Thread Peter Hutterer
On Wed, Nov 23, 2016 at 11:46:57AM +0200, Pekka Paalanen wrote: > From: Pekka Paalanen > > Fix the following error from 'make distcheck': > > CC libweston/wayland_backend_la-compositor-wayland.lo > ../../libweston/compositor-wayland.c:54:51: fatal error: > xdg-shell-unstable-v6-client-p

Re: [PATCH weston] build: fix wayland-backend distcheck

2016-11-23 Thread Daniel Stone
Hi Pekka, On 23 November 2016 at 09:46, Pekka Paalanen wrote: > Fix the following error from 'make distcheck': > > CC libweston/wayland_backend_la-compositor-wayland.lo > ../../libweston/compositor-wayland.c:54:51: fatal error: > xdg-shell-unstable-v6-client-protocol.h: No such file or d

Re: [PATCH weston] tests: Extend subsurface place_{above, below} hierarchy

2016-11-23 Thread Daniel Stone
Hi, On 23 November 2016 at 10:15, Pekka Paalanen wrote: > On Tue, 22 Nov 2016 12:42:45 + Daniel Stone wrote: >> Following on from b8c16c995b, extend the family tree being tested by >> place_above and place_below a little, ensuring that subsurfaces can't be >> placed above or below surfaces w

Re: [PATCH weston] tests: Extend subsurface place_{above, below} hierarchy

2016-11-23 Thread Pekka Paalanen
On Tue, 22 Nov 2016 12:42:45 + Daniel Stone wrote: > Following on from b8c16c995b, extend the family tree being tested by > place_above and place_below a little, ensuring that subsurfaces can't be > placed above or below surfaces which are related to them, but aren't > their immediate parent

Re: [PATCH wayland] doc: Remove display of WL_PRINTF attribute

2016-11-23 Thread Daniel Stone
Hi Peter, Yong, On 23 November 2016 at 00:39, Peter Hutterer wrote: > On Tue, Nov 22, 2016 at 08:13:43AM -0800, Yong Bakos wrote: >> Doxygen truncates a WL_PRINTF function attribute, and there does not >> seem to be any workaround[1]. When using the attribute like this: >> >> typedef void (*wl_lo

[PATCH weston] build: fix wayland-backend distcheck

2016-11-23 Thread Pekka Paalanen
From: Pekka Paalanen Fix the following error from 'make distcheck': CC libweston/wayland_backend_la-compositor-wayland.lo ../../libweston/compositor-wayland.c:54:51: fatal error: xdg-shell-unstable-v6-client-protocol.h: No such file or directory #include "xdg-shell-unstable-v6-client-p

[PATCH v2] gl-renderer: support format and modifier queries

2016-11-23 Thread Varad Gautam
From: Varad Gautam EGL_EXT_image_dma_buf_import_modifiers allows querying the formats and modifiers supported by the platform. expose these to the compositor. v2: - change calloc args (Daniel Stone) - check for modifier support before querying formats (Daniel Stone) Signed-off-by: Varad Gauta

[PATCH v2] gl-renderer: allow importing fourth dmabuf plane

2016-11-23 Thread Varad Gautam
From: Varad Gautam EGL_EXT_image_dma_buf_import_modifiers supports importing upto four dmabuf planes into an EGLImage. v2: correct PLANE3_PITCH token (Daniel Stone) Signed-off-by: Varad Gautam Reviewed-by: Daniel Stone --- libweston/gl-renderer.c| 17 - libweston/weston-e

[PATCH v2] clients/simple-dmabuf-drm: import with dmabuf modifiers

2016-11-23 Thread Varad Gautam
From: Varad Gautam mesa's freedreno driver supports importing dmabufs with format DRM_FORMAT_NV12 and DRM_FORMAT_MOD_SAMSUNG_64_32_TILE modifier. demonstrate weston modifier advertising and import path using this combination when run with --import-format=NV12. v2: - hard code format if platform

[PATCH v2] gl-renderer: allow importing dmabufs with format modifiers

2016-11-23 Thread Varad Gautam
From: Varad Gautam pass over the modifier attributes to EGL. v2: ensure same modifier is passed for all planes (Daniel Stone) Signed-off-by: Varad Gautam --- libweston/gl-renderer.c| 29 ++--- libweston/weston-egl-ext.h | 6 ++ 2 files changed, 32 insertions(+

Re: [PATCH wayland v2 3/3] tests: add scanner tests

2016-11-23 Thread Pekka Paalanen
On Tue, 22 Nov 2016 07:46:16 -0800 Yong Bakos wrote: > Hi Pekka, > > > On Nov 16, 2016, at 3:38 AM, Pekka Paalanen wrote: > > > > From: Pekka Paalanen > > > > Add tests that ensure that wayland-scanner output for a given input does > > not change unexpectedly. This makes it very easy to revi