Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Ping Cheng
On Tuesday, November 22, 2016, Peter Hutterer wrote: > On Tue, Nov 22, 2016 at 09:03:52AM -0800, Ping Cheng wrote: > > On Tuesday, November 22, 2016, Daniel Stone > wrote: > > > > > Hey, > > > > > > On 21 November 2016 at 23:13, Peter Hutterer > > > > wrote: > > > > On Mon, Nov 21, 2016 at 12:

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Peter Hutterer
On Tue, Nov 22, 2016 at 09:03:52AM -0800, Ping Cheng wrote: > On Tuesday, November 22, 2016, Daniel Stone wrote: > > > Hey, > > > > On 21 November 2016 at 23:13, Peter Hutterer > > wrote: > > > On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: > > >> Concretely though, reusing BTN_*

Re: [PATCH wayland] doc: Remove display of WL_PRINTF attribute

2016-11-22 Thread Peter Hutterer
On Tue, Nov 22, 2016 at 08:13:43AM -0800, Yong Bakos wrote: > From: Yong Bakos > > Doxygen truncates a WL_PRINTF function attribute, and there does not > seem to be any workaround[1]. When using the attribute like this: > > typedef void (*wl_log_func_t)(const char *, va_list) WL_PRINTF(1, 0); >

Re: [PATCH weston] weston-terminal: Fix crash on first keystroke

2016-11-22 Thread Daniel Stone
Hi, On 22 November 2016 at 19:00, Derek Foreman wrote: > Since 894b3rcc634 weston-terminal will crash on first keystroke if you > fail to create an xkb compose state. This can happen if you don't have > a Compose file. > > Instead, no we just return uncomposed symbols. Obviously correct, apart

[PATCH weston] weston-terminal: Fix crash on first keystroke

2016-11-22 Thread Derek Foreman
Since 894b3rcc634 weston-terminal will crash on first keystroke if you fail to create an xkb compose state. This can happen if you don't have a Compose file. Instead, no we just return uncomposed symbols. Signed-off-by: Derek Foreman --- clients/window.c | 1 + 1 file changed, 1 insertion(+)

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Ping Cheng
On Tuesday, November 22, 2016, Daniel Stone wrote: > Hey, > > On 21 November 2016 at 23:13, Peter Hutterer > wrote: > > On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: > >> Concretely though, reusing BTN_* codes where possible would make it > >> easier for clients to transition bet

[PATCH wayland] doc: Remove display of WL_PRINTF attribute

2016-11-22 Thread Yong Bakos
From: Yong Bakos Doxygen truncates a WL_PRINTF function attribute, and there does not seem to be any workaround[1]. When using the attribute like this: typedef void (*wl_log_func_t)(const char *, va_list) WL_PRINTF(1, 0); Doxygen generates something that looks like this: typedef void (*wl_log_

Re: [PATCH wayland v2 3/3] tests: add scanner tests

2016-11-22 Thread Yong Bakos
Hi Pekka, > On Nov 16, 2016, at 3:38 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Add tests that ensure that wayland-scanner output for a given input does > not change unexpectedly. This makes it very easy to review > wayland-scanner patches. > > Before, when patches were proposed f

Re: [PATCH v2] protocol: Define further the behavior of input on the presence of grabs

2016-11-22 Thread Carlos Garnacho
Hey Daniel :), On Tue, Nov 22, 2016 at 12:43 PM, Daniel Stone wrote: > Hi Carlos, > > On 12 November 2015 at 12:31, Carlos Garnacho wrote: >> The leave events in the respective device interfaces has been further >> documented so those can convey the necessary info when input is being >> redirect

[PATCH weston] tests: Extend subsurface place_{above, below} hierarchy

2016-11-22 Thread Daniel Stone
Following on from b8c16c995b, extend the family tree being tested by place_above and place_below a little, ensuring that subsurfaces can't be placed above or below surfaces which are related to them, but aren't their immediate parent or sibling. Signed-off-by: Daniel Stone Cc: Arnaud Vrac Cc: Pe

Re: [PATCH weston] compositor: allow using nested parent as a subsurface sibling

2016-11-22 Thread Daniel Stone
Hi Arnaud, On 8 June 2016 at 17:37, Arnaud Vrac wrote: > The parent of a subsurface can be used as a sibling in the place_below > and place_above calls. However this did not work when the parent is > nested, so fix the sibling check and add a test to check this case. It took a few reads over, bu

Re: [PATCH weston] xwayland: Create the drag-and-drop window in weston_wm_dnd_init

2016-11-22 Thread Daniel Stone
Hi, On 16 November 2016 at 15:32, Daniel Stone wrote: > On 24 May 2016 at 19:34, Derek Foreman wrote: >> On 22/02/16 12:42 PM, Carlos Garnacho wrote: >>> Just to keep it hidden so far... A lot of the plumbing necessary to >>> handle x11->wayland drag and drop is missing, and the current >>> part

Re: [PATCH v2] protocol: Define further the behavior of input on the presence of grabs

2016-11-22 Thread Daniel Stone
Hi Carlos, On 12 November 2015 at 12:31, Carlos Garnacho wrote: > The leave events in the respective device interfaces has been further > documented so those can convey the necessary info when input is being > redirected out of their currently focused surface. > > Only wl_touch is missing somethi

KVM and Xen guest fail with cirrus emulated graphic card

2016-11-22 Thread Dario Faggioli
Hello, I've recently tried Fedora 25 inside both a KVM and Xen guest. In both cases, the emulated graphic card selected by default is the "bad old" Cirrus. So, as I reported in my comment to this (already existing) bug: https://bugzilla.redhat.com/show_bug.cgi?id=1227770  - on Wayland, with Cirr

Re: [PATCH weston 7/8] compositor-drm: Implement clone mode, refactor output into logical ones

2016-11-22 Thread Daniel Stone
Hi, On 22 November 2016 at 09:41, Pekka Paalanen wrote: > On Tue, 22 Nov 2016 09:06:00 + Daniel Stone wrote: >> Thanks for this - it's a good point. It's strengthened my resolve a >> little bit though, especially in the context of >> https://phabricator.freedesktop.org/T7621, where our probl

Re: [PATCH wayland] doc: start documenting Xwayland

2016-11-22 Thread Pekka Paalanen
On Tue, 22 Nov 2016 09:20:48 + Daniel Stone wrote: > Hi, > Hi Daniel, nice comments, I'll revise the patch later. Some replies below. > On 21 November 2016 at 15:06, Pekka Paalanen > wrote: > > On Mon, 21 Nov 2016 14:31:43 +0200 > > Pekka Paalanen wrote: > >> + > >> + X11 and

Re: [PATCH weston 7/8] compositor-drm: Implement clone mode, refactor output into logical ones

2016-11-22 Thread Pekka Paalanen
On Tue, 22 Nov 2016 09:06:00 + Daniel Stone wrote: > Hi Pekka, > > On 22 November 2016 at 08:54, Pekka Paalanen wrote: > > On Mon, 21 Nov 2016 19:41:33 + Daniel Stone > > wrote: > >> On 2 May 2016 at 22:40, Emmanuel Gil Peyrot > >> wrote: > >> The core already has to deal with sur

Re: [weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-11-22 Thread Daniel Stone
Hi Vincent, On 22 November 2016 at 09:14, Vincent ABRIOU wrote: > This was not my understanding of the EGL extension. > In that case I agree it still make sense. > I will then propose a new implementation to take into account your comment. The EGL extension is to advertise all formats which can

Re: [PATCH wayland] doc: start documenting Xwayland

2016-11-22 Thread Daniel Stone
Hi, On 21 November 2016 at 15:06, Pekka Paalanen wrote: > On Mon, 21 Nov 2016 14:31:43 +0200 > Pekka Paalanen wrote: >> + >> + X11 and Wayland are different enough that there is no "simple" way to >> + translate between them. Most of X11 is uninteresting to a Wayland >> + comp

Re: [weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-11-22 Thread Vincent ABRIOU
Hi Daniel, This was not my understanding of the EGL extension. In that case I agree it still make sense. I will then propose a new implementation to take into account your comment. Vincent On 11/22/2016 10:07 AM, Daniel Stone wrote: > Hi Vincent, > > On 22 November 2016 at 08:54, Vincent ABRIOU

Re: [RFC v2 wayland-protocols] tablet: define our own enum for tablet tool buttons

2016-11-22 Thread Daniel Stone
Hey, On 21 November 2016 at 23:13, Peter Hutterer wrote: > On Mon, Nov 21, 2016 at 12:42:36PM +, Daniel Stone wrote: >> Concretely though, reusing BTN_* codes where possible would make it >> easier for clients to transition between the two. > > I disagree here. The kernel only has BTN_STYLUS

Re: [PATCH libinput] touchpad: only use the last two coordinates for delta calculation

2016-11-22 Thread Hans de Goede
Hi, On 22-11-16 02:34, Peter Hutterer wrote: Taking the last 4 points means factoring in a coordinate that may be more than 40ms in the past - or even more when the finger moves slowly and we don't get events for a while. This makes the pointer more sluggish and slower to catch up with what the

Re: [PATCH libinput 1/4] test: start with the first offset when moving touches

2016-11-22 Thread Hans de Goede
Hi, On 22-11-16 02:32, Peter Hutterer wrote: This doesn't have an effect in our current tests because the touchpad always needs 4 motion events to get moving. But for the future, it simplifies the case of "i want to move between x1/y1 and x2/y2", because it fills in only the events in between ra

Re: [weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-11-22 Thread Daniel Stone
Hi Vincent, On 22 November 2016 at 08:54, Vincent ABRIOU wrote: > I did this patch because I didn't know when the EGL extension to > advertise EGL supported format will be available. > Since Varad patch set I understand that it is in a good way to land shortly. > > So we can abandon my patch. No

Re: [PATCH weston 7/8] compositor-drm: Implement clone mode, refactor output into logical ones

2016-11-22 Thread Daniel Stone
Hi Pekka, On 22 November 2016 at 08:54, Pekka Paalanen wrote: > On Mon, 21 Nov 2016 19:41:33 + Daniel Stone wrote: >> On 2 May 2016 at 22:40, Emmanuel Gil Peyrot >> wrote: >> The core already has to deal with surfaces overlapping multiple 'real' >> outputs - i.e. running on different paint

Re: [weston] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

2016-11-22 Thread Vincent ABRIOU
I Daniel, I did this patch because I didn't know when the EGL extension to advertise EGL supported format will be available. Since Varad patch set I understand that it is in a good way to land shortly. So we can abandon my patch. BR Vincent On 11/21/2016 06:49 PM, Daniel Stone wrote: > Hi Vinc

Re: [PATCH weston 7/8] compositor-drm: Implement clone mode, refactor output into logical ones

2016-11-22 Thread Pekka Paalanen
On Mon, 21 Nov 2016 19:41:33 + Daniel Stone wrote: > Hi Emmanuel, > > On 2 May 2016 at 22:40, Emmanuel Gil Peyrot > wrote: > > Introduces a “same-as” configuration option for each output, which > > bypasses the rest of the output configuration (mode, scale, transform > > and seat) and inste