[PATCH weston v2 5/8] clients/window: use weston_platform_destroy_egl_surface wrapper

2016-11-18 Thread Emil Velikov
From: Emil Velikov v2: Use correct (destroy) API (Dan) Signed-off-by: Emil Velikov --- clients/window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 84d585e..9c2fc68 100644 --- a/clients/window.c +++ b/clients/window.c @@ -645,7

Re: [PATCH] weston-editor: Don't copy the preedit string before inserting it

2016-11-18 Thread Silvan Jegen
Hi Bryce And thanks for the review! On Fri, Nov 18, 2016 at 1:20 AM, Bryce Harrington wrote: > On Thu, Nov 17, 2016 at 09:43:05PM +0100, Silvan Jegen wrote: >> Signed-off-by: Silvan Jegen >> --- >> clients/editor.c | 8 +--- >> 1 file changed, 1 insertion(+), 7 deletions(-) >> >> diff --gi

Re: [PATCH wayland v3] util: Improve documentation of wl_argument

2016-11-18 Thread Pekka Paalanen
On Mon, 14 Nov 2016 08:32:01 +1000 Peter Hutterer wrote: > On Sat, Nov 12, 2016 at 10:11:21AM -0800, Yong Bakos wrote: > > From: Yong Bakos > > > > Standardize the doxygen comment format, add clarity to the writing, decouple > > the description from specifics of usage, add see-also's, and massa

Re: [PATCH wayland] tests: Add nullable check to wl_message_count_arrays

2016-11-18 Thread Pekka Paalanen
On Fri, 11 Nov 2016 07:08:09 -0800 Yong Bakos wrote: > From: Yong Bakos > > Array argument symbols in a wl_message may be nullable, but the test for > wl_message_count_arrays did not test this. Add one more wl_message with > nullable array arguments. > > Signed-off-by: Yong Bakos > --- > tes

Re: [PATCH wayland v2] tests: Test wl_interface_equal

2016-11-18 Thread Pekka Paalanen
On Tue, 8 Nov 2016 07:56:30 -0800 Yong Bakos wrote: > From: Yong Bakos > > The test suite did not cover wl_interface_equal, so add one test that > specifically tests this method. Add the new test to Makefile.am. > > Signed-off-by: Yong Bakos > --- > v2: Remove unnecessary server header inclu

Re: [PATCH wayland] util: Document wl_interface

2016-11-18 Thread Pekka Paalanen
On Sun, 6 Nov 2016 18:25:37 -0800 Yong Bakos wrote: > From: Yong Bakos > > Add doxygen comments for wl_interface. > > Signed-off-by: Yong Bakos > --- > src/wayland-util.h | 52 > 1 file changed, 52 insertions(+) > > diff --git a/src/wayl

Re: [PATCH v2 wayland] protocol: indentation fixes

2016-11-18 Thread Yong Bakos
On Nov 17, 2016, at 7:49 PM, Peter Hutterer wrote: > > 8 spaces changed to one tab > > Signed-off-by: Peter Hutterer > Acked-by: Bryce Harrington Reviewed-by: Yong Bakos Cheers, yong > --- > Changes to v1: > - Rebased on top of aa51a83 > > protocol/wayland.xml | 100 +

Re: [PATCH weston] text-input: Clear out context->input pointer

2016-11-18 Thread Pekka Paalanen
On Thu, 10 Nov 2016 15:47:56 + Daniel Stone wrote: > If we destroy the text_input (e.g. due to surface deactivation) whilst > the IM manager (the client holding the input_method_context resource, > usually weston-keyboard) sends an event, we can hit a segfault in > text-backend. This is becau

[PATCH weston] clients/simple-shm: remove unreachable function call

2016-11-18 Thread Ryo Munakata
window->wait_for_configure should be false after dispatching more than once. Therefore this redraw() will never be called. Signed-off-by: Ryo Munakata --- clients/simple-shm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/clients/simple-shm.c b/clients/simple-shm.c index 9fa2e21..04b4eff

[PATCH weston] libweston: remove unused function declaration of weston_compositor_top

2016-11-18 Thread Ryo Munakata
Signed-off-by: Ryo Munakata --- libweston/compositor.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/libweston/compositor.h b/libweston/compositor.h index e00d285..4ca52f9 100644 --- a/libweston/compositor.h +++ b/libweston/compositor.h @@ -1451,9 +1451,6 @@ weston_compositor_set_default_