[PATCH weston] Get rid of the window_create_menu function

2016-11-13 Thread Dima Ryazanov
It's currently unused, and there's actually no way to use it correctly. The caller cannot free the menu that was created: - the function only returns the window, not the menu - there's no public API to destroy a menu object Signed-off-by: Dima Ryazanov --- clients/window.c | 15 ---

Re: [PATCH v6] protocol: Extend wl_touch with touchpoint shape and orientation

2016-11-13 Thread Peter Hutterer
On Fri, Nov 11, 2016 at 11:40:55AM -0800, Dennis Kempin wrote: > This CL updates the wl_touch interface with a shape and > orientation event. > The shape/orientation of a touch point is not relevant for most UI > applications, but allows a better experience in some cases > such as drawing apps. >

[PATCH libinput 4/4] Disable test runs on 'distcheck'

2016-11-13 Thread Peter Hutterer
The tests require the creation of udev devices which in turn require root and usually cause distcheck runs to fail. Add a new option to disable the *running* of tests at distcheck (we still want to build them). Signed-off-by: Peter Hutterer --- Makefile.am | 2 ++ configure.ac | 7 +

[PATCH libinput 2/4] configure.ac: add some comment markers to see the configure.ac sections easier

2016-11-13 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- configure.ac | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index 012ab0b..5b5b68a 100644 --- a/configure.ac +++ b/configure.ac @@ -83,6 +83,9 @@ fi AC_SUBST(GCC_CFLAGS) AC_SUBST(GCC_CXXFLAGS) +###

[PATCH libinput 3/4] configure.ac: move the udev test path up into the test section

2016-11-13 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- configure.ac | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 5b5b68a..206a4ed 100644 --- a/configure.ac +++ b/configure.ac @@ -211,6 +211,12 @@ if test "x$build_tests" = "xyes"; then fi f

[PATCH libinput 1/4] configure.ac: move all AM_CONDITIONALs into one place

2016-11-13 Thread Peter Hutterer
Makes it easier to see in one go what is conditional in the build. Signed-off-by: Peter Hutterer --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 43db9bb..012ab0b 100644 --- a/configure.ac +++ b/configure.ac @@ -159,7 +1

Re: [PATCH wayland v3] util: Improve documentation of wl_argument

2016-11-13 Thread Peter Hutterer
On Sat, Nov 12, 2016 at 10:11:21AM -0800, Yong Bakos wrote: > From: Yong Bakos > > Standardize the doxygen comment format, add clarity to the writing, decouple > the description from specifics of usage, add see-also's, and massage the union > member type comments. > > Signed-off-by: Yong Bakos

Re: [PATCH wayland] util: Document wl_fixed_t

2016-11-13 Thread Peter Hutterer
On Fri, Nov 11, 2016 at 07:55:38AM -0800, Yong Bakos wrote: > From: Yong Bakos > > Add doxygen comments for wl_fixed_t and its methods. > > Although wl_fixed_t can be thought of as an opaque struct, it is a typedef. As > such, doxygen does not provide an elegant means of documenting it as both a

[RFC wayland 0/1] tests: Test wl_argument_from_va_list

2016-11-13 Thread Yong Bakos
From: Yong Bakos Hello, My ongoing routine of documenting objects and checking for related test coverage has recently led me to notice that wl_argument_from_va_list does not have a specific test in connection-test.c. The 1/1 patch in this RFC describes a rough draft at the testing approach: using

[RFC wayland 1/1] tests: Test wl_argument_from_va_list

2016-11-13 Thread Yong Bakos
From: Yong Bakos connection-test.c did not cover wl_argument_from_va_list, so add one test that specifically tests this method. Signed-off-by: Yong Bakos --- tests/connection-test.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/connection-test.c b/tests/conne