[PATCH weston v2] xwayland: Fix crash when run with no input device

Starting an xterm with no input device led to a crash because weston_wm_pick_seat() was returning garbage and weston_wm_selection_init() was trying to use the garbage. Signed-off-by: Tom Hochstein --- v2: Don't call weston_wm_set_selection if there is no seat xwayland/selection.c | 2 ++ x

[PATCH v2 libinput] evdev: actually ignore joysticks

A joystick has ID_INPUT_JOYSTICK *and* ID_INPUT set, so we need to check for both. https://bugs.freedesktop.org/show_bug.cgi?id=98009 Signed-off-by: Peter Hutterer --- Changes to v1: - fix bug with previous version where a device with just ID_INPUT set would be detected as joystick (though in

Re: [PATCH libinput] evdev: actually ignore joysticks

On Tue, Nov 01, 2016 at 08:06:09PM -0700, Dima Ryazanov wrote: > On Tue, Nov 1, 2016 at 6:19 PM, Peter Hutterer > wrote: > > > A joystick has ID_INPUT_JOYSTICK *and* ID_INPUT set, so we need to check > > for > > both. > > > > https://bugs.freedesktop.org/show_bug.cgi?id=98009 > > > > Signed-off-b

Re: [PATCH libinput] evdev: actually ignore joysticks

On Tue, Nov 1, 2016 at 6:19 PM, Peter Hutterer wrote: > A joystick has ID_INPUT_JOYSTICK *and* ID_INPUT set, so we need to check > for > both. > > https://bugs.freedesktop.org/show_bug.cgi?id=98009 > > Signed-off-by: Peter Hutterer > --- > src/evdev.c | 2 +- > test/device.c | 34 +++

[PATCH libinput] evdev: actually ignore joysticks

A joystick has ID_INPUT_JOYSTICK *and* ID_INPUT set, so we need to check for both. https://bugs.freedesktop.org/show_bug.cgi?id=98009 Signed-off-by: Peter Hutterer --- src/evdev.c | 2 +- test/device.c | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-)

Re: [RFC wayland] tests: Test wl_message_count_arrays

2016-11-01 18:49 GMT+01:00 Yong Bakos : > On Nov 1, 2016, at 10:35 AM, Giulio Camuffo wrote: >> >> Hi, >> >> I think i would put more messages in the array, just two seems like >> it's not really testing much. Besides that it looks good. >> >> >> Cheers, >> Giulio > > Thanks Giulio, I'll add some

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

Dear Esaki-san, On 30 September 2016 at 10:28, Tomohito Esaki wrote: > Multiplanar formats are supported by using drmModeAddFB2 and bypassing > gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path > is used and multiplanar formats are unsupported. Thanks very much for these fou

Re: [PATCH 1/1] libweston: fix building issue when EGL support is not enabled

Hi, On 1 November 2016 at 17:51, Giulio Camuffo wrote: > 2016-10-11 13:47 GMT+02:00 Vincent Abriou : >> weston-egl-ext.h has been include in compositor-xx.c file in order to >> define EGL_PLATFORM_xxx_KHR extensions used by the compositors. >> But in case EGL support is not enabled, all EGL relat

Re: [RFC wayland] tests: Test wl_message_count_arrays

On Nov 1, 2016, at 10:35 AM, Giulio Camuffo wrote: > > Hi, > > I think i would put more messages in the array, just two seems like > it's not really testing much. Besides that it looks good. > > > Cheers, > Giulio Thanks Giulio, I'll add some more. My main concern (hence the RFC) is about ABI

Re: [weston] gl-renderer: conditionally call query_buffer while gl_renderer_attach

Hi, 2016-10-07 17:08 GMT+02:00 Vincent Abriou : > While gl_renderer_attach, query_buffer should be call only if the > query_buffer function exists. > > Signed-off-by: Vincent Abriou > --- > libweston/gl-renderer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libwest

Re: [PATCH 1/1] libweston: fix building issue when EGL support is not enabled

2016-10-11 13:47 GMT+02:00 Vincent Abriou : > weston-egl-ext.h has been include in compositor-xx.c file in order to > define EGL_PLATFORM_xxx_KHR extensions used by the compositors. > But in case EGL support is not enabled, all EGL related definition must > be skipped except EGL_PLATFORM_xxx_KHR th

Re: [RFC wayland] tests: Test wl_message_count_arrays

Hi, I think i would put more messages in the array, just two seems like it's not really testing much. Besides that it looks good. Cheers, Giulio 2016-10-27 17:58 GMT+02:00 Yong Bakos : > From: Yong Bakos > > message-test.c did not cover wl_message_count_arrays, so add one test that > specifica

Re: [PATCH weston] xwayland: Fix crash when run with no input device

Hi, 2016-11-01 2:38 GMT+01:00 Tom Hochstein : > Starting an xterm with no input device led to a crash > because weston_wm_pick_seat() was returning garbage and > weston_wm_selection_init() was trying to use the garbage. > > Signed-off-by: Tom Hochstein > --- > xwayland/selection.c | 10

Re: [PATCH weston] xwayland: Move includes to avoid deprecation warnings

On 1 November 2016 at 16:55, Yong Bakos wrote: > On Oct 31, 2016, at 7:53 AM, Daniel Stone wrote: >> compositor.h already helpfully defines WL_HIDE_DEPRECATED for us, so we >> don't get warnings about wl_buffer (in particular) being deprecated when >> we have wayland-server headers defining it as

Re: [PATCH weston] xwayland: Move includes to avoid deprecation warnings

On Oct 31, 2016, at 7:53 AM, Daniel Stone wrote: > > compositor.h already helpfully defines WL_HIDE_DEPRECATED for us, so we > don't get warnings about wl_buffer (in particular) being deprecated when > we have wayland-server headers defining it as deprecated, and then > wayland-client headers usi

[PATCH weston] xwayland: Fix crash when run with no input device

Starting an xterm with no input device led to a crash because weston_wm_pick_seat() was returning garbage and weston_wm_selection_init() was trying to use the garbage. Signed-off-by: Tom Hochstein --- xwayland/selection.c | 10 +++--- xwayland/window-manager.c | 6 -- 2 files chang