Re: [PATCH weston v2 2/3] compositor-drm: Add scanout support for linux_dmabuf buffers

2016-10-03 Thread Derek Foreman
On 30/09/16 04:28 AM, Tomohito Esaki wrote: This implementations bypasses gbm and passes the dmabuf handles directly to libdrm for composition. Signed-off-by: Tomohito Esaki Very cool work! Acked-by: Derek Foreman I don't see anything here that Eric hasn't already mentioned, but I'm having

Re: [PATCH weston v2 1/3] compositor-drm: refactor destroy drm_fb function

2016-10-03 Thread Derek Foreman
On 30/09/16 04:28 AM, Tomohito Esaki wrote: The drm_fb destroy callback to mostly the same thing regardless of whether the buffer is a dumb buffer or gbm buffer. This patch refactors the common parts into a new function that can be called for both cases. Signed-off-by: Tomohito Esaki --- libwe

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-03 Thread Daniel Stone
Hi, On 3 October 2016 at 15:01, Derek Foreman wrote: > On 03/10/16 06:03 AM, Fabien DESSENNE wrote: >> I do not know all the history of Weston, and I am not aware of all the >> reasons that made the sprites "broken". I have always been told that it >> was not a good idea to enable sprites because

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-03 Thread Derek Foreman
On 03/10/16 06:03 AM, Fabien DESSENNE wrote: On 09/30/2016 08:49 PM, Derek Foreman wrote: On 30/09/16 04:28 AM, Tomohito Esaki wrote: Multiplanar formats are supported by using drmModeAddFB2 and bypassing gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path is used and multip

Re: [weston 2/2] gl-renderer: add support of WL_SHM_FORMAT_NV12

2016-10-03 Thread Daniel Stone
Hi Vincent, On 5 August 2016 at 10:21, Vincent Abriou wrote: > This patch allow weston to accept WL_SHM_FORMAT_NV12 buffers. > > It has been tested on top of weston-1.11 Both of these patches have some quite long lines: could you please wrap to 80 characters? > @@ -1352,6 +1353,9 @@ gl_renderer

Re: [PATCH weston v2 3/3] compositor-drm: Support linux_dmabuf output for sprite planes without gbm

2016-10-03 Thread Fabien DESSENNE
On 09/30/2016 08:49 PM, Derek Foreman wrote: > On 30/09/16 04:28 AM, Tomohito Esaki wrote: >> Multiplanar formats are supported by using drmModeAddFB2 and bypassing >> gbm. If drmModeAddFB2 isn't available, the existing gbm bo import path >> is used and multiplanar formats are unsupported. > I'm n