Re: [PATCH wayland v2] scanner: Remove return doxygen annotation

2016-09-07 Thread Bryce Harrington
On Wed, Sep 07, 2016 at 06:25:27AM -0700, Yong Bakos wrote: > From: Yong Bakos > > Replace \returns with just Returns, as this is not a doxygen comment block. > (Avoids differing with the existing convention of \return for return values.) > > Signed-off-by: Yong Bakos Reviewed-by: Bryce Harring

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-09-07 Thread Bryce Harrington
On Wed, Aug 31, 2016 at 11:17:09PM +0100, Emil Velikov wrote: > On 31 August 2016 at 19:10, Derek Foreman wrote: > >>> +* Edit a local copy of the script to make $WLD point to the base > >>> directory > >> How about one honours the WLD that's already set since ... > > > > It's not already set - t

Re: [PATCH wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-09-07 Thread Bryce Harrington
On Wed, Aug 31, 2016 at 01:10:59PM -0500, Derek Foreman wrote: > Thanks for taking a look! > > On 31/08/16 04:22 AM, Emil Velikov wrote: > > On 30 August 2016 at 19:56, Derek Foreman wrote: > >> From: "Reynaldo H. Verdejo Pinochet" > >> > >> The wl_uninstalled script provides a shell environment

Re: [PATCH v2 wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-09-07 Thread Bryce Harrington
On Wed, Sep 07, 2016 at 01:26:03PM -0500, Derek Foreman wrote: > From: "Reynaldo H. Verdejo Pinochet" > > This is an alternative to developing with a --prefixed > installation, and is a familiar workflow for developers > coming from some projects (such as gstreamer). Compared to > a prefixed ins

Re: [PATCH libinput] tools: prefix debug output with '.' on device changes

2016-09-07 Thread Peter Hutterer
On Thu, Sep 08, 2016 at 03:55:47PM +1000, Peter Hutterer wrote: > We print the sysname, but it's not always obvious when there's an event from > another device within the stream from another device. Prefix it so it's easier > to spot and search for. > > See https://bugzilla.redhat.com/show_bug.cgi

[PATCH libinput] tools: prefix debug output with '.' on device changes

2016-09-07 Thread Peter Hutterer
We print the sysname, but it's not always obvious when there's an event from another device within the stream from another device. Prefix it so it's easier to spot and search for. See https://bugzilla.redhat.com/show_bug.cgi?id=1364850#c3 for an example of how such an event can hide. We only use

Re: [PATCH libinput] touchpad: require at least 3 events before enabling trackpoint palm detection

2016-09-07 Thread Peter Hutterer
On Wed, Sep 07, 2016 at 10:22:22AM +1000, Peter Hutterer wrote: > Some trackpoints, notably the one on the Lenovo T460s have a tendency to send > the odd event even when they're not actually used. Trackpoint events trigger > palm detection (see 0210f1fee193) and thus effectively disable the touchpa

[PATCH v2 wayland-build-tools] Add helper script to setup and use an uninstalled environment

2016-09-07 Thread Derek Foreman
From: "Reynaldo H. Verdejo Pinochet" This is an alternative to developing with a --prefixed installation, and is a familiar workflow for developers coming from some projects (such as gstreamer). Compared to a prefixed installation it saves a small amount of time (primarily due to relinking durin

[PATCH weston v3] build: add -uninstalled.pc.in files for libweston and libweston-desktop

2016-09-07 Thread Derek Foreman
From: "Reynaldo H. Verdejo Pinochet" -uninstalled.pc files are a pkg-config facility for working with uninstalled libraries. With pkg-config, foo-uninstalled.pc overrides foo.pc. foo-uninstalled.pc should never be installed, and will be generated with references to the build directory. If you

Re: [PATCH wayland 4/4] build: remove white space in -uninstalled.pc.in files

2016-09-07 Thread Derek Foreman
On 30/08/16 12:24 PM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > Afaict the gratuitous space isn't a requirement, then again I've just > read up on -uninstalled .pc files. Obviously correct, Reviewed-by: Derek Foreman > --- > src/wayland-scanner-uninstal

[PATCH wayland v2] scanner: Remove return doxygen annotation

2016-09-07 Thread Yong Bakos
From: Yong Bakos Replace \returns with just Returns, as this is not a doxygen comment block. (Avoids differing with the existing convention of \return for return values.) Signed-off-by: Yong Bakos --- v2: Just remove the doxygen annotation (whot) src/scanner.c | 2 +- 1 file changed, 1 insert

Re: [PATCH weston v3 3/3] libweston-desktop/xdg_shell_v5: Add surface as needed

2016-09-07 Thread Quentin Glidic
On 06/09/2016 05:46, Jonas Ã…dahl wrote: On Sun, Sep 04, 2016 at 06:37:59PM +0200, Quentin Glidic wrote: From: Quentin Glidic This way we are sure the compositor is aware of a surface when we forward a request for said surface. Signed-off-by: Quentin Glidic On all three: Reviewed-by: Jonas