Re: [PATCH weston] clients: Add a weston-autorotater client and rotater protocol

2016-08-08 Thread Emmanuel Gil Peyrot
On Mon, May 23, 2016 at 12:00:13PM +0300, Pekka Paalanen wrote: > On Sat, 21 May 2016 03:43:04 +0100 > Emmanuel Gil Peyrot wrote: > > > This client uses libiio to retrieve accelerometer values from the iio > > subsystem on Linux (and maybe some other kernels), and automatically > > rotate the out

[PATCH weston v2] clients: Add a weston-autorotator client and rotator protocol

2016-08-08 Thread Emmanuel Gil Peyrot
This client uses libiio to retrieve accelerometer values from the iio subsystem on Linux (and maybe some other kernels), and automatically rotate the output whenever orientation changed. I tested it with a mma8453 accelerometer, but everything needed should be available in the configuration to mak

Re: [PATCH wayland 2/2] scanner: Generate all SINCE_VERSION macros for everyone

2016-08-08 Thread Quentin Glidic
On 08/08/2016 15:45, Pekka Paalanen wrote: On Tue, 5 Jul 2016 20:41:50 +0200 Quentin Glidic wrote: From: Quentin Glidic Practical example: a client supporting version 2 of wl_output will wait for the wl_output.done event before starting wl_output-related operations. However, if the server o

Re: [PATCH wayland 2/2] scanner: Generate all SINCE_VERSION macros for everyone

2016-08-08 Thread Pekka Paalanen
On Tue, 5 Jul 2016 20:41:50 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Practical example: a client supporting version 2 of wl_output will wait > for the wl_output.done event before starting wl_output-related > operations. However, if the server only supports version 1, no event > w

Re: [PATCH weston] libweston: Implement wl_output version 3 (release request)

2016-08-08 Thread Pekka Paalanen
On Tue, 5 Jul 2016 20:44:33 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > libweston/compositor.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/libweston/compositor.c b/libweston/compositor.c > index 7

Re: [PATCH wayland 1/2] protocol: Add release (destructor) request to wl_output

2016-08-08 Thread Pekka Paalanen
On Tue, 5 Jul 2016 20:41:49 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > protocol/wayland.xml | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 700ef03..0

Re: [PATCH 1/3 v3] wayland-server: Add API to control globals visibility

2016-08-08 Thread Giulio Camuffo
2016-08-08 11:07 GMT+02:00 Olivier Fourdan : > Hi Giulio, > > On 8 August 2016 at 10:53, Giulio Camuffo wrote: >> Hi, >> >> this looks like a nice way to implement restricted interfaces... i >> just wonder, would we need to revoke allowed interfaces? How would >> this approach allow that? > > Not

Re: [PATCH weston v2] compositor-drm: Use non-cast functions to retrieve backend and output objects

2016-08-08 Thread Pekka Paalanen
On Fri, 5 Aug 2016 15:54:18 +0200 Armin Krezović wrote: > This uses container_of instead of explicit cast to retrieve > backend and output objects from generic weston_backend and > weston_output pointers. > > v2: > > - Remove unneeded cast > - Remove unneeded line breaks > > Signed-off-by: Ar

Re: [PATCH weston v4 5/5] Switch to use safe_strtoint instead of strtol

2016-08-08 Thread Pekka Paalanen
On Wed, 3 Aug 2016 17:40:52 -0700 Bryce Harrington wrote: > Reviewed-by: Eric Engestrom > Signed-off-by: Bryce Harrington > --- > compositor/main.c | 7 +++ > compositor/systemd-notify.c | 9 +++-- > libweston/compositor.c | 9 +++-- > libweston/libbacklight.c

Re: [PATCH weston v2 1/8] gl-renderer: Silence maybe-uninitialized warning

2016-08-08 Thread Giulio Camuffo
Hi, Reviewed-by: Giulio Camuffo 2016-07-10 11:00 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > libweston/gl-renderer.c: In function 'compress_bands': > libweston/gl-renderer.c:481:6: warning: 'merged' may be used > uninitialized in this function [-Wmaybe-uninitialized] >if (!merged)

Re: [PATCH weston v2 2/8] shared/image: Silence maybe-uninitialized warning

2016-08-08 Thread Giulio Camuffo
Hi, Reviewed-by: Giulio Camuffo 2016-07-10 11:00 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > shared/image-loader.c: In function 'load_image': > shared/image-loader.c:434:12: warning: 'image' may be used uninitialized > in this function [-Wmaybe-uninitialized] > } else if (!image) {

Re: [PATCH weston v2 4/8] libweston: Silence tautological-compare warning

2016-08-08 Thread Giulio Camuffo
Hi, Reviewed-by: Giulio Camuffo 2016-07-10 11:00 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > libweston/compositor.c:5023:14: warning: comparison of unsigned enum > expression < 0 is always false [-Wtautological-compare] > if (backend < 0 || backend >= ARRAY_LENGTH(backend_map)

Re: [PATCH weston v2 5/8] libweston/launcher-weston-launch: Silence unused-function warning

2016-08-08 Thread Giulio Camuffo
Hi, Reviewed-by: Giulio Camuffo 2016-07-10 11:00 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > libweston/launcher-weston-launch.c:58:1: warning: unused function > 'is_drm_master' [-Wunused-function] > is_drm_master(int drm_fd) > ^ > > Warning produced by Clang 3.8. > > Signed-off-by: Qu

Re: [PATCH weston v2 6/8] share/cairo-util: Use wl_pointer_button_state enum directly

2016-08-08 Thread Giulio Camuffo
Hi, Reviewed-by: Giulio Camuffo 2016-07-10 11:00 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > This silences two warnings: > > clients/window.c:2450:20: warning: implicit conversion from enumeration > type 'enum wl_pointer_button_state' to different enumeration type 'enum > frame_button

Re: [PATCH weston v2] desktop-shell: Send fewer pings

2016-08-08 Thread Giulio Camuffo
Hi, looks good. Reviewed-by: Giulio Camuffo 2016-07-08 20:20 GMT+02:00 Derek Foreman : > Currently we can end up sending pings to popups every screen redraw and every > pointer move when they're focused. Instead let's send a maximum of 1 every > 200ms > by letting the ping timer expire before

Re: [PATCH 4/5] client: "_id" versions of constructors, alternative to proxy_wrapper

2016-08-08 Thread Giulio Camuffo
Hi, What's the point of this now that we have the proxy wrapper approach? Cheers, Giulio 2016-05-17 8:18 GMT+02:00 : > From: Bill Spitzak > > Scanner produces a wl_xyz_new() for each object, and for each constructor > request it produces an "_id" version that takes one of these, instead of >

Re: [PATCH wayland] cursor: Remove "weston" from anonymous shm filenames

2016-08-08 Thread Giulio Camuffo
Hi, Reviewed-by: Giulio Camuffo 2016-07-27 21:02 GMT+02:00 Yong Bakos : > On Jul 27, 2016, at 9:06 AM, Derek Foreman wrote: >> >> This mildly confused me during some debugging, so I guess it wouldn't >> hurt to make the filename more indicative of where it was actually >> created. >> >> Signed-

Re: [PATCH 1/3 v3] wayland-server: Add API to control globals visibility

2016-08-08 Thread Olivier Fourdan
Hi Giulio, On 8 August 2016 at 10:53, Giulio Camuffo wrote: > Hi, > > this looks like a nice way to implement restricted interfaces... i > just wonder, would we need to revoke allowed interfaces? How would > this approach allow that? Not sure what you mean, but if an interface was allowed, revok

Re: Re: Wayland application start failed

2016-08-08 Thread Giulio Camuffo
Hi, your qtwayland version and qtbase version don't match. Run your application with QT_DEBUG_PLUGINS=1 and look at the output for more details. Cheers, Giulio 2016-08-08 3:22 GMT+02:00 Anthenony : > The error still existed. > Is there any other way? > > > > At 2016-08-05 17:50:57, "madana gop

Re: [PATCH 1/3 v3] wayland-server: Add API to control globals visibility

2016-08-08 Thread Giulio Camuffo
Hi, this looks like a nice way to implement restricted interfaces... i just wonder, would we need to revoke allowed interfaces? How would this approach allow that? Also, this still doesn't prevent a client from binding an interface if it knows the name and id. Do we care? 2016-08-08 10:10 GMT+02:

Re: [PATCH 3/3 v3] tests: Add a test for global filter

2016-08-08 Thread Jonas Ådahl
On Mon, Aug 08, 2016 at 10:10:52AM +0200, Olivier Fourdan wrote: > Test if the global filter is effectively filtering out the global when > the filter returns false. > > Signed-off-by: Olivier Fourdan 1-3 looks good to me and are Reviewed-by: Jonas Ådahl One nit below. Also could be good to te

[PATCH 0/3] Re: [PATCH v2] wayland-server: Add API to control globals visibility

2016-08-08 Thread Olivier Fourdan
Hi Jonas, > The API additions to wl_global should be their own patches IMHO. Agreed, I have splitted the patch in 3: - Add the global filter with its own user data - Add the API to retrieve the wl_global's interface and data - Add the test > What I meant was that one would pass a user_data w

[PATCH 1/3 v3] wayland-server: Add API to control globals visibility

2016-08-08 Thread Olivier Fourdan
Add a new API to let compositor decide whether or not a wl_global should be advertised to the clients via wl_registry_bind() or display_get_registry() By using its own filter, the compositor can decide which wl_global would be listed to clients. Compositors can use this mechanism to hide their ow

[PATCH 2/3 v3] wayland-server: Add functions to wl_global

2016-08-08 Thread Olivier Fourdan
When using a wl_global, a server may need to retrieve the associated wl_interface and user data. Add a couple of convenient functions wl_global_get_interface() and wl_global_get_user_data() for this purpose. Signed-off-by: Olivier Fourdan --- v3: split out as its own commit src/wayland-server

[PATCH 3/3 v3] tests: Add a test for global filter

2016-08-08 Thread Olivier Fourdan
Test if the global filter is effectively filtering out the global when the filter returns false. Signed-off-by: Olivier Fourdan --- v3: split out as its own commit tests/display-test.c | 58 1 file changed, 58 insertions(+) diff --git a/tes