Re: [PATCH libinput] gestures: reduce the 2fg scroll timeout to 150ms

2016-08-03 Thread Peter Hutterer
On Wed, Aug 03, 2016 at 01:06:01PM +0200, Hans de Goede wrote: > Hi, > > On 03-08-16 11:36, Peter Hutterer wrote: > > This timeout is there to switch to scrolling when the fingers rest on the > > touchpad unmoving and thus avoids the initial scroll threshold for slow > > scrolls. > > > > Since th

[PATCH libinput] touchpad: ignore modifier key combos for dwt

2016-08-03 Thread Peter Hutterer
Inspired by the syndaemon -K switch and Anton Lindqvist's patch. https://patchwork.freedesktop.org/patch/102417/ We already ignored modifiers for dwt. Now we also ignore modifier + key combinations, i.e. hitting Ctrl+s to save does not trigger dwt, the touchpad remains immediately usable. However

RE: [Question] About muti-thread with wayland/weston

2016-08-03 Thread Zhu, Lingyun
Hi, Daniel Thank you :). I also tried it with create threads in simple-egl. It works well. Thanks, Lingyun -Original Message- From: Daniel Stone [mailto:dan...@fooishbar.org] Sent: Wednesday, July 20, 2016 8:39 PM To: Zhu, Lingyun Cc: wayland-devel@lists.freedesktop.org Subject: Re: [Q

[PATCH weston v4 5/5] Switch to use safe_strtoint instead of strtol

2016-08-03 Thread Bryce Harrington
Reviewed-by: Eric Engestrom Signed-off-by: Bryce Harrington --- compositor/main.c | 7 +++ compositor/systemd-notify.c | 9 +++-- libweston/compositor.c | 9 +++-- libweston/libbacklight.c| 11 +-- shared/config-parser.c | 7 ++- shared/option-

[PATCH weston v4 0/5] Add safe_strtoint() helper

2016-08-03 Thread Bryce Harrington
Incorporated a number of review suggestions: - Test against INT32_MIN instead of -INT_MAX - Don't modify *value on out of range conditions - A couple doc fixups - Add test cases accidentally missing in last post - Move test cases from patch #5 to #4 Bryce Harrington (5): Standardize er

[PATCH weston v4 2/5] xwayland: Improve error checking for strtol call

2016-08-03 Thread Bryce Harrington
This updates the error checking for the strtol() call in xwayland's create_lockfile to match other cases. C.f. cbc05378 and other recent patches. A notable difference here is that the existing error checking was verifying that exactly 10 digits were being read from the lock file, but the fact tha

[PATCH weston v4 1/5] Standardize error checking for strtol calls

2016-08-03 Thread Bryce Harrington
This tightens up the strtol() error checking in several places where it is used for parsing environment variables, and in the backlight interface that is reading numbers from files under /sys/class/backlight. All of these uses are expecting strings containing decimal numbers and nothing else, so th

[PATCH weston v4 3/5] option-parser: Improve error checking for strtol call

2016-08-03 Thread Bryce Harrington
Make the error checking consistent with other strtol() calls. Note that since strtol(nptr, &endptr) sets endptr == nptr if there were no digits, this catches the case where the string was blank, so there's no need to test *value != '\0'. Signed-off-by: Bryce Harrington Reviewed-by: Eric Engestro

[PATCH weston v4 4/5] Add safe_strtoint() helper

2016-08-03 Thread Bryce Harrington
Adds a safe strtol helper function, modeled loosely after Wayland scanner's strtouint. This encapsulates the various quirks of strtol behavior, and streamlines the interface to just handling base-10 numbers with a simple true/false error indicator and a uint32_t return by reference. Test cases ar

[PATCH libinput] evdev: recognize and use ID_INPUT_TRACKBALL

2016-08-03 Thread Peter Hutterer
We leave the old LIBINPUT_MODEL_TRACKBALL in place until we can rely on systems to have the new systemd tagging. https://github.com/systemd/systemd/pull/3872 Signed-off-by: Peter Hutterer --- src/evdev.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/evdev.c

Re: [PATCH libinput] gestures: reduce the 2fg scroll timeout to 150ms

2016-08-03 Thread Hans de Goede
Hi, On 03-08-16 11:36, Peter Hutterer wrote: This timeout is there to switch to scrolling when the fingers rest on the touchpad unmoving and thus avoids the initial scroll threshold for slow scrolls. Since the only other gestures we support are swipe (usually a fast movement) and pinch-and-rota

Re: [PATCH libinput] gestures: reduce the 2fg scroll timeout to 150ms

2016-08-03 Thread Martin Peres
On 03/08/16 12:36, Peter Hutterer wrote: This timeout is there to switch to scrolling when the fingers rest on the touchpad unmoving and thus avoids the initial scroll threshold for slow scrolls. Since the only other gestures we support are swipe (usually a fast movement) and pinch-and-rotate (a

[PATCH libinput] gestures: reduce the 2fg scroll timeout to 150ms

2016-08-03 Thread Peter Hutterer
This timeout is there to switch to scrolling when the fingers rest on the touchpad unmoving and thus avoids the initial scroll threshold for slow scrolls. Since the only other gestures we support are swipe (usually a fast movement) and pinch-and-rotate (also a fast movement) we can drop the timeou