Re: [PATCH wayland 1/2] protocol: Add release (destructor) request to wl_output

2016-07-26 Thread Quentin Glidic
On 26/07/2016 23:35, Yong Bakos wrote: On Jul 5, 2016, at 11:41 AM, Quentin Glidic wrote: From: Quentin Glidic Signed-off-by: Quentin Glidic Would be nice to see, in the commit message, what use case motivated you to add this. I hope it is not required, because we agreed already that

Re: [PATCHv2 weston] include stdint.h for int32_t/uint32_t

2016-07-26 Thread Bryce Harrington
On Tue, Jul 19, 2016 at 12:30:40PM -0700, Yong Bakos wrote: > On Jul 19, 2016, at 4:16 AM, Jussi Kukkonen wrote: > > > > Signed-off-by: Jussi Kukkonen > > Thanks Jussi, seems like you caught them all. > > Reviewed-by: Yong Bakos Thanks Yong and Jussi, pushed: a4b3497..649bbce master -> m

Re: [PATCH weston] gitignore: Ignore weston-confine client

2016-07-26 Thread Bryce Harrington
On Tue, Jul 26, 2016 at 05:09:06PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington and pushed d0716f4..a4b3497 master -> master > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore >

Re: [PATCH weston v2 2/2] Re-apply "config-parser: Catch negative numbers assigned to unsigned config values"

2016-07-26 Thread Bryce Harrington
On Thu, Jul 14, 2016 at 06:28:04PM -0700, Bryce Harrington wrote: > [With hexadecimal color values now handled via their own routine, > re-introduce the negative unsigned numbers fix.] > > strtoul() has a side effect that when given a string representing a > negative number, it treats it as a high

Re: [PATCH wayland 1/2] protocol: Add release (destructor) request to wl_output

2016-07-26 Thread Yong Bakos
On Jul 5, 2016, at 11:41 AM, Quentin Glidic wrote: > > From: Quentin Glidic > > Signed-off-by: Quentin Glidic Would be nice to see, in the commit message, what use case motivated you to add this. Reviewed-by: Yong Bakos yong > --- > protocol/wayland.xml | 13 - > 1 file chan

[PATCH weston] gitignore: Ignore weston-confine client

2016-07-26 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index dfbb4d3..41a140b 100644 --- a/.gitignore +++ b/.gitignore @@ -54,6 +54,7 @@ protocol/*.[ch] weston-calibrator weston-clickdot weston-cliptest +weston-co

Re: [PATCH wayland 2/2] scanner: Generate all SINCE_VERSION macros for everyone

2016-07-26 Thread Yong Bakos
On Jul 5, 2016, at 11:41 AM, Quentin Glidic wrote: > > From: Quentin Glidic > > Practical example: a client supporting version 2 of wl_output will wait > for the wl_output.done event before starting wl_output-related > operations. However, if the server only supports version 1, no event > will

[PATCH wayland] scanner: Correct doxygen group name for *_add_listener

2016-07-26 Thread Yong Bakos
From: Yong Bakos From: Bill Spitzak Scanner has been generating the doxygen group label "foo_iface" for all *_add_listener functions, and the label "iface_foo" everywhere else. Correct the label generation, so all *_add_listener functions appear correctly within doxygen output. See: https://p

Re: [PATCH libinput] udev: don't overwrite a previously set device group

2016-07-26 Thread Hans de Goede
Hi, On 20-07-16 11:55, Peter Hutterer wrote: In some cases a device may need a device group assigned by a custom udev rule or hwdb entry. Don't overwrite that with our generated one. Signed-off-by: Peter Hutterer LGTM: Reviewed-by: Hans de Goede Regards, Hans --- udev/80-libinput-dev

Re: [PATCH v2 libinput 4/4] touchpad: change manual calculations of dimensions to helper functions

2016-07-26 Thread Hans de Goede
Hi, On 18-07-16 05:28, Peter Hutterer wrote: Wherever we use an absolute size in mm on the touchpad, switch to the new helper functions. In a few cases we only need one coordinate so just leave the other one as 0 in those cases. Signed-off-by: Peter Hutterer --- Changes to v2: - remove duplica