Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

2016-07-22 Thread Nils Chr. Brause
HI, On Thu, Jun 2, 2016 at 10:30 AM, Pekka Paalanen wrote: > On Thu, 2 Jun 2016 15:39:47 +0800 > Jonas Ådahl wrote: > >> On Thu, Jun 02, 2016 at 10:24:19AM +0300, Pekka Paalanen wrote: >> > On Wed, 1 Jun 2016 13:16:31 -0500 >> > Yong Bakos wrote: >> > >> > > On May 30, 2016, at 3:54 AM, Pekka P

Re: [PATCH wayland-protocols 2/3] xdg-shell: Clarify focus semantics for popup grabs

2016-07-22 Thread Yong Bakos
Hi Jonas, On Jul 21, 2016, at 11:59 PM, Jonas Ådahl wrote: > > On Wed, Jul 20, 2016 at 11:07:50AM -0700, Yong Bakos wrote: >> Hi Jonas, >> >>> On Jul 15, 2016, at 2:37 AM, Jonas Ådahl wrote: >>> >>> Make it clearer what the focus semantics are during a popup grab. In >>> short, when a grabbin

Re: [PATCH weston 0/9] Finalise EGL/GL define(s) rework

2016-07-22 Thread Daniel Stone
Hi, On 22 July 2016 at 10:57, Emil Velikov wrote: > On 4 July 2016 at 15:34, Emil Velikov wrote: >> This series depends on "EGL/GL definitions cleanup" and does a couple of >> things: >> - makes sure that we consistently use check_extension over strstr for >> extension checking, as the latter m

[PATCH weston] automake: list static libraries before the shared ones

2016-07-22 Thread Emil Velikov
From: Emil Velikov The linker processes those in the order that they are given. Thus as-it we can get unresolved symbols. Signed-off-by: Emil Velikov --- Some places in weston already follow this approach, and although I've not had a problem it'll be nice to fix things. Noticed while looking a

[PATCH weston v3 2/3] libweston: use new versioning scheme

2016-07-22 Thread Emil Velikov
From: Emil Velikov Use the documented libweston-$major.so.0.$minor.$patch scheme. An (almost) identical one is used by GLIB, GDK{2,3}, QT5, json-glib and others. Signed-off-by: Emil Velikov --- I kind of agree with Quentin that the revision log isn't too helpful in the commit message in this c

[PATCH weston v3 3/3] libweston: remove pkgincludedir variable from libweston.pc

2016-07-22 Thread Emil Velikov
From: Emil Velikov Common practise it to provide the includes directly into Cflags, hence the variable is not needed and we can remove it. Signed-off-by: Emil Velikov --- Replaces the "libweston: do not add libweston-$version to the Cflags" patch. --- libweston/libweston.pc.in | 3 +-- 1 file

[PATCH weston v3 1/3] README: Document versioning scheme, forward compatibility

2016-07-22 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- Pekka, considering the noticable rework I've dropped your r-b. v2: - s/QT/Qt/;s/GTK/GDK/ - s/LIBWESTON_API_VERSION/REQUIRE_LIBWESTON_API_VERSION/ - Provide configure.ac example and mention how to override the fwd compat checking. - Misc rew

[PATCH weston 0/3]Rework libweston versioning take 3

2016-07-22 Thread Emil Velikov
Hi all, Here is hopefully the final take on the series of the topic in question. The changes: - Reworked the README, elaborating on why and how to use REQUIRE_LIBWESTON_API_VERSION (what to write in your configure), how to avoid forward compat and misc working improvements. - There is a com

Re: [PATCH weston 2/2] automake: add missing git-version.h dependency

2016-07-22 Thread Emil Velikov
On 6 July 2016 at 12:52, Emil Velikov wrote: > On 5 July 2016 at 13:18, Quentin Glidic > wrote: >> On 04/07/2016 15:57, Emil Velikov wrote: >>> >>> From: Emil Velikov >>> >>> compositor/main.c depends on the header, while the dependency isn't >>> specified. Thus depending on the order of how th

Re: [PATCH weston 1/2] automake: list the the builddir include before the srcdir

2016-07-22 Thread Emil Velikov
On 5 July 2016 at 13:16, Quentin Glidic wrote: > On 04/07/2016 15:57, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Otherwise we'll pick up the stale (in-tree) generated source(s) over the >> fresh (out-of-tree) ones. >> >> Signed-off-by: Emil Velikov >> --- >> It's quite a corner case, alt

Re: [PATCH weston 0/9] Finalise EGL/GL define(s) rework

2016-07-22 Thread Emil Velikov
On 4 July 2016 at 15:34, Emil Velikov wrote: > Hi all, > > This series depends on "EGL/GL definitions cleanup" and does a couple of > things: > - makes sure that we consistently use check_extension over strstr for > extension checking, as the latter might trigger false positives. > - The remaind

Re: [PATCH weston 0/7] EGL/GL definitions cleanup

2016-07-22 Thread Emil Velikov
On 4 July 2016 at 15:27, Emil Velikov wrote: > It seems that a handful of extensions were missing fallback definitions > and/or were handled sub optimally. > > So this series folds most (the > remainder coming in another series) of the typedef/defines in > weston-egl-ext.h and cleanups all the ifd

Re: [PATCH wayland-protocols 2/3] xdg-shell: Clarify focus semantics for popup grabs

2016-07-22 Thread Jonas Ådahl
On Wed, Jul 20, 2016 at 11:07:50AM -0700, Yong Bakos wrote: > Hi Jonas, > > > On Jul 15, 2016, at 2:37 AM, Jonas Ådahl wrote: > > > > Make it clearer what the focus semantics are during a popup grab. In > > short, when a grabbing popup is mapped, the top most popup will always > > have keyboard