[PATCH libinput 6/6] test: move include for local linux/input.h down

2016-07-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/litest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/litest.c b/test/litest.c index 56b9364..e22c729 100644 --- a/test/litest.c +++ b/test/litest.c @@ -39,7 +39,6 @@ #include #include #include -#include "linux/input.h" #in

[PATCH libinput 2/6] test: split 1fg touchpad tap tests into a separate binary

2016-07-18 Thread Peter Hutterer
This is one of the longest-running test suites, split it out so we can run it in parallel with the other tap tests. Signed-off-by: Peter Hutterer --- test/Makefile.am| 5 + test/touchpad-tap-1fg.c | 965 test/touchpad-tap.c | 924 ---

[PATCH libinput 3/6] test: split scroll tests out of the main touchpad tests

2016-07-18 Thread Peter Hutterer
A set of long-running tests better off in their own binary for parallelization Signed-off-by: Peter Hutterer --- test/Makefile.am | 5 + test/touchpad-scroll.c | 873 + test/touchpad.c| 845 --

[PATCH libinput 1/6] test: use the .test suffix instead of a test- prefix

2016-07-18 Thread Peter Hutterer
Having a suffix means we can use some automake features that rely on the suffix Signed-off-by: Peter Hutterer --- .gitignore | 2 +- test/Makefile.am | 202 +++ 2 files changed, 102 insertions(+), 102 deletions(-) diff --git a/.gitigno

[PATCH libinput 4/6] test: split dwt tests into separate binary

2016-07-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/Makefile.am|5 + test/touchpad-dwt.c | 1110 +++ test/touchpad.c | 1073 - 3 files changed, 1115 insertions(+), 1073 deletions(-) create mode 100644

[PATCH libinput 0/6] test: more cleanup to enhance parallel runs

2016-07-18 Thread Peter Hutterer
Doesn't really change much, this is largely a rename of the files and it splits the touchpad tests up into smaller binaries. Before 2/6 the touchpad.test would take approx 13 minutes and a large part of that consists of waiting for various timeouts. Splitting it up means we have a chance to run th

[PATCH libinput 5/6] test: reduce the time we're holding the udev lock

2016-07-18 Thread Peter Hutterer
Once we have the device and an open fd we can drop the lock, it's not going to change anymore now. libevdev inits from the open fd and we can do the other checks afterwards. Signed-off-by: Peter Hutterer --- test/litest.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH libinput 5/6] touchpad: change palm detection trigger functions to bools

2016-07-18 Thread Peter Hutterer
And rename to make it more obvious what the return value means. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 7ee86a9..190448b 10

[PATCH libinput 3/6] Switch a bunch of internal functions from int to bool

2016-07-18 Thread Peter Hutterer
All these effectively returned bools anyway, switch the signature over to be less ambiguous. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 2 +- src/evdev-mt-touchpad.c | 26 ++-- src/evdev-mt-touchpad.h | 4 +- src/evdev-tablet.c | 2

[PATCH libinput 6/6] touchpad: change the sanity check function to a bool

2016-07-18 Thread Peter Hutterer
And rename to make the return value more obvious Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 190448b..777914e 100644 --- a/src/evdev-mt-touchpa

[PATCH libinput 4/6] touchpad: change clickfinger check distance function to a bool

2016-07-18 Thread Peter Hutterer
And rename to make it more obvious what the return value will mean. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c index 95603f9

[PATCH libinput 1/6] evdev_device_suspend() is a void function

2016-07-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev.c | 4 +--- src/evdev.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 1a0759b..3a7eda1 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -2865,7 +2865,7 @@ evdev_notify_resumed_device(struct evdev_dev

[PATCH libinput 2/6] Change a few functions that only ever returned 0 to voids

2016-07-18 Thread Peter Hutterer
These are internal functions, if we need them to return an error code we can change that at any time. Meanwhile, if we only ever return 0 anyway we might as well just make them voids to save on error paths. Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad-buttons.c | 14 +++ src/e

[PATCH libinput 0/6] Return value cleanup

2016-07-18 Thread Peter Hutterer
Return values are a bit messy, we randomly use bool and int. Functions returning int sometimes return 0 or 1, sometimes 0 and -1, etc. This set cleans up a bit, mostly by switching a bunch of functions to just be void and the rest to actual bool true/false returns (with renames where needed for ob

Re: [PATCH wayland] display-test: Remove redundant stdbool include

2016-07-18 Thread Bryce Harrington
On Mon, Jul 18, 2016 at 12:46:00PM -0500, Yong Bakos wrote: > From: Yong Bakos > > display-test.c includes stdbool.h twice. Remove the redundant include. > > Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington > --- > tests/display-test.c | 1 - > 1 file changed, 1 deletion(-) > > diff

[PATCH wayland] display-test: Remove redundant stdbool include

2016-07-18 Thread Yong Bakos
From: Yong Bakos display-test.c includes stdbool.h twice. Remove the redundant include. Signed-off-by: Yong Bakos --- tests/display-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/display-test.c b/tests/display-test.c index 17956db..b7557d0 100644 --- a/tests/display-test.c +++

[PATCH wayland] (multiple): Include stdint.h

2016-07-18 Thread Yong Bakos
From: Yong Bakos Some headers and source files have been using types such as uint32_t without explicitly including stdint.h. Explicitly include stdint.h where appropriate. Signed-off-by: Yong Bakos --- cursor/cursor-data.h | 2 ++ cursor/wayland-cursor.c | 1 + src/event-loop.c

Re: [PATCH weston] shared: include stdint.h for int32_t

2016-07-18 Thread Jussi Kukkonen
On 18 July 2016 at 12:09, Eric Engestrom wrote: > On Mon, Jul 18, 2016 at 09:53:20AM +0100, Eric Engestrom wrote: > > On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote: > > > This fixes build on musl. > > > > > > Signed-off-by: Jussi Kukkonen > > > > Reviewed-by: Eric Engestrom > >

Re: [PATCH] scanner: Use unit32_t instead of uint

2016-07-18 Thread Daniel Stone
Hi, On 18 July 2016 at 08:35, Khem Raj wrote: > On Sun, Jul 17, 2016 at 3:36 PM, Peter Hutterer > wrote: >> On Fri, Jul 15, 2016 at 04:23:48PM -0700, Khem Raj wrote: >>> uint32_t is C99 defined stdint type >>> >>> Signed-off-by: Khem Raj >> >> subject line says unit32_t :) > > ah a typo. Can we

Re: [RFC weston 0/6] libweston-desktop, first try

2016-07-18 Thread Pekka Paalanen
On Sun, 17 Jul 2016 10:59:17 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Hi, > > Here is my first RFC series for libweston-desktop. > > The code style does not match weston’s, it lacks documentation and > there are still segfaults here and there, but it works. > A little regression

Re: [PATCH weston] shared: include stdint.h for int32_t

2016-07-18 Thread Eric Engestrom
On Mon, Jul 18, 2016 at 09:53:20AM +0100, Eric Engestrom wrote: > On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote: > > This fixes build on musl. > > > > Signed-off-by: Jussi Kukkonen > > Reviewed-by: Eric Engestrom Actually, a quick grep tells me 92 other files could use the sam

Re: [PATCH weston] shared: include stdint.h for int32_t

2016-07-18 Thread Eric Engestrom
On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote: > This fixes build on musl. > > Signed-off-by: Jussi Kukkonen Reviewed-by: Eric Engestrom > --- > shared/xalloc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/shared/xalloc.h b/shared/xalloc.h > index 85fccb4..484de2