On Jul 12, 2016, at 4:51 PM, Peter Hutterer wrote:
>
> All Dell touchpas appear to have a visual marker on their touchpads. With a
> visible marker our middle button can (and should) be much smaller since we
> can rely on users to hit the button precisely.
>
> https://bugs.freedesktop.org/show_b
Make error handling of most strtol calls consistent with each other.
The first patch fixes various cases that are straightforward refactors.
The second and third patch cover cases where some idiosyncracies need
highlighted in the commit messages. All three patches can be squashed
if desired.
Not
Make the error checking consistent with other strtol() calls.
Note that since strtol(nptr, &endptr) sets endptr == nptr if there were
no digits, this catches the case where the string was blank, so there's
no need to test *value != '\0'.
Signed-off-by: Bryce Harrington
---
shared/option-parser.
This updates the error checking for the strtol() call in xwayland's
create_lockfile to match other cases. C.f. cbc05378 and other recent
patches.
A notable difference here is that the existing error checking was
verifying that exactly 10 digits were being read from the lock file,
but the fact tha
This tightens up the strtol() error checking in several places where it
is used for parsing environment variables, and in the backlight
interface that is reading numbers from files under /sys/class/backlight.
All of these uses are expecting strings containing decimal numbers and
nothing else, so th
On Tue, Jul 12, 2016 at 06:54:49PM -0700, Bryce Harrington wrote:
> On Wed, Jul 13, 2016 at 10:27:49AM +1000, Peter Hutterer wrote:
> > On Tue, Jul 12, 2016 at 04:51:27PM -0700, Bryce Harrington wrote:
> > > The third arg to strtol() specifies the base to assume for the number.
> > > When 0 is pass
On Jul 12, 2016, at 4:51 PM, Bryce Harrington wrote:
>
> The third arg to strtol() specifies the base to assume for the number.
> When 0 is passed, as is currently done in option-parser.c, hexadecimal
> and octal numbers are permitted and automatically detected and
> converted.
>
> This change i
On Tue, Jul 12, 2016 at 06:49:06PM -0700, Yong Bakos wrote:
> On Jul 12, 2016, at 4:51 PM, Bryce Harrington wrote:
> >
> > The third arg to strtol() specifies the base to assume for the number.
> > When 0 is passed, as is currently done in option-parser.c, hexadecimal
> > and octal numbers are pe
On Wed, Jul 13, 2016 at 10:27:49AM +1000, Peter Hutterer wrote:
> On Tue, Jul 12, 2016 at 04:51:27PM -0700, Bryce Harrington wrote:
> > The third arg to strtol() specifies the base to assume for the number.
> > When 0 is passed, as is currently done in option-parser.c, hexadecimal
> > and octal num
On Wed, Jul 13, 2016 at 10:23:42AM +1000, Peter Hutterer wrote:
> On Tue, Jul 12, 2016 at 04:59:05PM -0700, Bryce Harrington wrote:
> > Signed-off-by: Bryce Harrington
> > ---
>
> Reviewed-by: Peter Hutterer
> but seriously, imo you should push things like this directly, I'm not sure
> how many
On Tue, Jul 12, 2016 at 04:51:27PM -0700, Bryce Harrington wrote:
> The third arg to strtol() specifies the base to assume for the number.
> When 0 is passed, as is currently done in option-parser.c, hexadecimal
> and octal numbers are permitted and automatically detected and
> converted.
>
> This
On Tue, Jul 12, 2016 at 04:59:05PM -0700, Bryce Harrington wrote:
> Signed-off-by: Bryce Harrington
> ---
Reviewed-by: Peter Hutterer
but seriously, imo you should push things like this directly, I'm not sure
how many eyeballs whitespace changes really need :)
Cheers,
Peter
> compositor/ma
Signed-off-by: Bryce Harrington
---
compositor/main.c | 2 +-
ivi-shell/ivi-layout-transition.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/compositor/main.c b/compositor/main.c
index 8400d70..1f75ae0 100644
--- a/compositor/main.c
+++ b/compositor/main.
The third arg to strtol() specifies the base to assume for the number.
When 0 is passed, as is currently done in option-parser.c, hexadecimal
and octal numbers are permitted and automatically detected and
converted.
This change is an expansion of f6051cbab84c0e577473b67f0585c0f329eb80fe
to cover t
All Dell touchpas appear to have a visual marker on their touchpads. With a
visible marker our middle button can (and should) be much smaller since we
can rely on users to hit the button precisely.
https://bugs.freedesktop.org/show_bug.cgi?id=96710
Signed-off-by: Peter Hutterer
Tested-by: Andy L
On Tue, Jul 12, 2016 at 01:17:20PM +0100, Eric Engestrom wrote:
> On Mon, Jul 11, 2016 at 05:55:15PM -0700, Bryce Harrington wrote:
> > strtoul() has a side effect that when given a string representing a
> > negative number, it returns a negated version as the value, and does not
> > flag an error.
On Tue, Jul 12, 2016 at 10:58:05AM -0700, Bill Spitzak wrote:
> I tested this and at least for libc on linux it returns 0x1-n, ie
> "-1" is 0x.
>
> This is actually pretty useful when the unsigned value is bitflags or you
> want to guarantee you typed in the largest number possible
On Tue, Jul 12, 2016 at 08:12:37AM -0700, Yong Bakos wrote:
> On Jul 11, 2016, at 5:02 PM, Bryce Harrington wrote:
> >
> > Improve error checking for situations like RDP_FD=42foo, or where the
> > provided number is out of range.
> >
> > Suggestion by Yong Bakos.
> >
> > Signed-off-by: Bryce Ha
On Jul 12, 2016, at 6:02 AM, Anthenony wrote:
>
> Hi,All:
>
> Dose anyone have the same problem in building wayland-ivi-extension as me?
Did you build and install wayland itself? Seems you don't have wayland-scanner.
yong
> yuanjiawei@yuanjiawei:~/wayland-ivi-entension/wayland-ivi-exten
On 13/05/16 01:56, Martin Peres wrote:
Hello,
I have the pleasure to announce that the X.org Developer Conference 2016
will be held in Helsinki from September 21 to September 23. The venue is
located at Haaga-Helia university[0], next to the Pasila station.
The official page for the event is ht
Hi,All:
Dose anyone have the same problem in building wayland-ivi-extension as me?
yuanjiawei@yuanjiawei:~/wayland-ivi-entension/wayland-ivi-extension-so/build$
cmake ../wayland-ivi-extension/
-- The C compiler identification is GNU 4.9.2
-- The CXX compiler identification is GNU 4.9.2
--
On Mon, Jul 11, 2016 at 05:02:44PM -0700, Bryce Harrington wrote:
> Improve error checking for situations like RDP_FD=42foo, or where the
> provided number is out of range.
>
> Suggestion by Yong Bakos.
>
> Signed-off-by: Bryce Harrington
Reviewed-by: Eric Engestrom
> ---
> libweston/composi
On Mon, Jul 11, 2016 at 05:55:15PM -0700, Bryce Harrington wrote:
> strtoul() has a side effect that when given a string representing a
> negative number, it returns a negated version as the value, and does not
> flag an error. IOW, strtoul("-42", &val) sets val to 42. This could
> potentially re
23 matches
Mail list logo
