Re: [PATCH weston] terminal: Fix segmentation fault when processing DCH ANSI escape code

2016-07-02 Thread aaron
All good points, and your previous review pointed out that terminal_shift_line is also used for ICH, though in that case I think the parameter is always positive, and so this would not apply. I think in the case of ICH it would wrap, whereas the VT docs seem to say that DCH has no effect outside t

Re: [PATCH wayland 5/5] Add API to retrieve and iterate over the resources list of a client

2016-07-02 Thread Giulio Camuffo
2016-06-17 14:07 GMT+02:00 Pekka Paalanen : > On Mon, 7 Mar 2016 18:31:35 +0100 > Giulio Camuffo wrote: > >> To complement on the new resource created signal, this allows to >> iterate over the existing resources of a client. >> --- >> src/wayland-server-core.h | 8 >> src/wayland-serv

Re: [PATCH libinput] touchpad: remove software middle button when emulation is enabled

2016-07-02 Thread Hans de Goede
Hi, On 01-07-16 07:54, Peter Hutterer wrote: Expose the middle button emulation on software buttons as proper config option. When enabled, remove the middle button software button area. https://bugs.freedesktop.org/show_bug.cgi?id=96663 Signed-off-by: Peter Hutterer This patch looks good to

Re: [PATCH libinput] gestures: make the gesture movement threshold depending on finger count

2016-07-02 Thread Hans de Goede
Hi, On 01-07-16 00:14, Peter Hutterer wrote: On Thu, Jun 30, 2016 at 02:24:02PM +0100, Eric Engestrom wrote: On Thu, Jun 30, 2016 at 02:10:24PM +0100, Eric Engestrom wrote: The threshold now becomes 0 for 1 finger, which I assume was not the Sorry for the noise, I just realized this code onl