Re:Re: How to create client in child thread

2016-06-22 Thread 袁嘉伟
Hi Pekka: Sorry to take you some time. It's still this issue. I made a test that using 'pthread' to created another thread, and then created the display in the child thread. But program was blocked when connecting to a server(wl_display_connect). It should be pending according to log. However, I

Re: [PATCH] scanner: Fix building on musl

2016-06-22 Thread Hardening
Le 23/06/2016 01:48, Kylie McClain a écrit : > From: Kylie McClain > > `uint` is defined in sys/types.h on musl libc. > > Signed-off-by: Kylie McClain > --- > src/scanner.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/scanner.c b/src/scanner.c > index 4708cae..48d6014 100644 >

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-22 Thread Daniel Stone
Hi Bryce, On 23 June 2016 at 14:33, Bryce Harrington wrote: > On Wed, Jun 22, 2016 at 02:44:23PM +0300, Pekka Paalanen wrote: >> so far only Yong has given a Reviewed-by. Bryce gave a sort-of ok but >> not an official tag, can I take that as an Acked-by? > > I would like to see the Weston patches

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-22 Thread Bryce Harrington
On Wed, Jun 22, 2016 at 02:44:23PM +0300, Pekka Paalanen wrote: > On Thu, 9 Jun 2016 15:20:35 +0300 > Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > After these two patches, we have weston-the-compositor sources in > > compositor/, > > and libweston sources in libweston/. > > > > S

RE: [PATCH weston v2 2/3] ivi-shell: introduce ivi_layout_view

2016-06-22 Thread Natsume, Wataru (ADITJ/SWG)
Hello Emre-san, v2 patch looks fine with me. It passed review at my side except here. (So trivial.) +}; + <--- It looks better to add blanc. struct ivi_layout_surface { Reviewed-by: Wataru Natsume Best Regards, Wataru Natsume --- Wataru Natsume / 夏目 亘 Advanced Driver Informatio

Re: [PATCH weston] Build: Silence shift-negative-value warning

2016-06-22 Thread Daniel Stone
Hi, On 23 June 2016 at 08:54, Derek Foreman wrote: > On 20/06/16 06:57 PM, Daniel Stone wrote: >> Pixman's headers include a representation of -1 in fixed-point, which is >> -1 << 16. This trips a GCC warning about shifting negative values. As we >> can't do much about it, just silence the warnin

Re: [PATCH weston] compositor-drm: support RGB565 with pixman renderer

2016-06-22 Thread Daniel Stone
Hi, On 21 June 2016 at 16:28, Tomi Valkeinen wrote: > On 21/06/16 04:32, Daniel Stone wrote: >> 16bpp in 2016? Ouch. :( > > Yeah... Well, it cuts the mem bandwidth usage to half, so it's quite a > nice bonus on low end SoCs. Pushed with mine & Derek's review: c7d88fa..f8da0c2 upstream -> mas

[PATCH] scanner: Fix building on musl

2016-06-22 Thread Kylie McClain
From: Kylie McClain `uint` is defined in sys/types.h on musl libc. Signed-off-by: Kylie McClain --- src/scanner.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/scanner.c b/src/scanner.c index 4708cae..48d6014 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -38,6 +38,7 @@ #include

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-22 Thread Daniel Stone
Hi, On 13 June 2016 at 17:27, Pekka Paalanen wrote: > I can promise to handle the rebases for landing patches that add new > files into src/. I would hope you and everyone else can take care of > patches that don't add new files like you would usually do. > > If you need more detailed instruction

Re: [PATCH weston 3/3] tests: fix the cursor race in internal-screenshot

2016-06-22 Thread Derek Foreman
On 17/06/16 03:57 AM, Pekka Paalanen wrote: > On Thu, 16 Jun 2016 10:59:21 -0500 Derek Foreman > wrote: > >> On 16/06/16 05:36 AM, Pekka Paalanen wrote: >>> From: Pekka Paalanen >>> >>> This fix also depends on "compositor-headless: do not create a >>> seat". >>> >>> If we lose the race agains

Re: [PATCH weston] Build: Silence shift-negative-value warning

2016-06-22 Thread Derek Foreman
On 20/06/16 06:57 PM, Daniel Stone wrote: > Pixman's headers include a representation of -1 in fixed-point, which is > -1 << 16. This trips a GCC warning about shifting negative values. As we > can't do much about it, just silence the warning. > > Signed-off-by: Daniel Stone Reviewed-by: Derek F

Re: [PATCH weston] compositor-drm: support RGB565 with pixman renderer

2016-06-22 Thread Derek Foreman
On 20/06/16 06:18 AM, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > At the moment only XRGB is supported when using pixman renderer. > This patch adds support also for RGB565. > > Signed-off-by: Tomi Valkeinen Looks fine to me, Reviewed-by: Derek Foreman > --- > src/compositor-drm.c

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-22 Thread Benoit Gschwind
Hello Pekka, I did not made an extensive check, but at less I tested it (drm-/x11-backend), and the idea of the patch is ok for me. Nothing is in stone, go for this way and fix issue when they arise. maybe I would choose weston for libweston and weston-compositor for the compositor, but that doe

Re: [PATCH] wayland-server: Add APIs to get some structure's value

2016-06-22 Thread Pekka Paalanen
On Wed, 22 Jun 2016 19:45:15 +0900 __ wrote: > Dear, Mr. Pekka Paalanen. > > Thank you for your reply and opinion. > I have checked Mr. Giulio's patch: > https://patchwork.freedesktop.org/series/4181/ > But unfortunately my patch was little different with Mr. Giulio's. > > His patch is to w

Re: [PATCH weston 08/11] compositor: Untangle mapedness from outputs

2016-06-22 Thread Pekka Paalanen
On Wed, 22 Jun 2016 12:16:31 +0200 Armin Krezović wrote: > On 21.06.2016 14:05, Pekka Paalanen wrote: > > On Sat, 18 Jun 2016 19:15:23 +0200 > > Armin Krezović wrote: > > > >> Currently, weston assumes a surface/view is mapped if > >> it has an output assigned. In a zero outputs scenario, > >

Re: [PATCH weston] main: log the command line

2016-06-22 Thread Quentin Glidic
On 13/06/2016 13:28, Pekka Paalanen wrote: From: Pekka Paalanen Write the command line to the log to aid debugging. It needs to be copied before parsing, because parsing mutates argv. Signed-off-by: Pekka Paalanen --- No big reason, I recall I have missed it in the past. And no big reason

Re: [PATCH weston] tests: print the command line to log

2016-06-22 Thread Quentin Glidic
On 13/06/2016 13:18, Pekka Paalanen wrote: From: Pekka Paalanen weston-tests-env is a beast to handle, when you would like to start weston manually for a test you wan to start inside gdb. This patch causes the full command line to be printed to the automake test logs, so you can copy it from th

Re: [PATCH weston 07/11] gl-renderer: Always setup gl-renderer

2016-06-22 Thread Pekka Paalanen
On Wed, 22 Jun 2016 12:05:01 +0200 Armin Krezović wrote: > On 21.06.2016 11:13, Pekka Paalanen wrote: > > On Sat, 18 Jun 2016 19:15:22 +0200 > > Armin Krezović wrote: > > > >> Currently, the gl-renderer setup is being done on per-output > >> basis. This isn't desirable when trying to make wes

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-22 Thread Quentin Glidic
On 22/06/2016 13:44, Pekka Paalanen wrote: On Thu, 9 Jun 2016 15:20:35 +0300 Pekka Paalanen wrote: From: Pekka Paalanen After these two patches, we have weston-the-compositor sources in compositor/, and libweston sources in libweston/. Since these patches have been generated with git forma

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-22 Thread Pekka Paalanen
On Thu, 9 Jun 2016 15:20:35 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > After these two patches, we have weston-the-compositor sources in compositor/, > and libweston sources in libweston/. > > Since these patches have been generated with git format-patch -M and so > probably canno

RE: [PATCH] wayland-server: Add APIs to get some structure's value

2016-06-22 Thread 강정현
Dear, Mr. Pekka Paalanen. Thank you for your reply and opinion. I have checked Mr. Giulio's patch: https://patchwork.freedesktop.org/series/4181/ But unfortunately my patch was little different with Mr. Giulio's. His patch is to watch interfaces binded such clients. So He added wl_resource_get_in

Re: [PATCH weston 08/11] compositor: Untangle mapedness from outputs

2016-06-22 Thread Armin Krezović
On 21.06.2016 14:05, Pekka Paalanen wrote: > On Sat, 18 Jun 2016 19:15:23 +0200 > Armin Krezović wrote: > >> Currently, weston assumes a surface/view is mapped if >> it has an output assigned. In a zero outputs scenario, >> this isn't really desirable. >> >> This patch introduces a new flag to we

Re: [PATCH weston 07/11] gl-renderer: Always setup gl-renderer

2016-06-22 Thread Armin Krezović
On 21.06.2016 11:13, Pekka Paalanen wrote: > On Sat, 18 Jun 2016 19:15:22 +0200 > Armin Krezović wrote: > >> Currently, the gl-renderer setup is being done on per-output >> basis. This isn't desirable when trying to make weston run >> with zero outputs. >> >> When there are no outputs present, th

Re: [PATCH weston 06/11] keyboard: Only set toplevel when there is a valid output

2016-06-22 Thread Armin Krezović
On 22.06.2016 11:39, Armin Krezović wrote: > On 20.06.2016 16:03, Pekka Paalanen wrote: >> On Sun, 19 Jun 2016 11:33:11 +0200 >> Quentin Glidic wrote: >> >>> On 18/06/2016 19:15, Armin Krezović wrote: Currently, the keyboard client is created and the input panel surface is set as topleve

Re: [PATCH weston 06/11] keyboard: Only set toplevel when there is a valid output

2016-06-22 Thread Armin Krezović
On 20.06.2016 16:03, Pekka Paalanen wrote: > On Sun, 19 Jun 2016 11:33:11 +0200 > Quentin Glidic wrote: > >> On 18/06/2016 19:15, Armin Krezović wrote: >>> Currently, the keyboard client is created and the input >>> panel surface is set as toplevel on the first output it >>> finds. This does not

Re: [PATCH weston 01/11] compositor-headless: Support starting with zero outputs

2016-06-22 Thread Armin Krezović
On 20.06.2016 15:42, Pekka Paalanen wrote: > On Sun, 19 Jun 2016 11:06:05 +0200 > Quentin Glidic wrote: > >> On 18/06/2016 19:15, Armin Krezović wrote: >>> This patch adds a new command line option which can be >>> used to tell headless backend not to create any >>> virtual outputs. >>> >>> This

Re: [PATCH weston 04/11] compositor: Avoid NULL pointer dereference

2016-06-22 Thread Armin Krezović
On 20.06.2016 15:38, Pekka Paalanen wrote: > On Sun, 19 Jun 2016 11:10:03 +0200 > Quentin Glidic wrote: > >> On 18/06/2016 19:15, Armin Krezović wrote: >>> When there are no outputs present, an output pointer >>> can be NULL. Dereferencing such pointer will result >>> in a crash. >>> >>> Signed-o

Re: [PATCH weston 03/11] toytoolkit: Return NULL when no outputs are present

2016-06-22 Thread Armin Krezović
On 20.06.2016 15:23, Pekka Paalanen wrote: > On Sun, 19 Jun 2016 11:08:50 +0200 > Quentin Glidic wrote: > >> On 18/06/2016 19:15, Armin Krezović wrote: >>> Currently, display_get_output returns a first member >>> of the linked list, which can never be NULL. >>> >>> This is problematic, as the fun

Re: [PATCH weston 02/11] desktop-shell: Return NULL when no outputs are present

2016-06-22 Thread Armin Krezović
On 20.06.2016 12:40, Pekka Paalanen wrote: > On Sun, 19 Jun 2016 11:08:33 +0200 > Quentin Glidic wrote: > >> On 18/06/2016 19:15, Armin Krezović wrote: >>> Currently, get_default_output returns a first member >>> of the linked list, which can never be NULL. >>> >>> This is problematic, as the fun

Re: [PATCH wayland-web] FAQ: Modernise FAQ and inject some optimism

2016-06-22 Thread Pekka Paalanen
On Tue, 21 Jun 2016 09:38:58 -0700 Bryce Harrington wrote: > On Tue, Jun 21, 2016 at 09:26:31PM +1000, Daniel Stone wrote: > > The FAQ was clearly written a very long time ago, when user sessions > > were a pipe dream, session compositors were the important thing, and we > > had a lot more questi