Re: [PATCH wayland-web] Build instructions for Ubuntu 16.04

2016-06-19 Thread darxus
On 06/19, Bill Spitzak wrote: > Looks good to me. Thanks. > Nice to see that they updated all that x11proto stuff. Yes! > I like adding the error message you got to the comments. Thanks, I like it. There are some I'd like to see improved. > One minor change below. > I think these links sho

[PATCH wayland-web] Build instructions for Ubuntu 16.04

2016-06-19 Thread darxus
Sorted links reverse chronologically as suggested by Bill Spitzak, and added --with-xserver-path to weston so it passes make check. --- building.html| 7 ++- ubuntu16.04.html | 157 +++ 2 files changed, 162 insertions(+), 2 deletions(-) c

Re: [PATCH weston 06/11] keyboard: Only set toplevel when there is a valid output

2016-06-19 Thread Quentin Glidic
On 18/06/2016 19:15, Armin Krezović wrote: Currently, the keyboard client is created and the input panel surface is set as toplevel on the first output it finds. This does not work in a scenario when there are no outputs, resulting in weston-keyboard to crash at startup due to operating on an inv

Re: [PATCH weston 05/11] desktop-shell: Avoid NULL pointer dereference

2016-06-19 Thread Quentin Glidic
On 18/06/2016 19:15, Armin Krezović wrote: When there are no outputs present, an output pointer can be NULL. Dereferencing such pointer will result in a crash. Signed-off-by: Armin Krezović --- desktop-shell/shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop-sh

Re: [PATCH weston 04/11] compositor: Avoid NULL pointer dereference

2016-06-19 Thread Quentin Glidic
On 18/06/2016 19:15, Armin Krezović wrote: When there are no outputs present, an output pointer can be NULL. Dereferencing such pointer will result in a crash. Signed-off-by: Armin Krezović --- src/compositor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compositor.c b/src/compo

Re: [PATCH weston 02/11] desktop-shell: Return NULL when no outputs are present

2016-06-19 Thread Quentin Glidic
On 18/06/2016 19:15, Armin Krezović wrote: Currently, get_default_output returns a first member of the linked list, which can never be NULL. This is problematic, as the function would return a dangling pointer and NULL pointer checks wouldn't work where needed and some of the invalid members wou

Re: [PATCH weston 03/11] toytoolkit: Return NULL when no outputs are present

2016-06-19 Thread Quentin Glidic
On 18/06/2016 19:15, Armin Krezović wrote: Currently, display_get_output returns a first member of the linked list, which can never be NULL. This is problematic, as the function would return a dangling pointer and NULL pointer checks wouldn't work where needed and some of the invalid members wou

Re: [PATCH weston 01/11] compositor-headless: Support starting with zero outputs

2016-06-19 Thread Quentin Glidic
On 18/06/2016 19:15, Armin Krezović wrote: This patch adds a new command line option which can be used to tell headless backend not to create any virtual outputs. This will be used for output hotplug emulation, where weston will start with no outputs available, and the virtual output will be cre