Re: [PATCH wayland-protocols v3 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-06-13 Thread Jonas Ådahl
On Wed, Jun 08, 2016 at 11:07:46AM +0300, Giulio Camuffo wrote: > 2016-06-08 3:08 GMT+02:00 Jonas Ådahl : > > On Tue, Jun 07, 2016 at 05:39:09PM +0300, Giulio Camuffo wrote: > >> Hi, a couple of comments below: > >> > >> 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : > >> > Turn xdg_popup into plain tempo

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

2016-06-13 Thread Jonas Ådahl
On Wed, Jun 08, 2016 at 11:52:03AM +0300, Giulio Camuffo wrote: > 2016-06-08 10:35 GMT+02:00 Jonas Ådahl : > > On Wed, Jun 08, 2016 at 11:16:49AM +0300, Giulio Camuffo wrote: > >> Hi, one comment below, but anyway i think this looks good. However i > >> will try to use it in qt asap to confirm it r

Re: [PATCH wayland-protocols v3 2/7] xdg-shell: Put xdg_shell events after requests

2016-06-13 Thread Jonas Ådahl
On Wed, Jun 08, 2016 at 04:48:10PM +0200, Benoit Gschwind wrote: > Hello Jonas, > > look good, few comment ahead. > > On 26/05/2016 06:32, Jonas Ådahl wrote: > > It makes the structure consistent with most other protocols and > > provides a clear separation between what is done by the server and

Re: [PATCH wayland-protocols v3 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-06-13 Thread Jonas Ådahl
On Wed, Jun 08, 2016 at 04:45:28PM +0200, Benoit Gschwind wrote: > Hello Jonas, > > On 08/06/2016 03:18, Jonas Ådahl wrote: > > On Wed, Jun 08, 2016 at 12:37:01AM +0200, Benoit Gschwind wrote: > >> Hello, > >> > >> This proposal look good, few optional comments following. > >> > >> On 26/05/2016 0

Re: [PATCH weston] clients/dmabuf-intel: use three buffers

2016-06-13 Thread Pekka Paalanen
On Mon, 13 Jun 2016 08:14:12 -0500 Yong Bakos wrote: > On Jun 13, 2016, at 6:17 AM, Pekka Paalanen wrote: > > > > From: Pekka Paalanen > > > > Use three buffers like simple-dmabuf-v4l instead of just two. > > > > This is required, because when a frame callback arrives, the just > > committed

Re: [PATCH weston] clients/dmabuf-intel: use three buffers

2016-06-13 Thread Yong Bakos
On Jun 13, 2016, at 6:17 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Use three buffers like simple-dmabuf-v4l instead of just two. > > This is required, because when a frame callback arrives, the just > committed buffer is only on its way to the screen, while the previous > buffer i

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-13 Thread Yong Bakos
On Jun 13, 2016, at 2:27 AM, Pekka Paalanen wrote: > > On Fri, 10 Jun 2016 09:29:31 -0700 > Bryce Harrington wrote: > >> On Fri, Jun 10, 2016 at 11:04:03AM +0300, Pekka Paalanen wrote: >>> On Thu, 9 Jun 2016 16:53:12 -0700 >>> Bryce Harrington wrote: >>> On Thu, Jun 09, 2016 at 03:20:35P

Re: [PATCH weston 2/3] ivi-shell: introduce ivi_layout_view

2016-06-13 Thread Pekka Paalanen
On Mon, 13 Jun 2016 12:05:52 + "Ucan, Emre (ADITG/SW1)" wrote: > Hello Pekka, > > My answer are below. Do you want me to send a second version of this > patch, or an additional patch(es) to fix the findings ? Hi Emre, a second version is how we usually deal with things. Of course, only in

RE: [PATCH weston 2/3] ivi-shell: introduce ivi_layout_view

2016-06-13 Thread Ucan, Emre (ADITG/SW1)
Hello Pekka, My answer are below. Do you want me to send a second version of this patch, or an additional patch(es) to fix the findings ? > -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Montag, 13. Juni 2016 13:08 > To: Ucan, Emre (ADITG/SW1) > Cc: waylan

[PATCH weston] main: report presentation clock resolution

2016-06-13 Thread Pekka Paalanen
From: Pekka Paalanen For debugging weird timing issues. If your clock resolution is unexpectedly e.g. 10 ms, you can be sure you will have strange timing issues. This is almost certainly caused by kernel misconfiguration. We rely on clock_getres() being available by the same thing that gets us c

[PATCH weston] main: log the command line

2016-06-13 Thread Pekka Paalanen
From: Pekka Paalanen Write the command line to the log to aid debugging. It needs to be copied before parsing, because parsing mutates argv. Signed-off-by: Pekka Paalanen --- No big reason, I recall I have missed it in the past. --- src/main.c | 30 +- 1 file chan

[PATCH weston] compositor-fbdev: drop EGL support

2016-06-13 Thread Pekka Paalanen
From: Pekka Paalanen EGL code was added to the fbdev backend in 4aa756dc7a8d3cf3b4c6f018c3e2a053fff424b0 in 2013, apparently for running Weston on libhybris with Android hardware drivers. This actually had nothing to do with the fbdev backend, really. Fbdev was just a convenient platform to plug

[PATCH weston] tests: print the command line to log

2016-06-13 Thread Pekka Paalanen
From: Pekka Paalanen weston-tests-env is a beast to handle, when you would like to start weston manually for a test you wan to start inside gdb. This patch causes the full command line to be printed to the automake test logs, so you can copy it from there and run it by hand. Signed-off-by: Pekka

[PATCH weston] clients/dmabuf-intel: use three buffers

2016-06-13 Thread Pekka Paalanen
From: Pekka Paalanen Use three buffers like simple-dmabuf-v4l instead of just two. This is required, because when a frame callback arrives, the just committed buffer is only on its way to the screen, while the previous buffer is still being scanned out. It will take for the page flip to complete

Re: [PATCH weston 3/3] ivi-shell: implement surface_on_many_layer test

2016-06-13 Thread Pekka Paalanen
On Tue, 7 Jun 2016 09:40:21 + "Ucan, Emre (ADITG/SW1)" wrote: > A surface can be added to many layers. > This test is implemented to test this use-case > and the correct behaviour of get_layers_under_surface > API. > > Signed-off-by: Emre Ucan > --- > tests/ivi-test.h |1

Re: [PATCH weston 1/3] ivi-shell: remove ivi_layout_get_weston_view

2016-06-13 Thread Pekka Paalanen
On Tue, 7 Jun 2016 09:40:17 + "Ucan, Emre (ADITG/SW1)" wrote: > A surface could have more than one views. > Therefore, it is not possible to map a surface to > a specific view. The implementation of the API > iterates the list of views of the surface, and > returns the first found view. > >

Re: [PATCH weston 2/3] ivi-shell: introduce ivi_layout_view

2016-06-13 Thread Pekka Paalanen
On Tue, 7 Jun 2016 09:40:20 + "Ucan, Emre (ADITG/SW1)" wrote: > This patch introduces ivi_layout_view data struct, > which is a wrapper of weston_view. > > There is always only one ivi_layout_view for an > ivi_layout_surface and ivi_layout_layer pair. > A surface could have many views with d

Re: Introduction and updates from NVIDIA

2016-06-13 Thread Martin Peres
On 13/06/16 12:32, Martin Peres wrote: This discussion has been going on for years (not this thread, the general discussion). Pekka made me realize on IRC that I was not specific enough about what I mean here. By discussion here, I am talking about sharing buffers across blocks/drivers/manufac

Re: Introduction and updates from NVIDIA

2016-06-13 Thread Martin Peres
On 21/03/16 18:28, Miguel Angel Vico wrote: Hi all, First of all, I'd like to introduce myself to the Wayland community: My name is Miguel A. Vico, and I've been working as a Software Engineer for NVIDIA for some time now, more specifically, in the Linux drivers team. Although I've never spoken

Re: [PATCH weston v2 2/2] weston-launch: Allow the user to use her login shell

2016-06-13 Thread Pekka Paalanen
On Fri, 10 Jun 2016 16:01:22 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > This avoids the need to maintain two parallel shell profile files for > users with a compatible shell (at least bash, sh and zsh are). > > There is no major security issue here, as the shell is the one returned

Re: [PATCH weston v2 1/2] weston-launch: Only run a login shell for new sessions

2016-06-13 Thread Pekka Paalanen
On Fri, 10 Jun 2016 16:01:21 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > This way, the environment is correctly preserved for weston. Since > commit 636156d5f693ac5b01cec6a2937d2b6cd4237ea9, clearenv() is only > called when we open a new PAM session, so it makes sense to only use a >

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-13 Thread Pekka Paalanen
On Fri, 10 Jun 2016 09:29:31 -0700 Bryce Harrington wrote: > On Fri, Jun 10, 2016 at 11:04:03AM +0300, Pekka Paalanen wrote: > > On Thu, 9 Jun 2016 16:53:12 -0700 > > Bryce Harrington wrote: > > > > > On Thu, Jun 09, 2016 at 03:20:35PM +0300, Pekka Paalanen wrote: > > > > From: Pekka Paalan