[PATCH v2 libinput] pad: group the button state into a private struct

2016-06-06 Thread Peter Hutterer
This is only set on button events so use the same approach as for rings and strips. No functional changes. Signed-off-by: Peter Hutterer --- Changes to v2: - rename button.button to button.number, brings it in line with ring/strip naming. src/libinput.c | 14 -- 1 file changed, 8

Re: [PATCH] scanner: Fix reported executable name to 'wayland-scanner'

2016-06-06 Thread Peter Hutterer
On Mon, Jun 06, 2016 at 10:41:04AM -0700, Bryce Harrington wrote: > On Fri, Jun 03, 2016 at 07:33:09PM +1000, Peter Hutterer wrote: > > On Fri, Jun 03, 2016 at 09:16:43AM +0800, Jonas Ådahl wrote: > > > On Thu, Jun 02, 2016 at 02:42:44PM -0700, Bryce Harrington wrote: > > > > 'wayland-scanner -v' (

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

2016-06-06 Thread Bryce Harrington
On Mon, Jun 06, 2016 at 10:08:00AM -0500, Yong Bakos wrote: > On Jun 6, 2016, at 7:18 AM, Pekka Paalanen wrote: > >> I don't believe this is a good choice. Imagine the case of a surface-less > >> 'inhibitor daemon.' > > > > An ordinary client must not be able to do that. > > > >> There may be no

Re: [PATCH libinput 4/7] doc: add two svgs showing the modes

2016-06-06 Thread Yong Bakos
On Jun 6, 2016, at 1:58 AM, Peter Hutterer wrote: > > Separate patch to avoid crowding out the actual content in the patch with the > documentation. > > Signed-off-by: Peter Hutterer FWIW, Reviewed-by: Yong Bakos yong > --- > doc/Makefile.am | 2 + > doc/svg/tablet-cin

Re: [PATCH v2] scanner: Fix reported executable name to 'wayland-scanner'

2016-06-06 Thread Yong Bakos
On Jun 6, 2016, at 12:58 PM, Bryce Harrington wrote: > > 'wayland-scanner -v' (correctly) reports the program as named > "wayland-scanner", but 'wayland-scanner -h' was inconsistent, referring > to it as './scanner'. > > Also refactor this and other references to the program name to use a > comm

[PATCH v2] scanner: Fix reported executable name to 'wayland-scanner'

2016-06-06 Thread Bryce Harrington
'wayland-scanner -v' (correctly) reports the program as named "wayland-scanner", but 'wayland-scanner -h' was inconsistent, referring to it as './scanner'. Also refactor this and other references to the program name to use a common #define, PROGRAM_NAME. Signed-off-by: Bryce Harrington Reviewed-

Re: [PATCH] scanner: Fix reported executable name to 'wayland-scanner'

2016-06-06 Thread Bryce Harrington
On Fri, Jun 03, 2016 at 07:33:09PM +1000, Peter Hutterer wrote: > On Fri, Jun 03, 2016 at 09:16:43AM +0800, Jonas Ådahl wrote: > > On Thu, Jun 02, 2016 at 02:42:44PM -0700, Bryce Harrington wrote: > > > 'wayland-scanner -v' (correctly) reports the program as named > > > "wayland-scanner", but 'wayl

Re: [PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-06 Thread Bryce Harrington
On Sun, Jun 05, 2016 at 07:01:11PM +0200, Benoit Gschwind wrote: > sprintf can overflow the fixed length title which is char[32]. This > patch change title to dynamically allocated char array using asprintf or > strdup. If one of them fail we leave returning NULL to indicate the > failure. > > Sig

Re: [PATCH weston] compositor-wayland: Correct output base make name

2016-06-06 Thread Bryce Harrington
On Sun, Jun 05, 2016 at 11:01:17AM -0500, Yong Bakos wrote: > From: Yong Bakos > > Change the output make value from "waywayland" to "wayland". > > References: 90bc88c710b34f46ef89e1c5765e5f63f8e02847 > > Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington > --- > src/compositor-waylan

Re: [PATCH libinput 5/7] pad: Add a new API for modes and mode groups

2016-06-06 Thread Yong Bakos
Hi Peter, One possible documentation error, one minor nit, and a string error (see "TABLET_PAD_MODE") inline below. Otherwise, this is, uh, Proofread-by: Yong Bakos Regards, yong > On Jun 6, 2016, at 1:50 AM, Peter Hutterer wrote: > > Move mode control to libinput. This reduces some flexibil

Re: [PATCH libinput 3/7] doc: move the struct declarations to the top

2016-06-06 Thread Yong Bakos
> On Jun 6, 2016, at 1:50 AM, Peter Hutterer wrote: > > They don't define anything, move them to the top so we don't have ordering > requirements of the stuff that actually uses those as parameters. > > Signed-off-by: Peter Hutterer FWIW, Reviewed-by: Yong Bakos yong > --- > src/libinput.h

Re: [PATCH libinput 2/7] doc: split the tablet pad events into their own doxygen module page

2016-06-06 Thread Yong Bakos
> On Jun 6, 2016, at 1:50 AM, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer FWIW, Reviewed-by: Yong Bakos yong > --- > src/libinput.h | 38 +++--- > 1 file changed, 23 insertions(+), 15 deletions(-) > > diff --git a/src/libinput.h b/src/libinput.h >

Re: [PATCH libinput 1/7] pad: group the button state into a private struct

2016-06-06 Thread Yong Bakos
Hi Peter, > On Jun 6, 2016, at 1:50 AM, Peter Hutterer wrote: > > This is only set on button events so use the same approach as for rings and > strips. No functional changes. > > Signed-off-by: Peter Hutterer > --- > src/libinput.c | 14 -- > 1 file changed, 8 insertions(+), 6 delet

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

2016-06-06 Thread Yong Bakos
On Jun 6, 2016, at 7:18 AM, Pekka Paalanen wrote: > > On Fri, 3 Jun 2016 10:39:24 -0500 > Yong Bakos wrote: > >> Hi, >> >> On Jun 3, 2016, at 4:04 AM, Pekka Paalanen wrote: >>> >>> On Fri, 3 Jun 2016 09:26:24 +0800 >>> Jonas Ådahl wrote: >>> On Thu, Jun 02, 2016 at 02:24:20PM -0700, B

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

2016-06-06 Thread Yong Bakos
On Jun 6, 2016, at 7:18 AM, Pekka Paalanen wrote: > > On Fri, 3 Jun 2016 10:39:24 -0500 > Yong Bakos wrote: > >> Hi, >> >> On Jun 3, 2016, at 4:04 AM, Pekka Paalanen wrote: >>> >>> On Fri, 3 Jun 2016 09:26:24 +0800 >>> Jonas Ådahl wrote: >>> On Thu, Jun 02, 2016 at 02:24:20PM -0700, B

Re: [PATCH weston v3 6/8] ivi-shell: Support tracking active surfaces

2016-06-06 Thread Pekka Paalanen
On Fri, 3 Jun 2016 19:24:40 -0700 Bryce Harrington wrote: > On Thu, May 26, 2016 at 06:02:00PM +0300, Pekka Paalanen wrote: > > On Thu, 7 Apr 2016 16:44:21 -0700 > > Bryce Harrington wrote: > > > > > Activity for ivi-shell follows either click or touch. Only a single > > > surface can be ac

Re: [PATCH weston v3 5/8] fullscreen-shell: Support tracking active surfaces

2016-06-06 Thread Pekka Paalanen
On Fri, 3 Jun 2016 18:45:59 -0700 Bryce Harrington wrote: > On Thu, May 26, 2016 at 06:01:52PM +0300, Pekka Paalanen wrote: > > On Thu, 7 Apr 2016 16:44:20 -0700 > > Bryce Harrington wrote: > > > > > Surface activity is determined by what surface is being displayed > > > fullscreen. Only a

Re: [RFC weston 4/4] WIP: libweston: rework versioning scheme

2016-06-06 Thread Pekka Paalanen
On Fri, 3 Jun 2016 14:27:39 +0100 Emil Velikov wrote: > From: Emil Velikov > > Use libweston-$major.so.0.$minor.$patch over the current scheme. Hi, is that really a commonly used versioning pattern? Could you add a reference to the project you used as an example? Is that project actually hap

Re: [PATCH] xdg-shell: add draw states for xdg_surface

2016-06-06 Thread Matthias Clasen
To me, 'draw states' sounds a lot like 'mwm hints' - which would be a 180 degree reversal from semantic states back to presentation states. Do we really want to go down that road ? ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https:/

Re: [RFC weston 3/4] XXX: README: Mention bits that we really want for libweston

2016-06-06 Thread Pekka Paalanen
On Fri, 3 Jun 2016 14:27:38 +0100 Emil Velikov wrote: > From: Emil Velikov > > --- > README | 12 > 1 file changed, 12 insertions(+) > > diff --git a/README b/README > index b8aa2e0..e411343 100644 > --- a/README > +++ b/README > @@ -161,3 +161,15 @@ major ABI-versions, except t

Re: [PATCH weston 2/4] README: minor the libweston ABI/API documentation

2016-06-06 Thread Pekka Paalanen
On Fri, 3 Jun 2016 14:27:37 +0100 Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > README | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/README b/README > index 76be7b9..b8aa2e0 100644 > --- a/README > +++ b/

Re: [PATCH weston 1/4] README: clarify libweston purpose/goals.

2016-06-06 Thread Pekka Paalanen
On Sun, 5 Jun 2016 23:37:57 +0100 Emil Velikov wrote: > Hi Yong, > > On 4 June 2016 at 01:58, Yong Bakos wrote: > > Hi Emil, > > > > On Jun 3, 2016, at 8:27 AM, Emil Velikov wrote: > >> > >> From: Emil Velikov > >> > >> v2: Rewrap, add a couple of missing words (Pekka). > >> > >> Signed-off

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-06 Thread Giulio Camuffo
2016-06-06 15:52 GMT+03:00 Pekka Paalanen : > On Sun, 5 Jun 2016 21:50:33 +0300 > Giulio Camuffo wrote: > >> 2016-06-03 17:33 GMT+03:00 Pekka Paalanen : >> > From: Pekka Paalanen >> > >> > This is the start of separating weston-the-compositor source files from >> > libweston source files. >> > >>

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-06 Thread Pekka Paalanen
On Sun, 5 Jun 2016 21:50:33 +0300 Giulio Camuffo wrote: > 2016-06-03 17:33 GMT+03:00 Pekka Paalanen : > > From: Pekka Paalanen > > > > This is the start of separating weston-the-compositor source files from > > libweston source files. > > > > This is moving all the files related to the 'weston'

Re: [PATCH weston 0/5] Clean up after backend config conversion

2016-06-06 Thread Pekka Paalanen
On Sun, 5 Jun 2016 21:20:42 +0300 Giulio Camuffo wrote: > Hi, > > i have a few nitpicks on some patches, but for the whole series: > Reviewed-by: Giulio Camuffo Hi, I fixed the whitespace issue and the typo, but did not squash the two patches. So with both of your R-bs, pushed: 9e44598..3

Re: [PATCH weston 5/5] main: remove unused argument from backend loaders

2016-06-06 Thread Pekka Paalanen
On Sun, 5 Jun 2016 21:24:18 +0300 Giulio Camuffo wrote: > Maybe it would make sense to squash this with the previous one? Hi, I don't think so. I can't write a commit summary that is both explicit and not listing two different things at the same time, so they really are two different changes.

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

2016-06-06 Thread Pekka Paalanen
On Fri, 3 Jun 2016 10:39:24 -0500 Yong Bakos wrote: > Hi, > > On Jun 3, 2016, at 4:04 AM, Pekka Paalanen wrote: > > > > On Fri, 3 Jun 2016 09:26:24 +0800 > > Jonas Ådahl wrote: > > > >> On Thu, Jun 02, 2016 at 02:24:20PM -0700, Bryce Harrington wrote: > >>> This interface allows disablin

[PATCH v2] xdg-shell: Add tiled state

2016-06-06 Thread Olivier Fourdan
When tiled, clients must obey the window geometry specified in the configure event and can choose to hide some of their decorations. Signed-off-by: Olivier Fourdan --- v2: Simplify the proposal and keep only one "tiled" state instead of one per edge. Note that the edges in my initial