[PATCH libinput 4/7] doc: add two svgs showing the modes

2016-06-05 Thread Peter Hutterer
Separate patch to avoid crowding out the actual content in the patch with the documentation. Signed-off-by: Peter Hutterer --- doc/Makefile.am | 2 + doc/svg/tablet-cintiq24hd-modes.svg | 460 doc/svg/tablet-intuos-modes.svg | 321 ++

[PATCH libinput 3/7] doc: move the struct declarations to the top

2016-06-05 Thread Peter Hutterer
They don't define anything, move them to the top so we don't have ordering requirements of the stuff that actually uses those as parameters. Signed-off-by: Peter Hutterer --- src/libinput.h | 252 - 1 file changed, 126 insertions(+), 126 de

[PATCH/RFC libinput 0/7] pad: add a mode toggle API

2016-06-05 Thread Peter Hutterer
Ok, I'm at the point where I can stare at this all day and don't see anything anymore, so up to you guys it is :) This implements mode switching support for tablet pads. The first two patches are just general cleanup, the meat is in 5/7 and 6/7. What is mode switching? On many tablets (Intuos P

[PATCH libinput 5/7] pad: Add a new API for modes and mode groups

2016-06-05 Thread Peter Hutterer
Move mode control to libinput. This reduces some flexibility on what we can do with modes but makes it a lot easier for anyone to implement modes correctly and have the LEDs apply appropriately, etc. Let's go with the option to make the 95% use-case easy. Note: whether the mode is actually used is

[PATCH libinput 7/7] test: add pad mode group tests

2016-06-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/pad.c | 163 + 1 file changed, 163 insertions(+) diff --git a/test/pad.c b/test/pad.c index 63bd2d7..9dea0fe 100644 --- a/test/pad.c +++ b/test/pad.c @@ -407,6 +407,164 @@ START_TEST(pad_left_hande

[PATCH libinput 1/7] pad: group the button state into a private struct

2016-06-05 Thread Peter Hutterer
This is only set on button events so use the same approach as for rings and strips. No functional changes. Signed-off-by: Peter Hutterer --- src/libinput.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/libinput.c b/src/libinput.c index 89fa594..0f676a3 10

[PATCH libinput 6/7] Implement tablet pad group mode support

2016-06-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- configure.ac | 2 +- src/Makefile.am | 1 + src/evdev-tablet-pad-leds.c | 621 ++ src/evdev-tablet-pad.c| 76 +- src/evdev-tablet-pad.h| 12 + src/evdev.h

[PATCH libinput 2/7] doc: split the tablet pad events into their own doxygen module page

2016-06-05 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/libinput.h | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/src/libinput.h b/src/libinput.h index ed3eb7d..dcfa09f 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -136,7 +136,7 @@ enum libinput_p

Re: [PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-05 Thread Yong Bakos
On Jun 5, 2016, at 12:01 PM, Benoit Gschwind wrote: > > sprintf can overflow the fixed length title which is char[32]. This > patch change title to dynamically allocated char array using asprintf or > strdup. If one of them fail we leave returning NULL to indicate the > failure. > > Signed-of-by

Re: [PATCH libinput] touchpad: restore the hysteresis by default

2016-06-05 Thread Peter Hutterer
On Fri, Jun 03, 2016 at 12:49:45PM +0200, Hans de Goede wrote: > Hi, > > On 03-06-16 03:59, Peter Hutterer wrote: > > A large part of the bugs seen right now are related to touchpads jittering > > too > > much. Fixing them one by one is entertaining but time consuming. Right now > > the number of

Re: [PATCH weston 1/4] README: clarify libweston purpose/goals.

2016-06-05 Thread Emil Velikov
Hi Yong, On 4 June 2016 at 01:58, Yong Bakos wrote: > Hi Emil, > > On Jun 3, 2016, at 8:27 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> v2: Rewrap, add a couple of missing words (Pekka). >> >> Signed-off-by: Emil Velikov > > I definitely agree that updating the README, especially reg

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-05 Thread Giulio Camuffo
2016-06-03 17:33 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > This is the start of separating weston-the-compositor source files from > libweston source files. > > This is moving all the files related to the 'weston' binary. Also the > CMS and systemd plugins are moved. > > xwayland plugi

Re: [PATCH weston 5/5] main: remove unused argument from backend loaders

2016-06-05 Thread Giulio Camuffo
Maybe it would make sense to squash this with the previous one? Cheers, Giulio 2016-06-03 15:41 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > There is no need to pass the backend name string to these functions > anymore. > > Signed-off-by: Pekka Paalanen > --- > src/main.c | 24 ++

Re: [PATCH weston 2/5] compositor, main: use weston_compositor_load_backend()

2016-06-05 Thread Giulio Camuffo
git am complains on this one: Applying patch #91319 using 'git am' Description: [weston,2/5] compositor, main: use weston_compositor_load_backend() Applying: compositor, main: use weston_compositor_load_backend() .git/rebase-apply/patch:44: new blank line at EOF. + warning: 1 line adds whitespace

Re: [PATCH weston 3/5] libweston: remove unused backend_init() arguments

2016-06-05 Thread Giulio Camuffo
2016-06-03 15:41 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > Backends do not have access to command line elements nor weston_config > anymore. The use the backend-specific config APIs now. Missing a y here, The -> They. Cheers, Giulio > > Signed-off-by: Pekka Paalanen > --- > src/co

Re: [PATCH weston 0/5] Clean up after backend config conversion

2016-06-05 Thread Giulio Camuffo
Hi, i have a few nitpicks on some patches, but for the whole series: Reviewed-by: Giulio Camuffo 2016-06-03 16:12 GMT+03:00 Quentin Glidic : > On 03/06/2016 14:41, Pekka Paalanen wrote: >> >> From: Pekka Paalanen >> >> Now that the rpi-backend is gone, we can clean this temporary stuff out, >>

[PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-05 Thread Benoit Gschwind
sprintf can overflow the fixed length title which is char[32]. This patch change title to dynamically allocated char array using asprintf or strdup. If one of them fail we leave returning NULL to indicate the failure. Signed-of-by: Benoit Gschwind --- v3: - fix xcb_destroy_window arguments v2:

[PATCH v2] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-05 Thread Benoit Gschwind
sprintf can overflow the fixed length title which is char[32]. This patch change title to dynamically allocated char array using asprintf or strdup. If one of them fail we leave returning NULL to indicate the failure. Signed-of-by: Benoit Gschwind --- src/compositor-x11.c | 28 +++

Re: [PATCH v1] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-05 Thread Benoit Gschwind
Hello Yong, Thanks for the review. On 05/06/2016 17:47, Yong Bakos wrote: > Hi Benoit, > Other than the comments inline below, this patch is > Reviewed-by: Yong Bakos > Tested-by: Yong Bakos > > On Jun 4, 2016, at 9:08 AM, Benoit Gschwind wrote: >> >> --- > > I'd love to see a short message

[PATCH weston] compositor-wayland: Correct output base make name

2016-06-05 Thread Yong Bakos
From: Yong Bakos Change the output make value from "waywayland" to "wayland". References: 90bc88c710b34f46ef89e1c5765e5f63f8e02847 Signed-off-by: Yong Bakos --- src/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/composit

Re: [PATCH v1] compositor-x11: fix title overflow in x11_backend_create_output

2016-06-05 Thread Yong Bakos
Hi Benoit, Other than the comments inline below, this patch is Reviewed-by: Yong Bakos Tested-by: Yong Bakos On Jun 4, 2016, at 9:08 AM, Benoit Gschwind wrote: > > --- I'd love to see a short message for the patch here explaining the rationale and behavior change, now that it's possible to re