Re: [PATCH wayland] wayland-server: Clarify included header dependencies

2016-06-01 Thread Bryce Harrington
On Tue, May 17, 2016 at 09:02:01PM -0600, Yong Bakos wrote: > From: Yong Bakos > > wayland-server.c directly depends on wayland-util.h, and will include > wayland-server-protocol.h via wayland-server.h. > > Explicitly include wayland-util.h, making this dependency clear. > Remove the redundant i

Re: [PATCH wayland] event-loop: Make transitive include explicit

2016-06-01 Thread Bryce Harrington
On Tue, May 17, 2016 at 02:32:02PM +0800, Jonas Ådahl wrote: > On Mon, May 16, 2016 at 12:05:39PM -0600, Yong Bakos wrote: > > From: Yong Bakos > > > > The explicit inclusion of wayland-server.h hides the real dependency, which > > is wayland-server-core.h. > > > > Signed-off-by: Yong Bakos >

Re: [PATCH] weston-launch: Handle invalid command line options

2016-06-01 Thread Bryce Harrington
On Mon, May 16, 2016 at 12:43:37PM -0600, Yong Bakos wrote: > On May 7, 2016, at 5:57 AM, Otavio Salvador wrote: > > > > From: Tom Hochstein > > > > Exit the program if an unrecognized command line option is found. > > > > Signed-off-by; Tom Hochstein > > Signed-off-by: Otavio Salvador > >

Re: [PATCH weston] Remove Raspberry Pi backend and renderer

2016-06-01 Thread Jonas Ådahl
On Wed, Jun 01, 2016 at 01:11:15PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > This patch completely removes the Raspberry Pi backend and the renderer. > > The backend and the renderer were written to use the proprietary > DispmanX API available only on the Raspberry Pi, to demonstra

Re: [PATCH RFC] xdg-shell: Add tiled states

2016-06-01 Thread Jonas Ådahl
On Wed, Jun 01, 2016 at 10:42:23AM -0400, Olivier Fourdan wrote: > Hi Mike, > > - Original Message - > > I've read the ticket linked in the other mail, but your use of "tiled" here > > is confusing to me since you (and the ticket) appear to be conflating two > > separate-but-unrelated mean

Re: [PATCH wayland 0/3] doc: Unpublish private objects and functions

2016-06-01 Thread Bryce Harrington
On Thu, May 12, 2016 at 03:52:36PM -0500, Yong Bakos wrote: > From: Yong Bakos > > The Wayland docbook and the doxygen html docs had been presenting a number > of private/inaccessible things as part of the public API, which is misleading. > > For 1/3, a \private command was introduced since the

Re: [PATCH weston] Remove Raspberry Pi backend and renderer

2016-06-01 Thread Bryce Harrington
Given there's an all-FOSS alternative coming down the pike, I see little reason to hold on to the proprietary-driver dependent backend. Acked-by: Bryce Harrington On Wed, Jun 01, 2016 at 01:11:15PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > This patch completely removes the Raspbe

Re: [PATCH libinput] touchpad: warn if we have invalid touchpad ranges

2016-06-01 Thread Peter Hutterer
On Wed, Jun 01, 2016 at 08:41:17AM -0500, Yong Bakos wrote: > On May 31, 2016, at 7:42 PM, Peter Hutterer wrote: > > > > Quite a few bugs are caused by touchpad ranges being out of whack. If we get > > input events significantly outside the expected range (5% width/height as > > error margin) pri

[PATCH weston v2 4/8] compositor: remove the weston_config field in weston_compositor

2016-06-01 Thread Giulio Camuffo
The config can now be retrieved with a new function defined in weston.h, weston_get_config(weston_compositor*). Signed-off-by: Giulio Camuffo --- desktop-shell/shell.c | 2 +- ivi-shell/hmi-controller.c | 6 +++--- ivi-shell/ivi-shell.c | 3 ++- src/cms-static.c | 3 ++- src/

[PATCH weston v2 6/8] allow compositors to define the logging behavior

2016-06-01 Thread Giulio Camuffo
Signed-off-by: Giulio Camuffo --- src/compositor.h | 5 ++-- src/log.c| 74 ++- src/main.c | 80 3 files changed, 90 insertions(+), 69 deletions(-) diff --git a/src/compositor.

[PATCH weston v2 3/8] Move the functions launching clients to main.c

2016-06-01 Thread Giulio Camuffo
They belong in the compositor rather than libweston since they set signals handlers, and a library should not do that behind its user's back. Besides, they were using functions in main.c already so they were not usable by other compositors. Signed-off-by: Giulio Camuffo --- ivi-shell/hmi-control

[PATCH weston v2 0/8] Create libweston.so, v2

2016-06-01 Thread Giulio Camuffo
This new version fixes the issues raised and adds two new patches to plug a hole i didn't notice before. Now libweston should not use any functionality that is part of weston-the-compositor. Giulio Camuffo (8): Rename weston_compositor_xkb_init to weston_compositor_set_xkb_rule_names Move

[PATCH weston v2 1/8] Rename weston_compositor_xkb_init to weston_compositor_set_xkb_rule_names

2016-06-01 Thread Giulio Camuffo
weston_compositor_xkb_destroy() is called automatically so having only weston_compositor_xkb_init() to be called by the user was a bit weird. So rename it so that it makes more sense. Also export it, since libweston compositors need to call it. --- v2: renamed xkb_init to set_xkb_rule_names src/

[PATCH weston v2 8/8] Create a libweston-0.so

2016-06-01 Thread Giulio Camuffo
This commit also adds a libweston-0.pc file. The -0 is the abi version introduced in the previous patch. Signed-off-by: Giulio Camuffo --- Makefile.am | 45 +++-- configure.ac| 4 src/libweston.pc.in | 12 src/weston.pc.i

[PATCH weston v2 7/8] Split the modules and include files between weston and libweston

2016-06-01 Thread Giulio Camuffo
The backends are now installed in lib/libweston-0, and the include files that will be used by libweston in include/libweston-0. The other modules and weston-specific include files are kept in the old paths. A new load_weston_module() is added to load plugins in the old path, which is not part of li

[PATCH weston v2 5/8] libinput: don't use weston_config when configuring input devices

2016-06-01 Thread Giulio Camuffo
Instead add callbacks to the drm and fbdev backends and pass that to the input backens so that when a new device needs to be configured that is called and the compositor can configure it. Signed-off-by: Giulio Camuffo --- Makefile.am| 3 ++- src/compositor-drm.c | 3 ++- src/comp

[PATCH weston v2 2/8] Move part of screenshooter.c to weston-screenshooter.c

2016-06-01 Thread Giulio Camuffo
This patch splits screensooter.c so that the code implementing the private screenshooter protocol and launching the client is moved to a weston specific file, leaving only the code that can be shared between compositors in screenshooter.c. Two exported functions are added in screenshooter.c to star

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

2016-06-01 Thread Yong Bakos
On May 30, 2016, at 3:54 AM, Pekka Paalanen wrote: > > On Sat, 28 May 2016 08:39:59 -0500 > Yong Bakos wrote: > >> Hi Mike, >> Regarding the combination of type="array" enum="foo"... >> >>> On May 27, 2016, at 12:30 PM, Mike Blumenkrantz >>> wrote: >>> >>> I've inlined some replies below. >

[RFC wayland 1/1] protocol: Add summary attributes to request params and enum entries

2016-06-01 Thread Yong Bakos
From: Yong Bakos Signed-off-by: Yong Bakos --- protocol/wayland.xml | 334 ++- 1 file changed, 172 insertions(+), 162 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 700ef03..d0db6cc 100644 --- a/protocol/wayland.xml +

Re: [PATCH RFC] xdg-shell: Add tiled states

2016-06-01 Thread Mike Blumenkrantz
On Wed, Jun 1, 2016 at 10:42 AM Olivier Fourdan wrote: > Hi Mike, > > - Original Message - > > I've read the ticket linked in the other mail, but your use of "tiled" > here > > is confusing to me since you (and the ticket) appear to be conflating two > > separate-but-unrelated meanings.

[RFC wayland 0/1] protocol: Add summary attributes to request params and enum entries

2016-06-01 Thread Yong Bakos
From: Yong Bakos This patch adds missing summary attributes to all request arg elements and enum entry elements. I've marked this as RFC as I would like some feedback before formalizing the patch. Specifically: wl_shm.format enum: Are these summaries fine? Do we want them at all? Doing so give

Re: [PATCH weston] Remove support for the proprietary Raspberry Pi drivers

2016-06-01 Thread Derek Foreman
On 01/06/16 05:11 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Hi, > > please see the commit message on the patch for the story. > > The patch has been generated with -D to avoid listing the contents of the > deleted files. You can find the proper, complete patch at: > https://git.colla

Re: [PATCH RFC] xdg-shell: Add tiled states

2016-06-01 Thread Olivier Fourdan
Hi Mike, - Original Message - > I've read the ticket linked in the other mail, but your use of "tiled" here > is confusing to me since you (and the ticket) appear to be conflating two > separate-but-unrelated meanings. "Tiled" is a type of window layout policy > which organizes windows in

Re: [PATCH RFC] xdg-shell: Add tiled states

2016-06-01 Thread Mike Blumenkrantz
Hi, On Wed, Jun 1, 2016 at 5:19 AM Olivier Fourdan wrote: > When tiled, clients must obey the window geometry specified in the > configure event and can choose to hide some of their decorations. > > Signed-off-by: Olivier Fourdan > --- > unstable/xdg-shell/xdg-shell-unstable-v6.xml | 27 >

Re: [PATCH libinput] touchpad: warn if we have invalid touchpad ranges

2016-06-01 Thread Yong Bakos
On May 31, 2016, at 7:42 PM, Peter Hutterer wrote: > > Quite a few bugs are caused by touchpad ranges being out of whack. If we get > input events significantly outside the expected range (5% width/height as > error margin) print a warning to the log. > > And add a new doc page to explain what i

[PATCH weston] Remove Raspberry Pi backend and renderer

2016-06-01 Thread Pekka Paalanen
From: Pekka Paalanen This patch completely removes the Raspberry Pi backend and the renderer. The backend and the renderer were written to use the proprietary DispmanX API available only on the Raspberry Pi, to demonstrate what the tiny computer is capable of graphics wise. They were also used t

[PATCH weston] Remove support for the proprietary Raspberry Pi drivers

2016-06-01 Thread Pekka Paalanen
From: Pekka Paalanen Hi, please see the commit message on the patch for the story. The patch has been generated with -D to avoid listing the contents of the deleted files. You can find the proper, complete patch at: https://git.collabora.com/cgit/user/pq/weston.git/log/?h=rpi-removal Thanks,

[PATCH wayland-web] Remove the special Raspberry Pi guide

2016-06-01 Thread Pekka Paalanen
From: Pekka Paalanen The Raspberry Pi backend has been removed from Weston. You should try the FOSS driver stack instead. Signed-off-by: Pekka Paalanen --- building.html| 4 +- raspberrypi.html | 225 --- 2 files changed, 3 insertions(+

[PATCH RFC] Add tiled states per edge

2016-06-01 Thread Olivier Fourdan
Hi all, I send this as an RFC for now, to gauge the water and get the ball rolling. I don't think tiling overlaps with the "draw states" proposed by Mike in the other thread currently on wayland-devel, I reckon tiling is more than just drawing, applications must obey the configure event when tile

[PATCH RFC] xdg-shell: Add tiled states

2016-06-01 Thread Olivier Fourdan
When tiled, clients must obey the window geometry specified in the configure event and can choose to hide some of their decorations. Signed-off-by: Olivier Fourdan --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 27 +++ 1 file changed, 27 insertions(+) diff --git a/un

Re: [PATCH weston 0/3] misc ivi-shell patches

2016-06-01 Thread Pekka Paalanen
On Thu, 12 May 2016 11:56:35 +0300 Pekka Paalanen wrote: > On Thu, 12 May 2016 07:50:08 + > "Ucan, Emre (ADITG/SW1)" wrote: > > > Hi Pekka, > > > > All patches look good. > > > > Reviewed-by: Emre Ucan > > Hi, > > cool, patches 1 and 2 pushed: >5375384..edcb312 master -> master

Re: Protocol for window previews/thumbnails

2016-06-01 Thread Pekka Paalanen
On Tue, 31 May 2016 14:49:38 +0100 adlo wrote: > > On 20 May 2016, at 08:50, Pekka Paalanen wrote: > > > > You would design a new protocol extension private to Weston, with which > > you deliver to your client the handles for top-level windows as they > > come and go. > > > > This should pr

Re: [PATCH libinput] touchpad: warn if we have invalid touchpad ranges

2016-06-01 Thread Hans de Goede
Hi, On 01-06-16 02:42, Peter Hutterer wrote: Quite a few bugs are caused by touchpad ranges being out of whack. If we get input events significantly outside the expected range (5% width/height as error margin) print a warning to the log. And add a new doc page to explain what is happening and h