[PATCH wayland-protocols v3 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

2016-05-25 Thread Jonas Ådahl
The reason for using wl_surface before was that xdg_popup and xdg_surface (now xdg_toplevel) had no common interface other than wl_surface, but since xdg_surface is now the base interface, lets use that. Signed-off-by: Jonas Ådahl Reviewed-by: Mike Blumenkrantz Reviewed-by: Yong Bakos --- unst

[PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

2016-05-25 Thread Jonas Ådahl
xdg_positioner is a method for declarative positioning of child surfaces (currently only xdg_popup surfaces). A client creates a description of a positioning logic using the xdg_positioner interface. The xdg_positioner object is then used when creating a xdg_popup for describing how the child surfa

[PATCH wayland-protocols v3 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-05-25 Thread Jonas Ådahl
Turn xdg_popup into plain temporary child surfaces without any grabbing or mapping order requirements by default. In order to create grabbing popup chains, a new request 'grab' is introduced which enables more or less the same semantics and requirements as xdg_popup previously had related to grabb

[PATCH wayland-protocols v3 0/7] Landing of xdg shell unstable v6 patches

2016-05-25 Thread Jonas Ådahl
Hi all, Here comes an updated version of the xdg shell patches that introduces xdg_surface as a building block, xdg_toplevel replacing the old xdg_surface and a xdg_popup that can be placed semantically and not take grabs. With these patches, there is only one more unfinished feature addition lef

[PATCH wayland-protocols v3 4/7] xdg-shell: Improve error enum formatting some

2016-05-25 Thread Jonas Ådahl
The long lines stood out, break them by putting the summary on its own line. Signed-off-by: Jonas Ådahl Reviewed-by: Yong Bakos Reviewed-by: Mike Blumenkrantz --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/unsta

[PATCH wayland-protocols v3 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-05-25 Thread Jonas Ådahl
Split out toplevel window like requests and events into a new interface called xdg_toplevel, and turn xdg_surface into a generic base interface which others extends. xdg_popup is changed to extend the xdg_surface. The configure event in xdg_surface was split up making xdg_surface.configure an eve

[PATCH wayland-protocols v3 3/7] xdg-shell: Add error codes for invalid surface state

2016-05-25 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl Reviewed-by: Mike Blumenkrantz Reviewed-by: Yong Bakos --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml index c7036f5..31

[PATCH wayland-protocols v3 2/7] xdg-shell: Put xdg_shell events after requests

2016-05-25 Thread Jonas Ådahl
It makes the structure consistent with most other protocols and provides a clear separation between what is done by the server and what is done by the client. Signed-off-by: Jonas Ådahl Reviewed-by: Yong Bakos Reviewed-by: Mike Blumenkrantz --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 74

[PATCH libinput] tablet: up the reference count for the tool in the event

2016-05-25 Thread Peter Hutterer
Make sure that the tool is valid while the event is valid, even if the device gets destroyed before the event is destroyed. This cannot actually be triggered right now, the event has a ref to the device and the tools do not get removed until the device is destroyed. But for future implementations

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

2016-05-25 Thread Bryce Harrington
On Wed, May 18, 2016 at 04:11:39PM +0300, Pekka Paalanen wrote: > On Thu, 24 Mar 2016 11:14:33 -0700 > > Should I go through the v3 Weston patches too, or do you want to revise > them according to protocol changes first? Yes, the weston patches are the main thing that haven't gotten reviewed so f

Re: [PATCH weston 1/6] Export weston_compositor_xkb_init, as required for libweston users

2016-05-25 Thread Pekka Paalanen
On Tue, 24 May 2016 19:59:05 +0300 Giulio Camuffo wrote: > --- > src/input.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/input.c b/src/input.c > index 8fe898c..c6cdedd 100644 > --- a/src/input.c > +++ b/src/input.c > @@ -2277,7 +2277,7 @@ bind_seat(struct wl

Re: [PATCH weston 6/6] Create a libweston-0.so

2016-05-25 Thread Quentin Glidic
On 24/05/2016 18:59, Giulio Camuffo wrote: This commit also adds a libweston-0.pc file. The -0 is the abi version introduced in the previous patch. Signed-off-by: Giulio Camuffo Almost perfect, a few comments inline. --- Makefile.am | 44 +++

Re: [PATCH weston 5/6] allow compositors to define the logging behavior

2016-05-25 Thread Quentin Glidic
On 24/05/2016 18:59, Giulio Camuffo wrote: Signed-off-by: Giulio Camuffo --- src/compositor.h | 5 ++-- src/log.c| 74 ++- src/main.c | 80 3 files changed, 90 insertions(+),

Re: [PATCH weston 3/6] Move the functions launching clients to main.c

2016-05-25 Thread Quentin Glidic
On 24/05/2016 18:59, Giulio Camuffo wrote: They belong in the compositor rather than libweston since they set signals handlers, and a library should not do that behind its user's back. Besides, they were using functions in main.c already so they were not usable by other compositors. Signed-off-b

Re: [PATCH] compositor-drm: pass only const strings as backend parameters

2016-05-25 Thread Giulio Camuffo
2016-05-25 10:46 GMT+03:00 Quentin Glidic : > On 24/05/2016 18:50, Giulio Camuffo wrote: >> >> This makes more clear that the backend doesn't take ownership >> of the data and it makes the API more usable. >> >> Signed-off-by: Giulio Camuffo > > > Good idea, but one little flaw. > > > >> --- >> s

Re: [PATCH weston 2/6] Split the modules and include files between weston and libweston

2016-05-25 Thread Quentin Glidic
On 24/05/2016 18:59, Giulio Camuffo wrote: The backends are now installed in lib/libweston-0, and the include files that will be used by libweston in include/libweston-0. The other modules and weston-specific include files are kept in the old paths. A new load_weston_module() is added to load plu

Re: [PATCH weston 1/6] Export weston_compositor_xkb_init, as required for libweston users

2016-05-25 Thread Quentin Glidic
On 24/05/2016 18:59, Giulio Camuffo wrote: --- src/input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/input.c b/src/input.c index 8fe898c..c6cdedd 100644 --- a/src/input.c +++ b/src/input.c @@ -2277,7 +2277,7 @@ bind_seat(struct wl_client *client, void *data, uin

Re: Touch input behavior on overlapping ivi surfaces

2016-05-25 Thread Pekka Paalanen
On Wed, 25 May 2016 11:13:09 +0530 Vikas Patil wrote: > On Tue, May 24, 2016 at 6:44 PM, Pekka Paalanen wrote: > > On Tue, 24 May 2016 18:29:52 +0530 > > Vikas Patil wrote: > > > >> Dear All, > >> > >> Here (attached here the image ) the touch input is not going to surface 1 > >> even after t

Re: [PATCH] compositor-drm: pass only const strings as backend parameters

2016-05-25 Thread Quentin Glidic
On 24/05/2016 18:50, Giulio Camuffo wrote: This makes more clear that the backend doesn't take ownership of the data and it makes the API more usable. Signed-off-by: Giulio Camuffo Good idea, but one little flaw. --- src/compositor-drm.h | 10 +- src/main.c | 18