Re: [PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

2016-05-17 Thread Peter Hutterer
On Tue, May 17, 2016 at 02:07:39PM -0700, Jason Gerecke wrote: > On 05/17/2016 03:02 AM, Carlos Garnacho wrote: > > Hey :), > > > > On Tue, May 17, 2016 at 2:50 AM, Peter Hutterer > > wrote: > >> On Tue, May 17, 2016 at 01:30:03AM +0200, Carlos Garnacho wrote: > >>> Hey :), > >>> > >>> On Wed, Ma

Re: [PATCH wayland-protocols v2 7/7] xdg-shell: Introduce xdg_positioner

2016-05-17 Thread Jonas Ådahl
On Tue, May 17, 2016 at 03:41:37PM -0500, Yong Bakos wrote: > On May 11, 2016, at 12:50 AM, Jonas Ådahl wrote: > > > > xdg_positioner is a method for declarative positioning of child surfaces > > (currently only xdg_popup surfaces). A client creates a description of a > > positioning logic using

[PATCH wayland] wayland-server: Clarify included header dependencies

2016-05-17 Thread Yong Bakos
From: Yong Bakos wayland-server.c directly depends on wayland-util.h, and will include wayland-server-protocol.h via wayland-server.h. Explicitly include wayland-util.h, making this dependency clear. Remove the redundant inclusion of wayland-server-protocol.h. Signed-off-by: Yong Bakos --- sr

Re: [PATCH wayland-protocols v2 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-05-17 Thread Jonas Ådahl
On Tue, May 17, 2016 at 01:35:43PM -0500, Yong Bakos wrote: > On May 11, 2016, at 12:49 AM, Jonas Ådahl wrote: > > > > Split out toplevel window like requests and events into a new interface > > called xdg_toplevel, and turn xdg_surface into a generic base interface > > which others extends. > >

Re: [PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

2016-05-17 Thread Jason Gerecke
On 05/17/2016 03:02 AM, Carlos Garnacho wrote: > Hey :), > > On Tue, May 17, 2016 at 2:50 AM, Peter Hutterer > wrote: >> On Tue, May 17, 2016 at 01:30:03AM +0200, Carlos Garnacho wrote: >>> Hey :), >>> >>> On Wed, May 11, 2016 at 4:51 AM, Peter Hutterer >>> wrote: From: Carlos Garnacho >>>

Re: [PATCH wayland-protocols v2 7/7] xdg-shell: Introduce xdg_positioner

2016-05-17 Thread Yong Bakos
On May 11, 2016, at 12:50 AM, Jonas Ådahl wrote: > > xdg_positioner is a method for declarative positioning of child surfaces > (currently only xdg_popup surfaces). A client creates a description of a > positioning logic using the xdg_positioner interface. The xdg_positioner > object is then used

Re: [PATCH wayland-protocols v2 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-05-17 Thread Yong Bakos
On May 11, 2016, at 12:50 AM, Jonas Ådahl wrote: > > Turn xdg_popup into plain temporary child surfaces without any grabbing > or mapping order requirements by default. > > In order to create grabbing popup chains, a new request 'grab' is > introduced which enables more or less the same semantic

Re: [PATCH wayland-protocols v2 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

2016-05-17 Thread Yong Bakos
On May 11, 2016, at 12:50 AM, Jonas Ådahl wrote: > > The reason for using wl_surface before was that xdg_popup and > xdg_surface (now xdg_toplevel) had no common interface other than > wl_surface, but since xdg_surface is now the base interface, lets use > that. > > Signed-off-by: Jonas Ådahl >

Re: [PATCH wayland-protocols v2 4/7] xdg-shell: Improve error enum formatting some

2016-05-17 Thread Yong Bakos
On May 11, 2016, at 12:50 AM, Jonas Ådahl wrote: > > The long lines stood out, break them by putting the summary on its own > line. > > Signed-off-by: Jonas Ådahl > Reviewed-by: Yong Bakos > Reviewed-by: Mike Blumenkrantz This v2 is again Reviewed-by: Yong Bakos At some point I want to gen

Re: [PATCH wayland-protocols v2 3/7] xdg-shell: Add error codes for invalid surface state

2016-05-17 Thread Yong Bakos
On May 11, 2016, at 12:50 AM, Jonas Ådahl wrote: > > Signed-off-by: Jonas Ådahl > Reviewed-by: Mike Blumenkrantz Makes sense, Reviewed-by: Yong Bakos yong > --- > unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/unstable/xdg-shell/xdg-

Re: [PATCH wayland-protocols v2 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-05-17 Thread Yong Bakos
On May 11, 2016, at 12:49 AM, Jonas Ådahl wrote: > > Split out toplevel window like requests and events into a new interface > called xdg_toplevel, and turn xdg_surface into a generic base interface > which others extends. > > xdg_popup is changed to extend the xdg_surface. > > The configure ev

Re: [PATCH] ivi-layout: Initialize surface source rectange to 1x1

2016-05-17 Thread Yong Bakos
On May 17, 2016, at 3:58 AM, mateuszx.potr...@intel.com wrote: > > From: Mateusz Polrola > > If surface will be set to visible before its source rectangle will > be defined it will be displayed in its orginal size. > This is because initial setting of destination rectangle to 1x1 is > not causin

Re: [PATCH] weston: Don't exit just because tty is in gfx mode already

2016-05-17 Thread Yong Bakos
On May 16, 2016, at 5:25 PM, Florian Hänel wrote: > > From: =?UTF-8?q?Florian=20H=C3=A4nel?= > > If weston crashed (or during development) it can leave the tty > in graphics mode, which would prevent it from ever coming up again. > > Another compositor running should be handled by upstart/syst

Re: [PATCH weston 4/8] compositor-drm: Prevent a crash in the pixman renderer

2016-05-17 Thread Pekka Paalanen
On Tue, 3 May 2016 15:08:37 +0200 Quentin Glidic wrote: > On 02/05/2016 23:40, Emmanuel Gil Peyrot wrote: > > When pixman is used and no connector could be found (or any other > > error), drm_backend_create() tried to destroy a gbm_device that would > > only be created in init_egl(), resulting in

Re: [PATCH weston 3/8] compositor-drm: Don’t try to set the cursor anymore once we know it’s broken

2016-05-17 Thread Pekka Paalanen
On Mon, 2 May 2016 22:40:12 +0100 Emmanuel Gil Peyrot wrote: > Signed-off-by: Emmanuel Gil Peyrot > --- > src/compositor-drm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > index ea118fa..c11562f 100644 > --- a/src/com

Re: [PATCH weston 1/2] compositor: fix comments about weston_compositor::surface_list

2016-05-17 Thread Pekka Paalanen
On Tue, 17 May 2016 12:17:45 +0300 Pekka Paalanen wrote: > On Mon, 16 May 2016 16:29:18 +0200 > Armin Krezović wrote: > > > On 10.05.2016 16:10, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > a7af70436b7dccfacd736626d6719b3e751fd985 converted the surface list into > > > a view

Re: [PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

2016-05-17 Thread Carlos Garnacho
Hey :), On Tue, May 17, 2016 at 2:50 AM, Peter Hutterer wrote: > On Tue, May 17, 2016 at 01:30:03AM +0200, Carlos Garnacho wrote: >> Hey :), >> >> On Wed, May 11, 2016 at 4:51 AM, Peter Hutterer >> wrote: >> > From: Carlos Garnacho >> > >> > The pad's interface is similar to the tool interface,

Re: [PATCH weston 1/2] compositor: fix comments about weston_compositor::surface_list

2016-05-17 Thread Pekka Paalanen
On Mon, 16 May 2016 16:29:18 +0200 Armin Krezović wrote: > On 10.05.2016 16:10, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > a7af70436b7dccfacd736626d6719b3e751fd985 converted the surface list into > > a view list. > > > > It looks like weston_surface::output's comment about surface

[PATCH] ivi-layout: Initialize surface source rectange to 1x1

2016-05-17 Thread mateuszx . potrola
From: Mateusz Polrola If surface will be set to visible before its source rectangle will be defined it will be displayed in its orginal size. This is because initial setting of destination rectangle to 1x1 is not causing surface resize and because source rectangle is 0x0 appropiate transformation

Re: [PATCH weston 2/2] compositor: surface and view output comment fixes

2016-05-17 Thread Pekka Paalanen
On Mon, 16 May 2016 23:02:42 +0800 Jonas Ådahl wrote: > On Mon, May 16, 2016 at 04:45:05PM +0200, Armin Krezović wrote: > > On 10.05.2016 16:10, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > weston_surface::output and weston_view::output as used for different > > > purposes. On