Re: [PATCH] weston-launch: Handle invalid command line options

2016-05-16 Thread Jonas Ådahl
On Mon, May 16, 2016 at 12:43:37PM -0600, Yong Bakos wrote: > On May 7, 2016, at 5:57 AM, Otavio Salvador wrote: > > > > From: Tom Hochstein > > > > Exit the program if an unrecognized command line option is found. > > > > Signed-off-by; Tom Hochstein > > Signed-off-by: Otavio Salvador > >

Re: [PATCH wayland] event-loop: Make transitive include explicit

2016-05-16 Thread Jonas Ådahl
On Mon, May 16, 2016 at 12:05:39PM -0600, Yong Bakos wrote: > From: Yong Bakos > > The explicit inclusion of wayland-server.h hides the real dependency, which > is wayland-server-core.h. > > Signed-off-by: Yong Bakos Reviewed-by: Jonas Ådahl > --- > src/event-loop.c | 2 +- > 1 file changed

Re: [PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

2016-05-16 Thread Peter Hutterer
On Tue, May 17, 2016 at 01:30:03AM +0200, Carlos Garnacho wrote: > Hey :), > > On Wed, May 11, 2016 at 4:51 AM, Peter Hutterer > wrote: > > From: Carlos Garnacho > > > > The pad's interface is similar to the tool interface, a client is notified > > of > > the pad after the tablet_added event. >

Re: [PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

2016-05-16 Thread Carlos Garnacho
Hey :), On Wed, May 11, 2016 at 4:51 AM, Peter Hutterer wrote: > From: Carlos Garnacho > > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons, rings and strips. > Buttons are fairly

[PATCH] weston: Don't exit just because tty is in gfx mode already

2016-05-16 Thread Florian Hänel
From: =?UTF-8?q?Florian=20H=C3=A4nel?= If weston crashed (or during development) it can leave the tty in graphics mode, which would prevent it from ever coming up again. Another compositor running should be handled by upstart/systemd and the tty in graphics mode does not prevent us from using i

[PATCH] weston: Don't exit just because tty is in gfx mode already

2016-05-16 Thread Florian Hänel
From: =?UTF-8?q?Florian=20H=C3=A4nel?= If weston crashed (or during development) it can leave the tty in graphics mode, which would prevent it from ever coming up again. Another compositor running should be handled by upstart/systemd and the tty in graphics mode does not prevent us from using i

Re: Introduction and updates from NVIDIA

2016-05-16 Thread Daniel Vetter
On Mon, May 16, 2016 at 11:12:35AM -0700, James Jones wrote: > On 05/16/2016 02:36 AM, Daniel Vetter wrote: > >On Sat, May 14, 2016 at 05:46:51PM +0100, Daniel Stone wrote: > >>On 12 May 2016 at 00:08, James Jones wrote: > >>>The EGLStream encapsulation takes into consideration the new use cases >

Re: [PATCH] weston-launch: Handle invalid command line options

2016-05-16 Thread Yong Bakos
On May 7, 2016, at 5:57 AM, Otavio Salvador wrote: > > From: Tom Hochstein > > Exit the program if an unrecognized command line option is found. > > Signed-off-by; Tom Hochstein > Signed-off-by: Otavio Salvador Simple enough of a review, and I did test this. But the question is whether we w

Re: Introduction and updates from NVIDIA

2016-05-16 Thread James Jones
On 05/16/2016 02:36 AM, Daniel Vetter wrote: On Sat, May 14, 2016 at 05:46:51PM +0100, Daniel Stone wrote: On 12 May 2016 at 00:08, James Jones wrote: The EGLStream encapsulation takes into consideration the new use cases EGLImage, GBM, etc. were intended to address, and restores what I believ

[PATCH wayland] event-loop: Make transitive include explicit

2016-05-16 Thread Yong Bakos
From: Yong Bakos The explicit inclusion of wayland-server.h hides the real dependency, which is wayland-server-core.h. Signed-off-by: Yong Bakos --- src/event-loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index ea27b69..11a9bf2 1

Re: [PATCH v2 libinput] Add configure.ac check for static_assert

2016-05-16 Thread Baruch Siach
Hi Peter, On Mon, May 16, 2016 at 01:32:07PM +1000, Peter Hutterer wrote: > Part of C11, defined via assert.h. > > Signed-off-by: Peter Hutterer This fixes the build using a uClibc-ng toolchain that does not define the static_assert macro. Tested-by: Baruch Siach Thanks, baruch > --- > Cha

Re: [PATCH weston 2/2] compositor: surface and view output comment fixes

2016-05-16 Thread Armin Krezović
On 16.05.2016 17:02, Jonas Ådahl wrote: > On Mon, May 16, 2016 at 04:45:05PM +0200, Armin Krezović wrote: >> On 10.05.2016 16:10, Pekka Paalanen wrote: >>> From: Pekka Paalanen >>> >>> weston_surface::output and weston_view::output as used for different >>> purposes. Only the surface output is use

Re: [PATCH weston 2/2] compositor: surface and view output comment fixes

2016-05-16 Thread Jonas Ådahl
On Mon, May 16, 2016 at 04:45:05PM +0200, Armin Krezović wrote: > On 10.05.2016 16:10, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > weston_surface::output and weston_view::output as used for different > > purposes. Only the surface output is used for frame callbacks. > > > > The uses o

Re: [PATCH weston 2/2] compositor: surface and view output comment fixes

2016-05-16 Thread Armin Krezović
On 10.05.2016 16:10, Pekka Paalanen wrote: > From: Pekka Paalanen > > weston_surface::output and weston_view::output as used for different > purposes. Only the surface output is used for frame callbacks. > > The uses of the view output are much more vague and hard to describe. > > Also fix a co

Re: [PATCH weston 1/2] compositor: fix comments about weston_compositor::surface_list

2016-05-16 Thread Armin Krezović
On 10.05.2016 16:10, Pekka Paalanen wrote: > From: Pekka Paalanen > > a7af70436b7dccfacd736626d6719b3e751fd985 converted the surface list into > a view list. > > It looks like weston_surface::output's comment about surface list does > not apply to view list. Still, many places assume weston_surf

Re: Feedback on xdg-shell v5

2016-05-16 Thread Bill Spitzak
On Mon, May 9, 2016 at 8:18 PM, Jonas Ådahl wrote: > On Fri, Apr 29, 2016 at 12:37:22PM +0300, Pekka Paalanen wrote: > > On Fri, 29 Apr 2016 15:31:28 +0800 > > Jonas Ådahl wrote: > > > > > On Thu, Apr 28, 2016 at 02:08:07PM +0300, Pekka Paalanen wrote: > > > > On Thu, 28 Apr 2016 17:36:58 +0800

[PATCH] weston-launch: Handle invalid command line options

2016-05-16 Thread Otavio Salvador
From: Tom Hochstein Exit the program if an unrecognized command line option is found. Signed-off-by; Tom Hochstein Signed-off-by: Otavio Salvador --- src/weston-launch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/weston-launch.c b/src/weston-launch.c index b8dfb17..9987d8e 10

Re: [PATCH weston v1 3/3] compositor-x11: remove manual mouse button grab/ungrab

2016-05-16 Thread Bill Spitzak
Does the x11 compositor have to do this at all? It owns that window so it gets automatic grabs. This is for one client to eat the events being passed to another client. On Fri, May 13, 2016 at 4:34 AM, Benoit Gschwind wrote: > In current compositor-x11, the mouse buttons are grabbed and ungrabb

Re: [PATCH wayland-protocols v2 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-05-16 Thread Bill Spitzak
On Tue, May 10, 2016 at 10:50 PM, Jonas Ådahl wrote: > Turn xdg_popup into plain temporary child surfaces without any grabbing > or mapping order requirements by default. > > In order to create grabbing popup chains, a new request 'grab' is > introduced which enables more or less the same semanti

Re: [PATCH weston] eventdemo: use %u for uint32_t printing

2016-05-16 Thread Pekka Paalanen
On Fri, 13 May 2016 13:50:17 +0200 Benoit Gschwind wrote: > Hello Pekka, > > Look sane. > > Reviewed-by: Benoit Gschwind And pushed: 0baffb0..901ac32 master -> master Thanks, pq > On 13/05/2016 13:38, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > I was confused why timestamp

Re: [PATCH wayland 5/5] tests: test whether the destroyed object is set to NULL on client destruction

2016-05-16 Thread Pekka Paalanen
On Fri, 13 May 2016 15:01:22 +0200 Marek Chalupa wrote: > when the client is being destroyed, we can use wl_client_get_object() > to get an object. Test whether it returns NULL when the object > has been destroyed > > Signed-off-by: Marek Chalupa > --- > tests/client-test.c | 63 > +++

Re: [PATCH wayland 4/5] client-test: test posting no-mem error on client destruction

2016-05-16 Thread Pekka Paalanen
On Mon, 16 May 2016 13:52:24 +0300 Pekka Paalanen wrote: > On Fri, 13 May 2016 15:01:21 +0200 > Marek Chalupa wrote: > > > while client is being destroyed, it destroys all its resources. > > Destroy handlers are called for the resources and if some > > destroy handler post no memory error, we g

Re: [PATCH wayland 4/5] client-test: test posting no-mem error on client destruction

2016-05-16 Thread Pekka Paalanen
On Fri, 13 May 2016 15:01:21 +0200 Marek Chalupa wrote: > while client is being destroyed, it destroys all its resources. > Destroy handlers are called for the resources and if some > destroy handler post no memory error, we get crash, because > the display resource is NULL (it is destroyed as a

Re: [PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

2016-05-16 Thread Quentin Glidic
On 01/05/2016 23:32, David Fort wrote: FreeRDP 2.0 is about to be released, this allows to compile against this version. The detection is adjusted to prefer FreeRDP 2 against version 1.x. Signed-off-by: David Fort Reviewed-by: Quentin Glidic If think you can retain Rb from Bryce too, as yo

Re: Introduction and updates from NVIDIA

2016-05-16 Thread Daniel Vetter
On Sat, May 14, 2016 at 05:46:51PM +0100, Daniel Stone wrote: > On 12 May 2016 at 00:08, James Jones wrote: > > The EGLStream encapsulation takes into consideration the new use cases > > EGLImage, GBM, etc. were intended to address, and restores what I believe to > > be the minimal amount of the t

Re: [PATCH wayland 3/5] server: don't proceed in posting no-memory error on client destruction

2016-05-16 Thread Pekka Paalanen
On Fri, 13 May 2016 15:01:20 +0200 Marek Chalupa wrote: > When a client is being destroyed, the display_resource is set to NULL. > If then some destroy handler calls wl_client_post_no_memory() or > wl_resource_post_no_memory() we crash. > > Signed-off-by: Marek Chalupa > --- > src/wayland-serv

Re: [PATCH wayland 1/5] display-test: move a misplaced comment

2016-05-16 Thread Pekka Paalanen
On Fri, 13 May 2016 15:01:18 +0200 Marek Chalupa wrote: > we split a function while refactoring in c643781 and now > the comment makes no sense > > Signed-off-by: Marek Chalupa > --- > tests/display-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/disp

Re: [PATCH wayland 2/5] server: set map entry to NULL after resource is destroyed

2016-05-16 Thread Pekka Paalanen
On Fri, 13 May 2016 15:01:19 +0200 Marek Chalupa wrote: > We did it only for client entries for some reason, so when > we used wl_client_get_object() for some server object that > has been destroyed, we got dangling pointer. > > NOTE: this is basically an API change, since it changes > the retur