[PATCH wayland-protocols v2 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

The reason for using wl_surface before was that xdg_popup and xdg_surface (now xdg_toplevel) had no common interface other than wl_surface, but since xdg_surface is now the base interface, lets use that. Signed-off-by: Jonas Ådahl Reviewed-by: Mike Blumenkrantz --- unstable/xdg-shell/xdg-shell-

[PATCH wayland-protocols v2 1/7] xdg-shell: Turn xdg_surface into a generic base interface

Split out toplevel window like requests and events into a new interface called xdg_toplevel, and turn xdg_surface into a generic base interface which others extends. xdg_popup is changed to extend the xdg_surface. The configure event in xdg_surface was split up making xdg_surface.configure an eve

[PATCH wayland-protocols v2 7/7] xdg-shell: Introduce xdg_positioner

xdg_positioner is a method for declarative positioning of child surfaces (currently only xdg_popup surfaces). A client creates a description of a positioning logic using the xdg_positioner interface. The xdg_positioner object is then used when creating a xdg_popup for describing how the child surfa

[PATCH wayland-protocols v2 4/7] xdg-shell: Improve error enum formatting some

The long lines stood out, break them by putting the summary on its own line. Signed-off-by: Jonas Ådahl Reviewed-by: Yong Bakos Reviewed-by: Mike Blumenkrantz --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/unsta

[PATCH wayland-protocols v2 3/7] xdg-shell: Add error codes for invalid surface state

Signed-off-by: Jonas Ådahl Reviewed-by: Mike Blumenkrantz --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml index 2a30af5..0d31ca5 100644 --- a/unstab

[PATCH wayland-protocols v2 2/7] xdg-shell: Put xdg_shell events after requests

It makes the structure consistent with most other protocols and provides a clear separation between what is done by the server and what is done by the client. Signed-off-by: Jonas Ådahl Reviewed-by: Yong Bakos Reviewed-by: Mike Blumenkrantz --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 74

[PATCH wayland-protocols v2 6/7] xdg-shell: Make xdg_popup non-grabbing by default

Turn xdg_popup into plain temporary child surfaces without any grabbing or mapping order requirements by default. In order to create grabbing popup chains, a new request 'grab' is introduced which enables more or less the same semantics and requirements as xdg_popup previously had related to grabb

[PATCH wayland-protocols 1/4] tablet: add v2 of the tablet protocol

This is a straightforward copy/paste with a _v1 -> _v2 rename. No functional changes otherwise. Signed-off-by: Peter Hutterer --- Makefile.am| 1 + unstable/tablet/tablet-unstable-v2.xml | 641 + 2 files changed, 642 insertions(+) cr

[PATCH v3 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

From: Carlos Garnacho The pad's interface is similar to the tool interface, a client is notified of the pad after the tablet_added event. The pad has three functionalities: buttons, rings and strips. Buttons are fairly straightforward, rings and strips are separate interfaces with a pointer-axis

[PATCH wayland-protocols 2/4] tablet: change all degree values from int to wl_fixed

Signed-off-by: Peter Hutterer --- unstable/tablet/tablet-unstable-v2.xml | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/unstable/tablet/tablet-unstable-v2.xml b/unstable/tablet/tablet-unstable-v2.xml index 81e9835..e7b8626 100644 --- a/unstable/tablet/

[PATCH wayland-protocols 0/4] tablet: switch to v2, add tablet pad

The switch to v2 is needed primarily for the ABI break when we go from ints to fixed for any rotational values. Patch 3/4 restricts the role a surface can play when assigned as tool cursor, specifically we now only allow a cursor surface to be assigned to one tool rather than shared across multipl

[PATCH wayland-protocols 3/4] tablet: restrict the cursor surface to one per tool

The initial approach was to allow one surface to be re-used between tools, seats and even used together as wl_pointer cursor surface. This has a few drawbacks, most of which are related to managing the surface correctly in the compositor. For example, the same cursor surface could have two differen

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

On Fri, Apr 22, 2016 at 10:05:11AM -0700, Bill Spitzak wrote: > Considering that the compositor is not doing anything about telling the > client whether it is using some keyboard keys, I just don't see the need to > tell it what button pad items it is eating. If this is a problem that needs > solvi

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

On Tue, May 10, 2016 at 03:33:59PM +0300, Pekka Paalanen wrote: > On Fri, 29 Apr 2016 15:40:35 -0700 > Bryce Harrington wrote: > > > The drm backend was copying most everything out of the config object > > already, but now also copy the use_current_mode parameter and the > > config_output functio

Re: [PATCH wayland 1/1] connection: Move wl_interface_equal to util

On Mon, May 09, 2016 at 03:41:14PM +0300, Pekka Paalanen wrote: > On Sun, 8 May 2016 08:44:08 -0500 > Yong Bakos wrote: > > > From: Yong Bakos > > > > Move the wl_interface_equal prototype to the top of wayland-private, where > > it is not buried in the middle of map, connection and closure fu

Re: [PATCH wayland 1/1] doc: Formalize file comment in wayland-client.h, wayland-server.h

On Sun, May 08, 2016 at 02:42:28PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Publican was generating a subtle error during a build: > Error: no ID for constraint linkend: Server-wayland-server-core_8h. > > This was caused by doxygen applying the doc comment at the top of > wayland-server.h

[PATCH weston v4 00/14] compositor-wayland: refactor the configuration API

v4: - reorder patches - more spacing and lines wraping fix. - shorter the patches set - use glue code instead of renaming/refactoring when moving code v3: - rebase to master - heavy patches spliting to help review as suggested by Pekka - spacing and lines wraping - rename functions and var

[PATCH weston v4 13/14] compositor-wayland: rename new_config arg of weston_wayland_backend_config_add_new_output

Rename new_config to config to follow legacy naming scheme. Signed-off-by: Benoit Gschwind --- src/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.c b/src/main.c index 285a10d..d0a962f 100644 --- a/src/main.c +++ b/src/main.c @@ -1104,18 +1104,18

[PATCH weston v4 12/14] compositor-wayland: rename new_config arg of weston_wayland_backend_config_release

Rename new_config to config to follow legacy naming scheme. Signed-off-by: Benoit Gschwind --- src/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.c b/src/main.c index e28a576..285a10d 100644 --- a/src/main.c +++ b/src/main.c @@ -1086,16 +1086,16

[PATCH weston v4 01/14] compositor-wayland: fix spacing and lines wraping

Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index d0d1082..9351687 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -2

[PATCH weston v4 11/14] compositor-wayland: rename out_config arg of load_wayland_backend_config

Rename the out_config arg of load_wayland_backend_config to follow legacy naming convention. Signed-off-by: Benoit Gschwind --- src/main.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/main.c b/src/main.c index e03bde7..e28a5

[PATCH weston v4 08/14] compositor-wayland: replace and remove new_config in load_wayland_backend_config

Remove the unseless intermediate variable new_config in the function load_wayland_backend_config, replacing it by the existing variable out_config. Signed-off-by: Benoit Gschwind --- src/main.c | 44 1 file changed, 20 insertions(+), 24 deletions(-)

[PATCH weston v4 03/14] compositor-wayland: rename wayland_output_init_from_config

Rename wayland_output_init_from_config to weston_wayland_output_config_init to prepare the following patch : "compositor-wayland: move configuration parsing to weston" Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions

[PATCH weston v4 14/14] compositor-wayland: move weston_wayland_backend_config_release call from load_wayland_backend_config to caller

Signed-off-by: Benoit Gschwind --- src/main.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/main.c b/src/main.c index d0a962f..06baae3 100644 --- a/src/main.c +++ b/src/main.c @@ -1170,7 +1170,7 @@ load_wayland_backend_config(struct weston_compositor *compos

[PATCH weston v4 04/14] compositor-wayland: rename misleading output arg of weston_wayland_output_config_init

Rename the misleading output argument to output_config in the weston_wayland_output_config_init function. Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/compositor-waylan

[PATCH weston v4 05/14] compositor-wayland: add versionning to config structure

The patch use temporary code that prepare the patch: "compositor-wayland: move configuration parsing to weston main.c" Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 29 ++--- src/compositor-wayland.h | 3 +++ 2 files changed, 29 insertions(+), 3 deletions

[PATCH weston v4 10/14] compositor-wayland: rename wayland_backend_config_release function

Rename the wayland_backend_config_release function to weston_wayland_backend_config_release to follow legacy naming scheme. Signed-off-by: Benoit Gschwind --- src/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c index 28e7e1d..e03bde7 10064

[PATCH weston v4 07/14] compositor-wayland: rename load_wayland_backend_config arg "config" to wc

Rename the load_wayland_backend_config arg "config" to use this name for another variable in the following patch. It also follow the legacy naming scheme. Signed-off-by: Benoit Gschwind --- src/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main

[PATCH weston v4 06/14] compositor-wayland: move configuration parsing to weston main.c

Move function load_wayland_backend_config, wayland_backend_config_add_new_output, wayland_backend_config_release, wayland_output_config_init from compositor-wayland.c to main.c. Create a glue function load_wayland_backend to use moved functions and following the new load_*_backend style. Signed-o

[PATCH weston v4 09/14] compositor-wayland: rename wayland_backend_config_add_new_output function

Rename wayland_backend_config_add_new_output to weston_wayland_backend_config_add_new_output to follow the legacy naming scheme. Signed-off-by: Benoit Gschwind --- src/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.c b/src/main.c index 231f1b9..28e7e1

[PATCH weston v4 02/14] compositor-wayland: fix too long lines

Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 9351687..4799f90 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -2347,9 +2347,10 @@

Protocol for window previews/thumbnails

I think that it would be a good idea to have a standard, cross-compositor protocol for getting previews/thumbnails of windows, similar to XComposite. This protocol should be as fast as possible and use as little system resources as possible. It should probably provide a handle to the native window

Re: [PATCH weston 1/3] eventdemo: do not print pointer frames alone

On May 10, 2016, at 9:11 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Print pointer frames only if any pointer related events are printed > first. > > This avoids flooding the output with "pointer frame" just because of > motion. > > Signed-off-by: Pekka Paalanen A suggestion rega

Re: [PATCH weston 1/3] eventdemo: do not print pointer frames alone

On May 10, 2016, at 9:11 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Print pointer frames only if any pointer related events are printed > first. > > This avoids flooding the output with "pointer frame" just because of > motion. > > Signed-off-by: Pekka Paalanen Makes sense, even

Re: [PATCH weston] desktop-shell: Don’t reconfigure an already fullscreen surface

On May 9, 2016, at 8:22 PM, Emmanuel Gil Peyrot wrote: > > When we receive an wl_shell_surface::set_fullscreen request for a > surface that was already fullscreen, don’t do anything if the > parameters are the same as the initial request. > > This prevents bogus or malicious clients from being a

Re: [PATCH weston 1/2] compositor: fix comments about weston_compositor::surface_list

On May 10, 2016, at 9:10 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > a7af70436b7dccfacd736626d6719b3e751fd985 converted the surface list into > a view list. > > It looks like weston_surface::output's comment about surface list does > not apply to view list. Still, many places assume

[PATCH weston 3/3] ivi-shell: add API for weston_surface -> ivi_layout_surface

From: Pekka Paalanen Add ivi-layout API for getting an ivi_layout_surface from a weston_surface if it exists. This can be used by controllers that hook up to core Weston callbacks and get handed a weston_surface, but need to use ivi-layout API to manipulate it. The only ways ivi-layout itself wo

[PATCH weston 0/3] misc ivi-shell patches

From: Pekka Paalanen Hi, these patches are a by-product from working on the IVI-surface remoting project. Patch 3 is adding new API, and we are past alpha release in the 1.11 release cycle, so we might want to postpone that one to 1.12. The others should be fine before beta, though. Thanks, pq

[PATCH weston 2/3] ivi-layout: clarify get_layers_under_surface doc

From: Pekka Paalanen This is derived from the implementation. I was not sure whether "under" referred to object relationships or region intersections. Signed-off-by: Pekka Paalanen --- ivi-shell/ivi-layout-export.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ivi-she

[PATCH weston 1/3] ivi-shell-user-interface: ignore all but first seat

From: Pekka Paalanen This client should support binding to multiple seats, but as it does not, make a quick and dirty fix to ignore all seats beyond the first one. Signed-off-by: Pekka Paalanen --- clients/ivi-shell-user-interface.c | 4 1 file changed, 4 insertions(+) diff --git a/clien

[PATCH weston 2/2] compositor: surface and view output comment fixes

From: Pekka Paalanen weston_surface::output and weston_view::output as used for different purposes. Only the surface output is used for frame callbacks. The uses of the view output are much more vague and hard to describe. Also fix a comment mistake in weston_surface_assign_output(). Signed-of

[PATCH weston 1/2] compositor: fix comments about weston_compositor::surface_list

From: Pekka Paalanen a7af70436b7dccfacd736626d6719b3e751fd985 converted the surface list into a view list. It looks like weston_surface::output's comment about surface list does not apply to view list. Still, many places assume weston_surface::output is not NULL when processing "visible" surface

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On May 10, 2016, at 3:19 AM, Pekka Paalanen wrote: > > On Mon, 9 May 2016 07:58:32 -0500 > Yong Bakos wrote: > >> Hi Pekka, >> Two minor nits in the description, noted inline below. >> >> yong >> >> On May 9, 2016, at 6:45 AM, Pekka Paalanen wrote: >>> >>> From: Pekka Paalanen >>> >>> The

[PATCH weston 1/3] eventdemo: do not print pointer frames alone

From: Pekka Paalanen Print pointer frames only if any pointer related events are printed first. This avoids flooding the output with "pointer frame" just because of motion. Signed-off-by: Pekka Paalanen --- clients/eventdemo.c | 26 ++ 1 file changed, 26 insertions(+)

[PATCH weston 3/3] eventdemo: do not print axis events if not requested

From: Pekka Paalanen Signed-off-by: Pekka Paalanen --- clients/eventdemo.c | 9 + 1 file changed, 9 insertions(+) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 38eb904..64b3d01 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -288,6 +288,9 @@ axis_source_han

[PATCH weston 2/3] eventdemo: use zalloc

From: Pekka Paalanen Zero-initialize the struct, just in case. Signed-off-by: Pekka Paalanen --- clients/eventdemo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index f1558d2..38eb904 100644 --- a/clients/eventdemo.c +++ b/clien

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

On Fri, 29 Apr 2016 15:40:35 -0700 Bryce Harrington wrote: > The drm backend was copying most everything out of the config object > already, but now also copy the use_current_mode parameter and the > config_output function pointer, so that there are no remaining > references to the config object

Re: [PATCH weston v7 2/3] drm: port the drm backend to the new init api

On Sat, 30 Apr 2016 11:35:22 +0200 Benoit Gschwind wrote: > Hello Bryce, > > I have some comments after a trivial rebase. > > Le 30/04/2016 00:40, Bryce Harrington a écrit : > > From: Giulio Camuffo > > > > Signed-off-by: Bryce Harrington > > Reviewed-by: Quentin Glidic > > Acked-by: Pekka

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On Tue, 10 May 2016 11:57:00 +0200 Martin Graesslin wrote: > Looks good to me, thanks for addressing this. Hi Martin, I'll record that as a Reviewed-by, then. Thanks, pq > On Monday, May 9, 2016 2:45:05 PM CEST Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The existing specificati

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On Tue, 10 May 2016 17:42:59 +0800 Jonas Ådahl wrote: > On Tue, May 10, 2016 at 11:19:29AM +0300, Pekka Paalanen wrote: > > On Mon, 9 May 2016 07:58:32 -0500 > > Yong Bakos wrote: > > > > > Hi Pekka, > > > Two minor nits in the description, noted inline below. > > > > > > yong > > > > > > O

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

Looks good to me, thanks for addressing this. Cheers, Martin G. On Monday, May 9, 2016 2:45:05 PM CEST Pekka Paalanen wrote: > From: Pekka Paalanen > > The existing specification was not explicitly clear on when > wl_subcompositor.get_subsurface request actually adds the sub-surface to > the pa

Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter

On Fri, 6 May 2016 15:07:19 +0300 Pekka Paalanen wrote: > On Thu, 5 May 2016 15:46:46 -0700 > Bryce Harrington wrote: > > > On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > > > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > > > From: Pekka Paalanen

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On Tue, May 10, 2016 at 11:19:29AM +0300, Pekka Paalanen wrote: > On Mon, 9 May 2016 07:58:32 -0500 > Yong Bakos wrote: > > > Hi Pekka, > > Two minor nits in the description, noted inline below. > > > > yong > > > > On May 9, 2016, at 6:45 AM, Pekka Paalanen wrote: > > > > > > From: Pekka Paa

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On Tue, May 10, 2016 at 11:27:25AM +0300, Pekka Paalanen wrote: > On Tue, 10 May 2016 11:43:04 +0800 > Jonas Ådahl wrote: > > > On Mon, May 09, 2016 at 02:45:05PM +0300, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > The existing specification was not explicitly clear on when > >

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On Tue, 10 May 2016 11:43:04 +0800 Jonas Ådahl wrote: > On Mon, May 09, 2016 at 02:45:05PM +0300, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The existing specification was not explicitly clear on when > > wl_subcompositor.get_subsurface request actually adds the sub-surface to > > t

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On Mon, 09 May 2016 11:48:07 -0500 Derek Foreman wrote: > On 09/05/16 06:45 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > The existing specification was not explicitly clear on when > > wl_subcompositor.get_subsurface request actually adds the sub-surface to > > the parent in the c

Re: [PATCH wayland] protocol: make get_subsurface double-buffered

On Mon, 9 May 2016 07:58:32 -0500 Yong Bakos wrote: > Hi Pekka, > Two minor nits in the description, noted inline below. > > yong > > On May 9, 2016, at 6:45 AM, Pekka Paalanen wrote: > > > > From: Pekka Paalanen > > > > The existing specification was not explicitly clear on when > > wl_sub