Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

Hello Bryce, Ok I can live with this patches ;) Reviewed-by: Benoit Gschwind On 05/05/2016 00:24, Bryce Harrington wrote: > On Sat, Apr 30, 2016 at 11:41:15AM +0200, Benoit Gschwind wrote: >> Hello Bryce, >> >> I think my comments on previous patch apply here, while you did some >> useful updat

Re: [PATCH wayland v2] scanner: Add version argument to wayland-scanner

On Thu, May 05, 2016 at 06:34:54PM -0500, Yong Bakos wrote: > On May 5, 2016, at 10:27 AM, Armin Krezović wrote: > > > > This adds a command line argument to print wayland-scanner version. > > > > It also makes wayland-scanner emit a comment with wayland library > > version to every file it gene

Re: [PATCH wayland v2] scanner: Add version argument to wayland-scanner

On May 5, 2016, at 10:27 AM, Armin Krezović wrote: > > This adds a command line argument to print wayland-scanner version. > > It also makes wayland-scanner emit a comment with wayland library > version to every file it generates. > > v2: separate variable definitions into their own lines and r

Re: [PATCH weston v3 03/17] compositor-wayland: rename wayland_output_init_from_config

On May 5, 2016, at 6:12 PM, Yong Bakos wrote: > > Hi Benoit, > > On May 5, 2016, at 3:45 PM, Benoit Gschwind wrote: >> >> Rename wayland_output_init_from_config to wayland_output_config_init. >> >> Signed-off-by: Benoit Gschwind >> --- >> src/compositor-wayland.c | 4 ++-- >> 1 file changed,

Re: [PATCH weston v3 03/17] compositor-wayland: rename wayland_output_init_from_config

Hi Benoit, On May 5, 2016, at 3:45 PM, Benoit Gschwind wrote: > > Rename wayland_output_init_from_config to wayland_output_config_init. > > Signed-off-by: Benoit Gschwind > --- > src/compositor-wayland.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/composito

Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter

On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Hi, > > > > here is the v3 of the stabilization series, which I hope to the final to be > > merged. > > > > The wayland-protocols

Re: [PATCH weston v2 9/9] wayland-backend: move all parsing functions to weston

Hello Pekka, I submitted a patches set (v3) to address all comments. Best regards. On 04/05/2016 15:41, Pekka Paalanen wrote: > On Thu, 28 Apr 2016 20:33:16 +0200 > Benoit Gschwind wrote: > >> Move all parsing functions from the wayland backend and put >> them into the weston code and add vers

[PATCH weston v3 00/17] compositor-wayland: refactor the configuration API

v3: - rebase to master - heavy patches spliting to help review as suggested by Pekka - fix typo. - rename functions and variables as suggested by Pekka Benoit Gschwind (17): compositor-wayland: fix misc. typo compositor-wayland: add versionning to config structure compositor-wayland: ren

[PATCH weston v3 06/17] compositor-wayland: refactor load_wayland_backend

Rename compositor to c in load_wayland_backend function. Signed-off-by: Benoit Gschwind --- src/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.c b/src/main.c index 92b7ac2..a84bdeb 100644 --- a/src/main.c +++ b/src/main.c @@ -1040,7 +1040,7 @@ wayland

[PATCH weston v3 05/17] compositor-wayland: move configuration parsing to main.c

Move function load_wayland_backend_config, wayland_backend_config_add_new_output, wayland_backend_config_release, wayland_output_config_init from compositor-wayland.c to main.c. Rename load_wayland_backend_config to load_wayland_backend ad update the signature to match other backend load functions

[PATCH weston v3 07/17] compositor-wayland: refactor load_wayland_backend

Rename config to wc in load_wayland_backend function. Signed-off-by: Benoit Gschwind --- src/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c index a84bdeb..2ff8cd7 100644 --- a/src/main.c +++ b/src/main.c @@ -1041,7 +1041,7 @@ wayland_back

[PATCH weston v3 12/17] compositor-wayland: refactor wayland_backend_create

Rename new_config to config in wayland_backend_create function. Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 140b11d..133bd37 100644 --- a/src/comp

[PATCH weston v3 01/17] compositor-wayland: fix misc. typo

Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index d0d1082..83f31de 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -2328,6 +2328,7

[PATCH weston v3 15/17] compositor-wayland: rename wayland_backend_config_release

Rename wayland_backend_config_release to weston_wayland_backend_config_release. Signed-off-by: Benoit Gschwind --- src/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main.c b/src/main.c index 5b8eb80..adaebf7 100644 --- a/src/main.c +++ b/src/main.c @@

[PATCH weston v3 17/17] compositor-wayland: rename wayland_backend_config_add_new_output

Rename wayland_backend_config_add_new_output to weston_wayland_backend_config_add_new_output. Signed-off-by: Benoit Gschwind --- src/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.c b/src/main.c index 55ecc08..2e5c743 100644 --- a/src/main.c +++ b/src

[PATCH weston v3 04/17] compositor-wayland: refactor wayland_output_config_init

Rename the missleading output to output_config. Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 2822a09..53f855d 1006

[PATCH weston v3 13/17] compositor-wayland: refactor backend_init

Rename unused variable config to wc in backend_init function. Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 133bd37..67d20d0 100644 --- a/src/compositor-way

[PATCH weston v3 14/17] compositor-wayland: refactor backend_init

Rename new_config to config in backend_init function. Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 67d20d0..335b70e 100644 --- a/src

[PATCH weston v3 02/17] compositor-wayland: add versionning to config structure

Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 27 --- src/compositor-wayland.h | 3 +++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index 83f31de..b51467d 100644 --- a/src/compositor-w

[PATCH weston v3 16/17] compositor-wayland: rename wayland_output_config_init

Rename wayland_output_config_init to weston_wayland_output_config_init. Signed-off-by: Benoit Gschwind --- src/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index adaebf7..55ecc08 100644 --- a/src/main.c +++ b/src/main.c @@ -957,7 +957,7 @

[PATCH weston v3 09/17] compositor-wayland: refactor wayland_backend_config_add_new_output

Rename new_config to config in wayland_backend_config_add_new_output function. Signed-off-by: Benoit Gschwind --- src/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.c b/src/main.c index 8d42ec5..3d643f1 100644 --- a/src/main.c +++ b/src/main.c @@

[PATCH weston v3 08/17] compositor-wayland: refactor load_wayland_backend

Rename variable new_config to config in load_wayland_backend function. Signed-off-by: Benoit Gschwind --- src/main.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/src/main.c b/src/main.c index 2ff8cd7..8d42ec5 100644

[PATCH weston v3 10/17] compositor-wayland: refactor wayland_backend_config_release

Rename new_config to config in wayland_backend_config_release function. Signed-off-by: Benoit Gschwind --- src/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main.c b/src/main.c index 3d643f1..5b8eb80 100644 --- a/src/main.c +++ b/src/main.c @@ -1010,

[PATCH weston v3 11/17] compositor-wayland: refactor wayland_backend_create

Remove argv, argc and weston_config from wayland_backend_create function. Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index fe8b082..140b11d 100644 --- a/s

[PATCH weston v3 03/17] compositor-wayland: rename wayland_output_init_from_config

Rename wayland_output_init_from_config to wayland_output_config_init. Signed-off-by: Benoit Gschwind --- src/compositor-wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index b51467d..2822a09 100644 --- a/src/co

[PATCH wayland v2] scanner: Add version argument to wayland-scanner

This adds a command line argument to print wayland-scanner version. It also makes wayland-scanner emit a comment with wayland library version to every file it generates. v2: separate variable definitions into their own lines and remove old style "version" argument Reviewed-by: Bryce Harringt