Re: [PATCH weston v3 14/17] compositor: check viewport source rect validity

2016-05-04 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 03:51:06PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > wp_viewporter spec requires protocol errors when the viewport is outside > the buffer area. > > The viewport is checked in wl_surface.commit handler as the error needs > to be delivered as a reply to the c

Re: [PATCH weston v3 13/17] compositor: fix wp_viewport use after free

2016-05-04 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 03:51:05PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > If a client destroyed the wl_surface before the wp_viewport, Weston core > would access freed memory, because the weston_surface pointer stored in > the wp_viewport wl_resource's user data was stale. > > F

Re: [PATCH weston v3 07/17] compositor: refactor into convert_size_by_transform_scale()

2016-05-04 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 03:50:59PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > There were two copies of code applying transform and scale to size. > Refactor the code to use just one copy in a new function. > > Signed-off-by: Pekka Paalanen Nice refactoring. I would probably use e

Re: [PATCH weston v3 06/17] compositor: constify weston_surface_build_buffer_matrix()

2016-05-04 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 03:50:58PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Makes it easier to see that it does not change weston_surface state > implicitly. > > Signed-off-by: Pekka Paalanen Sure, LGTM: Reviewed-by: Bryce Harrington > --- > src/compositor.c | 4 ++-- > 1 fi

Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter

2016-05-04 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Hi, > > here is the v3 of the stabilization series, which I hope to the final to be > merged. > > The wayland-protocols patches are essentially the same as v2, except few > cosmetic changes as suggested b

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-05-04 Thread Bryce Harrington
On Sat, Apr 30, 2016 at 11:41:15AM +0200, Benoit Gschwind wrote: > Hello Bryce, > > I think my comments on previous patch apply here, while you did some > useful update here. This patch essentially takes care of much of what you mentioned in the previous review. Your other suggestions sound like

Re: [ANNOUNCE] wayland 1.10.91

2016-05-04 Thread Bryce Harrington
On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote: > Here's the alpha for the upcoming 1.11 release. I'll summarize the > major features for this release in the beta announcement, but see below > for the detailed listing. > > The schedule going forward is: > > √ 1.11-alpha on Ma

Re: [PATCH wayland] Add version argument to wayland-scanner

2016-05-04 Thread Pekka Paalanen
On Wed, 4 May 2016 18:29:30 +0200 Armin Krezović wrote: > On 02.05.2016 16:14, Pekka Paalanen wrote: > > On Mon, 2 May 2016 12:27:50 +0200 > > Armin Krezović wrote: > > > >> This adds a command line argument to print wayland-scanner version. > >> > >> It also makes wayland-scanner emit a com

Re: [PATCH wayland] Add version argument to wayland-scanner

2016-05-04 Thread Armin Krezović
On 02.05.2016 16:14, Pekka Paalanen wrote: > On Mon, 2 May 2016 12:27:50 +0200 > Armin Krezović wrote: > >> This adds a command line argument to print wayland-scanner version. >> >> It also makes wayland-scanner emit a comment with wayland library >> version to every file it generates. >> >> Sig

Re: Introduction and updates from NVIDIA

2016-05-04 Thread Daniel Stone
Hi, Interleaving both replies ... On 3 May 2016 at 19:44, James Jones wrote: > On 05/03/2016 09:53 AM, Daniel Stone wrote: >> On 3 May 2016 at 17:07, James Jones wrote: >>> No, the necessary extensions can not be contained within the binding. >>> There >>> is not enough information within the dr

Re: [PATCH weston 3/3] clients: Fork clickdot as confine

2016-05-04 Thread Derek Foreman
On 15/03/16 08:14 AM, Jonas Ådahl wrote: > The new confine client will be used to demonstrate pointer confinement. > It is so far identical to clickdot except that it doesn't respond to > clicks. So basically just "dot". :P Doesn't build though - looks like it needs to include xalloc.h I'm not r

Re: [PATCH weston 1/3] input: Activate view no matter the keyboard focus

2016-05-04 Thread Derek Foreman
On 15/03/16 08:14 AM, Jonas Ådahl wrote: > Activate a view even though it effectively may already be active. > Without this, in later patches, it won't be possibe to track what view > was activated by clicking last, as a view which surface already had > keyboard focus, won't be activated. > > To k

Re: [PATCH weston v2 9/9] wayland-backend: move all parsing functions to weston

2016-05-04 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:33:16 +0200 Benoit Gschwind wrote: > Move all parsing functions from the wayland backend and put > them into the weston code and add versionning to configuration > structure. Hi Benoit, the commit message already reveals that this should be at least two separate patches:

Re: [PATCH weston v2 8/9] wayland-backend: put configuration structure in separate header

2016-05-04 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:33:15 +0200 Benoit Gschwind wrote: > Signed-off-by: Benoit Gschwind > --- > Makefile.am | 3 +++ > src/compositor-wayland.c | 20 + > src/compositor-wayland.h | 58 > > 3 files changed, 62 ins

Re: [PATCH weston v2 2/9] wayland-backend: fix memory leak of display_name

2016-05-04 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:33:09 +0200 Benoit Gschwind wrote: > Signed-off-by: Benoit Gschwind > --- > src/compositor-wayland.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c > index 8577a74..0bfd3ad 100644 > --- a/src/compositor-wayl

Re: [PATCH weston v2 7/9] wayland-backend: split init_backend

2016-05-04 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:33:14 +0200 Benoit Gschwind wrote: > Extract configuration parsing from init_backend function. The new > init_backend start by generating the configuration structure from > configuration file with separated function and then use this structure > to load the backend. > > Si

Re: [PATCH weston v2 5/9] wayland-backend: define output configuration structure

2016-05-04 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:33:12 +0200 Benoit Gschwind wrote: > The structure is not used currently, just the definition to be used. > > Signed-off-by: Benoit Gschwind > --- > src/compositor-wayland.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/compositor-wayland.c b/src/

Re: [PATCH weston v2 6/9] wayland-backend: split wayland_output_create_for_config

2016-05-04 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:33:13 +0200 Benoit Gschwind wrote: > The splitting intend to separate configuration parsing from output > setup. > > Signed-off-by: Benoit Gschwind > --- > src/compositor-wayland.c | 96 > ++-- > 1 file changed, 60 insertions(

Re: [PATCH weston v2 0/9] wayland-backend: refactor the configuration API

2016-05-04 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:33:07 +0200 Benoit Gschwind wrote: > I did a patches set that split the previous patch in severals steps. The step > intend to help the review, and may not be logical. The patch is focuced on > keeping the legacy configuration behaviours. > > Benoit Gschwind (9): > wayla

[ANNOUNCE] libinput 1.2.903

2016-05-04 Thread Peter Hutterer
libinput 1.3 rc3 is now available. Only a couple of minor fixes, I expect the next one to be the 1.3 final. Some documentation fixes, Logitech touchpads (which are all external) are now ignored for disable-while-typing. The most obvious fix is a detection of large touchpad finger movement jumps. T

Re: [PATCH libinput 3/3] Add support for relative device rotation (trackball only)

2016-05-04 Thread Peter Hutterer
On Wed, May 04, 2016 at 07:13:43AM +1000, Peter Hutterer wrote: > Trackballs are effectively stationary devices and can be positioned at any > rotation. They are also employed by users with impaired dexterity which > sometimes implies that they are positioned at an non-default angle to make the > b

Re: [PATCH weston] libinput: Remove unused static values

2016-05-04 Thread Jonas Ådahl
On Wed, May 04, 2016 at 10:04:33AM +0100, Daniel Stone wrote: > default_seat and default_seat_name are not used anywhere in this file. > > Signed-off-by: Daniel Stone RB me and pushed: 63225cf..d62004e master -> master Jonas > --- > src/libinput-seat.c | 3 --- > 1 file changed, 3 deleti

Re: [PATCH weston] data: Some client icons

2016-05-04 Thread Daniel Stone
Hi Bryce, On 25 March 2016 at 00:57, Bryce Harrington wrote: > This adds an alternate weston terminal icon and icons for the flower and > editor clients. The original Inkscape SVG file is included. > > Example screenshot: > http://www.bryceharrington.org/Files/weston-icons.png Thanks for thes

Re: [PATCH weston v2] weston.pc: Properly specify Requires.private

2016-05-04 Thread Daniel Stone
Hi, On 6 April 2016 at 13:09, Quentin Glidic wrote: > On 06/04/2016 08:39, Bryce Harrington wrote: >> One thing I wonder is if any of these might need to become a Require >> when we are providing a libweston library API? > > From [1] which references [2], a lot of pkg-config files are doing it wr

[PATCH weston] libinput: Remove unused static values

2016-05-04 Thread Daniel Stone
default_seat and default_seat_name are not used anywhere in this file. Signed-off-by: Daniel Stone --- src/libinput-seat.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/libinput-seat.c b/src/libinput-seat.c index 5b2dbec..5168890 100644 --- a/src/libinput-seat.c +++ b/src/libinput-se

Re: [PATCH weston 2/3] Implement pointer locking and confinement

2016-05-04 Thread Daniel Stone
Hi Jonas, On 15 March 2016 at 13:14, Jonas Ådahl wrote: > This patch implements the wp_pointer_constraints protocol used for > locking or confining a pointer. It consists of a new global object with > two requests; one for locking the surface to a position, one for > confining the pointer to a gi

Re: [PATCH weston 1/3] input: Activate view no matter the keyboard focus

2016-05-04 Thread Daniel Stone
Hi, On 15 March 2016 at 13:14, Jonas Ådahl wrote: > Activate a view even though it effectively may already be active. > Without this, in later patches, it won't be possibe to track what view > was activated by clicking last, as a view which surface already had > keyboard focus, won't be activated

[ANNOUNCE] weston 1.10.91

2016-05-04 Thread Bryce Harrington
Here's the alpha for the upcoming 1.11 release. Below are the full list of changes so far for this release. Changes: Armin Krezović (1): desktop-shell: make panel clock configurable Benoit Gschwind (5): headless: port the headless backend to the new init api c

[ANNOUNCE] wayland 1.10.91

2016-05-04 Thread Bryce Harrington
Here's the alpha for the upcoming 1.11 release. I'll summarize the major features for this release in the beta announcement, but see below for the detailed listing. The schedule going forward is: √ 1.11-alpha on May 3rd. Major features done by this point. - 1.11-beta around May 17th. -