Re: [PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

2016-04-29 Thread Bryce Harrington
On Tue, Apr 26, 2016 at 11:34:03PM +0200, David Fort wrote: > FreeRDP 2.0 is about to be released, this allows to compile against this > version. > The detection is adjusted to prefer FreeRDP 2 against version 1.x. > > Signed-off-by: David Fort Is this just to handle when an old and a new versi

Re: [PATCH wayland 09/10] doc: Hyphenate compound adjectives window-local, surface-local

2016-04-29 Thread Bryce Harrington
On Thu, Apr 28, 2016 at 12:01:33PM -0500, Yong Bakos wrote: > From: Yong Bakos > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos Patches 9 and 10 for wayland R-b'd and pushed: 6fe12f0..4db7602 master -> master > --- > d

Re: [PATCH wayland-protocols 07/10] pointer-constraints: Use 'surface-local' in simplified parameter summary

2016-04-29 Thread Bryce Harrington
On Thu, Apr 28, 2016 at 12:00:45PM -0500, Yong Bakos wrote: > From: Yong Bakos > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos Pushed for wayland-protocols: 5eb2a8d..aaafffe master -> master > --- > unstable/pointer-co

Re: [PATCH weston 02/10] desktop-shell: Use 'surface-local' to correct grammar

2016-04-29 Thread Bryce Harrington
On Thu, Apr 28, 2016 at 11:59:06AM -0500, Yong Bakos wrote: > From: Yong Bakos > > Correct the pluralization by simplifying with 'surface-local'. > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos Patches 2-6 for weston R-b'd

Re: [PATCH wayland-web 01/10] architecture: Hyphenate compound adjective window-local

2016-04-29 Thread Bryce Harrington
On Thu, Apr 28, 2016 at 11:57:52AM -0500, Yong Bakos wrote: > From: Yong Bakos > > See > https://lists.freedesktop.org/archives/wayland-devel/2016-April/028249.html. > > Signed-off-by: Yong Bakos Reviewed-by: Bryce Harrington pushed for wayland-web: 5265778..2883000 master -> master >

Re: [PATCH weston v1] headless-backend: fix leak of transfrom configuration

2016-04-29 Thread Bryce Harrington
On Fri, Apr 29, 2016 at 03:36:49PM +0200, Quentin Glidic wrote: > On 29/04/2016 15:21, Benoit Gschwind wrote: > >Signed-off-by: Benoit Gschwind > >--- > >v1: > > - fix warning for freeing a const > > - fix typo > > > > src/main.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deletions(-)

[PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-04-29 Thread Bryce Harrington
The drm backend was copying most everything out of the config object already, but now also copy the use_current_mode parameter and the config_output function pointer, so that there are no remaining references to the config object passed into backend_init(). By decoupling the config struct to the b

[PATCH weston v7 1/3] x11: port the x11 backend to the new init api

2016-04-29 Thread Bryce Harrington
From: Benoit Gschwind Use a "well" defined structure to configure x11-backend and move configuration file parsing inside the weston compositor code. Enforce destruction of all backend config objects after initialization. Since the backend config struct versioning implies that there we expect pot

[PATCH weston v7 2/3] drm: port the drm backend to the new init api

2016-04-29 Thread Bryce Harrington
From: Giulio Camuffo Signed-off-by: Bryce Harrington Reviewed-by: Quentin Glidic Acked-by: Pekka Paalanen Tested-by: Benoit Gschwind Signed-off-by: Bryce Harrington --- v5: - Update to reflect format rename to gdb_format - Initialize width/height (suggested by pq) - squash drm struct

[PATCH weston v7 0/3] drm and x11 backend configuration

2016-04-29 Thread Bryce Harrington
Yet another stab at the drm and x11 backend config stuff... Benoit Gschwind (1): x11: port the x11 backend to the new init api Bryce Harrington (1): drm: Don't hang onto the backend config object post-backend_init Giulio Camuffo (1): drm: port the drm backend to the new init api Makefile

Re: Introduction and updates from NVIDIA

2016-04-29 Thread Daniel Stone
Hi James, On 29 April 2016 at 22:16, James Jones wrote: > I was on leave when this discussion was started. Now that I'm back, I'd > like to respond to a few points raised below: Welcome back! > On 03/29/2016 09:44 AM, Daniel Stone wrote: >> Right, atomic allows you separate pipe/CRTC configura

Re: [PATCH weston v6 12/12] x11: Initialize all outputs at start

2016-04-29 Thread Bryce Harrington
On Sun, Apr 17, 2016 at 05:35:07PM +0300, Giulio Camuffo wrote: > 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > > We know ahead of time the maximum number of outputs we'll be > > configuring, so just alloc that memory from the get-go, instead of > > realloc'ing for each new output. > > > > Suggest

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

2016-04-29 Thread Bryce Harrington
On Sun, Apr 17, 2016 at 05:10:24PM +0300, Giulio Camuffo wrote: > 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > > From: Benoit Gschwind > > > > Use a "well" defined structure to configure x11-backend and move > > configuration > > file parsing inside the weston compositor code. > > > > Signed-of

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

2016-04-29 Thread Bryce Harrington
On Sun, Apr 17, 2016 at 05:31:32PM +0300, Giulio Camuffo wrote: > Sorry, i keep seeing things after i hit send... > > 2016-04-17 17:10 GMT+03:00 Giulio Camuffo : > > 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > >> +static int > >> +load_x11_backend(struct weston_compositor *c, char const * backe

Re: Introduction and updates from NVIDIA

2016-04-29 Thread James Jones
I was on leave when this discussion was started. Now that I'm back, I'd like to respond to a few points raised below: On 03/29/2016 09:44 AM, Daniel Stone wrote: Hi Andy, On 23 March 2016 at 00:12, Andy Ritger wrote: Thanks for the thorough responses, Daniel. No problem; as I said, I'm ac

Re: Feedback on xdg-shell v5

2016-04-29 Thread Daniel Stone
Hi, On 29 April 2016 at 10:37, Pekka Paalanen wrote: > On Fri, 29 Apr 2016 15:31:28 +0800 > Jonas Ådahl wrote: >> On Thu, Apr 28, 2016 at 02:08:07PM +0300, Pekka Paalanen wrote: >> > On Thu, 28 Apr 2016 17:36:58 +0800 >> > Jonas Ådahl wrote: >> > > Because you don't ping a surface, you ping the

Re: Feedback on xdg-shell v5

2016-04-29 Thread Mike Blumenkrantz
On Fri, Apr 29, 2016 at 4:38 AM Martin Graesslin wrote: > On Thursday, April 28, 2016 5:36:58 PM CEST Jonas Ådahl wrote: > > On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote: > > > Hi Wayland and Plasma, > > > > > > I finished the implementation of xdg-shell in KWayland [1] and KW

Re: [PATCH wayland-protocols v3 5/5] stable/viewporter: add more error cases

2016-04-29 Thread Derek Foreman
On 29/04/16 07:41 AM, Pekka Paalanen wrote: > On Thu, 28 Apr 2016 13:40:47 -0500 Derek Foreman > wrote: > >> On 26/04/16 07:50 AM, Pekka Paalanen wrote: >>> From: Pekka Paalanen >>> >>> Rather than silenty doing things, make them explicit and error >>> if anything is not quite right. Suggested

Re: [PATCH weston v1] headless-backend: fix leak of transfrom configuration

2016-04-29 Thread Quentin Glidic
On 29/04/2016 15:21, Benoit Gschwind wrote: Signed-off-by: Benoit Gschwind --- v1: - fix warning for freeing a const - fix typo src/main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c index f034dda..404e5fc 100644 --- a/src/main.c +++

[PATCH weston v1] rpi-backend: refactor the configuration API

2016-04-29 Thread Benoit Gschwind
Signed-off-by: Benoit Gschwind --- v1: - fix missing file - update Makefile.am Makefile.am | 3 +++ src/compositor-rpi.c | 42 -- src/compositor-rpi.h | 49 + src/main.c | 40 +++

[PATCH weston v1] headless-backend: fix leak of transfrom configuration

2016-04-29 Thread Benoit Gschwind
Signed-off-by: Benoit Gschwind --- v1: - fix warning for freeing a const - fix typo src/main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main.c b/src/main.c index f034dda..404e5fc 100644 --- a/src/main.c +++ b/src/main.c @@ -692,7 +692,7 @@ load_headles

[PATCH] rpi-backend: refactor the configuration API

2016-04-29 Thread Benoit Gschwind
Signed-off-by: Benoit Gschwind --- NOTE: The patch is theorical and wasn't tested on rasbery-pi src/compositor-rpi.c | 42 -- src/main.c | 40 ++-- 2 files changed, 54 insertions(+), 28 deletions(-) diff --gi

Re: [PATCH wayland 4/4] client: Fix wl_display_roundtrip_queue() race condition

2016-04-29 Thread Pekka Paalanen
On Wed, 27 Apr 2016 13:42:14 +0300 Pekka Paalanen wrote: > On Wed, 27 Apr 2016 15:37:41 +0800 > Jonas Ådahl wrote: > > > Without this commit, wl_display_roundtrip_queue() is vulnerable to a > > race condition, causing the callback to be dispatched on the wrong > > queue. > > > > The race condi

Re: [PATCH wayland v4] client: Introduce proxy wrappers

2016-04-29 Thread Pekka Paalanen
On Fri, 29 Apr 2016 19:30:22 +0800 Jonas Ådahl wrote: > Using the libwayland-client client API with multiple threads with > thread local queues are prone to race conditions. > > The problem is that one thread can read and queue events after another > thread creates a proxy but before it sets the

Re: [PATCH wayland-protocols v3 5/5] stable/viewporter: add more error cases

2016-04-29 Thread Pekka Paalanen
On Thu, 28 Apr 2016 13:40:47 -0500 Derek Foreman wrote: > On 26/04/16 07:50 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Rather than silenty doing things, make them explicit and error if > > anything is not quite right. Suggested by Daniel Stone. > > > > Signed-off-by: Pekka Paal

Re: [PATCH wayland* weston 00/10] hyphenate compound adjectives

2016-04-29 Thread Pekka Paalanen
On Thu, 28 Apr 2016 18:22:03 -0700 Bryce Harrington wrote: > On Thu, Apr 28, 2016 at 11:57:51AM -0500, Yong Bakos wrote: > > From: Yong Bakos > > > > The following ten patches: > > > > 1) hyphenate all occurrences of surface local and window local > > 2) remove 'local' from one occurrence of '

Re: [PATCH wayland-protocols v3 1/5] stable: add viewporter draft

2016-04-29 Thread Pekka Paalanen
On Thu, 28 Apr 2016 13:26:33 -0500 Derek Foreman wrote: > On 26/04/16 07:50 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > This XML file has been copied verbatim from Weston 1.10.0 release, > > protocol/scaler.xml. > > > > The interfaces still need renaming according to wayland-pro

[PATCH wayland v4] tests/queue-test: Add tests for proxy wrappers

2016-04-29 Thread Jonas Ådahl
Test that doing wl_display.sync on a wrapped proxy with a special queue works as expected. Test that creating a wrapper on a destroyed but not freed proxy fails. Signed-off-by: Jonas Ådahl Reviewed-by: Pekka Paalanen --- Changes since v3: - Removed test that checked that creating a wrapper f

[PATCH wayland v4] client: Introduce proxy wrappers

2016-04-29 Thread Jonas Ådahl
Using the libwayland-client client API with multiple threads with thread local queues are prone to race conditions. The problem is that one thread can read and queue events after another thread creates a proxy but before it sets the queue. This may result in the event to the proxy being silently

Re: [PATCH weston] compositor-fbdev: make copy of the device string

2016-04-29 Thread Pekka Paalanen
On Thu, 28 Apr 2016 20:03:27 +0200 Benoit Gschwind wrote: > Hello Pekka, > > The patch look good, but leave a leak in backend_init: the param.device > is never freed. That is because it is never malloc'd either, so this patch is fine. > This fixed you get my Reviewed-by ;) Pushed this and the

Re: [PATCH wayland v3] client: Introduce proxy wrappers

2016-04-29 Thread Jonas Ådahl
On Fri, Apr 29, 2016 at 02:08:06PM +0300, Pekka Paalanen wrote: > On Fri, 29 Apr 2016 14:24:32 +0800 > Jonas Ådahl wrote: > > > On Thu, Apr 28, 2016 at 02:28:21PM +0300, Pekka Paalanen wrote: > > > On Thu, 28 Apr 2016 15:31:31 +0800 > > > Jonas Ådahl wrote: > > > > > > > Using the libwayland-

Re: [PATCH wayland v3] client: Introduce proxy wrappers

2016-04-29 Thread Pekka Paalanen
On Fri, 29 Apr 2016 14:24:32 +0800 Jonas Ådahl wrote: > On Thu, Apr 28, 2016 at 02:28:21PM +0300, Pekka Paalanen wrote: > > On Thu, 28 Apr 2016 15:31:31 +0800 > > Jonas Ådahl wrote: > > > > > Using the libwayland-client client API with multiple threads with > > > thread local queues are prone

Re: Feedback on xdg-shell v5

2016-04-29 Thread Pekka Paalanen
On Fri, 29 Apr 2016 15:31:28 +0800 Jonas Ådahl wrote: > On Thu, Apr 28, 2016 at 02:08:07PM +0300, Pekka Paalanen wrote: > > On Thu, 28 Apr 2016 17:36:58 +0800 > > Jonas Ådahl wrote: > > > > > On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote: > > > > Hi Wayland and Plasma, >

Re: Feedback on xdg-shell v5

2016-04-29 Thread Jonas Ådahl
On Fri, Apr 29, 2016 at 10:37:49AM +0200, Martin Graesslin wrote: > On Thursday, April 28, 2016 5:36:58 PM CEST Jonas Ådahl wrote: > > On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote: > > > Hi Wayland and Plasma, > > > > > > I finished the implementation of xdg-shell in KWayland [

Re: Feedback on xdg-shell v5

2016-04-29 Thread Martin Graesslin
On Thursday, April 28, 2016 2:08:07 PM CEST Pekka Paalanen wrote: > > > The biggest problem for me is the request set_window_geometry. I think I > > > mentioned it already before on the wayland list. Basically I have no > > > idea how to implement that in KWin. We have only one geometry for a > > >

Re: Feedback on xdg-shell v5

2016-04-29 Thread Martin Graesslin
On Thursday, April 28, 2016 5:36:58 PM CEST Jonas Ådahl wrote: > On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote: > > Hi Wayland and Plasma, > > > > I finished the implementation of xdg-shell in KWayland [1] and KWin [2]. > > Overall it was more straight forward than I would have

Re: Feedback on xdg-shell v5

2016-04-29 Thread Jonas Ådahl
On Thu, Apr 28, 2016 at 02:08:07PM +0300, Pekka Paalanen wrote: > On Thu, 28 Apr 2016 17:36:58 +0800 > Jonas Ådahl wrote: > > > On Thu, Apr 28, 2016 at 10:36:14AM +0200, Martin Graesslin wrote: > > > Hi Wayland and Plasma, > > > > > > I finished the implementation of xdg-shell in KWayland [1] an

Re: GSOC student (re)introduction

2016-04-29 Thread Pekka Paalanen
On Thu, 28 Apr 2016 04:19:32 +0200 Armin Krezovic wrote: > Hello everyone, > > As you may have seen, I was chosen to participate in GSOC > and work on your project. > > I do need to apologize for not contacting you sooner, but > it was a busy week here (midterms week), so I didn't have > much t