Re: [RFC libinput] Import buttonset interface

2016-04-21 Thread Peter Hutterer
On Fri, Apr 22, 2016 at 12:00:43AM +0530, PrasannaKumar Muralidharan wrote: > From: PrasannaKumar Muralidharan fwiw, it's very frowned upon to take someone else's patch, rebase it and then send it on as your own when it has very little changes. Please keep original authorship while it makes sense

Re: [PATCH weston 4/4] input: Don't try to send axis_source when there are no resources

2016-04-21 Thread Jonas Ådahl
On Thu, Apr 21, 2016 at 03:32:56PM +, Mike Blumenkrantz wrote: > Functionally Reviewed-By: Mike Blumenkrantz but the > commit message is a bit confusing Tweaked the commit message before. Thanks for the reviews, Mike and Carlos. Pushed all four: 3c53094..ed6014a master -> master Jonas

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

2016-04-21 Thread Peter Hutterer
On Thu, Apr 21, 2016 at 05:46:24PM -0700, Jason Gerecke wrote: > On Mon, Apr 18, 2016 at 10:00 PM, Peter Hutterer > wrote: > > From: Carlos Garnacho > > > > The pad's interface is similar to the tool interface, a client is notified > > of > > the pad after the tablet_added event. > > > > The pad

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

2016-04-21 Thread Peter Hutterer
On Thu, Apr 21, 2016 at 11:55:49AM -0700, Bryce Harrington wrote: > On Tue, Apr 19, 2016 at 03:00:38PM +1000, Peter Hutterer wrote: > > From: Carlos Garnacho > > > > The pad's interface is similar to the tool interface, a client is notified > > of > > the pad after the tablet_added event. > > >

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

2016-04-21 Thread Jason Gerecke
On Mon, Apr 18, 2016 at 10:00 PM, Peter Hutterer wrote: > From: Carlos Garnacho > > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons, rings and strips. > Buttons are fairly straight

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

2016-04-21 Thread Peter Hutterer
On Thu, Apr 21, 2016 at 11:02:37AM -0500, Yong Bakos wrote: > On Apr 19, 2016, at 12:00 AM, Peter Hutterer wrote: > > > > From: Carlos Garnacho > > > > The pad's interface is similar to the tool interface, a client is notified > > of > > the pad after the tablet_added event. > > > > The pad h

Re: [PATCH wayland] protocol: Correct grammar and spelling

2016-04-21 Thread Bryce Harrington
On Tue, Apr 05, 2016 at 10:15:53PM -0500, Yong Bakos wrote: > > On Apr 5, 2016, at 8:03 PM, Bryce Harrington wrote: > > > > On Tue, Apr 05, 2016 at 06:24:01PM -0500, Yong Bakos wrote: > >> From: Yong Bakos > >> > >> Fix grammar, spelling, tense, and other inconsistencies, based on > >> correctn

Re: [PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

2016-04-21 Thread Bryce Harrington
On Thu, Apr 14, 2016 at 05:05:56PM +0300, Pekka Paalanen wrote: > On Mon, 11 Apr 2016 17:30:21 -0500 > Yong Bakos wrote: > > > Jason, > > See below, this one patch affects the argument name of the > > zwp_fullscreen_shell_v1#capability event param name. > > > > yong > > > > > > > On Apr 11, 20

Re: [PATCH weston] weston-info: look for the right wp_presentation

2016-04-21 Thread Bryce Harrington
On Tue, Apr 19, 2016 at 04:20:32PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Patch b00c79b587a4903df576008a64a49f851fed234c forgot to update the > global interface name to look for. Fix it. > > This makes weston-info report the presentation clock again. > > Signed-off-by: Pekka Pa

Re: standardizing "surface-local coordinates"

2016-04-21 Thread Bryce Harrington
On Thu, Apr 21, 2016 at 09:17:32AM -0500, Yong Bakos wrote: > > On Apr 19, 2016, at 12:26 PM, Daniel Stone wrote: > > > > On 19 April 2016 at 17:55, Yong Bakos wrote: > >> There was a little discussion recently about standardizing occurrences of > >> "surface local coordinates" to the grammatic

Re: [PATCH weston] man: Clarify weston.ini scale option

2016-04-21 Thread Bryce Harrington
On Thu, Apr 21, 2016 at 02:21:38PM -0500, Yong Bakos wrote: > On Apr 21, 2016, at 2:15 PM, Bryce Harrington wrote: > > > > On Thu, Apr 21, 2016 at 12:49:29PM -0500, Yong Bakos wrote: > >> From: Yong Bakos > >> > >> Add explanations of scaling that are a bit more approachable for users. > >> >

Re: [PATCH weston] man: Clarify weston.ini scale option

2016-04-21 Thread Yong Bakos
On Apr 21, 2016, at 2:15 PM, Bryce Harrington wrote: > > On Thu, Apr 21, 2016 at 12:49:29PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> Add explanations of scaling that are a bit more approachable for users. >> >> https://bugs.freedesktop.org/show_bug.cgi?id=94824 >> >> Signed-off-by:

Re: [PATCH weston] man: Clarify weston.ini scale option

2016-04-21 Thread Bryce Harrington
On Thu, Apr 21, 2016 at 12:49:29PM -0500, Yong Bakos wrote: > From: Yong Bakos > > Add explanations of scaling that are a bit more approachable for users. > > https://bugs.freedesktop.org/show_bug.cgi?id=94824 > > Signed-off-by: Yong Bakos Looks good, Reviewed-by: Bryce Harrington Btw in c

Re: [PATCH weston] build: add check for clock_gettime() in librt

2016-04-21 Thread Bryce Harrington
On Thu, Apr 21, 2016 at 11:18:48AM -0300, Gustavo Zacarias wrote: > zuctest is another clock_gettime() user that fails to link against librt when > necessary. > > Instead of adding another -lrt LDADD entry i've opted for the saner way and > converted the check to a configure test that will set CLO

Re: [PATCH weston] tests: check for NULL surface in keyboard and pointer handlers

2016-04-21 Thread Bryce Harrington
On Thu, Apr 21, 2016 at 05:12:47PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > When a test destroys a wl_surface, it is still possible to get events > referring to the destroyed surface. The surface in such cases will be > NULL. > > Handle NULL surface gracefully in keyboard and poin

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

2016-04-21 Thread Bryce Harrington
On Tue, Apr 19, 2016 at 03:00:38PM +1000, Peter Hutterer wrote: > From: Carlos Garnacho > > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons, rings and strips. > Buttons are fairly

[RFC libinput] Import buttonset interface

2016-04-21 Thread PrasannaKumar Muralidharan
From: PrasannaKumar Muralidharan Import buttonset interface code from https://github.com/whot/libinput/tree/wip/buttonbox-interface. There is no user for buttonset interface as of now. I have taken the buttonset interface code and removed code related to wacom tablet. Please review the changes.

[PATCH weston] man: Clarify weston.ini scale option

2016-04-21 Thread Yong Bakos
From: Yong Bakos Add explanations of scaling that are a bit more approachable for users. https://bugs.freedesktop.org/show_bug.cgi?id=94824 Signed-off-by: Yong Bakos --- man/weston.ini.man | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/man/weston.ini.ma

Re: xdg-shell: about configure, states and ack_configure

2016-04-21 Thread Michael Forney
On Thu, Apr 21, 2016 at 03:57:52AM -0400, Olivier Fourdan wrote: > So, for example, if the compositor sets a state maximized and a size > larger than the client would expect, in theory, the client could > ignore the request, not configure its surface and never send an > ack_configure for that seria

Re: [PATCH weston 3/4] data-device: Update current action even if source version is old

2016-04-21 Thread Carlos Garnacho
Hi!, On Thu, Apr 21, 2016 at 5:09 AM, Jonas Ådahl wrote: > If the version of the source object is old enough to not have > wl_data_source.set_actions() the current action would never be updated > since source->set_actions would never be set. > > To fix this, instead of checking whether source->se

Re: [PATCH v2 wayland-protocols] Add pad support to the tablet protocol

2016-04-21 Thread Yong Bakos
On Apr 19, 2016, at 12:00 AM, Peter Hutterer wrote: > > From: Carlos Garnacho > > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons, rings and strips. > Buttons are fairly straigh

Re: [PATCH weston 3/4] data-device: Update current action even if source version is old

2016-04-21 Thread Mike Blumenkrantz
On Wed, Apr 20, 2016 at 11:11 PM Jonas Ådahl wrote: > If the version of the source object is old enough to not have > wl_data_source.set_actions() the current action would never be updated > since source->set_actions would never be set. > > To fix this, instead of checking whether source->set_act

Re: [PATCH weston 4/4] input: Don't try to send axis_source when there are no resources

2016-04-21 Thread Mike Blumenkrantz
Functionally Reviewed-By: Mike Blumenkrantz but the commit message is a bit confusing On Wed, Apr 20, 2016 at 11:11 PM Jonas Ådahl wrote: > We miss to NULL check the focus_client, which is only non-NULL when > there the focused client has any resources. > > https://bugs.freedesktop.org/show_bug

Re: [PATCH weston 2/4] desktop-shell: Get rid of some unused fields

2016-04-21 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz On Wed, Apr 20, 2016 at 11:11 PM Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > desktop-shell/shell.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c > index f705c99..cd269a8 100644 > --- a/des

Re: [PATCH weston 1/4] desktop-shell: Unset the shell surface owner when it goes away

2016-04-21 Thread Mike Blumenkrantz
Reviewed-By: Mike Blumenkrantz On Wed, Apr 20, 2016 at 11:11 PM Jonas Ådahl wrote: > On client destruction, the shell object may be destroyed before the > shell surface objects. If this happens to two surfaces of the same > client, and one surface being destroyed results in the focus being > sw

[PATCH weston] build: add check for clock_gettime() in librt

2016-04-21 Thread Gustavo Zacarias
zuctest is another clock_gettime() user that fails to link against librt when necessary. Instead of adding another -lrt LDADD entry i've opted for the saner way and converted the check to a configure test that will set CLOCK_GETTIME_LIBS appropiately and replaced all instances of -lrt with it. Bui

Re: standardizing "surface-local coordinates"

2016-04-21 Thread Yong Bakos
> On Apr 19, 2016, at 12:26 PM, Daniel Stone wrote: > > On 19 April 2016 at 17:55, Yong Bakos wrote: >> There was a little discussion recently about standardizing occurrences of >> "surface local coordinates" to the grammatically correct "surface-local >> coordinates." (It's a compound adjecti

[PATCH weston] tests: check for NULL surface in keyboard and pointer handlers

2016-04-21 Thread Pekka Paalanen
From: Pekka Paalanen When a test destroys a wl_surface, it is still possible to get events referring to the destroyed surface. The surface in such cases will be NULL. Handle NULL surface gracefully in keyboard and pointer enter/leave handlers. Touch-down handler is already NULL-safe. This fixes

Re: xdg-shell: about configure, states and ack_configure

2016-04-21 Thread Olivier Fourdan
- Original Message - > On Thu, 21 Apr 2016 03:57:52 -0400 (EDT) > Olivier Fourdan wrote: > > > Hi all, > > > > Following the discussion around the min/max size addition to > > xdg-shell v6, I would like to get one point about configure events > > clarified, if possible. > > > > First,

Re: xdg-shell: about configure, states and ack_configure

2016-04-21 Thread Pekka Paalanen
On Thu, 21 Apr 2016 03:57:52 -0400 (EDT) Olivier Fourdan wrote: > Hi all, > > Following the discussion around the min/max size addition to > xdg-shell v6, I would like to get one point about configure events > clarified, if possible. > > First, a quick reminder of what the spec currently says:

xdg-shell: about configure, states and ack_configure

2016-04-21 Thread Olivier Fourdan
Hi all, Following the discussion around the min/max size addition to xdg-shell v6, I would like to get one point about configure events clarified, if possible. First, a quick reminder of what the spec currently says: 1. configure: The configure event asks the client to resize its surface

Re: [PATCH libinput] touchpad: exclude Logitech touchpads from disable-while-typing

2016-04-21 Thread Hans de Goede
Hi, On 21-04-16 08:06, Peter Hutterer wrote: Logitech does not sell internal touchpads, the closest ones are the TK820 and the K400 series devices. Neither of which need DWT, the touchpad is next to the keyboard. Signed-off-by: Peter Hutterer Patch looks good to me: Reviewed-by: Hans de Goe