2016-04-16 1:02 GMT+03:00 Bryce Harrington :
> On Fri, Apr 15, 2016 at 02:32:04PM +0200, Benoit Gschwind wrote:
>> > + /** The seat to be used by the output. Set to NULL to use the
>> > +* default seat. */
>> > + char *seat;
>> > + /** The modeline to be used by the output. Refer to the d
On Fri, Apr 15, 2016 at 03:17:15PM +0200, Benoit Gschwind wrote:
> Hello Bryce,
>
> The patches set was tested above [1]
>
> I tested drm-bakcend and x11-backend successfully with the full patchset.
>
> Here are the resume of my comments and review. I send separate e-mail
> when contextual comme
On Wed, Apr 13, 2016 at 05:21:39PM +0300, Pekka Paalanen wrote:
> On Wed, 13 Apr 2016 03:25:04 -0700
> Bryce Harrington wrote:
>
> > In following up on my earlier update of Giulio's drm backend config
> > patch, I've taken the liberty to try and also integrate a couple of
> > Benoit's other backe
Signed-off-by: Bryce Harrington
---
src/compositor-drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compositor-drm.c b/src/compositor-drm.c
index 119b6c5..a47b453 100644
--- a/src/compositor-drm.c
+++ b/src/compositor-drm.c
@@ -1551,7 +1551,7 @@ create_gbm_device(int
Signed-off-by: Bryce Harrington
---
src/compositor-drm.c | 93
src/compositor-drm.h | 41 ---
src/main.c | 43
3 files changed, 80 insertions(+), 97 deletions(-)
diff --git a/src/composito
From: Giulio Camuffo
Signed-off-by: Bryce Harrington
Reviewed-by: Quentin Glidic
Acked-by: Pekka Paalanen
Tested-by: Benoit Gschwind
v6:
- Fix gcc warning about missing braces. Use double-brackets for config
initializer for create_output_for_connector to avoid gcc warning,
since f
The drm backend was copying most everything out of the config object
already, but now also copy the use_current_mode parameter and the
config_output function pointer, so that there are no remaining
references to the config object passed into backend_init().
By decoupling the config struct to the b
This reverts commit 5ffbfffaf7758c33791978516d0a1100773b85e2.
Restore load_backend_new() for use with libweston backend configuration.
Signed-off-by: Bryce Harrington
Reviewed-by: Pekka Paalanen
---
src/main.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/main.c b/
Signed-off-by: Bryce Harrington
---
src/compositor.h | 8
1 file changed, 8 deletions(-)
diff --git a/src/compositor.h b/src/compositor.h
index 0ba00be..5ca497c 100644
--- a/src/compositor.h
+++ b/src/compositor.h
@@ -691,14 +691,6 @@ struct weston_backend_config {
struct weston_backen
In following up on my earlier update of Giulio's drm backend config
patch, I've taken the liberty to try and also integrate Benoit's
other backend configuration patches into this patchset, and reconcile
them for stylistic and design consistency. This includes adding a
versioning capability for the
Signed-off-by: Bryce Harrington
---
src/compositor-drm.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/src/compositor-drm.c b/src/compositor-drm.c
index d129adc..a896785 100644
--- a/src/compositor-drm.c
+++ b/src/compositor-drm.c
@@ -93,13 +93,13 @
Since the backend config struct versioning implies that there we expect
potential future descrepancy between main's definition of the config
object and the backend's, don't allow the backend to hang onto the
config object outside the initialization scope.
Signed-off-by: Bryce Harrington
Reviewed-
We know ahead of time the maximum number of outputs we'll be
configuring, so just alloc that memory from the get-go, instead of
realloc'ing for each new output.
Suggested-by: Pekka Paalanen
Signed-off-by: Bryce Harrington
---
src/main.c | 37 -
1 file changed
From: Benoit Gschwind
Use a "well" defined structure to configure x11-backend and move configuration
file parsing inside the weston compositor code.
Signed-off-by: Bryce Harrington
v6:
- Define version number in the header
- Don't use initial underscores in header guards
- Add stub confi
From: Benoit Gschwind
refactor configuration API of headless-backend
Signed-off-by: Bryce Harrington
Reviewed-by: Pekka Paalanen
v6:
- Define version number in the header
- Don't use leading underscores in header guards
- Add stub config_init_to_defaults()
- Allocate config on stack
With this struct versioning, it is possible to add new options without
breaking the ABI, as long as all additions are made to the end of a
struct and nothing existing is modified or removed. When things are
added, the structure's size will increase, and we'll use this size as
our minor version num
On Fri, Apr 15, 2016 at 03:46:43AM -0400, Olivier Fourdan wrote:
>
> Hi,
>
> - Original Message -
> > On Thu, Apr 14, 2016 at 1:56 AM, Jonas Ådahl wrote:
> >
> > >
> > > This makes it sound like the compositor will have to obay the limits.
> > > Did we end up with requiring that a corre
On Fri, Apr 15, 2016 at 02:32:04PM +0200, Benoit Gschwind wrote:
> > + /** The seat to be used by the output. Set to NULL to use the
> > +* default seat. */
> > + char *seat;
> > + /** The modeline to be used by the output. Refer to the documentation
> > +* of WESTON_DRM_BACKEND_OUTPU
On Fri, Apr 15, 2016 at 12:01:01PM +0300, Pekka Paalanen wrote:
> On Thu, 14 Apr 2016 19:09:34 +0300
> Giulio Camuffo wrote:
>
> > 2016-04-13 14:30 GMT+03:00 Pekka Paalanen :
> > > On Tue, 12 Apr 2016 21:34:28 -0700
> > > Bryce Harrington wrote:
> > >
> > >> On Wed, Apr 06, 2016 at 11:37:57AM
On Fri, Apr 15, 2016 at 12:01:01PM +0300, Pekka Paalanen wrote:
> On Thu, 14 Apr 2016 19:09:34 +0300
> Giulio Camuffo wrote:
>
> > 2016-04-13 14:30 GMT+03:00 Pekka Paalanen :
> > > On Tue, 12 Apr 2016 21:34:28 -0700
> > > Bryce Harrington wrote:
> > >
> > >> On Wed, Apr 06, 2016 at 11:37:57AM
On Fri, Apr 15, 2016 at 03:17:15PM +0200, Benoit Gschwind wrote:
> Hello Bryce,
>
> The patches set was tested above [1]
>
> I tested drm-bakcend and x11-backend successfully with the full patchset.
>
> Here are the resume of my comments and review. I send separate e-mail
> when contextual comme
On Fri, Apr 15, 2016 at 02:32:04PM +0200, Benoit Gschwind wrote:
> Hello Bryce and Giulio,
>
> Thanks for your contribution :), here is my comments.
>
> Le 13/04/2016 12:25, Bryce Harrington a écrit :
> > From: Giulio Camuffo
> >
> > Signed-off-by: Bryce Harrington
> > Reviewed-by: Quentin Gli
On Fri, Apr 15, 2016 at 11:55:57AM +0300, Pekka Paalanen wrote:
> On Thu, 14 Apr 2016 11:10:57 -0700
> Bryce Harrington wrote:
>
> > On Thu, Apr 14, 2016 at 03:16:07PM +0300, Pekka Paalanen wrote:
> > > On Sat, 13 Feb 2016 23:56:38 +0100
> > > Benoit Gschwind wrote:
> > >
> > > > Hello Bryce,
On Thu, Apr 14, 2016 at 05:48:12PM -0500, Yong Bakos wrote:
> From: Yong Bakos
>
> Building on Ubuntu 15.10 x64 fails due to missing packages:
> libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgcrypt20-dev,
> x11proto-scrnsaver-dev, libxfont-dev, and libedit-dev.
>
> After these changes, wl
- Fixed the rebase error, some typos and formatting as suggested by Yong.
- I did not notice that the file is mixing tabs and spaces, so I fixed
that as well.
- Split the event into orientation and shape as suggested by Peter.
On Fri, Apr 15, 2016 at 8:01 AM, Dennis Kempin wrote:
> This CL update
This CL updates the wl_touch interface with a shape and
orientation event.
The shape/orientation of a touch point is not relevant for most UI
applications, but allows a better experience in some cases
such as drawing apps.
The events are used by the compositor to inform the client
about changes in
From: Pekka Paalanen
The stable version of the scaling and cropping extension is found in
wayland-protocols as viewporter.xml.
Remove scaler.xml as nothing uses it.
Signed-off-by: Pekka Paalanen
---
Makefile.am | 5 --
protocol/scaler.xml | 208 --
From: Pekka Paalanen
Use wp_viewporter instead of wl_scaler and rename things as appropriate.
Signed-off-by: Pekka Paalanen
---
Makefile.am | 4 ++--
clients/simple-damage.c | 32
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/Mak
From: Pekka Paalanen
Use wp_viewporter instead of wl_scaler and rename things accordingly.
Since interface versions were reset, there is no need to check the
interface version anymore, and the wl_scaler.set request disappeared.
Signed-off-by: Pekka Paalanen
---
Makefile.am | 4
cli
From: Pekka Paalanen
Since the interface is now called wp_viewport, rename functions from
"scaler" to "viewporter" as well.
scaler_surface_to_buffer() is renamed to viewport_surface_to_buffer()
because it is more about viewport than viewporter.
Signed-off-by: Pekka Paalanen
---
src/compositor
From: Pekka Paalanen
This XML file has been copied verbatim from Weston 1.10.0 release,
protocol/scaler.xml.
The interfaces still need renaming according to wayland-protocols
policy. Also a redundant request needs to be removed. These will be done
in a follow-up patch to clearly show the changes
From: Pekka Paalanen
Rename interfaces and the protocol to follow the policy.
Reset interface versions.
Remove the redundant wp_viewport.set request.
Replace "surface coordinates" with "surface local coordinates".
Hook up to build and install.
Signed-off-by: Pekka Paalanen
---
Makefile.am
From: Pekka Paalanen
Hi,
it's a high time we declare the scaling and cropping extension as stable. I
took wl_scaler from Weston, renamed it to wp_viewporter, and removed the
redundant wp_viewport.set request.
There must be a wayland-protocols release, before the Weston patches can be
landed, an
From: Pekka Paalanen
Migrate from wl_scaler to wp_viewporter extension. The viewporter.xml
file is provided by wayland-protocols.
This stops Weston from advertising wl_scaler, and advertises
wp_viewporter instead.
Signed-off-by: Pekka Paalanen
---
Makefile.am | 4 ++--
configure.ac
On Fri, 15 Apr 2016 14:32:04 +0200
Benoit Gschwind wrote:
> Hello Bryce and Giulio,
>
> Thanks for your contribution :), here is my comments.
>
> Le 13/04/2016 12:25, Bryce Harrington a écrit :
> > From: Giulio Camuffo
> >
> > Signed-off-by: Bryce Harrington
> > Reviewed-by: Quentin Glidic
Hello Bryce,
The patches set was tested above [1]
I tested drm-bakcend and x11-backend successfully with the full patchset.
Here are the resume of my comments and review. I send separate e-mail
when contextual comments are required.
PATCH 01/11:
Do what is expected.
Reviewed-by: Benoit Gschwi
Hello Bryce and Giulio,
Thanks for your contribution :), here is my comments.
Le 13/04/2016 12:25, Bryce Harrington a écrit :
> From: Giulio Camuffo
>
> Signed-off-by: Bryce Harrington
> Reviewed-by: Quentin Glidic
> Acked-by: Pekka Paalanen
>
> ---
> v5:
> - Update to reflect format renam
Hi!,
On Mon, Apr 11, 2016 at 5:15 AM, Peter Hutterer
wrote:
>
> Second version of the tablet pad support patches. The main change is
> switching from button codes to simple button numbers. This is motivated
> by the fact that most buttons don't have any actual meaning and the only
> reason we hav
Hey!,
On Mon, Apr 11, 2016 at 5:15 AM, Peter Hutterer
wrote:
> Signed-off-by: Peter Hutterer
> ---
> Changes since v1:
> - new in this version
>
> src/evdev-tablet.c | 38 +-
> src/evdev.c| 52
> sr
On Apr 14, 2016, at 8:54 PM, Jonas Ådahl wrote:
>
> On Thu, Apr 14, 2016 at 07:04:25PM -0500, Yong Bakos wrote:
>> On Apr 14, 2016, at 3:23 PM, Dennis Kempin wrote:
>>>
>>> This CL updates the wl_touch interface with a shape and
>>> orientation event.
>>> The shape/orientation of a touch point
On Thu, Apr 14, 2016 at 09:33:38AM -0500, Yong Bakos wrote:
> On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote:
> >
> > xdg_positioner is a method for declarative positioning of child surfaces
> > (currently only xdg_popup surfaces). A client creates a description of a
> > positioning logic using t
On Thu, 14 Apr 2016 19:09:34 +0300
Giulio Camuffo wrote:
> 2016-04-13 14:30 GMT+03:00 Pekka Paalanen :
> > On Tue, 12 Apr 2016 21:34:28 -0700
> > Bryce Harrington wrote:
> >
> >> On Wed, Apr 06, 2016 at 11:37:57AM +0300, Pekka Paalanen wrote:
> >> > On Wed, 9 Mar 2016 16:49:29 -0800
> >> >
On Thu, 14 Apr 2016 11:10:57 -0700
Bryce Harrington wrote:
> On Thu, Apr 14, 2016 at 03:16:07PM +0300, Pekka Paalanen wrote:
> > On Sat, 13 Feb 2016 23:56:38 +0100
> > Benoit Gschwind wrote:
> >
> > > Hello Bryce,
> > >
> > > It seems the corner case '-f42xxx 2938475' doesn't work as expecte
Hi,
- Original Message -
> On Thu, Apr 14, 2016 at 1:56 AM, Jonas Ådahl wrote:
>
> >
> > This makes it sound like the compositor will have to obay the limits.
> > Did we end up with requiring that a correctly working compositor never
> > tries to configure a size that is not within the
44 matches
Mail list logo
