Re: [PATCH libinput 4/4] evdev: always defuzz absolute touchscreens

2016-04-14 Thread Jonas Ådahl
On Fri, Apr 15, 2016 at 03:38:46PM +1000, Peter Hutterer wrote: > If a touchscreen has a fuzz value use it for motion hysteresis similar to how > we do it for a touchpad. This stops pointer wobbles as seen in > https://bugs.freedesktop.org/show_bug.cgi?id=94918 > > It's up to the system to overrid

Re: [PATCH libinput 1/4] evdev: move the hysteresis code to a more generic location

2016-04-14 Thread Jonas Ådahl
On Fri, Apr 15, 2016 at 03:38:43PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/evdev-mt-touchpad.c | 12 ++-- > src/evdev.h | 13 + > 2 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/src/evdev-mt-touchpad.c b/src/evde

[PATCH libinput 4/4] evdev: always defuzz absolute touchscreens

2016-04-14 Thread Peter Hutterer
If a touchscreen has a fuzz value use it for motion hysteresis similar to how we do it for a touchpad. This stops pointer wobbles as seen in https://bugs.freedesktop.org/show_bug.cgi?id=94918 It's up to the system to override or set the kernel's fuzz value correctly, i.e. a udev hwdb entry is requ

[PATCH libinput 1/4] evdev: move the hysteresis code to a more generic location

2016-04-14 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 12 ++-- src/evdev.h | 13 + 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index cf5fffe..48edb80 100644 --- a/src/evdev-mt-touchpad.c ++

[PATCH libinput 2/4] evdev: rename slot to slot_idx

2016-04-14 Thread Peter Hutterer
No functional changes Signed-off-by: Peter Hutterer --- src/evdev.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index e44dfd1..d9d2302 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -346,7 +346,7 @@ static void evdev_fl

[PATCH libinput 3/4] evdev: use a slot variable instead of dereferencing everywhere

2016-04-14 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d9d2302..4f69cb1 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -353,8 +353,11 @@ evdev_flush_pending_event(struct evdev_device *devi

Re: [PATCH v3] protocol: Extend wl_touch with touchpoint shape event

2016-04-14 Thread Jonas Ådahl
On Thu, Apr 14, 2016 at 07:04:25PM -0500, Yong Bakos wrote: > On Apr 14, 2016, at 3:23 PM, Dennis Kempin wrote: > > > > This CL updates the wl_touch interface with a shape and > > orientation event. > > The shape/orientation of a touch point is not relevant for most UI > > applications, but allow

Re: [PATCH v2 libinput 2/5] Add the LIBINPUT_DEVICE_CAP_TABLET_PAD capability and matching interface

2016-04-14 Thread Peter Hutterer
On Thu, Apr 14, 2016 at 03:33:38PM -0700, Jason Gerecke wrote: > On 04/10/2016 09:15 PM, Peter Hutterer wrote: > > This interface handles the buttons on the physical tablet itself, including > > the touch ring and the strip. > > > > A notable difference to other libinput interfaces here is that we

Re: [PATCH v3] protocol: Extend wl_touch with touchpoint shape event

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:23 PM, Dennis Kempin wrote: > > This CL updates the wl_touch interface with a shape and > orientation event. > The shape/orientation of a touch point is not relevant for most UI > applications, but allows a better experience in some cases > such as drawing apps. > > The eve

[PATCH wayland-build-tools] wl_install_deps: Add missing dependencies

2016-04-14 Thread Yong Bakos
From: Yong Bakos Building on Ubuntu 15.10 x64 fails due to missing packages: libtool, libxml2-dev, libpng-dev, libglib2.0-dev, libgcrypt20-dev, x11proto-scrnsaver-dev, libxfont-dev, and libedit-dev. After these changes, wl_build succeeds on Ubuntu 15.10 x64. Signed-off-by: Yong Bakos --- wl_i

Re: [PATCH v2 libinput 0/5] Add tablet pad support

2016-04-14 Thread Jason Gerecke
On 04/10/2016 09:15 PM, Peter Hutterer wrote: > > Second version of the tablet pad support patches. The main change is > switching from button codes to simple button numbers. This is motivated > by the fact that most buttons don't have any actual meaning and the only > reason we have something oth

Re: [PATCH v2 libinput 2/5] Add the LIBINPUT_DEVICE_CAP_TABLET_PAD capability and matching interface

2016-04-14 Thread Jason Gerecke
On 04/10/2016 09:15 PM, Peter Hutterer wrote: > This interface handles the buttons on the physical tablet itself, including > the touch ring and the strip. > > A notable difference to other libinput interfaces here is that we do not use > linux/input.h event codes for buttons. Instead, the buttons

Re: [PATCH v2 libinput 4/5] pad: implement wacom pad support

2016-04-14 Thread Jason Gerecke
On 04/10/2016 09:15 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Adjustments for the new API in 2/5 > > src/Makefile.am| 1 + > src/evdev-tablet-pad.c | 614 > + > src/evdev-tablet-pad.h | 69 ++ > src/evdev.c

[PATCH v3] protocol: Extend wl_touch with touchpoint shape event

2016-04-14 Thread Dennis Kempin
This CL updates the wl_touch interface with a shape and orientation event. The shape/orientation of a touch point is not relevant for most UI applications, but allows a better experience in some cases such as drawing apps. The events are used by the compositor to inform the client about changes in

Re: [PATCH weston v5 07/11] headless: port the headless backend to the new init api

2016-04-14 Thread Bryce Harrington
On Thu, Apr 14, 2016 at 04:53:39PM +0300, Pekka Paalanen wrote: > On Wed, 13 Apr 2016 03:25:11 -0700 > Bryce Harrington wrote: > > > refactor configuration API of headless-backend > > > > Signed-off-by: Bryce Harrington > > Hi Bryce, > > did you write this from scratch, or did you start from

Re: [PATCH] option-parser: Handle short double-arg options

2016-04-14 Thread Bryce Harrington
On Thu, Apr 14, 2016 at 03:16:07PM +0300, Pekka Paalanen wrote: > On Sat, 13 Feb 2016 23:56:38 +0100 > Benoit Gschwind wrote: > > > Hello Bryce, > > > > It seems the corner case '-f42xxx 2938475' doesn't work as expected with > > 'f' short option as integer: > > > > 1. one dash then call short

Re: [PATCH weston v5 08/11] drm: Code and comments reformatting for consistency with other backend configs

2016-04-14 Thread Giulio Camuffo
2016-04-13 16:17 GMT+03:00 Pekka Paalanen : > On Wed, 13 Apr 2016 03:25:12 -0700 > Bryce Harrington wrote: > >> Signed-off-by: Bryce Harrington >> --- >> src/compositor-drm.c | 10 ++ >> src/compositor-drm.h | 43 --- >> src/main.c | 6 +

Re: [PATCH 2/5] drm: port the drm backend to the new init api

2016-04-14 Thread Giulio Camuffo
2016-04-13 14:30 GMT+03:00 Pekka Paalanen : > On Tue, 12 Apr 2016 21:34:28 -0700 > Bryce Harrington wrote: > >> On Wed, Apr 06, 2016 at 11:37:57AM +0300, Pekka Paalanen wrote: >> > On Wed, 9 Mar 2016 16:49:29 -0800 >> > Bryce Harrington wrote: >> > >> > > From: Giulio Camuffo >> > > >> > > Sign

Re: [PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 9:05 AM, Pekka Paalanen wrote: > > On Mon, 11 Apr 2016 17:30:21 -0500 > Yong Bakos wrote: > >> Jason, >> See below, this one patch affects the argument name of the >> zwp_fullscreen_shell_v1#capability event param name. >> >> yong >> >> >>> On Apr 11, 2016, at 5:23 PM, Yo

Re: [PATCH wayland-protocols 4/7] xdg-shell: Improve error enum formatting some

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > The long lines stood out, break them by putting the summary on its own > line. > > Signed-off-by: Jonas Ådahl Looks good to me. Reviewed-by: Yong Bakos yong > --- > unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 > 1 file

Re: [PATCH wayland-protocols 7/7] xdg-shell: Introduce xdg_positioner

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > xdg_positioner is a method for declarative positioning of child surfaces > (currently only xdg_popup surfaces). A client creates a description of a > positioning logic using the xdg_positioner interface. The xdg_positioner > object is then used

Re: [PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

2016-04-14 Thread Pekka Paalanen
On Mon, 11 Apr 2016 17:30:21 -0500 Yong Bakos wrote: > Jason, > See below, this one patch affects the argument name of the > zwp_fullscreen_shell_v1#capability event param name. > > yong > > > > On Apr 11, 2016, at 5:23 PM, Yong Bakos wrote: > > > > From: Yong Bakos > > > > Signed-off-by:

Re: [PATCH wayland-protocols 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > Turn xdg_popup into plain temporary child surfaces without any grabbing > or mapping order requirements by default. > > In order to create grabbing popup chains, a new request 'grab' is > introduced which enables more or less the same semantics

Re: [PATCH weston v5 07/11] headless: port the headless backend to the new init api

2016-04-14 Thread Pekka Paalanen
On Wed, 13 Apr 2016 03:25:11 -0700 Bryce Harrington wrote: > refactor configuration API of headless-backend > > Signed-off-by: Bryce Harrington Hi Bryce, did you write this from scratch, or did you start from Benoit's patch? Just asking, since I see Benoit posting v0 and v1 for headless, but

Re: [PATCH wayland-protocols 2/7] xdg-shell: Put xdg_shell events after requests

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > It makes the structure consistent with most other protocols and > provides a clear separation between what is done by the server and what > is done by the client. > > Signed-off-by: Jonas Ådahl Looks good to me. Reviewed-by: Yong Bakos >

Re: [PATCH wayland-protocols 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-04-14 Thread Yong Bakos
On Apr 14, 2016, at 3:28 AM, Jonas Ådahl wrote: > > Split out toplevel window like requests and events into a new interface > called xdg_toplevel, and turn xdg_surface into a generic base interface > which others extends. > > xdg_popup is changed to extend the xdg_surface. > > The configure eve

Re: [PATCH] option-parser: Handle short double-arg options

2016-04-14 Thread Pekka Paalanen
On Sat, 13 Feb 2016 23:56:38 +0100 Benoit Gschwind wrote: > Hello Bryce, > > It seems the corner case '-f42xxx 2938475' doesn't work as expected with > 'f' short option as integer: > > 1. one dash then call short_option > 2. in short_option will check arg[2] and call handle_option > 3. in hand

Re: [PATCH weston v2] Makefile: Fix compilation error when git commit message has quotes

2016-04-14 Thread Pekka Paalanen
On Thu, 14 Apr 2016 11:25:47 + "Chokshi, Mitul" wrote: > Do we really need the git commit message (subject) in version string? > What if we use commit hash instead? That will be a simple solution of > replacing %s with %H i.e. git --git-dir=$(top_srcdir)/.git log -1 > --format='%H (%ci)' I s

Re: [PATCH weston v5 06/11] x11: port the x11 backend to the new init api

2016-04-14 Thread Pekka Paalanen
On Wed, 13 Apr 2016 03:25:10 -0700 Bryce Harrington wrote: > From: Benoit Gschwind > > Use a "well" defined structure to configure x11-backend and move configuration > file parsing inside the weston compositor code. > > Signed-off-by: Bryce Harrington > > --- > v5: > - Update to current tr

RE: [PATCH weston v2] Makefile: Fix compilation error when git commit message has quotes

2016-04-14 Thread Chokshi, Mitul
Do we really need the git commit message (subject) in version string? What if we use commit hash instead? That will be a simple solution of replacing %s with %H i.e. git --git-dir=$(top_srcdir)/.git log -1 --format='%H (%ci)' Regards, Mitul -Original Message- From: Pekka Paalanen [mail

Re: [PATCH libinput] touchpad: add LIBINPUT_MODEL_WOBBLY_TOUCHPAD for the HP 14-ac157tu

2016-04-14 Thread Hans de Goede
Hi, On 14-04-16 01:41, Peter Hutterer wrote: If some elantech touchpads require a hysteresis, let's use some more generic tag for those touchpads that require correct handling of pointer wobbles. https://bugs.freedesktop.org/show_bug.cgi?id=94897 Signed-off-by: Peter Hutterer Looks good to

Re: [PATCH libinput] touchpad: enlarge top button area by a factor 3 instead of 1.5

2016-04-14 Thread Hans de Goede
Hi, On 14-04-16 02:43, Peter Hutterer wrote: From: Peter Frühberger When the touchpad is disabled, the top software button on the Lenovo T440 series touchpads currently enlarge by a factor of 1.5 (to 15mm). This is not enough, a user has to rotate the wrist quite uncomfortable when using the l

Re: [PATCH 4/5] compositor: Version the backend configuration structures

2016-04-14 Thread Pekka Paalanen
On Wed, 13 Apr 2016 11:38:37 -0700 Bryce Harrington wrote: > On Wed, Apr 13, 2016 at 02:47:06PM +0300, Pekka Paalanen wrote: > > On Tue, 12 Apr 2016 21:44:10 -0700 > > Bryce Harrington wrote: > > > > > On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote: > > > > On Mon, 21 Mar 20

Re: [PATCH v6 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-14 Thread Jonas Ådahl
On Wed, Apr 13, 2016 at 08:15:57PM +0200, Olivier Fourdan wrote: > Some application may wish to restrict their window in size, but > xdg-shell has no mechanism for the client to specify a maximum or > minimum size. > > As a result, the compositor may try to maximize or fullscreen a window > while

Re: [PATCH wayland-protocols 0/7] xdg-shell: Tooltips revisited and xdg_positioner

2016-04-14 Thread Jonas Ådahl
On Thu, Apr 14, 2016 at 04:28:11PM +0800, Jonas Ådahl wrote: > Hi, > > This is the continuation of the previous patch series meaning to split up > xdg_surface into different per-role interfaces, while making it possible to > map > more types of surfaces. It enables using xdg_shell to create toolt

Re: [PATCH wayland-protocols 1/4] stable/presentation-time: swap two paragraphs in 'presented'

2016-04-14 Thread Pekka Paalanen
On Wed, 13 Apr 2016 15:09:12 -0700 Bryce Harrington wrote: > On Wed, Apr 13, 2016 at 11:11:54AM +0300, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Associates better with the surrounding paragraphs by not jumping topics > > back and forth. > > > > Suggested-by: Bill Spitzak > > Sign

[PATCH wayland-protocols 5/7] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

2016-04-14 Thread Jonas Ådahl
The reason for using wl_surface before was that xdg_popup and xdg_surface (now xdg_toplevel) had no common interface other than wl_surface, but since xdg_surface is now the base interface, lets use that. Signed-off-by: Jonas Ådahl --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 +- 1 file c

[PATCH wayland-protocols 7/7] xdg-shell: Introduce xdg_positioner

2016-04-14 Thread Jonas Ådahl
xdg_positioner is a method for declarative positioning of child surfaces (currently only xdg_popup surfaces). A client creates a description of a positioning logic using the xdg_positioner interface. The xdg_positioner object is then used when creating a xdg_popup for describing how the child surfa

[PATCH wayland-protocols 4/7] xdg-shell: Improve error enum formatting some

2016-04-14 Thread Jonas Ådahl
The long lines stood out, break them by putting the summary on its own line. Signed-off-by: Jonas Ådahl --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-s

[PATCH wayland-protocols 3/7] xdg-shell: Add error codes for invalid surface state

2016-04-14 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml index f8875e8..2a3cf66 100644 --- a/unstable/xdg-shell/xdg-shell-unstable-

[PATCH wayland-protocols 2/7] xdg-shell: Put xdg_shell events after requests

2016-04-14 Thread Jonas Ådahl
It makes the structure consistent with most other protocols and provides a clear separation between what is done by the server and what is done by the client. Signed-off-by: Jonas Ådahl --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 16 1 file changed, 8 insertions(+), 8 del

[PATCH wayland-protocols 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-04-14 Thread Jonas Ådahl
Split out toplevel window like requests and events into a new interface called xdg_toplevel, and turn xdg_surface into a generic base interface which others extends. xdg_popup is changed to extend the xdg_surface. The configure event in xdg_surface was split up making xdg_surface.configure an eve

[PATCH wayland-protocols 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-04-14 Thread Jonas Ådahl
Turn xdg_popup into plain temporary child surfaces without any grabbing or mapping order requirements by default. In order to create grabbing popup chains, a new request 'grab' is introduced which enables more or less the same semantics and requirements as xdg_popup previously had related to grabb

[PATCH wayland-protocols 0/7] xdg-shell: Tooltips revisited and xdg_positioner

2016-04-14 Thread Jonas Ådahl
Hi, This is the continuation of the previous patch series meaning to split up xdg_surface into different per-role interfaces, while making it possible to map more types of surfaces. It enables using xdg_shell to create tooltips and other non-grabbing popups, as well as introduces a declarative sys