Re: Introduction and updates from NVIDIA

2016-03-22 Thread Andy Ritger
On Tue, Mar 22, 2016 at 09:52:21PM +, Daniel Stone wrote: > Hi, > > On 22 March 2016 at 21:43, Daniel Vetter wrote: > > On Tue, Mar 22, 2016 at 01:49:59PM +, Daniel Stone wrote: [...] > >> I think it's been good to have this series to push the discussion > >> further in more concrete term

Re: Introduction and updates from NVIDIA

2016-03-22 Thread Andy Ritger
Thanks for the thorough responses, Daniel. On Tue, Mar 22, 2016 at 01:49:59PM +, Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:28, Miguel Angel Vico wrote: > > First of all, I'd like to introduce myself to the Wayland community: My > > name is Miguel A. Vico, and I've been work

Re: [PATCH 7/7] compositor-drm: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 11:20:47 + Daniel Stone wrote: > Hi, > > On 21 March 2016 at 16:41, Miguel A. Vico > wrote: > > As previously stated, EGLDevice and EGLOutput will provide means > > to access native device objects and different portions of display > > control hardware respect

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Miguel Angel Vico
Hi, On Tue, 22 Mar 2016 09:30:51 + Daniel Stone wrote: > Hi, > > On 22 March 2016 at 08:50, Daniel Vetter wrote: > > On Tue, Mar 22, 2016 at 08:47:12AM +, Daniel Stone wrote: > >> This is odd. Instant queries failing is fine, but in which > >> circumstances can you fail to return a v

Re: [PATCH 4/7] gl-renderer: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 10:53:38 + Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico > wrote: > > EGLDevice provides means to enumerate native devices, and then > > create an EGL display connection from them. > > > > Similarly, EGLOutput will provide mea

Re: [PATCH 2/7] gl-renderer: Refactor gl_renderer_output_window_create()

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 09:02:55 + Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico > wrote: > > + egl_surface = gl_renderer_create_window_surface(gr, > > + > > window_for_legacy, > > + > > window_for_platform, > > + > > config_attribs, > > +

Re: [PATCH 1/7] gl-renderer: Renaming of things and minor improvements

2016-03-22 Thread Miguel Angel Vico
Hi Daniel, On Tue, 22 Mar 2016 09:06:25 + Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico > wrote: > > In preparation for follow-on changes to support frame presentation > > through EGLDevice+EGLOutput, this change includes the following: > > -Rename gl_ren

Re: Introduction and updates from NVIDIA

2016-03-22 Thread Daniel Stone
Hi, On 22 March 2016 at 21:43, Daniel Vetter wrote: > On Tue, Mar 22, 2016 at 01:49:59PM +, Daniel Stone wrote: >> 'We don't know when to schedule decompression, because there's no >> explicit barrier' - completely untrue. eglSwapBuffers is that barrier. >> For example, in Freescale i.MX6, th

Re: Introduction and updates from NVIDIA

2016-03-22 Thread Daniel Vetter
On Tue, Mar 22, 2016 at 01:49:59PM +, Daniel Stone wrote: > On 21 March 2016 at 16:28, Miguel Angel Vico wrote: > I'd like to look at the elephant in the room, which is why you're > using this in the first place (aside from general NVIDIA enthusiasm > for encapsulating everything within EGL St

Re: [PATCH 4/7] gl-renderer: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Giulio Camuffo
2016-03-21 18:37 GMT+02:00 Miguel A. Vico : > static void > +gl_renderer_attach_egl_fd_texture(struct weston_surface *es, > + struct weston_buffer *buffer, > + EGLNativeFileDescriptorKHR streamFd) > +{ > + struct weston_compo

[PATCH weston v6] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
This patch is a further step in the wl_fixed_t internal sanitization. It changes the notify_* functions to take doubles instead of wl_fixed_t but does not change how these are stored in the various input structs yet, except for weston_pointer_axis_event. However this already allows to remove all wl

Re: [PATCH weston v5] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Pekka Paalanen
On Tue, 22 Mar 2016 16:53:14 +0200 Giulio Camuffo wrote: > This patch is a further step in the wl_fixed_t internal sanitization. > It changes the notify_* functions to take doubles instead of wl_fixed_t > but does not change how these are stored in the various input structs > yet, except for west

[PATCH weston 4/5] ivi-shell: harden get_ivi_shell_surface()

2016-03-22 Thread Pekka Paalanen
From: Pekka Paalanen Add more sanity checks to get_ivi_shell_surface() just in case. If the configure hook is set, we must always have non-NULL configure_private. Check the ivi_shell_surface matches the surface. Signed-off-by: Pekka Paalanen --- ivi-shell/ivi-shell.c | 12 +--- 1 fil

[PATCH weston v5] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
This patch is a further step in the wl_fixed_t internal sanitization. It changes the notify_* functions to take doubles instead of wl_fixed_t but does not change how these are stored in the various input structs yet, except for weston_pointer_axis_event. However this already allows to remove all wl

[PATCH weston 3/5] ivi-shell: add sanity check in ivi_shell_surface_configure

2016-03-22 Thread Pekka Paalanen
From: Pekka Paalanen This should not get called unless there is an ivi_shell_surface. Signed-off-by: Pekka Paalanen --- ivi-shell/ivi-shell.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ivi-shell/ivi-shell.c b/ivi-shell/ivi-shell.c index 9c11f6f..d136f46 100644 ---

[PATCH weston 5/5] ivi-shell: forward zero size to controller

2016-03-22 Thread Pekka Paalanen
From: Pekka Paalanen When surface size changes to zero, do not ignore it, but forward that change to the controller. A controller should do what's proper for a surface that just lost its content. Signed-off-by: Pekka Paalanen --- ivi-shell/hmi-controller.c | 2 ++ ivi-shell/ivi-shell.c |

[PATCH weston 2/5] ivi-shell: add input panel label func

2016-03-22 Thread Pekka Paalanen
From: Pekka Paalanen Copied from desktop-shell/input-panel.c, add a label function for the input panel. This patch strictly reduces the difference between input-panel.c and input-panel-ivi.c. Signed-off-by: Pekka Paalanen --- ivi-shell/input-panel-ivi.c | 8 1 file changed, 8 inserti

[PATCH weston 1/5] ivi-shell: add shell surface labels

2016-03-22 Thread Pekka Paalanen
From: Pekka Paalanen To be used by the Weston timeline feature for identifying surfaces in a trace. The 'get_label' functionality can also be used by any debugging code, too. Signed-off-by: Pekka Paalanen --- ivi-shell/ivi-shell.c | 16 1 file changed, 16 insertions(+) diff -

[PATCH weston 0/5] simple ivi-shell fortification

2016-03-22 Thread Pekka Paalanen
From: Pekka Paalanen Hi, I have written these simple patches as a side-product, and I'm proposing to merge them upstream. They are mostly just adding sanity checks, except the last one that is a possible behavioral change. I'm not sure what the proper response in hmi-controller would be in patc

Re: Introduction and updates from NVIDIA

2016-03-22 Thread Daniel Stone
Hi Miguel, On 21 March 2016 at 16:28, Miguel Angel Vico wrote: > First of all, I'd like to introduce myself to the Wayland community: My > name is Miguel A. Vico, and I've been working as a Software Engineer > for NVIDIA for some time now, more specifically, in the Linux drivers > team. Although

Re: Introduction and updates from NVIDIA

2016-03-22 Thread Nicole Fontenot
Hello Miguel, I cannot comment on if these patches are within scope of wayland but, I think now is the perfect time to consider API extensions. It would be great if someone with an Nvidia card has time to run performance tests when you submit your patches. A proper decision to include the patches

Re: [PATCH weston v3] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
2016-03-22 14:32 GMT+02:00 Pekka Paalanen : > On Mon, 21 Mar 2016 13:29:00 +0200 > Giulio Camuffo wrote: > >> This patch is a further step in the wl_fixed_t internal sanitization. >> It changes the notify_* functions to take doubles instead of wl_fixed_t >> but does not change how these are stored

Re: [PATCH weston v3] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Pekka Paalanen
On Mon, 21 Mar 2016 13:29:00 +0200 Giulio Camuffo wrote: > This patch is a further step in the wl_fixed_t internal sanitization. > It changes the notify_* functions to take doubles instead of wl_fixed_t > but does not change how these are stored in the various input structs > yet, except for west

Re: [PATCH 6/7] compositor-drm: Renaming of things

2016-03-22 Thread Pekka Paalanen
On Tue, 22 Mar 2016 08:49:11 + Daniel Stone wrote: > Hi, > > On 21 March 2016 at 16:41, Miguel A. Vico wrote: > > In preparation for follow-on changes to support frame presentation > > through EGLDevice+EGLOutput, this change includes the following: > > - Rename drm_backend::format to g

Re: [PATCH 3/7] gl-renderer: Implement & use check_extension

2016-03-22 Thread Pekka Paalanen
On Tue, 22 Mar 2016 08:42:41 + Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico wrote: > > Using strstr(3) for checking for extensions is an error-prone mechanism > > as extension names can be prefixes of other extension names (see > > https://www.opengl.org/re

Re: [PATCH 7/7] compositor-drm: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Daniel Stone
Hi, On 21 March 2016 at 16:41, Miguel A. Vico wrote: > As previously stated, EGLDevice and EGLOutput will provide means > to access native device objects and different portions of display > control hardware respectively. > > Whenever EGL_EXT_device_drm extension is present, EGLDevice can > be use

[PATCH weston v4] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
This patch is a further step in the wl_fixed_t internal sanitization. It changes the notify_* functions to take doubles instead of wl_fixed_t but does not change how these are stored in the various input structs yet, except for weston_pointer_axis_event. However this already allows to remove all wl

Re: [PATCH weston v3] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
2016-03-22 11:47 GMT+02:00 Daniel Stone : > Hey Giulio, > > On 21 March 2016 at 11:29, Giulio Camuffo wrote: >> @@ -1275,11 +1275,15 @@ input_set_cursor(struct wayland_input *input) >> static void >> input_handle_pointer_enter(void *data, struct wl_pointer *pointer, >>

Re: [PATCH 4/7] gl-renderer: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Daniel Stone
Hi Miguel, On 21 March 2016 at 16:37, Miguel A. Vico wrote: > EGLDevice provides means to enumerate native devices, and then create > an EGL display connection from them. > > Similarly, EGLOutput will provide means to access different > portions of display control hardware associated with an EGLD

Re: [PATCH weston v3] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Daniel Stone
Hey Giulio, On 21 March 2016 at 11:29, Giulio Camuffo wrote: > @@ -1275,11 +1275,15 @@ input_set_cursor(struct wayland_input *input) > static void > input_handle_pointer_enter(void *data, struct wl_pointer *pointer, >uint32_t serial, struct wl_surface *surface, > -

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Daniel Stone
Hi, On 22 March 2016 at 08:50, Daniel Vetter wrote: > On Tue, Mar 22, 2016 at 08:47:12AM +, Daniel Stone wrote: >> This is odd. Instant queries failing is fine, but in which >> circumstances can you fail to return a valid timestamp in a pageflip >> event ... ? I don't know of any other kernel

Re: [PATCH 1/7] gl-renderer: Renaming of things and minor improvements

2016-03-22 Thread Daniel Stone
Hi Miguel, On 21 March 2016 at 16:37, Miguel A. Vico wrote: > In preparation for follow-on changes to support frame presentation > through EGLDevice+EGLOutput, this change includes the following: > -Rename gl_renderer_output_create to gl_renderer_output_window_create > -Add argument to gl_re

Re: [PATCH 2/7] gl-renderer: Refactor gl_renderer_output_window_create()

2016-03-22 Thread Daniel Stone
Hi Miguel, On 21 March 2016 at 16:37, Miguel A. Vico wrote: > + egl_surface = gl_renderer_create_window_surface(gr, > + window_for_legacy, > + window_for_platform, > +

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Daniel Vetter
On Tue, Mar 22, 2016 at 08:47:12AM +, Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico wrote: > > Instant query for vblank timestamp may always fail, resulting in > > never scheduling a full repaint in drm_output_start_repaint_loop(). > > > > Additionally, timest

Re: [PATCH 6/7] compositor-drm: Renaming of things

2016-03-22 Thread Daniel Stone
Hi, On 21 March 2016 at 16:41, Miguel A. Vico wrote: > In preparation for follow-on changes to support frame presentation > through EGLDevice+EGLOutput, this change includes the following: > - Rename drm_backend::format to gbm_format > - Rename drm_output::formatto gbm_format > - Rena

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Daniel Stone
Hi Miguel, On 21 March 2016 at 16:37, Miguel A. Vico wrote: > Instant query for vblank timestamp may always fail, resulting in > never scheduling a full repaint in drm_output_start_repaint_loop(). > > Additionally, timestamp provided in page_flip_handler() may also be > invalid. > > [...] > > @@

Re: [PATCH 3/7] gl-renderer: Implement & use check_extension

2016-03-22 Thread Daniel Stone
Hi Miguel, On 21 March 2016 at 16:37, Miguel A. Vico wrote: > Using strstr(3) for checking for extensions is an error-prone mechanism > as extension names can be prefixes of other extension names (see > https://www.opengl.org/registry/doc/rules.html#using). > > This change implements the check_ex

Re: [PATCH 7/7] compositor-drm: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Daniel Vetter
On Mon, Mar 21, 2016 at 05:41:32PM +0100, Miguel A. Vico wrote: > As previously stated, EGLDevice and EGLOutput will provide means > to access native device objects and different portions of display > control hardware respectively. > > Whenever EGL_EXT_device_drm extension is present, EGLDevice ca

Re: Questions about experimental Spice compositor rebase

2016-03-22 Thread Yury Shvedov
Hi, Fabio. Unfortunately, I haven't time for this at all. On 03/21/2016 12:59 AM, Fabio Fantoni wrote: I unfortunately had short time also this weekend. I tried to search a more efficient way to limit fps send to spice (instead of adding another buffer like xspice) and probably I found someth