Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Yury Shvedov
On 03/03/2016 09:08 PM, Fabio Fantoni wrote: 2016-03-03 20:17 GMT+01:00 Юрий Шведов >: Ok, I understood why did you do so, and now I see, where did you take the code. The reason, why I change that is to remove unnecessary macro parce_name, which can

Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Fabio Fantoni
2016-03-03 20:17 GMT+01:00 Юрий Шведов : > Ok, I understood why did you do so, and now I see, where did you take the > code. > > The reason, why I change that is to remove unnecessary macro parce_name, > which can be replaced by inline function, and merge two functions to one > with the same funct

Re: [PATCH weston GSoC v2] desktop-shell: make panel clock configurable

2016-03-03 Thread Bryce Harrington
On Thu, Mar 03, 2016 at 03:48:03PM +0100, Armin Krezović wrote: > This patch enhances the panel clock by adding a config file > option which can be used to either disable the clock or make > it also show seconds in the current clock format. > > v2: Implement suggestions from Pekka's review. > > B

Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Юрий Шведов
Ok, I understood why did you do so, and now I see, where did you take the code. The reason, why I change that is to remove unnecessary macro parce_name, which can be replaced by inline function, and merge two functions to one with the same functionality and code reduce. But my mistake isthet I f

Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Fabio Fantoni
2016-03-03 18:57 GMT+01:00 Yury Shvedov : > I cherry-picked your commits to my repo > with some > modifications. Take a look if you want =). > I saw your change, compression option I think should be image compression or similar because

Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Yury Shvedov
I cherry-picked your commits to my repo with some modifications. Take a look if you want =). On 03/03/2016 05:23 PM, Fabio Fantoni wrote: Il 03/03/2016 17:03, Yury Shvedov ha scritto: On 03/03/2016 04:40 PM, Fabio Fantoni wrote:

Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Fabio Fantoni
Il 03/03/2016 17:03, Yury Shvedov ha scritto: On 03/03/2016 04:40 PM, Fabio Fantoni wrote: host and port parameter are working, added also in documentation Perfect! Thank you! It is not a problemfor me, I do it quickly. Ok, it is up to you. I did very fast some small commits: https://githu

Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Yury Shvedov
On 03/03/2016 04:40 PM, Fabio Fantoni wrote: host and port parameter are working, added also in documentation Perfect! Thank you! It is not a problemfor me, I do it quickly. Ok, it is up to you. I did very fast some small commits: https://github.com/Fantu/compositor-spice/commits/rebase/spi

Re: Questions about experimental Spice compositor rebase

2016-03-03 Thread Fabio Fantoni
Il 01/03/2016 17:16, Yury Shvedov ha scritto: On 03/01/2016 04:56 PM, Fabio Fantoni wrote: Il 29/02/2016 21:51, Yury Shvedov ha scritto: Hi, Fabio! I managed to compile and run compositor-spice with the latest weston master branch. See last commit

Re: GSOC 2016

2016-03-03 Thread Pekka Paalanen
On Thu, 3 Mar 2016 15:55:51 +0100 Armin Krezović wrote: > On 03.03.2016 05:30, Jonas Ådahl wrote: > > On Thu, Mar 03, 2016 at 04:56:23AM +0100, Armin Krezović wrote: > >> Hello everyone, > > > > Hi! > > > > Hi Jonas, thanks for your quick reply. > > >> > >> My name is Armin Krezović, a

Re: GSOC 2016

2016-03-03 Thread Armin Krezović
On 03.03.2016 05:30, Jonas Ådahl wrote: > On Thu, Mar 03, 2016 at 04:56:23AM +0100, Armin Krezović wrote: >> Hello everyone, > > Hi! > Hi Jonas, thanks for your quick reply. >> >> My name is Armin Krezović, a 3rd year student from Bosnia and Herzegovina >> studying >> at Faculty of Electrical

Re: [PATCH GSoC] desktop-shell: enhance weston-desktop-shell panel's clock

2016-03-03 Thread Armin Krezović
On 03.03.2016 11:25, Pekka Paalanen wrote: > Hi Armin, > Hi, > this is a good first step, and the patch applies cleanly. I added a > comment in bugzilla that you will be working on this. A detailed review > follows inline. I may be more nitpicky than usual, because I take this > as a teaching se

[PATCH weston GSoC v2] desktop-shell: make panel clock configurable

2016-03-03 Thread Armin Krezović
This patch enhances the panel clock by adding a config file option which can be used to either disable the clock or make it also show seconds in the current clock format. v2: Implement suggestions from Pekka's review. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57583 Signed-off-by: Arm

RE: [PATCH weston 00/14] IVI Layout API Cleanup

2016-03-03 Thread Ucan, Emre (ADITG/SW1)
Hello Bryce, I will check this out and send a new patch set. Thank you. Best regards Emre Ucan Software Group I (ADITG/SW1) Tel. +49 5121 49 6937 -Original Message- From: Bryce Harrington [mailto:br...@osg.samsung.com] Sent: Mittwoch, 2. März 2016 20:42 To: Ucan, Emre (ADITG/SW1) Cc:

[PATCH weston] hmi-controller: fix leak of ivi surface list

2016-03-03 Thread Wataru Natsume
From: Wataru Natsume get_surfaces_on_layer() allocates memory and stores the pointer to 'ivisurfs'. But it was not freed. Signed-off-by: Wataru Natsume --- ivi-shell/hmi-controller.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ivi-shell/hmi-controller.c b/ivi-sh

[PATCH weston] remove warning of ivisurface reassign on the ivilayer

2016-03-03 Thread Wataru Natsume
From: Wataru Natsume The warning of ivisurface reassign can be removed. Current ivi_layout_layer_add_surface() removes the ivisurface from its previous ivilayer and returns sucess. Signed-off-by: Wataru Natsume --- ivi-shell/ivi-layout.c |8 +++- 1 file changed, 7 insertions(+), 1 de

Re: [PATCH GSoC] desktop-shell: enhance weston-desktop-shell panel's clock

2016-03-03 Thread Pekka Paalanen
Hi Armin, this is a good first step, and the patch applies cleanly. I added a comment in bugzilla that you will be working on this. A detailed review follows inline. I may be more nitpicky than usual, because I take this as a teaching session. :-) IMHO the perfect subject line would be: "[PATCH w

Re: [PATCH wayland] client: ensure thread safety for wl_display_roundtrip_queue()

2016-03-03 Thread Pekka Paalanen
On Wed, 2 Mar 2016 11:01:12 -0800 Bill Spitzak wrote: > On Wed, Mar 2, 2016 at 4:25 AM, Pekka Paalanen wrote: > > > > > > bar_obj = wl_bar_new(); > > > wl_proxy_set_queue((wl_proxy *)bar_obj, queue); > > > wl_bar_add_listener(bar_obj, ...); > > > /* whatever else to init bar_obj */ > > > wl_b