Re: Plan for libweston backend configuration?

2016-02-26 Thread Benoit Gschwind
Hello Bryce, Thanks for the summarization, I have few comment that I share here. Le 26/02/2016 22:37, Bryce Harrington a écrit : > To followup Pekka's recent libweston thread, here's the next actions it > looks like we should take? > >a. Revert 5ffbfffa >b. Land https://patchwork.freed

Plan for libweston backend configuration?

2016-02-26 Thread Bryce Harrington
To followup Pekka's recent libweston thread, here's the next actions it looks like we should take? a. Revert 5ffbfffa b. Land https://patchwork.freedesktop.org/patch/67547/, which covers the drm-backend. (Is this patch proposal good as is, or would it benefit from any additi

Re: [PATCH weston 00/14] IVI Layout API Cleanup

2016-02-26 Thread Bryce Harrington
On Fri, Feb 26, 2016 at 03:57:56PM +, Ucan, Emre (ADITG/SW1) wrote: > I removed the get APIs, because the same information can be get from > ivi_layout_get_properties_of_surface/layer APIs. Therefore, these APIs > are redundant. Looks like a good cleanup, but do we have any concerns about API

[PATCH weston 07/14] ivi-shell: remove ivi_layout_surface_get_dimension API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h|9 - ivi-shell/ivi-layout-private.h |3 --- ivi-shell/ivi-layout.c | 16 ivi-shell/ivi-shell.c|7 ++- tests/ivi_layout-internal-test.c |7 --- tests/ivi_layout

[PATCH weston 10/14] ivi-shell: remove ivi_layout_layer_get_orientation API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h| 10 -- ivi-shell/ivi-layout.c | 12 tests/ivi_layout-internal-test.c | 10 +++--- 3 files changed, 3 insertions(+), 29 deletions(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-

[PATCH weston 12/14] ivi-shell: remove ivi_layout_layer_set_position API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c|6 +- ivi-shell/ivi-layout-export.h |9 - ivi-shell/ivi-layout-private.h|5 +++-- ivi-shell/ivi-layout-transition.c |3 ++- ivi-shell/ivi-layout.c| 26 +- test

[PATCH weston 06/14] ivi-shell: remove ivi_layout_layer_get_position API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/hmi-controller.c| 11 --- ivi-shell/ivi-layout-export.h |9 - ivi-shell/ivi-layout-private.h|3 --- ivi-shell/ivi-layout-transition.c |6 ++ ivi-shell/ivi-layout.c| 16 tests/iv

[PATCH weston 08/14] ivi-shell: remove ivi_layout_layer_get_dimension API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h|9 - ivi-shell/ivi-layout.c | 16 tests/ivi_layout-internal-test.c | 38 +- 3 files changed, 5 insertions(+), 58 deletions(-) diff --git a/ivi-shell/ivi-l

[PATCH weston 11/14] ivi-shell: remove ivi_layout_surface_set_position API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h|9 - ivi-shell/ivi-layout.c | 24 tests/ivi_layout-internal-test.c | 11 --- tests/ivi_layout-test-plugin.c | 16 +++- 4 files changed, 3 insertions(+), 57 del

[PATCH weston 13/14] ivi-shell: remove ivi_layout_surface_set_dimension API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h|9 - ivi-shell/ivi-layout.c | 25 - tests/ivi_layout-internal-test.c | 11 --- tests/ivi_layout-test-plugin.c | 14 ++ 4 files changed, 2 insertions(+), 57 dele

[PATCH weston 14/14] ivi-shell: remove ivi_layout_layer_set_dimension API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h|9 - ivi-shell/ivi-layout.c | 26 -- tests/ivi_layout-internal-test.c | 35 ++- 3 files changed, 2 insertions(+), 68 deletions(-) diff --git a/ivi-shel

[PATCH weston 09/14] ivi-shell: remove ivi_layout_surface_get_orientation API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h| 10 -- ivi-shell/ivi-layout.c | 12 tests/ivi_layout-internal-test.c |2 -- tests/ivi_layout-test-plugin.c | 13 - 4 files changed, 4 insertions(+), 33 deletions(-) diff --git a

[PATCH weston 03/14] ivi-shell: remove ivi_layout_surface_get_opacity API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h |8 ivi-shell/ivi-layout-private.h|2 -- ivi-shell/ivi-layout-transition.c |6 +++--- ivi-shell/ivi-layout.c| 12 tests/ivi_layout-test-plugin.c| 24 +++- 5

[PATCH weston 05/14] ivi-shell: remove ivi_layout_surface_get_position API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h|9 - ivi-shell/ivi-layout.c | 16 tests/ivi_layout-internal-test.c |7 --- tests/ivi_layout-test-plugin.c | 27 ++- 4 files changed, 6 insertions(+), 53 dele

[PATCH weston 04/14] ivi-shell: remove ivi_layout_layer_get_opacity API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h |8 ivi-shell/ivi-layout-private.h|2 -- ivi-shell/ivi-layout-transition.c |2 +- ivi-shell/ivi-layout.c| 12 tests/ivi_layout-internal-test.c | 16 5 files chang

[PATCH weston 00/14] IVI Layout API Cleanup

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
I removed the get APIs, because the same information can be get from ivi_layout_get_properties_of_surface/layer APIs. Therefore, these APIs are redundant. Furthermore, I removed *_set_position/dimension APIs, because position and dimension can be set by ivi_layout_surface/layer_set_destination_re

[PATCH weston 02/14] ivi-shell: remove ivi_layout_layer_get_visibility API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h|9 - ivi-shell/ivi-layout.c | 12 tests/ivi_layout-internal-test.c | 11 --- 3 files changed, 4 insertions(+), 28 deletions(-) diff --git a/ivi-shell/ivi-layout-export.h b/ivi-shell/ivi-

[PATCH weston 01/14] ivi-shell: remove ivi_layout_surface_get_visibility API

2016-02-26 Thread Ucan, Emre (ADITG/SW1)
Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout-export.h | 10 -- ivi-shell/ivi-layout-private.h|2 -- ivi-shell/ivi-layout-transition.c |2 +- ivi-shell/ivi-layout.c| 12 tests/ivi_layout-internal-test.c |4 tests/ivi_layout-test-p

Re: [PATCH v3 wayland 3/3] doc: generate doxygen html output from the scanner

2016-02-26 Thread Pekka Paalanen
On Mon, 22 Feb 2016 08:57:47 +1000 Peter Hutterer wrote: > This switches the scanner to generate doxygen-compatible tags for the > generated protocol headers, and hooks up the doxygen build to generate server > and client-side API documentation. > > Each protocol is a separate doxygen @page, wit

Re: [PATCH wayland-protocols] xdg-shell: Add startup notification

2016-02-26 Thread Carlos Garnacho
Hey :), On Fri, Feb 26, 2016 at 1:54 PM, Pekka Paalanen wrote: > On Mon, 15 Feb 2016 16:59:02 +0800 > Jonas Ådahl wrote: > >> On Thu, Feb 11, 2016 at 01:52:36PM +0100, Carlos Garnacho wrote: >> > The xdg_launcher interface is added for the launcher, it's used >> > to notify of the startup ID to

Re: [PATCH wayland-protocols] xdg-shell: Add startup notification

2016-02-26 Thread Carlos Garnacho
Hey :), On Mon, Feb 15, 2016 at 9:59 AM, Jonas Ådahl wrote: > On Thu, Feb 11, 2016 at 01:52:36PM +0100, Carlos Garnacho wrote: >> The xdg_launcher interface is added for the launcher, it's used >> to notify of the startup ID to be transmitted to the launchee, >> plus notifications about the start

Re: [PATCH wayland] server: add listener API for new clients

2016-02-26 Thread Pekka Paalanen
On Fri, 19 Feb 2016 19:03:29 -0800 Bryce Harrington wrote: > On Thu, Feb 11, 2016 at 09:20:00PM +0900, nic...@nicesj.com wrote: > > Using display object, Emit a signal if a new client is created. > > > > In the server-side, we can get the destroy event of a client, > > But there is no way to get

Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-26 Thread Pekka Paalanen
On Mon, 22 Feb 2016 16:14:56 -0800 Bryce Harrington wrote: > On Mon, Feb 22, 2016 at 08:47:24AM -0500, Chris Michael wrote: > > When we handle keyboard key events, we already retrieve the key state > > at the top of this function, so there is no real need to call the same > > libinput function ag

Re: [PATCH] server: Add get/set user data for wl_client

2016-02-26 Thread Pekka Paalanen
On Wed, 17 Feb 2016 18:47:44 +0900 Sung-Jin Park wrote: > Hi pq, > I'm sorry for replying late. > > The reasons why I tried to add are following. > - If a wl_client is able to has a user data, > a wayland server can use it for storing the client specific data such as > security privilege, the

Re: [PATCH wayland-protocols] xdg-shell: Add startup notification

2016-02-26 Thread Pekka Paalanen
On Mon, 15 Feb 2016 16:59:02 +0800 Jonas Ådahl wrote: > On Thu, Feb 11, 2016 at 01:52:36PM +0100, Carlos Garnacho wrote: > > The xdg_launcher interface is added for the launcher, it's used > > to notify of the startup ID to be transmitted to the launchee, > > plus notifications about the startup

Re: [RFC wayland] scanner: Add support for dynamic symbol loading

2016-02-26 Thread Pekka Paalanen
On Thu, 18 Feb 2016 18:51:33 +0800 Jonas Ådahl wrote: > In certain configurations the wl_interface symbols up various > interfaces from wayland core (such as wl_surface_interface, > wl_pointer_interface etc) are not available at build time, for example > when the application will dlopen() the req

Re: [PATCH] server: Fix shm_create_pool size fail path fd leak

2016-02-26 Thread Pekka Paalanen
On Mon, 22 Feb 2016 14:41:44 -0800 Bryce Harrington wrote: > On Mon, Feb 22, 2016 at 01:23:00PM +0800, Jonas Ådahl wrote: > > On Fri, Feb 19, 2016 at 11:13:25AM +0100, xerpi wrote: > > > I was just reading the source when I found it (no valgrind involved). So > > > as wl_connection_destroy() al

Re: [PATCH wayland] tests: Test creating a shm pool with 0 size

2016-02-26 Thread Pekka Paalanen
On Tue, 23 Feb 2016 08:25:23 +0800 Jonas Ådahl wrote: > On Mon, Feb 22, 2016 at 02:35:42PM -0800, Bryce Harrington wrote: > > On Mon, Feb 22, 2016 at 03:03:11PM +0100, Marek Chalupa wrote: > > > Hi > > > > > > On 02/22/16 06:52, Jonas Ådahl wrote: > > > >Add a test case that tests the server

Re: [PATCH wayland] client: Don't segfault when receiving error on destroyed object

2016-02-26 Thread Pekka Paalanen
On Fri, 26 Feb 2016 11:57:51 +0200 Pekka Paalanen wrote: > On Mon, 22 Feb 2016 13:22:05 -0800 > Bryce Harrington wrote: > > > On Mon, Feb 22, 2016 at 02:34:57PM +0100, Marek Chalupa wrote: > > > Hi, > > > > > > can confirm the segfault, tested it (will send the test I used for > > > it as a

Re: [PATCH wayland] tests: add test for receiving an error on destroyed object

2016-02-26 Thread Pekka Paalanen
On Mon, 22 Feb 2016 13:25:33 -0800 Bryce Harrington wrote: > On Mon, Feb 22, 2016 at 02:37:00PM +0100, Marek Chalupa wrote: > > test if receiving an error on already destroyed object won't > > do any harm > > > > Signed-off-by: Marek Chalupa > > Confirmed that this test catches the error tha

Re: [PATCH wayland] client: Don't segfault when receiving error on destroyed object

2016-02-26 Thread Pekka Paalanen
On Mon, 22 Feb 2016 13:22:05 -0800 Bryce Harrington wrote: > On Mon, Feb 22, 2016 at 02:34:57PM +0100, Marek Chalupa wrote: > > Hi, > > > > can confirm the segfault, tested it (will send the test I used for > > it as a follow-up). The only API change problem could be in > > returning > > NULL as