Re: [PATCH] doc: Use enum argument type to make links in protocol documentation

2016-02-19 Thread Bryce Harrington
On Fri, Nov 06, 2015 at 04:44:58PM +, Auke Booij wrote: > On 6 November 2015 at 16:27, wrote: > > From: Bill Spitzak > > This is good preparation for when we'll get cross-interface enums. > > Reviewed-by: Auke Booij Thanks, pushed: To ssh://git.freedesktop.org/git/wayland/wayland 3a25

Re: [PATCH v2 wayland 3/3] doc: generate doxygen html output from the scanner

2016-02-19 Thread Bryce Harrington
On Mon, Dec 07, 2015 at 02:41:58PM -0800, Bryce Harrington wrote: > On Tue, Nov 17, 2015 at 10:17:23AM +1000, Peter Hutterer wrote: > > This switches the scanner to generate doxygen-compatible tags for the > > generated protocol headers, and hooks up the doxygen build to generate > > server > > an

Re: [PATCH 2/2] xdg-shell: clarify xdg_surface creation semantics regarding buffers

2016-02-19 Thread Bryce Harrington
On Wed, Dec 02, 2015 at 08:06:46PM -0500, Mike Blumenkrantz wrote: > this change ensures that the client will set its initial state > before performing any drawing, ensuring that there is no mismatch > when creating a surface with a non-default state > (eg. maximize, fullscreen, ...) > > looking a

Re: [PATCH weston 1/2] simple-touch: Use damage_buffer if available

2016-02-19 Thread Bryce Harrington
On Fri, Feb 12, 2016 at 09:03:16AM +0200, Giulio Camuffo wrote: > 2016-02-12 6:26 GMT+02:00 Bryce Harrington : > > On Fri, Jan 08, 2016 at 03:00:55PM -0600, Derek Foreman wrote: > >> Signed-off-by: Derek Foreman > >> --- > >> clients/simple-touch.c | 18 +++--- > >> 1 file changed, 15

Re: [PATCH] platform: explicitly cast the return value of weston_platform_get_egl_proc_address

2016-02-19 Thread Bryce Harrington
On Fri, Jan 29, 2016 at 05:02:15PM +0100, Matthias Treydte wrote: > This allows the header to be consumed by C++ compilers, because C++ does > away with C's implicit cast from (void*). > --- > shared/platform.h | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) Tabbing looks off m

Re: [PATCH wayland 2/2] shm: Defer wl_shm_pool_resize if a pool has external references

2016-02-19 Thread Bryce Harrington
On Tue, Feb 09, 2016 at 04:03:48PM -0600, Derek Foreman wrote: > If a compositor is rendering in one thread while dispatching wayland > events in another, a wl_shm_pool_resize() could change the memory > mappings it's rendering from and cause a crash. > > Now we defer wl_shm_pool_resize() if the c

Re: [PATCH wayland 1/2] shm: Split pool reference counting into external and internal references

2016-02-19 Thread Bryce Harrington
On Tue, Feb 09, 2016 at 04:03:47PM -0600, Derek Foreman wrote: > This is a preliminary step towards deferring shm resize operations until > after the compositor has released all external references on a pool. > > Signed-off-by: Derek Foreman Yep looks good. Reviewed-by: Bryce Harrington > --- >

Re: [PATCH wayland] shm: Log a warning if a shm buffer address is requested when it may be invalid

2016-02-19 Thread Bryce Harrington
On Tue, Feb 09, 2016 at 04:29:49PM -0600, Derek Foreman wrote: > If wl_shm_buffer_get_data() is called on a shm pool that has an external > reference and a pending resize, then the buffer may be outside the pool's > current mapping. > > Log a warning if this happens. > > Signed-off-by: Derek Fore

Re: [PATCH wayland] server: add listener API for new clients

2016-02-19 Thread Bryce Harrington
On Thu, Feb 11, 2016 at 09:20:00PM +0900, nic...@nicesj.com wrote: > Using display object, Emit a signal if a new client is created. > > In the server-side, we can get the destroy event of a client, > But there is no way to get the created event of it. > Of course, we can get the client object fro

Re: [PATCH weston v2 1/2] configure: Make WebP support togglable, and improve its error message.

2016-02-19 Thread Bryce Harrington
On Tue, Feb 16, 2016 at 10:26:25PM -0800, Bryce Harrington wrote: > On Tue, Feb 16, 2016 at 01:57:51AM +, Emmanuel Gil Peyrot wrote: > > The current way was enabling WebP support whenever libwebp was found, > > giving no way to the user to disable it if they had the library > > installed but di

Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-19 Thread Bryce Harrington
On Fri, Feb 19, 2016 at 11:07:00AM -0500, Chris Michael wrote: > When we handle pointer button events, we already retrieve the button > state at the top of this function, so there is no real need to call > the same function again as we can just reuse the 'button_state' > variable that we have above

Re: [PATCH] libinput-device: Remove unnecessary function call

2016-02-19 Thread Bryce Harrington
On Fri, Feb 19, 2016 at 11:07:00AM -0500, Chris Michael wrote: > When we handle pointer button events, we already retrieve the button > state at the top of this function, so there is no real need to call > the same function again as we can just reuse the 'button_state' > variable that we have above

[RFC wayland-protocols v4] Add Primary Selection Protocol Version 1

2016-02-19 Thread Carlos Garnacho
From: Lyude This primary selection is similar in spirit to the eponimous in X11, allowing a quick "select text + middle click" shortcut to copying and pasting. It's otherwise very similar to it wayland counterpart, and explicitly made consistent with it. Signed-off-by: Lyude Signed-off-by: Car

Re: [RFC libinput] Add dial input device support

2016-02-19 Thread Peter Hutterer
On Fri, Feb 19, 2016 at 08:03:52PM +0530, PrasannaKumar Muralidharan wrote: > > right. the approach we used for this was to have an API that exports the > > value in degrees and an API for get_value_discrete() or similarly named. > > Look up the libinput_event_pointer*axis* API to get an idea. > >

[PATCH] refactor x11-backend configuration API

2016-02-19 Thread Benoit Gschwind
Use a "well" defined structure to configure x11-backend and move configuration file parsing inside the weston's compositor code. --- Makefile.am | 1 + src/compositor-x11.c | 160 ++--- src/compositor-x11.h | 61 +++ src/compo

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-19 Thread Jan Arne Petersen
Hi, On 18/02/16 20:36, Rui Tiago Cação Matos wrote: > On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen wrote: + > ... + + + + >>> >>> These arguments could, and perhaps should, all be type="uint" >> >> Yes I guess for width/height. > > As Jo

[PATCH] libinput-device: Remove unnecessary function call

2016-02-19 Thread Chris Michael
When we handle pointer button events, we already retrieve the button state at the top of this function, so there is no real need to call the same function again as we can just reuse the 'button_state' variable that we have above. Signed-off-by: Chris Michael --- src/libinput-device.c | 3 ++- 1

Re: [RFC libinput] Add dial input device support

2016-02-19 Thread PrasannaKumar Muralidharan
> right. the approach we used for this was to have an API that exports the > value in degrees and an API for get_value_discrete() or similarly named. > Look up the libinput_event_pointer*axis* API to get an idea. For several devices (example dimmers used for controlling lamps) value in degrees is

Re: [RFC libinput] Add dial input device support

2016-02-19 Thread PrasannaKumar Muralidharan
Hi Andreas, > Instead of car steering wheels I would rather mention rotaty knobs that are > common in car infotainment systems to navigate through menues. Those are > relative - you never get absolute angles just rotation ticks. > But is that the type of device you had in mind? Those devices usua

Re: [PATCH weston v2] hmi-controller: remove duplicate commit_changes in random mode

2016-02-19 Thread Pekka Paalanen
On Thu, 18 Feb 2016 08:48:40 +0900 Wataru Natsume wrote: > From: Wataru Natsume > > Previous code cleaned up surfaces in layer once and then added > surfaces to a layer in random. In this flow, two commitchanges are > required. > > Signed-off-by: Nobuhiko Tanibata > [wataru_nats...@xddp.denso

Re: [PATCH] server: Fix shm_create_pool size fail path fd leak

2016-02-19 Thread xerpi
I was just reading the source when I found it (no valgrind involved). So as wl_connection_destroy() already takes care of that, my patch is pointless. My final idea would be to add support to fds that have the F_SEAL_SHRINK seal set (see memfd_create(2) and fcntl(2)), so if a client creates shm_po

Re: [PATCH wayland v2] server: validate resource versions at creation time

2016-02-19 Thread Pekka Paalanen
On Tue, 16 Feb 2016 22:08:50 -0800 Bryce Harrington wrote: > On Fri, Jan 15, 2016 at 10:06:48AM -0600, Derek Foreman wrote: > > We shouldn't ever create a resource with version less than 1 or > > greater than the interface version. > > > > Reviewed-by: Marek Chalupa > > Signed-off-by: Derek For