Re: [RFC libinput] Add dial input device support

2016-02-18 Thread Peter Hutterer
On Thu, Feb 18, 2016 at 02:08:09PM +0530, PrasannaKumar Muralidharan wrote: > Hi Peter, > > Thanks for your time in looking at the patch. > > > First: yes, implementing support for dial interfaces is within the scope of > > libinput, I think it makes sense to add this. But not quite in this form,

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-18 Thread Jonas Ådahl
On Thu, Feb 18, 2016 at 08:36:38PM +0100, Rui Tiago Cação Matos wrote: > On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen wrote: > >>> + > ... > >>> + > >>> + > >>> + > >>> + > >> > >> These arguments could, and perhaps should, all be type="uint" > > > > Yes I guess f

Re: [PATCH] server: Fix shm_create_pool size fail path fd leak

2016-02-18 Thread Jonas Ådahl
On Thu, Feb 18, 2016 at 11:59:29PM +0100, Sergi Granell wrote: > If the client passed a size <= 0 to shm_create_pool, it would > go to err_free, which wouldn't close the fd, and thus leave it opened. > > We can also move the size check before the struct wl_shm_pool > malloc, so in case the client

[PATCH] server: Fix shm_create_pool size fail path fd leak

2016-02-18 Thread Sergi Granell
If the client passed a size <= 0 to shm_create_pool, it would go to err_free, which wouldn't close the fd, and thus leave it opened. We can also move the size check before the struct wl_shm_pool malloc, so in case the client passes a wrong size, it won't do an unnecessary malloc and then free. ---

Re: [PATCH v4 wayland-protocols] text: Create second version of text input protocol

2016-02-18 Thread Rui Tiago Cação Matos
On Wed, Feb 17, 2016 at 6:13 AM, Jan Arne Petersen wrote: >>> + ... >>> + >>> + >>> + >>> + >> >> These arguments could, and perhaps should, all be type="uint" > > Yes I guess for width/height. As Jonas pointed out, just leave them as "int". One thing I now noticed is

Re: [RFC libinput] Add dial input device support

2016-02-18 Thread Andreas Pokorny
Hi, On Mon, Feb 15, 2016 at 11:51 AM, PrasannaKumar Muralidharan < prasannatsmku...@gmail.com> wrote: > From: PrasannaKumar Muralidharan > > I am implementing dial input device support and would like to get feedback > on the code that I have implemented so far. Did not implement test cases as >

Google Summer of Code 2016

2016-02-18 Thread Alex Deucher
Hi, It's time to start thinking about the Google Summer of Code for 2016! The Xorg GSoC project is open to all projects related to graphics, windowing systems, and related technologies (Mesa, Wayland, X, input, kernel, OpenGL, OpenCL, etc.). For mentors and developers, please start thinking of id

[PATCH v2 wayland-protocols] configure.ac: Don't use AC_CANONICAL_* macro calls

2016-02-18 Thread Jussi Kukkonen
Check autoconfs $cross_compiling instead as AC_CANONICAL_HOST call will fail if the host cpu is not recognised (which can happen when e.g. Yocto builds for "allarch"). Signed-off-by: Jussi Kukkonen --- configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configure

Re: [PATCH wayland-protocols] configure.ac: Don't use AC_CANONICAL_* macro calls

2016-02-18 Thread Jussi Kukkonen
On 18 February 2016 at 14:38, Quentin Glidic < sardemff7+wayl...@sardemff7.net> wrote: > On 18/02/2016 13:29, Jussi Kukkonen wrote: > >> There's nothing in the build that requires knowledge of target or >> host architecture, yet the calls will fail if the host cpu is not >> recognised (which happe

Re: [PATCH wayland-protocols] configure.ac: Don't use AC_CANONICAL_* macro calls

2016-02-18 Thread Quentin Glidic
On 18/02/2016 13:29, Jussi Kukkonen wrote: There's nothing in the build that requires knowledge of target or host architecture, yet the calls will fail if the host cpu is not recognised (which happens when e.g. Yocto builds for "allarch"). Signed-off-by: Jussi Kukkonen --- configure.ac | 3 --

[PATCH wayland-protocols] configure.ac: Don't use AC_CANONICAL_* macro calls

2016-02-18 Thread Jussi Kukkonen
There's nothing in the build that requires knowledge of target or host architecture, yet the calls will fail if the host cpu is not recognised (which happens when e.g. Yocto builds for "allarch"). Signed-off-by: Jussi Kukkonen --- configure.ac | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH wayland] client: ensure thread safety for wl_display_roundtrip_queue()

2016-02-18 Thread Pekka Paalanen
On Tue, 16 Feb 2016 14:26:53 -0800 Bill Spitzak wrote: > On Mon, Feb 15, 2016 at 7:48 PM, Jonas Ådahl wrote: > > The proxy wrapper approach can be tested out by appling this patch: > > https://lists.freedesktop.org/archives/wayland-devel/2015-June/023054.html > > > Paraphrased here: > > >

Re: [PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2016-02-18 Thread Daniel Stone
Hi, On 18 February 2016 at 11:57, Carlos Garnacho wrote: > On Thu, Feb 18, 2016 at 11:03 AM, Daniel Stone wrote: >> That works for touchpads (what I assume this was designed against), >> but breaks for multitouch touchscreens: there you could be >> pinching/zooming/scrolling/etc in multiple area

Re: [PATCH v3 wayland-protocols] Add the tablet protocol

2016-02-18 Thread Daniel Stone
Hi, No real opinion on the angles/units thing, and indeed we can't really add native 64-bit integers now (even if we did, it rapidly descends into a padding/alignment nightmare; much easier to keep _everything_ on the wire as 32-bit units for that reason). Aside from that: On 29 January 2016 at 04

Re: [PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2016-02-18 Thread Carlos Garnacho
Hey Daniel :), I see Jonas replied, I'll try to give some more detail. On Thu, Feb 18, 2016 at 11:03 AM, Daniel Stone wrote: > Hi, > > On 31 July 2015 at 14:53, Carlos Garnacho wrote: >> On Wed, Jul 29, 2015 at 4:52 AM, Jonas Ådahl wrote: >>> On Thu, Jul 23, 2015 at 07:00:27PM +0200, Carlos Ga

[RFC wayland] scanner: Add support for dynamic symbol loading

2016-02-18 Thread Jonas Ådahl
In certain configurations the wl_interface symbols up various interfaces from wayland core (such as wl_surface_interface, wl_pointer_interface etc) are not available at build time, for example when the application will dlopen() the required symbols at run time. To make it possible to build files g

Re: [PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2016-02-18 Thread Daniel Stone
Hi, On 18 February 2016 at 10:08, Jonas Ådahl wrote: > On Thu, Feb 18, 2016 at 10:03:36AM +, Daniel Stone wrote: >> On 31 July 2015 at 14:53, Carlos Garnacho wrote: >> > On Wed, Jul 29, 2015 at 4:52 AM, Jonas Ådahl wrote: >> >> On Thu, Jul 23, 2015 at 07:00:27PM +0200, Carlos Garnacho wrote

Re: [PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2016-02-18 Thread Jonas Ådahl
On Thu, Feb 18, 2016 at 10:03:36AM +, Daniel Stone wrote: > Hi, > > On 31 July 2015 at 14:53, Carlos Garnacho wrote: > > On Wed, Jul 29, 2015 at 4:52 AM, Jonas Ådahl wrote: > >> On Thu, Jul 23, 2015 at 07:00:27PM +0200, Carlos Garnacho wrote: > >>> + > >>> + > >>> + > >>> + A glob

Re: [PATCH weston v2 1/5] protocol: Add _wl_pointer_gestures (swipe/pinch) protocol

2016-02-18 Thread Daniel Stone
Hi, On 31 July 2015 at 14:53, Carlos Garnacho wrote: > On Wed, Jul 29, 2015 at 4:52 AM, Jonas Ådahl wrote: >> On Thu, Jul 23, 2015 at 07:00:27PM +0200, Carlos Garnacho wrote: >>> + >>> + >>> + >>> + A global interface to provide semantic touchpad gestures for a given >>> + pointe

Re: [PATCH wayland] client: ensure thread safety for wl_display_roundtrip_queue()

2016-02-18 Thread Bill Spitzak
On Mon, Feb 15, 2016 at 7:48 PM, Jonas Ådahl wrote: The proxy wrapper approach can be tested out by appling this patch: > https://lists.freedesktop.org/archives/wayland-devel/2015-June/023054.html Paraphrased here: > In short, instead of > > bar = wl_foo_get_bar(foo); > wl_prox

Wayland for GSoC

2016-02-18 Thread Ekaterina Gerasimova
Hi all, Daniel, pq and I would like to submit Wayland as an organisation (usually referred to as an "org") for GSoC 2016 to attract new, young contributors to the project. In theory, Wayland would fit under the X.Org Foundation umbrella org but X.Org apparently doesn't get as many student slots as

Re: [PATCH wayland] server: validate resource versions at creation time

2016-02-18 Thread Giulio Camuffo
2016-01-14 22:46 GMT+02:00 Derek Foreman : > We shouldn't ever create a resource with version less than 1 or > greater than the interface version. There was a discussion in IRC some days ago, stemming from the bumping of wl_buffer to v2 in your network patch series. Currently it's not possible to

Re: [RFC libinput] Add dial input device support

2016-02-18 Thread PrasannaKumar Muralidharan
Hi Peter, Thanks for your time in looking at the patch. > First: yes, implementing support for dial interfaces is within the scope of > libinput, I think it makes sense to add this. But not quite in this form, > the various CAP flags are libinput interfaces that denote a specific > functionality.