Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-16 Thread Jonas Ådahl
On Sat, Jan 16, 2016 at 03:07:00PM -0500, Mike Blumenkrantz wrote: > On Sat, 16 Jan 2016 10:28:20 +0800 > Jonas Ådahl wrote: > > > On Fri, Jan 15, 2016 at 09:19:34PM -0500, Mike Blumenkrantz wrote: > > > Hi, > > > > > > I have some suggestions which I've inlined below: > > > > > > On Tue, 12 Ja

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-16 Thread Mike Blumenkrantz
On Sat, 16 Jan 2016 10:28:20 +0800 Jonas Ådahl wrote: > On Fri, Jan 15, 2016 at 09:19:34PM -0500, Mike Blumenkrantz wrote: > > Hi, > > > > I have some suggestions which I've inlined below: > > > > On Tue, 12 Jan 2016 16:16:49 +0800 > > Jonas Ådahl wrote: > > > > > An xdg_tooltip is a new wi

Re: [PATCH weston 2/5] data-device: Implement DnD actions

2016-01-16 Thread Jonas Ådahl
On Fri, Jan 15, 2016 at 09:14:24PM +0100, Carlos Garnacho wrote: > The policy in weston in order to determine the chosen DnD action is > deliberately simple, and is probably the minimals that any compositor > should be doing here. > > Besides honoring the set_actions requests on both wl_data_sourc

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2016-01-16 Thread Carlos Garnacho
Hi Jonas! On Sat, Jan 16, 2016 at 9:37 AM, Jonas Ådahl wrote: > On Fri, Jan 15, 2016 at 02:49:33PM -0800, Bryce Harrington wrote: >> On Fri, Jan 15, 2016 at 09:11:40PM +0100, Carlos Garnacho wrote: >> > These 2 requests have been added: >> > >> > - wl_data_source.set_actions: Notifies the composi

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-16 Thread Jonas Ådahl
On Tue, Jan 12, 2016 at 10:01:17AM +, Daniel Stone wrote: > On 12 January 2016 at 04:31, Jonas Ådahl wrote: > > wl_display_flush() may fail with EAGAIN which means that not all data > > waiting in the buffer has been flushed. We later block until there > > data to read, which could mean that w

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2016-01-16 Thread Jonas Ådahl
On Fri, Jan 15, 2016 at 02:49:33PM -0800, Bryce Harrington wrote: > On Fri, Jan 15, 2016 at 09:11:40PM +0100, Carlos Garnacho wrote: > > These 2 requests have been added: > > > > - wl_data_source.set_actions: Notifies the compositor of the available > > actions on the data source. > > - wl_data_