Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

On Fri, Jan 15, 2016 at 11:43:33AM -0800, Bill Spitzak wrote: > Would it make sense for wl_display_flush() to do this always? Ie it will > never return EAGAIN. Then if needed make the non-blocking version be a new > call. No, we can't change the semantics of wl_display_flush() to be blocking, as i

Re: [PATCH weston v6 1/5] data-device: Implement DnD progress notification

On Fri, Jan 15, 2016 at 09:09:46PM +0100, Carlos Garnacho wrote: > Hey Jonas, > > On Fri, Jan 15, 2016 at 6:32 AM, Jonas Ådahl wrote: > > On Thu, Jan 14, 2016 at 11:43:39PM +0100, Carlos Garnacho wrote: > >> Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in > >> order to not

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

On Fri, Jan 15, 2016 at 09:19:34PM -0500, Mike Blumenkrantz wrote: > Hi, > > I have some suggestions which I've inlined below: > > On Tue, 12 Jan 2016 16:16:49 +0800 > Jonas Ådahl wrote: > > > An xdg_tooltip is a new window type used to implement tooltip like > > surfaces. See the interface doc

Re: [PATCH wayland-protocols 1/3] xdg-shell: Turn xdg_surface into a generic base interface

On Fri, Jan 15, 2016 at 09:02:57PM -0500, Mike Blumenkrantz wrote: > Hi, > > I have some suggestions which I've inlined below: All fine points (except the sneaky whitespace in the bottom, that was actually intentional since a sneaky whitespace is in the top as well :P). And sorry for missing add

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

Hi, I have some suggestions which I've inlined below: On Tue, 12 Jan 2016 16:16:49 +0800 Jonas Ådahl wrote: > An xdg_tooltip is a new window type used to implement tooltip like > surfaces. See the interface documentation for details. > > Signed-off-by: Jonas Ådahl > --- > unstable/xdg-shell/

Re: [PATCH wayland-protocols 2/3] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

On Tue, 12 Jan 2016 16:16:48 +0800 Jonas Ådahl wrote: > The reason for using wl_surface before was that xdg_popup and > xdg_surface (now xdg_toplevel) had no common interface other than > wl_surface, but since xdg_surface is now the base interface, lets use > that. > > Signed-off-by: Jonas Ådahl

Re: [PATCH wayland-protocols 1/3] xdg-shell: Turn xdg_surface into a generic base interface

Hi, I have some suggestions which I've inlined below: On Tue, 12 Jan 2016 16:16:47 +0800 Jonas Ådahl wrote: > Split out toplevel window like requests and events into a new interface > called xdg_toplevel, and turn xdg_surface into a generic base interface > which others extends. > > xdg_popup

Re: [PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

Hey Bryce :), On Sat, Jan 16, 2016 at 12:13 AM, Bryce Harrington wrote: > On Fri, Jan 15, 2016 at 09:14:25PM +0100, Carlos Garnacho wrote: >> That way we'll be able to set the corresponding pointer surface to >> a current DnD operation. >> >> Signed-off-by: Carlos Garnacho >> Reviewed-by: Jonas

Re: [PATCH weston 4/5] data-device: Implement compositor-chosen actions

On Fri, Jan 15, 2016 at 09:14:26PM +0100, Carlos Garnacho wrote: > Set up a keyboard grab during drag-and-drop, so we can translate > modifiers into preferred actions. The compositor chosen action > is stored in the current weston_data_source in order to make it > accessible to the source/offer at

Re: [PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

On Fri, Jan 15, 2016 at 09:14:25PM +0100, Carlos Garnacho wrote: > That way we'll be able to set the corresponding pointer surface to > a current DnD operation. > > Signed-off-by: Carlos Garnacho > Reviewed-by: Jonas Ådahl > --- > clients/window.c | 16 > clients/window.h | 3

Re: [PATCH weston 1/5] data-device: Implement DnD progress notification

On Fri, Jan 15, 2016 at 09:14:23PM +0100, Carlos Garnacho wrote: > Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in > order to notify about the different phases of DnD. > > wl_data_source.cancelled is also used as mentioned in the docs, being > emitted also on DnD when the o

Re: [PATCH wayland 2/2] protocol: Add DnD actions

On Fri, Jan 15, 2016 at 09:11:40PM +0100, Carlos Garnacho wrote: > These 2 requests have been added: > > - wl_data_source.set_actions: Notifies the compositor of the available > actions on the data source. > - wl_data_offer.set_actions: Notifies the compositor of the available > actions on the

Re: [PATCH libinput 0/7] tablet: add support for relative x/y motion deltas

On Thu, Jan 14, 2016 at 4:26 PM, Peter Hutterer wrote: > > This patchset adds support for relative motion to the tablet branch. AFAICT, > this is the last large feature that was still missing. > The approach is notably different to the current X driver. There we > toggle a property in the driver t

Re: [PATCH libinput] tablet: allow the various get_ on tablet button events

On Wed, Jan 13, 2016 at 8:22 PM, Peter Hutterer wrote: > There's no reason to prevent this for button events. Unlike the pointer > which is a relative device a tablet is (usually) a device with a lot of state. > Caller code that handles axes is likely shared between the various events, > treating

Re: [PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

On Fri, Jan 15, 2016 at 09:11:39PM +0100, Carlos Garnacho wrote: > Currently, there's no means for the DnD origin to know whether the > destination is actually finished with the DnD transaction, short of > finalizing it after the first transfer finishes, or leaking it forever. > > But this poses o

Re: [PATCH wayland-protocols] ignore: ignore config.sub and config.guess

On Thu, Jan 14, 2016 at 03:34:28PM -0600, Derek Foreman wrote: > Signed-off-by: Derek Foreman > --- > > I think this is my fault and I didn't notice the extra files after my > make check changes... sorry about that. :/ Trivial enough, I've gone ahead and pushed: To ssh://git.freedesktop.org/gi

Re: [PATCH] server: Add an API to get the socket fd for a client

On Fri, Jan 15, 2016 at 02:15:51PM +0900, Sung-Jin Park wrote: > Dear guys and pq, > I updated the new version of patch with version 4 and modified its title to > the following. Sorry for my mistake. :D > > "[PATCH v4] server: Add an API to get the file descriptor for a client" ( > http://patchwor

[PATCH weston 2/5] data-device: Implement DnD actions

The policy in weston in order to determine the chosen DnD action is deliberately simple, and is probably the minimals that any compositor should be doing here. Besides honoring the set_actions requests on both wl_data_source and wl_data_offer, weston now will emit the newly added "action" events n

[PATCH weston 3/5] client: Add DnD cursors to the managed cursors list

That way we'll be able to set the corresponding pointer surface to a current DnD operation. Signed-off-by: Carlos Garnacho Reviewed-by: Jonas Ådahl --- clients/window.c | 16 clients/window.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/clients/window.c b/clients/w

[PATCH weston 1/5] data-device: Implement DnD progress notification

Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in order to notify about the different phases of DnD. wl_data_source.cancelled is also used as mentioned in the docs, being emitted also on DnD when the operation is meant to fail (eg. source and dest didn't agree on a mimetype).

[PATCH weston 4/5] data-device: Implement compositor-chosen actions

Set up a keyboard grab during drag-and-drop, so we can translate modifiers into preferred actions. The compositor chosen action is stored in the current weston_data_source in order to make it accessible to the source/offer at the time of calculating the new action, but would conceptually be part of

[PATCH weston 5/5] dnd: Turn into a full blown example

In order to keep things simple, weston-dnd made a few choices that turn out to be unrealistic, a few tweaks have been done to make it less of a playground demo: - It now caters for copy/move operations, instead of just move, which still remains the default nonetheless. - As "move" operations are

[PATCH wayland 1/2] protocol: Improve data source notification around DnD progress

Currently, there's no means for the DnD origin to know whether the destination is actually finished with the DnD transaction, short of finalizing it after the first transfer finishes, or leaking it forever. But this poses other interoperation problems, drag destinations might be requesting several

[PATCH wayland 2/2] protocol: Add DnD actions

These 2 requests have been added: - wl_data_source.set_actions: Notifies the compositor of the available actions on the data source. - wl_data_offer.set_actions: Notifies the compositor of the available actions on the destination side, plus the preferred action. Out of the data from these req

Re: [PATCH weston v6 1/5] data-device: Implement DnD progress notification

Hey Jonas, On Fri, Jan 15, 2016 at 6:32 AM, Jonas Ådahl wrote: > On Thu, Jan 14, 2016 at 11:43:39PM +0100, Carlos Garnacho wrote: >> Weston now sends wl_data_source.dnd_drop_performed and .dnd_finished in >> order to notify about the different phases of DnD. >> >> wl_data_source.cancelled is also

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

Would it make sense for wl_display_flush() to do this always? Ie it will never return EAGAIN. Then if needed make the non-blocking version be a new call. On Thu, Jan 14, 2016 at 6:40 PM, Jonas Ådahl wrote: > On Fri, Jan 15, 2016 at 12:12:09AM +, Auke Booij wrote: > > On 12 January 2016 at

Re: [PATCH weston v7 2/5] data-device: Implement DnD actions

Hey Jonas, On Fri, Jan 15, 2016 at 7:10 AM, Jonas Ådahl wrote: > On Thu, Jan 14, 2016 at 11:46:34PM +0100, Carlos Garnacho wrote: >> The policy in weston in order to determine the chosen DnD action is >> deliberately simple, and is probably the minimals that any compositor >> should be doing here

[PATCH wayland 1/2] build: Add an --enable-fatal-warnings configure option

New --enable-fatal-warnings ./configure option that just adds -Werror to GCC_CFLAGS Signed-off-by: Derek Foreman --- configure.ac | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 48658cf..17c1fa3 100644 --- a/configure.ac +++ b/con

[PATCH wayland 2/2] build: build distcheck with --enable-fatal-warnings

Signed-off-by: Derek Foreman --- Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index e850abc..5e5576e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -11,6 +11,8 @@ AM_CPPFLAGS = \ AM_CFLAGS = $(GCC_CFLAGS) +AM_DISTC

[PATCH wayland v3] tests: Test proxy versions

Add a test that confirms that proxy versions are always 0 for display and correct otherwise. Signed-off-by: Derek Foreman --- Changes from previous version: Test now attemps to mimic behaviour of clients built with old headers tests/display-test.c | 133 +

Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

Hi, On 12 January 2016 at 22:28, Bill Spitzak wrote: > There should *only* be "one shot" requests, which are very quickly accepted > or denied by the compositor. The client creates it in response to an input > event, and it includes the input event id. > > Most/all things that triggers pointer lo

[PATCH wayland v2] server: validate resource versions at creation time

We shouldn't ever create a resource with version less than 1 or greater than the interface version. Reviewed-by: Marek Chalupa Signed-off-by: Derek Foreman --- Changes since v1: Fix silly typo - [0, %d] is now [1, %d] src/wayland-server.c | 7 +++ 1 file changed, 7 insertions(+) diff --g

Re: [PATCH wayland] server: validate resource versions at creation time

On 15/01/16 03:14 AM, Marek Chalupa wrote: > Hi, > > On 01/14/2016 09:46 PM, Derek Foreman wrote: >> We shouldn't ever create a resource with version less than 1 or >> greater than the interface version. >> >> Signed-off-by: Derek Foreman >> --- >> >> I'm a little nervous about this one. >> >> An

Re: [PATCH weston] input: use doubles in the interfaces to notify of input events

Hi, On 19 October 2015 at 09:05, Giulio Camuffo wrote: > send-email continues to be broken so here's the v2: > - remove unneded casts > - avoid naming absolute variables dx/dy Reviewed-by: Daniel Stone Cheers, Daniel ___ wayland-devel mailing list wa

Re: [PATCH wayland] server: validate resource versions at creation time

Hi, On 01/14/2016 09:46 PM, Derek Foreman wrote: We shouldn't ever create a resource with version less than 1 or greater than the interface version. Signed-off-by: Derek Foreman --- I'm a little nervous about this one. Anything doing this probably gets what it deserves, but it does break way

Re: [PATCH] config-parser: Check malloc returns

Hi On 01/13/2016 09:30 PM, Bryce Harrington wrote: Signed-off-by: Bryce Harrington --- shared/config-parser.c | 4 1 file changed, 4 insertions(+) diff --git a/shared/config-parser.c b/shared/config-parser.c index a50773b..137a9f1 100644 --- a/shared/config-parser.c +++ b/shared/config

Re: [PATCH] clients: fix build on Linux

Hi Derek, - Original Message - > > stropts.h is not available on Linux. > Well, this is all fascinating. :) Yeah, sorry, my sentence was badly worded, I should have written "streams is not available on Linux upstream" instead (even though there've been 3rd party modules in the past). "