[PATCH v4] server: Add an API to get the file descriptor for a client

2016-01-13 Thread Sung-Jin Park
This adds an API to get the file descriptor for a client. The client file descriptor can be used for a wayland compositor to validate a request from a client if there are any additional information provided from the client's file descriptor. For instance, this will be helpful in some linux distrib

Re: [PATCH v200 wayland-protocols] test: add make check

2016-01-13 Thread Jonas Ådahl
On Tue, Jan 12, 2016 at 09:12:37PM +0100, Quentin Glidic wrote: > From: Derek Foreman > > We can now test all the protocol files by running make check (or distcheck) > which will pass them through the scanner. > > Signed-off-by: Derek Foreman > Reviewed-by: Quentin Glidic Merged version 200 o

[PATCH libinput] tablet: allow the various get_ on tablet button events

2016-01-13 Thread Peter Hutterer
There's no reason to prevent this for button events. Unlike the pointer which is a relative device a tablet is (usually) a device with a lot of state. Caller code that handles axes is likely shared between the various events, treating button events separately here doesn't get us any benefit. Signe

[PATCH wayland v10 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
These 2 requests have been added: - wl_data_source.set_actions: Notifies the compositor of the available actions on the data source. - wl_data_offer.set_actions: Notifies the compositor of the available actions on the destination side, plus the preferred action. Out of the data from these req

Re: [PATCH wayland 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
Hi Michal, On Mon, Jan 11, 2016 at 11:34 AM, Michal Suchanek wrote: > On 24 December 2015 at 01:58, Carlos Garnacho wrote: > >> @@ -757,6 +883,40 @@ >> >> >> >> + >> + >> + >> + >> + >> +This is a bitmask of the available/preferred actions in a >> +

[PATCH wayland v9 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
These 2 requests have been added: - wl_data_source.set_actions: Notifies the compositor of the available actions on the data source. - wl_data_offer.set_actions: Notifies the compositor of the available actions on the destination side, plus the preferred action. Out of the data from these req

Re: [PATCH wayland v8 2/2] protocol: Add DnD actions

2016-01-13 Thread Carlos Garnacho
Hey Jonas, On Mon, Jan 11, 2016 at 9:12 AM, Jonas Ådahl wrote: > On Thu, Dec 24, 2015 at 03:21:11AM +0100, Carlos Garnacho wrote: >> These 2 requests have been added: >> >> - wl_data_source.set_actions: Notifies the compositor of the available >> actions on the data source. >> - wl_data_offer.s

Re: [PATCH wayland 4/6] doc: Don't warn if something is undocumented

2016-01-13 Thread Bryce Harrington
On Tue, Dec 29, 2015 at 01:56:14PM +0100, Nils Chr. Brause wrote: > No. > If we want Wayland to be successful and widely used it has to be well > documented (which it still is far from). Turning off warnings about > undocumented fields doesn't exactly help the documentation effort but > rather impe

Re: [PATCH wayland v2] server: don't send an error to NULL display_resource

2016-01-13 Thread Bryce Harrington
On Mon, Jan 11, 2016 at 11:33:32AM -0600, Derek Foreman wrote: > On 11/01/16 04:45 AM, Marek Chalupa wrote: > > if display_resource = wl_resource_create() fails in bind_display(), > > we call wl_client_post_no_memory() which is wrong, since this function > > uses display_resource (which is NULL at

Re: [PATCH wayland] client: Add missing arg in a wl_log invocation

2016-01-13 Thread Bryce Harrington
On Mon, Jan 11, 2016 at 09:25:25AM +0100, Marek Chalupa wrote: > Hi, > > obviously correct > > Reviewed-by: Marek Chalupa Thanks, pushed: To ssh://git.freedesktop.org/git/wayland/wayland 0a37511..693bf00 master -> master > Cheers, > Marek > > On 01/04/2016 11:09 AM, Victor Berger wrote

Re: [PATCH weston] compositor: create_data_source(): Fix potential crash on OOM

2016-01-13 Thread Bryce Harrington
On Mon, Jan 11, 2016 at 09:23:01AM +0100, Marek Chalupa wrote: > Hi, > > Reviewed-by: Marek Chalupa > > (one small comment below) > > Cheers, > Marek > > On 01/05/2016 05:18 PM, Lyude wrote: > >Noticed this while working on primary selection, in the event we run out > >of memory when trying to

Re: [PATCH wayland-protocols 0/3] xdg_surface base interface and xdg_tooltip

2016-01-13 Thread Jasper St. Pierre
It would help if you actually read the spec that was there before commenting. The difference between toplevels and popups is not whether they have a parent (toplevels indeed have a set_parent method), but that popups take an implicit pointer and keyboard grab, e.g. menus and comboboxes. They have w

[PATCH weston v2] build: Add an --enable-fatal-warnings configure option

2016-01-13 Thread Derek Foreman
New --enable-fatal-warnings ./configure option that just adds -Werror to GCC_CFLAGS Signed-off-by: Derek Foreman --- Mess with GCC_CFLAGS instead of CFLAGS configure.ac | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 97cbfe5..a4f

[PATCH weston] clipboard: Only copy text into internal clipboard

2016-01-13 Thread Derek Foreman
This is intended to fix an Xwayland + weston livelock. When something is selected, clipboard_set_selection() copied the first available type into an internal selection source. When an X application exits this clipboard would be made into the current selection buffer, so the buffer doesn't disappe

Wayland 1.10 release plan

2016-01-13 Thread Bryce Harrington
Our next major release will be version 1.10, which we roughly scheduled as follows: √ Development open - 1.10-alpha in mid-January - 1.10-beta in first week of February - 1.10-rc1 around Feb 9th - 1.10.0 by mid-February I'd like to propose the following dates: - 1.10-alphaTuesday

[PATCH] config-parser: Check malloc returns

2016-01-13 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- shared/config-parser.c | 4 1 file changed, 4 insertions(+) diff --git a/shared/config-parser.c b/shared/config-parser.c index a50773b..137a9f1 100644 --- a/shared/config-parser.c +++ b/shared/config-parser.c @@ -312,6 +312,8 @@ config_add_section(struct

Re: [PATCH libinput] touchpad: disable MT for elantech semi-mt touchpads

2016-01-13 Thread Benjamin Tissoires
Hi Hans, On Jan 13 2016 or thereabouts, Hans de Goede wrote: > Hi, > > On 13-01-16 05:09, Peter Hutterer wrote: > >When three fingers are set down on the touchpad, one finger tends to get a > >0/0 > >coordinate, triggering palm detection in the upper left corner. Handle this > >like the jumping

Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

2016-01-13 Thread Bill Spitzak
On Mon, Jan 11, 2016 at 11:03 PM, Jonas Ådahl wrote: > > Come to think of it, we would still introduce a race condition, just for > the other use case. If the intention is that the lock should be > one-shot, the client may not be able to respond with a .destroy() in > time, resulting in the compo

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-13 Thread 박성진
>sorry, that sounds completely bogus and I never implied anything like that. Oh, don't mention it. I misunderstood your comment. :) I'm also sorry for I mentioned UID in my previous email. I think that sounds stranges. I should have mentioned PID instead of UID. >socketpair() is used for creating

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-13 Thread Pekka Paalanen
On Wed, 13 Jan 2016 10:02:18 + (GMT) 박성진 wrote: > Samsung Enterprise Portal mySingle > > Pekka Paalanen, thank you for your review on this. :) > > > > >The fd may not always be from a socket file, it can also be from a call > >to socketpair(2). > > Yes, exactly. > > >Please refer to wl

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-13 Thread 박성진
Title: Samsung Enterprise Portal mySingle Pekka Paalanen, thank you for your review on this. :)   >The fd may not always be from a socket file, it can also be from a call>to socketpair(2). Yes, exactly. >Please refer to wl_client_get_credentials() for the>caveat there, and evaluate whether it

Re: [PATCH libinput] touchpad: disable MT for elantech semi-mt touchpads

2016-01-13 Thread Hans de Goede
Hi, On 13-01-16 05:09, Peter Hutterer wrote: When three fingers are set down on the touchpad, one finger tends to get a 0/0 coordinate, triggering palm detection in the upper left corner. Handle this like the jumping semi-mt touchpads and disable MT handling and instead just rely on the x/y axis

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-13 Thread Pekka Paalanen
On Wed, 13 Jan 2016 10:31:58 +0800 Jonas Ådahl wrote: > On Tue, Jan 12, 2016 at 10:58:16AM -0600, Derek Foreman wrote: > > On 11/01/16 04:30 PM, Sung-Jin Park wrote: > > > This adds an API to get the socket fd for a client. > > > The client socket fd can be used for a wayland compositor to vali