Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

2016-01-12 Thread Jonas Ådahl
On Wed, Jan 13, 2016 at 01:59:21PM +0800, Jonas Ådahl wrote: > On Wed, Jan 13, 2016 at 02:44:29PM +1000, Peter Hutterer wrote: > > On Wed, Jan 13, 2016 at 10:14:50AM +0800, Jonas Ådahl wrote: > > > This patch introduces a new protocol for locking and confining a > > > pointer. It consists of a new

Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

2016-01-12 Thread Peter Hutterer
On Wed, Jan 13, 2016 at 01:59:24PM +0800, Jonas Ådahl wrote: [...] > > > + > > > + > > > + > > > + > > > + These errors can be emitted in response to wp_pointer_constraints > > > + requests. > > > + > > > + > > + summary="pointer constraint already requested on that s

Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

2016-01-12 Thread Jonas Ådahl
On Wed, Jan 13, 2016 at 02:44:29PM +1000, Peter Hutterer wrote: > On Wed, Jan 13, 2016 at 10:14:50AM +0800, Jonas Ådahl wrote: > > This patch introduces a new protocol for locking and confining a > > pointer. It consists of a new global object with two requests; one for > > locking the surface to a

Re: [PATCH v4 wayland-protocols] test: add make check

2016-01-12 Thread Peter Hutterer
On Tue, Jan 12, 2016 at 07:31:05PM +, Daniel Stone wrote: > Hi, > > On 12 January 2016 at 19:22, Derek Foreman wrote: > > --- /dev/null > > +++ b/tests/scan.sh > > @@ -0,0 +1,10 @@ > > +#!/bin/sh -e > > + > > +if [ "x$SCANNER" = "x" ] ; then > > + echo "No scanner present, test will fai

Re: [PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

2016-01-12 Thread Peter Hutterer
On Wed, Jan 13, 2016 at 10:14:50AM +0800, Jonas Ådahl wrote: > This patch introduces a new protocol for locking and confining a > pointer. It consists of a new global object with two requests; one for > locking the surface to a position, one for confining the pointer to a > given region. > > Signe

[PATCH libinput] touchpad: disable MT for elantech semi-mt touchpads

2016-01-12 Thread Peter Hutterer
When three fingers are set down on the touchpad, one finger tends to get a 0/0 coordinate, triggering palm detection in the upper left corner. Handle this like the jumping semi-mt touchpads and disable MT handling and instead just rely on the x/y axis and the BTN_TOOL_* events. https://bugs.freede

[PATCH v3] server: Add an API to get the socket fd for a client

2016-01-12 Thread Sung-Jin Park
This adds an API to get the socket fd for a client. The client socket fd can be used for a wayland compositor to validate a request from a client. For instance, this will be helpful in some linux distributions, in which SELinux or SMACK is enabled. In those environments, each file (including socket

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-12 Thread Sung-Jin Park
Jonas Ådahl, thanks for your review. wl_client_get_fd() looks better to me as well. Including API name, I'll correct comments as well. Thanks and regards, Sung-Jin Park 2016. 1. 13. 오전 11:32에 "Jonas Ådahl" 님이 작성: > On Tue, Jan 12, 2016 at 10:58:16AM -0600, Derek Foreman wrote: > > On 11/01/16 0

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-12 Thread Jonas Ådahl
On Tue, Jan 12, 2016 at 10:58:16AM -0600, Derek Foreman wrote: > On 11/01/16 04:30 PM, Sung-Jin Park wrote: > > This adds an API to get the socket fd for a client. > > The client socket fd can be used for a wayland compositor to validate a > > request > > from a client. > > For instance, this will

[PATCH v2] server: Add an API to get the socket fd for a client

2016-01-12 Thread Sung-Jin Park
This adds an API to get the socket fd for a client. The client socket fd can be used for a wayland compositor to validate a request from a client. For instance, this will be helpful in some linux distributions, in which SELinux or SMACK is enabled. In those environments, each file (including socket

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-12 Thread Sung-Jin Park
Derek, thanks for your review. :) I'll correct the comment regarding fd and update this patch. >Should probably just be > * \return The fd to use for the connection Thanks and regards, Sung-Jin Park 2016. 1. 13. 오전 1:58에 "Derek Foreman" 님이 작성: > On 11/01/16 04:30 PM, Sung-Jin Park wrote: > > Thi

[PATCH wayland-protocols v3] Introduce pointer locking and confinement protocol

2016-01-12 Thread Jonas Ådahl
This patch introduces a new protocol for locking and confining a pointer. It consists of a new global object with two requests; one for locking the surface to a position, one for confining the pointer to a given region. Signed-off-by: Jonas Ådahl Reviewed-by: Peter Hutterer Reviewed-by: Derek Fo

Re: [PATCH v3 weston 2/2] Support axis source, axis discrete, frame and axis stop events

2016-01-12 Thread Bill Spitzak
On Mon, Jan 11, 2016 at 4:07 PM, Jonas Ådahl wrote: > > > > > + widget_pointer_frame_handler_t pointer_frame_handler; > > > > + widget_axis_source_handler_t axis_source_handler; > > > > + widget_axis_stop_handler_t axis_stop_handler; > > > > + widget_axis_discrete_handler_t axis_discrete_handler;

[PATCH wayland 3/3] tests: Test proxy versions

2016-01-12 Thread Derek Foreman
Add a test that confirms that proxy versions are always 0 for display and correct otherwise. Signed-off-by: Derek Foreman --- tests/display-test.c | 41 + 1 file changed, 41 insertions(+) diff --git a/tests/display-test.c b/tests/display-test.c index 161a

[PATCH v2 wayland 2/3] client: Use a 0 version to mean indeterminate proxy version

2016-01-12 Thread Derek Foreman
This sets wl_display's version (for proxy version query purposes) to 0. Any proxy created with unversioned API (this happens when a client compiled with old headers links against new wayland) will inherit this 0. This gives us a way for new libraries linked by old clients to realize they can't kn

[PATCH v2 wayland 1/3] Track protocol object versions inside wl_proxy.

2016-01-12 Thread Derek Foreman
From: Jason Ekstrand This provides a standardized mechanism for tracking protocol object versions in client code. The wl_display object is created with version 1. Every time an object is created from within wl_registry_bind, it gets the bound version. Every other time an object is created, it s

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-12 Thread Bill Spitzak
On Tue, Jan 12, 2016 at 12:16 AM, Jonas Ådahl wrote: > An xdg_tooltip is a new window type used to implement tooltip like > surfaces. See the interface documentation for details. > > + > + > + This creates an xdg_tooltip for the given xdg_surface and gives the > + associated

[PATCH weston 1/2] build: Add an --enable-fatal-warnings configure option

2016-01-12 Thread Derek Foreman
New --enable-fatal-warnings ./configure option that just adds -Werror to CFLAGS Signed-off-by: Derek Foreman --- configure.ac | 9 + 1 file changed, 9 insertions(+) diff --git a/configure.ac b/configure.ac index 97cbfe5..d7fa1b2 100644 --- a/configure.ac +++ b/configure.ac @@ -632,6 +63

[PATCH weston 2/2] build: build distcheck with --enable-fatal-warnings

2016-01-12 Thread Derek Foreman
Builds distcheck with -Werror Signed-off-by: Derek Foreman --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 623621d..a25825f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -8,7 +8,7 @@ module_LTLIBRARIES = noinst_LTLIBRARIES = B

[PATCH v200 wayland-protocols] test: add make check

2016-01-12 Thread Quentin Glidic
From: Derek Foreman We can now test all the protocol files by running make check (or distcheck) which will pass them through the scanner. Signed-off-by: Derek Foreman Reviewed-by: Quentin Glidic --- Just added AC_ARG_VAR to allow overriding the variable when calling configure. .gitignore

[PATCH v172 wayland-protocols] test: add make check

2016-01-12 Thread Derek Foreman
We can now test all the protocol files by running make check (or distcheck) which will pass them through the scanner. Signed-off-by: Derek Foreman --- This time I just removed AC_SUBST skipped tests instead of failing added AC_CANONICAL_BUILD and AC_CANONICAL_HOST .gitignore| 3 +++ Makefi

Re: [PATCH v4 wayland-protocols] test: add make check

2016-01-12 Thread Daniel Stone
Hi, On 12 January 2016 at 19:22, Derek Foreman wrote: > --- /dev/null > +++ b/tests/scan.sh > @@ -0,0 +1,10 @@ > +#!/bin/sh -e > + > +if [ "x$SCANNER" = "x" ] ; then > + echo "No scanner present, test will fail." 1>&2 > + exit 1 > +fi Bikeshed: exit 77 will skip rather than fail. Ch

[PATCH v4 wayland-protocols] test: add make check

2016-01-12 Thread Derek Foreman
We can now test all the protocol files by running make check (or distcheck) which will pass them through the scanner. Signed-off-by: Derek Foreman --- I haven't kept any RBs as this has changed significantly since anyone reviewed it. Changes: v2: Use #/bin/sh -e and drop the && from the script

[PATCH v3 wayland-protocols] test: add make check

2016-01-12 Thread Derek Foreman
We can now test all the protocol files by running make check (or distcheck) which will pass them through the scanner. Signed-off-by: Derek Foreman --- Changes from v1: Use #/bin/sh -e and drop the && from the script Discover the scanner's location and use it Changes from v2: use dist_check_SCRI

Re: [PATCH] server: Add an API to get the socket fd for a client

2016-01-12 Thread Derek Foreman
On 11/01/16 04:30 PM, Sung-Jin Park wrote: > This adds an API to get the socket fd for a client. > The client socket fd can be used for a wayland compositor to validate a > request > from a client. > For instance, this will be helpful in some linux distributions, in which > SELinux > or SMACK is

Re: [PATCH v3] server: Calculate remaining data size after a closure is processed

2016-01-12 Thread Derek Foreman
On 11/01/16 10:12 PM, Jaeyoon Jung wrote: > When processing a closure, data in the connection can be consumed again > if the closure itself invokes extra event dispatch. In that case the > remaining data size is also altered, so the variable len should be > updated after the closure is processed. >

Re: [PATCH v2 1/3] compositor-{drm, fbdev, rpi}: Make VT switching configurable

2016-01-12 Thread Derek Foreman
On 12/01/16 04:21 AM, Bob Ham wrote: > Add a new boolean weston.ini option, "vt-switching" to enable or > disable Ctrl-Alt-Fn key combinations. > > Signed-off-by: Bob Ham > Reviewed-by: Derek Foreman > --- > man/weston.ini.man | 6 ++ > src/compositor-drm.c | 15 +-- > sr

Re: [PATCH wayland v2] client: Fully flush during blocking dispatch

2016-01-12 Thread Daniel Stone
On 12 January 2016 at 04:31, Jonas Ådahl wrote: > wl_display_flush() may fail with EAGAIN which means that not all data > waiting in the buffer has been flushed. We later block until there > data to read, which could mean that we block on input from the > compositor without having sent out all dat

[PATCH v2 0/3] Make important key bindings easily on-and-off-able

2016-01-12 Thread Bob Ham
Allow various sets of key combinations, most importantly Ctrl-Alt-Fn and Ctrl-Alt-Backspace to be disabled from weston.ini. Changes since v1: Moved new function from new files launcher-bindings.* to existing launcher-util.*. Changed zapping option name to "allow

[PATCH v2 2/3] desktop-shell: Make zapping configurable

2016-01-12 Thread Bob Ham
Add a new boolean weston.ini option, "allow-zap" to enable or disable the Ctrl-Alt-Backspace key combination. Signed-off-by: Bob Ham Reviewed-by: Derek Foreman --- desktop-shell/shell.c | 14 +++--- desktop-shell/shell.h | 1 + man/weston.ini.man| 4 3 files changed, 16 inser

[PATCH v2 1/3] compositor-{drm, fbdev, rpi}: Make VT switching configurable

2016-01-12 Thread Bob Ham
Add a new boolean weston.ini option, "vt-switching" to enable or disable Ctrl-Alt-Fn key combinations. Signed-off-by: Bob Ham Reviewed-by: Derek Foreman --- man/weston.ini.man | 6 ++ src/compositor-drm.c | 15 +-- src/compositor-fbdev.c | 17 ++--- src/compos

[PATCH v2 3/3] desktop-shell: Allow binding-modifier weston.ini option to be none

2016-01-12 Thread Bob Ham
Allow the binding-modifier option in weston.ini to take a value of "none", meaning that none of the usual Super+Tab, Super+K, Super+Fn, etc. key bindings will be enabled. Signed-off-by: Bob Ham Reviewed-by: Derek Foreman --- desktop-shell/shell.c | 26 ++ man/weston.ini.

Re: [PATCH 2/3] desktop-shell: Make zapping configurable

2016-01-12 Thread Bob Ham
On Mon, 2016-01-11 at 12:04 -0600, Derek Foreman wrote: > On 11/01/16 09:41 AM, Bob Ham wrote: > > + weston_config_section_get_bool(section, > > + "zap", &zap, true); > > I think "allow_zap" would be better... Ack > > + if (shell->zap != false) > > Wouldn't

Re: [PATCH 1/3] compositor-{drm, fbdev, rpi}: Make VT switching configurable

2016-01-12 Thread Bob Ham
On Mon, 2016-01-11 at 11:58 -0600, Derek Foreman wrote: > On 11/01/16 09:41 AM, Bob Ham wrote: > > diff --git a/src/launcher-bindings.h b/src/launcher-bindings.h > > new file mode 100644 > Couldn't these just go into launcher-util? They could, yes. > If we really need new files, we should have

[PATCH wayland-protocols 0/3] xdg_surface base interface and xdg_tooltip

2016-01-12 Thread Jonas Ådahl
Hi, These patches turns xdg_surface into a generic base interface that other xdg_* roles would then extend. The point of this is to unify some concepts common to all surfaces related to xdg_shell. The parts related to toplevel window management was moved out to a new "xdg_toplevel" interface. xdg_

[PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-12 Thread Jonas Ådahl
An xdg_tooltip is a new window type used to implement tooltip like surfaces. See the interface documentation for details. Signed-off-by: Jonas Ådahl --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 47 1 file changed, 47 insertions(+) diff --git a/unstable/xdg-she

[PATCH wayland-protocols 2/3] xdg-shell: Make get_popup take a xdg_surface instead of wl_surface

2016-01-12 Thread Jonas Ådahl
The reason for using wl_surface before was that xdg_popup and xdg_surface (now xdg_toplevel) had no common interface other than wl_surface, but since xdg_surface is now the base interface, lets use that. Signed-off-by: Jonas Ådahl --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 2 +- 1 file c

[PATCH wayland-protocols 1/3] xdg-shell: Turn xdg_surface into a generic base interface

2016-01-12 Thread Jonas Ådahl
Split out toplevel window like requests and events into a new interface called xdg_toplevel, and turn xdg_surface into a generic base interface which others extends. xdg_popup is changed to extend the xdg_surface. The configure event in xdg_surface was split up making xdg_surface.configure an eve