Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Jonas Ådahl
On Fri, Dec 04, 2015 at 09:25:06AM +0200, Pekka Paalanen wrote: > On Thu, 3 Dec 2015 17:38:34 -0800 > Bryce Harrington wrote: > > > On Fri, Dec 04, 2015 at 08:09:17AM +0800, Jonas Ådahl wrote: > > > On Thu, Dec 03, 2015 at 03:26:16PM -0800, Bryce Harrington wrote: > > > > On Thu, Dec 03, 2015 a

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Pekka Paalanen
On Thu, 3 Dec 2015 17:38:34 -0800 Bryce Harrington wrote: > On Fri, Dec 04, 2015 at 08:09:17AM +0800, Jonas Ådahl wrote: > > On Thu, Dec 03, 2015 at 03:26:16PM -0800, Bryce Harrington wrote: > > > On Thu, Dec 03, 2015 at 04:33:47PM +0800, Jonas Ådahl wrote: > > > > This copies the version 5 o

Re: [PATCH libinput 6/8] tablet: support tool-specific pressure offsets

2015-12-03 Thread Jason Gerecke
On Wed, Dec 2, 2015 at 5:03 PM, Peter Hutterer wrote: > On Wed, Dec 02, 2015 at 04:21:56PM -0800, Jason Gerecke wrote: >> On Tue, Dec 1, 2015 at 5:46 PM, Peter Hutterer >> wrote: >> > If a tool wears out, it may have a pre-loaded pressure offset. In that >> > case, >> > even when the tool is no

Re: [PATCH v1] rephrasing the index.html to match the current shape of the project

2015-12-03 Thread Bryce Harrington
On Fri, Nov 27, 2015 at 03:35:11PM +0100, Benoit Gschwind wrote: > Hello, > > I added bryce comments, my comments and my favorite capitalization. > > Best regards It's coming along. Don't forget to take pq's review comments into account too. Especially, you need to state the rationale for the

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Jonas Ådahl
On Thu, Dec 03, 2015 at 09:18:30PM -0500, Mike Blumenkrantz wrote: > On Fri, 04 Dec 2015 10:01:21 +0800 > Jonas Ådahl wrote: > > > On Thu, Dec 03, 2015 at 05:38:34PM -0800, Bryce Harrington wrote: > > > On Fri, Dec 04, 2015 at 08:09:17AM +0800, Jonas Ådahl wrote: > > > > On Thu, Dec 03, 2015 at 0

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Mike Blumenkrantz
On Fri, 04 Dec 2015 10:01:21 +0800 Jonas Ådahl wrote: > On Thu, Dec 03, 2015 at 05:38:34PM -0800, Bryce Harrington wrote: > > On Fri, Dec 04, 2015 at 08:09:17AM +0800, Jonas Ådahl wrote: > > > On Thu, Dec 03, 2015 at 03:26:16PM -0800, Bryce Harrington wrote: > > > > On Thu, Dec 03, 2015 at 04:33:

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Jonas Ådahl
On Thu, Dec 03, 2015 at 05:38:34PM -0800, Bryce Harrington wrote: > On Fri, Dec 04, 2015 at 08:09:17AM +0800, Jonas Ådahl wrote: > > On Thu, Dec 03, 2015 at 03:26:16PM -0800, Bryce Harrington wrote: > > > On Thu, Dec 03, 2015 at 04:33:47PM +0800, Jonas Ådahl wrote: > > > > This copies the version 5

Re: [PATCH weston] configure.ac: add explicit enable/disable for lcms

2015-12-03 Thread Bryce Harrington
On Fri, Nov 27, 2015 at 04:37:35PM +0200, Jussi Kukkonen wrote: > This is useful for reproducable builds. > > Signed-off-by: Jussi Kukkonen LGTM, Reviewed-by: Bryce Harrington > --- > > This was originally sent by Tim Orling on May 2014. I've moved the > AM_CONDITIONAL below the test as reque

Re: [PATCH v3 wayland-protocols] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Peter Hutterer
On Thu, Dec 03, 2015 at 05:40:47PM -0800, Bryce Harrington wrote: > noarch_pkgconfigdir is not available on oldish pkg-config's. Among > other things this affects Wayland's nightly auto-build Ubuntu 14.04 > PPAs. > > Signed-off-by: Bryce Harrington > Cc: Pekka Paalanen > Cc: Quentin Glidic > C

[PATCH v3 wayland-protocols] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Bryce Harrington
noarch_pkgconfigdir is not available on oldish pkg-config's. Among other things this affects Wayland's nightly auto-build Ubuntu 14.04 PPAs. Signed-off-by: Bryce Harrington Cc: Pekka Paalanen Cc: Quentin Glidic Cc: Peter Hutterer --- Changes from v2 - Place config.m4 into an m4 subdir -

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Bryce Harrington
On Fri, Dec 04, 2015 at 08:09:17AM +0800, Jonas Ådahl wrote: > On Thu, Dec 03, 2015 at 03:26:16PM -0800, Bryce Harrington wrote: > > On Thu, Dec 03, 2015 at 04:33:47PM +0800, Jonas Ådahl wrote: > > > This copies the version 5 of the XML to a new version 6 version, while > > > at the same time the i

Re: [PATCH v2 wayland] protocol: specify behavior of get_pointer when capabilities change

2015-12-03 Thread Jonas Ådahl
On Fri, Dec 04, 2015 at 10:34:34AM +1000, Peter Hutterer wrote: > Also applies to touch/keyboard > > Signed-off-by: Peter Hutterer > --- > Changes to v1: > - make it clear that from the next version onwards sending events to an > earlier wl_pointer object is a no-no. > > protocol/wayland.xml

Re: [PATCH] Refine compositor grabs behavior

2015-12-03 Thread Peter Hutterer
On Tue, Dec 01, 2015 at 07:51:21AM +, Daniel Stone wrote: > Hi, > > On 30 November 2015 at 23:20, Peter Hutterer wrote: > > On Mon, Nov 30, 2015 at 09:56:16PM +, Daniel Stone wrote: > >> On 23 November 2015 at 00:19, Peter Hutterer > >> wrote: > >> > double pointer case when split acros

[PATCH v2 wayland] protocol: specify behavior of get_pointer when capabilities change

2015-12-03 Thread Peter Hutterer
Also applies to touch/keyboard Signed-off-by: Peter Hutterer --- Changes to v1: - make it clear that from the next version onwards sending events to an earlier wl_pointer object is a no-no. protocol/wayland.xml | 36 +--- 1 file changed, 33 insertions(+), 3 del

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Jonas Ådahl
On Thu, Dec 03, 2015 at 03:26:16PM -0800, Bryce Harrington wrote: > On Thu, Dec 03, 2015 at 04:33:47PM +0800, Jonas Ådahl wrote: > > This copies the version 5 of the XML to a new version 6 version, while > > at the same time the interface names are changed to use the unstable > > naming convention.

Re: [PATCH] cosmetic: Remove use of C++ style comments

2015-12-03 Thread Bryce Harrington
On Thu, Dec 03, 2015 at 05:24:48PM +, Daniel Stone wrote: > Hi, > > On 3 December 2015 at 17:23, Chris Michael wrote: > > Patch updated to remove dead lines as suggested by Daniel Stone > > > > Signed-off-by: Chris Michael > > Sorry, should've said, that with that: > Reviewed-by: Daniel Sto

Re: [PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Bryce Harrington
On Thu, Dec 03, 2015 at 04:33:47PM +0800, Jonas Ådahl wrote: > This copies the version 5 of the XML to a new version 6 version, while > at the same time the interface names are changed to use the unstable > naming convention. > > A whitespace cleanup was done as no git-blame:ability would be lost

Re: [PATCH v2] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Bryce Harrington
On Thu, Dec 03, 2015 at 11:57:24PM +0100, Quentin Glidic wrote: > On 03/12/2015 23:45, Bryce Harrington wrote: > >noarch_pkgconfigdir is not available on oldish pkg-config's. Among > >other things this affects Wayland's nightly auto-build Ubuntu 14.04 > >PPAs. > > > >Signed-off-by: Bryce Harringto

Re: [PATCH v2] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Peter Hutterer
On Thu, Dec 03, 2015 at 02:45:14PM -0800, Bryce Harrington wrote: > noarch_pkgconfigdir is not available on oldish pkg-config's. Among > other things this affects Wayland's nightly auto-build Ubuntu 14.04 > PPAs. > > Signed-off-by: Bryce Harrington > Cc: Pekka Paalanen > Cc: Quentin Glidic > C

Re: [PATCH v2] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Quentin Glidic
On 03/12/2015 23:45, Bryce Harrington wrote: noarch_pkgconfigdir is not available on oldish pkg-config's. Among other things this affects Wayland's nightly auto-build Ubuntu 14.04 PPAs. Signed-off-by: Bryce Harrington Cc: Pekka Paalanen Cc: Quentin Glidic Cc: Peter Hutterer --- Changes fro

Re: [PATCH libinput] tablet: handle custom proximity handling

2015-12-03 Thread Peter Hutterer
On Thu, Dec 03, 2015 at 02:37:26PM +0100, Hans de Goede wrote: > Hi, > > On 03-12-15 00:57, Peter Hutterer wrote: > >For the puck/lens cursor tool we need to artificially reduce proximity > >detection. These tools are usually used in a relative mode (i.e. like a > >mouse) > >and thus require lift

[PATCH v2] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Bryce Harrington
noarch_pkgconfigdir is not available on oldish pkg-config's. Among other things this affects Wayland's nightly auto-build Ubuntu 14.04 PPAs. Signed-off-by: Bryce Harrington Cc: Pekka Paalanen Cc: Quentin Glidic Cc: Peter Hutterer --- Changes from v1 - Document why the work around is needed

Re: [PATCH weston 2/2] compositor: Add doxygen for weston_surface_to_buffer_rect()

2015-12-03 Thread Derek Foreman
On 02/12/15 01:04 AM, Pekka Paalanen wrote: > On Tue, 1 Dec 2015 13:00:44 -0600 > Derek Foreman wrote: > >> Signed-off-by: Derek Foreman >> --- >> src/compositor.c | 21 - >> 1 file changed, 20 insertions(+), 1 deletion(-) >> >> diff --git a/src/compositor.c b/src/composito

Re: [PATCH] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Bryce Harrington
On Fri, Dec 04, 2015 at 08:11:51AM +1000, Peter Hutterer wrote: > On Thu, Dec 03, 2015 at 01:43:44PM -0800, Bryce Harrington wrote: > > noarch_pkgconfigdir is not available on oldish pkg-config's. Among > > other things this affects Wayland's nightly auto-build Ubuntu 14.04 > > PPAs. > > > > Sign

Re: [PATCH] [RFC] desktop-shell: change the alpha of black view in fullscreen mode

2015-12-03 Thread Bryce Harrington
On Thu, Dec 03, 2015 at 10:33:27PM +0900, Hyungwon Hwang wrote: > This patch changes the alpha value of black view in fullscreen mode, > when the applications opacity changes. > > Signed-off-by: Hyungwon Hwang > --- > This patch is incomplete, and just a proof of concept. But I want to > make thi

Re: [PATCH] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Peter Hutterer
On Thu, Dec 03, 2015 at 01:43:44PM -0800, Bryce Harrington wrote: > noarch_pkgconfigdir is not available on oldish pkg-config's. Among > other things this affects Wayland's nightly auto-build Ubuntu 14.04 > PPAs. > > Signed-off-by: Bryce Harrington > Cc: Pekka Paalanen > Cc: Quentin Glidic > -

[PATCH] configure.ac: Fix compatibility for older pkg-config versions

2015-12-03 Thread Bryce Harrington
noarch_pkgconfigdir is not available on oldish pkg-config's. Among other things this affects Wayland's nightly auto-build Ubuntu 14.04 PPAs. Signed-off-by: Bryce Harrington Cc: Pekka Paalanen Cc: Quentin Glidic --- compat.m4| 9 + configure.ac | 2 ++ 2 files changed, 11 insertion

Re: [PATCH 6/6] clients: add simple-v4l-dmabuf client

2015-12-03 Thread Derek Foreman
On 24/11/15 01:28 PM, Emmanuel Gil Peyrot wrote: > This client opens a V4L2 device, usually exposed as /dev/videoN, and > retrieves its frames as dmabuf for later import into the compositor. > > It supports both single- and multi-planar devices, and any format > exposed by the V4L2 device the Wayl

Re: [PATCH 5/6] clients: Fix a few issues in simple-dmabuf-intel

2015-12-03 Thread Derek Foreman
On 24/11/15 01:28 PM, Emmanuel Gil Peyrot wrote: > Those were found while working on simple-dmabuf-v4l, as found in the > next patch of this series. > > After each buffer’s params were ready to be submitted to the > compositor, a roundtrip was done, which is wasteful since we can do it > only once

Re: [PATCH 4/6] clients: rename simple-dmabuf into simple-dmabuf-intel

2015-12-03 Thread Derek Foreman
On 24/11/15 01:28 PM, Emmanuel Gil Peyrot wrote: > This client was using an Intel-specific way to allocate a dmabuf, so it > makes sense to have that in its name. > > Signed-off-by: Emmanuel Gil Peyrot > Reviewed-by: Pekka Paalanen > Reviewed-by: Daniel Stone Looks good to me. Reviewed-by: De

[PATCH weston 2/2] compositor-drm: the cursor plane only supports ARGB

2015-12-03 Thread Derek Foreman
Keep XRGB apps out of the cursor plane, only ARGB is supported. This prevents programs like weston-simple-shm from landing in the cursor plane and being misrendered. Signed-off-by: Derek Foreman --- src/compositor-drm.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --

[PATCH weston 1/2] compositor-drm: update internal cursor plane location when disabling cursor

2015-12-03 Thread Derek Foreman
When the cursor plane is disabled the kernel can lose its location. If we don't update our internal idea of where the plane is at that time, the next time we set a cursor it can show up at 0,0. This can show up when an application is put in the cursor plane, removed from the plane, then put back a

Re: [PATCH] cosmetic: Remove use of C++ style comments

2015-12-03 Thread Daniel Stone
Hi, On 3 December 2015 at 17:23, Chris Michael wrote: > Patch updated to remove dead lines as suggested by Daniel Stone > > Signed-off-by: Chris Michael Sorry, should've said, that with that: Reviewed-by: Daniel Stone Cheers, Daniel ___ wayland-deve

[PATCH] cosmetic: Remove use of C++ style comments

2015-12-03 Thread Chris Michael
Patch updated to remove dead lines as suggested by Daniel Stone Signed-off-by: Chris Michael --- src/compositor-rdp.c | 1 - src/vaapi-recorder.c | 2 +- tests/weston-test.c | 2 +- xwayland/window-manager.c | 2 -- 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/s

Re: [PATCH] cosmetic: Remove use of C++ style comments

2015-12-03 Thread Daniel Stone
Hi, On 3 December 2015 at 15:54, Nils Chr. Brause wrote: > On Thu, Dec 3, 2015 at 4:31 PM, Chris Michael wrote: >> diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c >> index 1098f01..412719d 100644 >> --- a/src/compositor-rdp.c >> +++ b/src/compositor-rdp.c >> @@ -717,7 +717,7 @@ struct r

Re: [PATCH weston 11/11] simple-damage: Add --use-buffer-damage flag

2015-12-03 Thread Derek Foreman
Pushed this one (changed the commit log to say --use-damage-buffer) On 30/11/15 01:11 PM, Derek Foreman wrote: > On 30/11/15 01:47 AM, Pekka Paalanen wrote: >> On Fri, 27 Nov 2015 14:55:13 -0600 >> Derek Foreman wrote: >> >>> On 27/11/15 07:47 AM, Pekka Paalanen wrote: On Wed, 18 Nov 2015 1

Re: [PATCH v2 weston 2/2] compositor: Add buffer_damage

2015-12-03 Thread Derek Foreman
Pushed (though I changed the commit log to have the proper "damage_buffer" name) On 26/11/15 02:17 PM, Derek Foreman wrote: > Add an implementation of wl_surface.buffer_damage, similar to > wl_surface.damage except it uses buffer co-ordinates. > > Reviewed-by: Pekka Paalanen > Signed-off-by: Der

Re: [PATCH] cosmetic: Remove use of C++ style comments

2015-12-03 Thread Nils Chr. Brause
Hi, On Thu, Dec 3, 2015 at 4:31 PM, Chris Michael wrote: > Signed-off-by: Chris Michael > --- > src/compositor-rdp.c | 2 +- > src/vaapi-recorder.c | 2 +- > tests/weston-test.c | 2 +- > xwayland/window-manager.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > di

Re: [PATCH wayland v5] protocol: Add wl_surface.damage_buffer

2015-12-03 Thread Derek Foreman
Ok, I've pushed this now. Thanks, Derek On 03/12/15 03:36 AM, Jonas Ådahl wrote: > On Mon, Nov 30, 2015 at 10:55:04AM -0600, Derek Foreman wrote: >> wl_surface.damage uses surface local co-ordinates. >> >> Buffer scale and buffer transforms came along, and EGL surfaces >> have no understanding of

[PATCH] cosmetic: Remove use of C++ style comments

2015-12-03 Thread Chris Michael
Signed-off-by: Chris Michael --- src/compositor-rdp.c | 2 +- src/vaapi-recorder.c | 2 +- tests/weston-test.c | 2 +- xwayland/window-manager.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 1098f01..412719

Re: [PATCH weston] gl-renderer: Dilate damage when output is zoomed or scaled

2015-12-03 Thread Derek Foreman
Looks like I need to autoNAK and try again. The problem occurs when the *previous* frame is capable of overflowing damage (eg: bilinear filtering was used), and can't be solved completely based purely on current state. On 02/12/15 01:46 PM, Derek Foreman wrote: > When we zoom or scale an output i

Re: [PATCH libinput] tablet: handle custom proximity handling

2015-12-03 Thread Hans de Goede
Hi, On 03-12-15 00:57, Peter Hutterer wrote: For the puck/lens cursor tool we need to artificially reduce proximity detection. These tools are usually used in a relative mode (i.e. like a mouse) and thus require lifting and resetting the tool multiple times to move across the screen. The tablets

[PATCH] [RFC] desktop-shell: change the alpha of black view in fullscreen mode

2015-12-03 Thread Hyungwon Hwang
This patch changes the alpha value of black view in fullscreen mode, when the applications opacity changes. Signed-off-by: Hyungwon Hwang --- This patch is incomplete, and just a proof of concept. But I want to make this patch as the starting point of discussion related the opacity in fullscreen

Re: [PATCH wayland v5] protocol: Add wl_surface.damage_buffer

2015-12-03 Thread Jonas Ådahl
On Mon, Nov 30, 2015 at 10:55:04AM -0600, Derek Foreman wrote: > wl_surface.damage uses surface local co-ordinates. > > Buffer scale and buffer transforms came along, and EGL surfaces > have no understanding of them. > > Theoretically, clients pass damage rectangles - in Y-inverted surface > co-o

Re: [PATCH libinput 1/3] test: abort if we have a test that doesn't run for any devices

2015-12-03 Thread Hans de Goede
Hi, On 02-12-15 22:43, Peter Hutterer wrote: If the test is filtered out and we never run it generates a false positive. Though it isn't listed in the "Checks" summary this is a bit hard to tell when you're running >700 tests. Signed-off-by: Peter Hutterer Series looks good to me and is: Re

Re: [PATCH] Introduce the authorizer protocol

2015-12-03 Thread Pekka Paalanen
On Wed, 2 Dec 2015 12:28:33 +0200 Giulio Camuffo wrote: > 2015-11-26 10:21 GMT+02:00 Pekka Paalanen : > > On Wed, 25 Nov 2015 17:39:25 +0100 > > Mariusz Ceier wrote: > > > >> Hi, > >> > >> On 25 November 2015 at 16:14, Pekka Paalanen wrote: > >> > >> > On Tue, 24 Nov 2015 18:07:34 +0100 > >

[PATCH wayland-protocols v2] xdg-shell: Bump unstable version to 6

2015-12-03 Thread Jonas Ådahl
This copies the version 5 of the XML to a new version 6 version, while at the same time the interface names are changed to use the unstable naming convention. A whitespace cleanup was done as no git-blame:ability would be lost anyway. Signed-off-by: Jonas Ådahl Reviewed-by: Mike Blumenkrantz --

Re: [PATCH] install pkg-config file to /usr/share

2015-12-03 Thread Pekka Paalanen
On Wed, 2 Dec 2015 18:13:41 -0800 Bryce Harrington wrote: > Hi Quentin, > > Wayland has some Ubuntu PPA nightly builds set up, which I'm updating to > include wayland-protocols, which weston now needs to build. However, > one of the targets for these PPAs is the Ubuntu LTS 14.04, which shipped