Re: Process for implementing a double buffer on Wayland

2015-11-26 Thread Pekka Paalanen
On Thu, 26 Nov 2015 17:56:05 +0100 Fabien DESSENNE wrote: > > > Date: Thu, 26 Nov 2015 10:40:20 +0200 > > > From: ppaala...@gmail.com > > > > > > On Wed, 25 Nov 2015 21:43:49 +0100 > > > Hardening wrote: > > > > > > > I may be wrong, but there's no guaranty that the compositor sends >

Re: [PATCH wayland v4] protocol: Add wl_surface.damage_buffer

2015-11-26 Thread Jason Ekstrand
On Nov 26, 2015 1:44 PM, "Derek Foreman" wrote: > > wl_surface.damage uses surface local co-ordinates. > > Buffer scale and buffer transforms came along, and EGL surfaces > have no understanding of them. > > Theoretically, clients pass damage rectangles - in Y-inverted surface > co-ordinates) to E

Re: [PATCH wayland] client: Use a 0 version to mean indeterminate proxy version

2015-11-26 Thread Jason Ekstrand
On Nov 26, 2015 1:23 PM, "Derek Foreman" wrote: > > This sets wl_display's version (for proxy version query purposes) > to 0. Any proxy created with unversioned API (this happens when > a client compiled with old headers links against new wayland) > will inherit this 0. > > This gives us a way fo

[PATCH wayland v4] protocol: Add wl_surface.damage_buffer

2015-11-26 Thread Derek Foreman
wl_surface.damage uses surface local co-ordinates. Buffer scale and buffer transforms came along, and EGL surfaces have no understanding of them. Theoretically, clients pass damage rectangles - in Y-inverted surface co-ordinates) to EGLSwapBuffersWithDamage, and the EGL implementation passed them

[PATCH wayland] client: Use a 0 version to mean indeterminate proxy version

2015-11-26 Thread Derek Foreman
This sets wl_display's version (for proxy version query purposes) to 0. Any proxy created with unversioned API (this happens when a client compiled with old headers links against new wayland) will inherit this 0. This gives us a way for new libraries linked by old clients to realize they can't kn

Re: [PATCH] compositor: Fix comment of subsurface_commit_to_cache function

2015-11-26 Thread Derek Foreman
On 26/11/15 10:30 AM, Chris Michael wrote: > commit 57388e44e5 accidentally changed the comment in > compositor.c::subsurface_commit_to_cache > Yup, looks correct to me. Reviewed-by: Derek Foreman (and pushed) > Signed-off-by: Chris Michael > --- > src/compositor.c | 2 +- > 1 file changed,

[PATCH weston 1/2] compositor, input: Don't use MIN() macro for new resource versions

2015-11-26 Thread Derek Foreman
libwayland-server protects us from invalid serial numbers by posting an error already. MIN() is for clients when selecting interface versions. Signed-off-by: Derek Foreman --- src/compositor.c | 8 src/input.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/

[PATCH v2 weston 2/2] compositor: Add buffer_damage

2015-11-26 Thread Derek Foreman
Add an implementation of wl_surface.buffer_damage, similar to wl_surface.damage except it uses buffer co-ordinates. Reviewed-by: Pekka Paalanen Signed-off-by: Derek Foreman --- Tiny changes since v1: rebase on patch to not use MIN() macros the width, height test in surface_damage_buffer is now

Re: [PATCH weston 09/11] compositor: Add buffer_damage

2015-11-26 Thread Derek Foreman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/11/15 08:54 AM, Pekka Paalanen wrote: > On Wed, 18 Nov 2015 16:32:32 -0600 Derek Foreman > wrote: > >> Add an implementation of wl_surface.buffer_damage, similar to >> wl_surface.damage except it uses buffer co-ordinates. >> >> Signed-off-by:

Re: Process for implementing a double buffer on Wayland

2015-11-26 Thread Fabien DESSENNE
> > Date: Thu, 26 Nov 2015 10:40:20 +0200 > > From: ppaala...@gmail.com > > To: rdp.eff...@gmail.com; mikeyj...@hotmail.com > > CC: wayland-devel@lists.freedesktop.org; dan...@fooishbar.org > > Subject: Re: Process for implementing a double buffer on Wayland > > > > On Wed, 25 Nov 2015 21:43

[PATCH] compositor: Fix comment of subsurface_commit_to_cache function

2015-11-26 Thread Chris Michael
commit 57388e44e5 accidentally changed the comment in compositor.c::subsurface_commit_to_cache Signed-off-by: Chris Michael --- src/compositor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 65abb72..d723b64 100644 --- a/src/composi

Re: [PATCH weston 08/11] compositor: ignore surface_damage with negative height or width

2015-11-26 Thread Derek Foreman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/11/15 07:21 AM, Pekka Paalanen wrote: > On Thu, 19 Nov 2015 11:15:38 -0600 Derek Foreman > wrote: > >> On 18/11/15 07:33 PM, Bill Spitzak wrote: >>> >>> >>> On Wed, Nov 18, 2015 at 2:32 PM, Derek Foreman >>> mailto:der...@osg.samsung.com>>

Re: [PATCH weston 09/11] compositor: Add buffer_damage

2015-11-26 Thread Pekka Paalanen
On Wed, 18 Nov 2015 16:32:32 -0600 Derek Foreman wrote: > Add an implementation of wl_surface.buffer_damage, similar to > wl_surface.damage except it uses buffer co-ordinates. > > Signed-off-by: Derek Foreman > --- > src/compositor.c | 90 > ++--

Re: [RFC] Declare enumeration wl_output.transform as bitfield.

2015-11-26 Thread Nils Chr. Brause
Hi, On Wed, Nov 25, 2015 at 10:01 PM, Bryce Harrington wrote: > On Wed, Nov 25, 2015 at 03:25:55PM +, Daniel Stone wrote: >> Hi, >> >> On 25 November 2015 at 14:17, Auke Booij wrote: >> > On 25 November 2015 at 13:43, Daniel Stone wrote: >> >> Warnings aren't harmless though; there's a reas

Re: [PATCH weston 08/11] compositor: ignore surface_damage with negative height or width

2015-11-26 Thread Pekka Paalanen
On Thu, 19 Nov 2015 11:15:38 -0600 Derek Foreman wrote: > On 18/11/15 07:33 PM, Bill Spitzak wrote: > > > > > > On Wed, Nov 18, 2015 at 2:32 PM, Derek Foreman > > wrote: > > > > If we pass negative height or width on to pixman we get error messages > > i

RE: Process for implementing a double buffer on Wayland

2015-11-26 Thread Mike Johnson
> Date: Thu, 26 Nov 2015 10:40:20 +0200 > From: ppaala...@gmail.com > To: rdp.eff...@gmail.com; mikeyj...@hotmail.com > CC: wayland-devel@lists.freedesktop.org; dan...@fooishbar.org > Subject: Re: Process for implementing a double buffer on Wayland > > On Wed, 25 Nov 2015 21:43:49 +0100 > Harden

Re: [RFC wayland-protocols v2] Add screensaver inhibition protocol

2015-11-26 Thread Pekka Paalanen
On Tue, 24 Nov 2015 23:24:55 -0800 Bryce Harrington wrote: > On Wed, Nov 25, 2015 at 08:09:16AM +0100, Michal Suchanek wrote: > > Hello > > > > On 25 November 2015 at 07:49, Bryce Harrington > > wrote: > > > This interface allows disabling of screensaver/screenblanking on a > > > per-surface

Re: [PATCH weston 0/4] fix bugs and TODO to support multi screens

2015-11-26 Thread Pekka Paalanen
On Wed, 25 Nov 2015 23:30:05 +0900 Nobuhiko Tanibata wrote: > Hi, > > I am proposing 4 patches to fix potential bugs and TODOs to support > multi screens. Hi, it's all R-b me already and IMO ready to land. Feel free to push, or I can push on Friday I think, if no-one screams. Thanks, pq p

Re: [PATCH wayland 2/2] protocol: Refine wl_surface.commit text

2015-11-26 Thread Pekka Paalanen
On Fri, 20 Nov 2015 15:49:59 -0600 Derek Foreman wrote: > The order of operations during wl_surface.commit hasn't been clarified > since wp_viewport, wl_surface.set_buffer_transform and > wl_surface.set_buffer_scale were added. > > Explain that any state that changes co-ordinates is applied firs

Re: [PATCH v3 wayland 1/2] protocol: Add wl_surface.damage_buffer

2015-11-26 Thread Pekka Paalanen
On Fri, 20 Nov 2015 20:37:58 -0600 Derek Foreman wrote: > On 20/11/15 07:39 PM, Bill Spitzak wrote: > > I am pretty certain you can just convert wl_surface.damage coordinates > > *to* buffer coordinates, using the transform the old buffer was attached > > with, and thus merge all the wl_surface.d

Re: [PATCH v3 wayland 1/2] protocol: Add wl_surface.damage_buffer

2015-11-26 Thread Pekka Paalanen
On Fri, 20 Nov 2015 15:49:58 -0600 Derek Foreman wrote: > wl_surface.damage uses surface local co-ordinates. > > Buffer scale and buffer transforms came along, and EGL surfaces > have no understanding of them. > > Theoretically, clients pass damage rectangles - in Y-inverted surface > co-ordina

Re: Process for implementing a double buffer on Wayland

2015-11-26 Thread Pekka Paalanen
On Wed, 25 Nov 2015 21:43:49 +0100 Hardening wrote: > Le 25/11/2015 17:18, Daniel Stone a écrit : > > Hi Mike, > > > > On 25 November 2015 at 16:06, Mike Johnson wrote: > >> I've created 2 buffers of the same size (800x600 pixels). So I want the > >> input buffer to get filled off-screen, wh

Re: [PATCH] Introduce the authorizer protocol

2015-11-26 Thread Pekka Paalanen
On Wed, 25 Nov 2015 17:39:25 +0100 Mariusz Ceier wrote: > Hi, > > On 25 November 2015 at 16:14, Pekka Paalanen wrote: > > > On Tue, 24 Nov 2015 18:07:34 +0100 > > Mariusz Ceier wrote: > > > > > Hi, > > > > > > On 24 November 2015 at 17:35, Giulio Camuffo > > > wrote: > > > > > > > 2015-1